From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E37A5CD11C2 for ; Fri, 5 Apr 2024 15:38:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 760726B009E; Fri, 5 Apr 2024 11:38:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 70FB26B009F; Fri, 5 Apr 2024 11:38:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B1856B00A1; Fri, 5 Apr 2024 11:38:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3DA1E6B009E for ; Fri, 5 Apr 2024 11:38:08 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E9AE61C146B for ; Fri, 5 Apr 2024 15:38:07 +0000 (UTC) X-FDA: 81975884214.09.C2CF882 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by imf17.hostedemail.com (Postfix) with ESMTP id D0CC04001B for ; Fri, 5 Apr 2024 15:38:05 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZYNb1pgE; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of klarasmodin@gmail.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=klarasmodin@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712331485; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A5HKjia/bBxV9bwJewCR86FUIvkQ6YbpSmsf0h/yiVw=; b=kBXoOD5diMxaBLpJ8RZxeSFZe3R2WM6wrkZkbGd5Qy8ANTAlPVI5H3ermc2Xl7lirq2VxX mjRTIUglUASvFbRoaLKtizvDd8A2xmw1fXEMbv2X2ksaeInBKUZSvpWkpLWjCvReuk2EY5 Qmt9m0BjjJlG4vao3LyicN4L2QQtVHA= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZYNb1pgE; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of klarasmodin@gmail.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=klarasmodin@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712331485; a=rsa-sha256; cv=none; b=YXAjqXNYd2CdAQL/dekAaO2xtDYbADj10MkZ0SXMToWbBh+92MOBRrHrOubyCC0v+dahrS FNOXq/3jb2vZ8avwSALJkYrS24J4n+HULDqeBZn7KRPRhWnvvOl9Iw+S7GcQ0XlX3jypF4 LvcRAJcj1g9+9W2o50dNEqCPQwu5Uzk= Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-516d09bd434so2091925e87.1 for ; Fri, 05 Apr 2024 08:38:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712331484; x=1712936284; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=A5HKjia/bBxV9bwJewCR86FUIvkQ6YbpSmsf0h/yiVw=; b=ZYNb1pgE/373W4aT5hAqqgLnEv3TiENPpweHqTR/GKHFsUG4n3LoABg5X8smaZmck+ qyhGKgFAGvm+bwmmaMPM/VMcIhfNsmuvX11y78TuD3qihw55krtO99yfWaH4XmL3C2mu plKsXf0OMf0aQI4YQ65w4oouNgWfSE1J1HbdZHgQT1MUXfRBgN2SFvItYsaIS1JDRvQH DO29pkXApu5xwWQO42SQOBEqqYjRtsJS4VePFfIB91NFPBv4rE7Wq2miX82fKt0Jm0gZ kZxEMFBQEeSjZgPE+DBn15tls70UdpuPKP4+BDZR4cte0G0XYQ+T/YXV3vQZa5RJAd8T Nabg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712331484; x=1712936284; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A5HKjia/bBxV9bwJewCR86FUIvkQ6YbpSmsf0h/yiVw=; b=twcP8dWp6Xe1UkyHFdVPy+CPHXXKjxoLvBVsbeOasgzY6xKqhMRMsBnL3zAaWyzNs6 zzeoje9VxwrazbdWubtHK8pXe38Nibso/UYBvJHyc0605S/ozVz1hlmd6Nu6adXkbsOw HyY9oiDdKl6rixw2mEyMor6CbDJ+9qFFKmAhVA8qZv8SopnAjVL250MKPpM57r4YLhsU YwFqcP9hMs3QoriwQwQhWITCVTmtS711teLypioQsizVla35vGeqRwf8Sg0l2FDSVkeE J6Ta3I7kSqWE3ruHFFgBE6UrXhDmEUt1xDuN2LPKHkjTwxozDFhLZxozFacqvsU/UX8L 49xA== X-Forwarded-Encrypted: i=1; AJvYcCWhFumAWDdBqhiHasJEFS00kIrmIZzAludiHyixeSZb9rSlsRFqL326Edtk554xg/n5JU7+mJFK06hydZLgDOi6bQM= X-Gm-Message-State: AOJu0Yw0JjXG/gyu3RKEk5kqt8O9b0wR9B0UswOQu0R0ihquwLaiNxrE rb6PSb1KiHlg98xQheQQa8h28zC7r5weoRYYaGvl5bHAZKHnqgTZ X-Google-Smtp-Source: AGHT+IEIEEmughiSiBHY8eCIsSnqVoMqZUWDTHfuKcBEPEydDjJRjHpHyQHuQL28VLtLT7iqCSGbkw== X-Received: by 2002:a05:6512:2fa:b0:516:d029:b513 with SMTP id m26-20020a05651202fa00b00516d029b513mr1341784lfq.69.1712331483357; Fri, 05 Apr 2024 08:38:03 -0700 (PDT) Received: from ?IPV6:2001:678:a5c:1202:2659:d6e4:5d55:b864? (soda.int.kasm.eu. [2001:678:a5c:1202:2659:d6e4:5d55:b864]) by smtp.gmail.com with ESMTPSA id j11-20020a056512344b00b0051589cc26afsm218610lfr.72.2024.04.05.08.38.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Apr 2024 08:38:02 -0700 (PDT) Message-ID: <3d496797-4173-43de-b597-af3668fd0eca@gmail.com> Date: Fri, 5 Apr 2024 17:37:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 00/37] Memory allocation profiling To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org References: <20240321163705.3067592-1-surenb@google.com> <41328d5a-3e41-4936-bcb7-c0a85e6ce332@gmail.com> Content-Language: en-US, sv-SE From: Klara Modin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: j6apnk53ne1s8j9pnu8uwuhy5t5456im X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D0CC04001B X-HE-Tag: 1712331485-307814 X-HE-Meta: U2FsdGVkX1/N87FeX/QWYqL0uAzhrc3X4Ttkk/ZXU4m4Fi5XOIBb7nzb/gw1Mjrm8m1GAjoLSWjTtThB+rAo0VCncF2U4SbG1r5O6jZglShNjzx+nCATVbNg/NEo4XMDSs4OJGKa63zaaS9vi3NXDSKgse7UB19mE7pY7xiCvbINar/qelk1LKbwUPX7nbk9esM5hNQtIbqoHwDdR9HxAXnFfa+m5p6VP7yls/12qzi3RqTBiQLTYZiFhJIO7icvfkX2lTZ+QzrZ8mXWR1d3dvhW5O6B69t5eZONyCY+J+4wevlKeBGiho/qWynskTWxJx45i+UYDOHgEh+N8t/c3HqoclodQPjWQWYO/1aA5E3bm2wrCIzF0UmUahRXAM/U2b6vFew7+yjFLO+OKiQ5YrVvkNPALABYm57v1J5j5JUr7uy6eEbIHwacF/trcsZOxXd67hdUAxALs6Asx9PamwlOi8QYi5+JHm1GtQ0IWvZDhZ8hXpiYRg8YnkKR55TTUjK8Z6sA0Wh6JSbKvopfw/g9IZazKHVybIjBsnCCqio+BLCzIXUvmImEnpKJahYqFgAZgn2w6/qfyoPmaLUj+S1AqmW9TufCa72U4+VJA9GtbFiEm+qyGkoA1Mpl/I4Rf//MB3f9VRG80j9PAiP9rqkF2E0HOjcGH4F7cAdRK7fz4xHoM+y8nODItm2KfB91kzsWiBn2Y3FKujYme8VbB1csZGbRnblS8Z0o7wdB/0Ql//KGVLkmddpjmZvHIEMvzHXenktmUXP2cZpGeIr1LaGDdbMIQzboDh+8liLU16nZA36IIPdmc4wr74cb3/7OlL9AOLftFGPdxc1s+8SxHIyaPEUSPI9DNxCkHjhMEgTfWa9qqbavLLoUy2L+1tzI4pAgM0myRylhxzvFZbEMA6U1EH5lbmQGMvDg4tZEBV7nqTCA+eMqsUlkQfKpScW2515fvrmMUQhV+UBM4KD x80/gNFn HJiowy9kClw8+PDGNe4UgMYnaptrJF0S5Lzsj1RUbpuTpkt9DK0syeeG2xoMGu5IuwhPI5HeDnSdOw+BG3l677a+0Is59Dzl1GxAteWMNmlzrS3/CTObLdV9zl4IYyITH6P1qj88QlUZrG+MSjOxo2glvjuclyriwFrE//9kaYJgAAnm+KnI8mPJAc/uAiSw3ZiYg534kipHbkG3XdSSaNdJMLDm6gR8U7BDjL/maw145tdhvsaLvgvZlL53UeXVvtn29Zqq49MOEZUIET2V3RerIJrlb77qoVZRiMNrKVxRXIfgoxy0sMCp9VG3Mh6jNpJpLcxRdTzLiafHCxqIOloMuqYW6UgV4tPCkK0BXIY3z0MiKV3pniKFtnBEYvT6QHhDXEi7AFfdUap9/YIwDRxM5TjYFwqd3aKpgcHLav9CXAxAe/Usx3vdxGlmuVxDOUx1/RkORdUf3Gy3kpyAoJ4B7a9aBcsA51sygAeGpRSg3qc7bIu2+qsiwWdjP4e2RiD0iGQ1H9cOKhuo7EeJ/Bos0ZfT+6O0/j6TnElIy/3EMZiRuJoIvcRe9fB6WDLD6xfwB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024-04-05 17:20, Suren Baghdasaryan wrote: > On Fri, Apr 5, 2024 at 7:30 AM Klara Modin wrote: >> >> On 2024-04-05 16:14, Suren Baghdasaryan wrote: >>> On Fri, Apr 5, 2024 at 6:37 AM Klara Modin wrote: >>>> If I enable this, I consistently get percpu allocation failures. I can >>>> occasionally reproduce it in qemu. I've attached the logs and my config, >>>> please let me know if there's anything else that could be relevant. >>> >>> Thanks for the report! >>> In debug_alloc_profiling.log I see: >>> >>> [ 7.445127] percpu: limit reached, disable warning >>> >>> That's probably the reason. I'll take a closer look at the cause of >>> that and how we can fix it. >> >> Thanks! > > In the build that produced debug_alloc_profiling.log I think we are > consuming all the per-cpu memory reserved for the modules. Could you > please try this change and see if that fixes the issue: > > include/linux/percpu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/percpu.h b/include/linux/percpu.h > index a790afba9386..03053de557cf 100644 > --- a/include/linux/percpu.h > +++ b/include/linux/percpu.h > @@ -17,7 +17,7 @@ > /* enough to cover all DEFINE_PER_CPUs in modules */ > #ifdef CONFIG_MODULES > #ifdef CONFIG_MEM_ALLOC_PROFILING > -#define PERCPU_MODULE_RESERVE (8 << 12) > +#define PERCPU_MODULE_RESERVE (8 << 13) > #else > #define PERCPU_MODULE_RESERVE (8 << 10) > #endif > Yeah, that patch fixes the issue for me. Thanks, Tested-by: Klara Modin