From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC07FC0015E for ; Sat, 12 Aug 2023 06:25:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 338456B0074; Sat, 12 Aug 2023 02:25:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E85F6B0078; Sat, 12 Aug 2023 02:25:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D6FB6B007B; Sat, 12 Aug 2023 02:25:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0A7C86B0074 for ; Sat, 12 Aug 2023 02:25:12 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D0CC2B2098 for ; Sat, 12 Aug 2023 06:25:11 +0000 (UTC) X-FDA: 81114465222.09.770A5D5 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf04.hostedemail.com (Postfix) with ESMTP id 1DBC34000E for ; Sat, 12 Aug 2023 06:25:07 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf04.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691821510; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1RxZct9LAG/z3/L8XSN6NTLDRHTnIwnNkPCA41m72eU=; b=BXHb9/iNnDjn4OkxFpZ3MWfasBexlYopzDmvNEx7X+FV4W56pqwY/aNRnjC5ZLTZgIO11x SwF5xEZNeD1Za7GB/odB7aOLGOcQg+T476y1mv2JOogrLBJ4XI06iZSQpHzecL3a05JuZZ LFPrrXQ9MPab4TQlAVh1Pg91Bgp55x8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf04.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691821510; a=rsa-sha256; cv=none; b=JBKbvx+nEwSFOE61PsCkneAQlLzkiQwj1Mx0hsLdOXZJ0JXQjkPgV4Wl4rk3LV9R3Qjlou 7CORVbPqulSO4TdD0huyXPlhHsg39jVPhYCwJr+9GNnxdQdJHQp09bGPrBwIrWo9aMgw/U kl/dYngs3HTsqf7VzxX6wDEmE5kFOH8= Received: from kwepemm600020.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RN9Xp6ZsJzNmpw; Sat, 12 Aug 2023 14:21:30 +0800 (CST) Received: from [10.174.179.160] (10.174.179.160) by kwepemm600020.china.huawei.com (7.193.23.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Sat, 12 Aug 2023 14:25:00 +0800 Message-ID: <3d48e5b6-8358-708b-e490-4d41d0dd2059@huawei.com> Date: Sat, 12 Aug 2023 14:24:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] mm/secretmem: use a folio in secretmem_fault() To: Matthew Wilcox CC: , , , References: <20230812015835.3041694-1-zhangpeng362@huawei.com> Content-Language: en-US From: "zhangpeng (AS)" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.160] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm600020.china.huawei.com (7.193.23.147) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 1DBC34000E X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: fzjfig4o4p9g9sswtw4fs1up1n6ijqk7 X-HE-Tag: 1691821507-321665 X-HE-Meta: U2FsdGVkX18bo/0ChtGW1IBSiXxOQK6PVcJOAlJXQ0aXDuMiSmUoVBGQIhyzYonb2oKkhdDkZbIprSsrrhgpLKC2k9yacRN9Cp6MUUzZWOjdgW9Y3WeS5G7OUS0zl46ONmT919zbYVVtVj0ivyWuc3+GEJa6VxMIgSP/+kqE+RqlFIjtjMIRIzs4kpaKD7IW6S1+oZE6Duz6cb0tAgtu/7llkaBmmpvDEO9Ro4/YyfX5TFbVpuUTQYg5mfdSGGGmwpXk/viSCgoWGM68KVDe3uqx59B5NxcPgJ/DSg5/ogHyHqpMa9liy/o//bpJiD11tGtPKqhJia0WE9BmPf7uFHk+fdM+FNT/VhNc2cUnrxC7mdE6iucavuYimDdHm5nvVBwUbvTSw4i12ECElJOP61xefg9/9BuC5nFL05Cu0tqqF5UN4DSGeZzr1nnfdTlEdRtrvvhrUbaAQSUUDb7aVAN9/bm97SBERdcT3UDA6RWKodL495nxmEMjWaaIUBQWUxQ2qZgNU2vtP7uhy4FN3m6ojnTL2OryKuM5M2RPO84jnBgEuL8QGxHMpto6HCV5gCIbGIKOzlgWMXQlJPWKTKdUoNEPdvpCYfj4FuOWaHwhUybdmNYxP8L9Zkviagt77MgURdMZVbD14yLGbSV2nVw4r8qv3GWab30Dadk64RXFCb+qfpdB6WKvqVb9WB/dRqVmy4NprNrNWivxLQQmBtOdT3zCuz8ch70uHVFfJmYaCMyL7Lpa1fYmdzqfqEUi3bEErdNrl7EoZOME4Pvg9aatghkUUb0wauwE80crZ4k8rWNDGFgsTzqByXsF/PbpKWMLTRYI2dbwEsAeCRLDW65FpMANxFFvacAYYitrUN34me5Knek71RJuZzVn4JxBGq3/gGbka5xHR0fJ8HaeGwlcrMfFIWQMD+zOScjGqQZSCEpbeMtKUW5zk/ruvOTkq8rzNNVPWnIXrbF/nnp 5jdO6hBQ S7kK4V/u0IVRNgnR/oUsEnqyb7Onf22YzeXTH25sw136EvZ2yVGZZuOWyCGLWwAt/Of2zvPUhjndjfVJQ4xvbF+UBzYEXrsE2m9y7bxh9qXIFFSn+33aBxX5sy3bujkNc5/9RpCia/b/SHReh5H6ZjU0Ej6FmDRPlrFx4TG9a17xx9ezg12O3/i90kWHeH7e3eRrwXdmFGytDssrop/LuZO6gwGlhIl0rpO6lJu7J8LJhzVSBY4opWQQdU5QYlBDYJZxCId8syGq8y7k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/8/12 11:53, Matthew Wilcox wrote: > On Sat, Aug 12, 2023 at 09:58:35AM +0800, Peng Zhang wrote: >> From: ZhangPeng >> >> Saves three implicit call to compound_head(). > I count four! > >> if (err) { >> - put_page(page); >> + folio_put(folio); >> ret = vmf_error(err); > One. > >> >> - __SetPageUptodate(page); >> - err = add_to_page_cache_lru(page, mapping, offset, gfp); >> + __folio_mark_uptodate(folio); >> + err = filemap_add_folio(mapping, folio, offset, gfp); > Two, three. > >> if (unlikely(err)) { >> - put_page(page); >> + folio_put(folio); > Four! > > Reviewed-by: Matthew Wilcox (Oracle) Indeed. Thanks! -- Best Regards, Peng