From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C478EC433FE for ; Mon, 14 Nov 2022 09:05:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 094D38E0001; Mon, 14 Nov 2022 04:05:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0453B6B0073; Mon, 14 Nov 2022 04:05:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E503C8E0001; Mon, 14 Nov 2022 04:05:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D5C1D6B0072 for ; Mon, 14 Nov 2022 04:05:37 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A0272120D7A for ; Mon, 14 Nov 2022 09:05:37 +0000 (UTC) X-FDA: 80131464714.04.B56B439 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 35FA5140008 for ; Mon, 14 Nov 2022 09:05:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668416736; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QQXjHcPTPGjzJPcozw9XlMPufcfNMdzCPnNa7JaQbHE=; b=BjRpWZgqBaynT804TLIudco+Aq0fVF/lL+iZWsqkyAb+Fr3Lvp50thihrT8MoJBqhQ07qC x9CYVOpVFGMoPORTwqgYpK+FMiQmiij+uFF4rJzrR3w67gpVtoYqlQMQjoj9YuFYe3qLRG 75X/75J+GneZW4AmQNpy2UU2vXHVgEY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-127-4YYNacJYOIafJi8K8dZF4w-1; Mon, 14 Nov 2022 04:05:32 -0500 X-MC-Unique: 4YYNacJYOIafJi8K8dZF4w-1 Received: by mail-wm1-f71.google.com with SMTP id u9-20020a05600c00c900b003cfb12839d6so2695438wmm.5 for ; Mon, 14 Nov 2022 01:05:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QQXjHcPTPGjzJPcozw9XlMPufcfNMdzCPnNa7JaQbHE=; b=TXlN4EZCeLF1bdgMYVtXH2K2/YTCrG0BhTT8c+TgASgX4aYX7Lsh0WsSVS9p/R6uir RcA3uC+WQ9Ki3ZZh4Vn3xJDIEUBrb81fuuI244BiwQEGTzbY2g9yzVXY+uhDTk2iJN2B LuD1E3aW2SfsordJsO84GWRlnr70hC3upJz2il3qmtygEO+jFjz/irEHE8bjDr8G3Q4+ vL1DMl7V+Tf8KmnoKMxpyuUCkWK9wsc8iEB1WteAqYMd9BpwqGZUM3LCnQpt4sdTifea W2gRd/QXc/6oq4qXagCT/aKVF+pveY603qDMxL2VnjQaYzvbsuZKpyI/PUe7g+MEUczL KY1Q== X-Gm-Message-State: ANoB5pmxZIE2u7cI18ZpAufMjhL8Ii1wuhMQzp/4RzCMcy9yNNzghq/l NDs4oGH0ACBE1iL570djrW8Kwb/fd4JTlzE7N9PJQcv6wT+neNDim5CY+WZukmwQ1wh8ZiqihKB bEt7ThVtJguQ= X-Received: by 2002:a05:600c:1d11:b0:3cf:a6eb:3290 with SMTP id l17-20020a05600c1d1100b003cfa6eb3290mr7351107wms.116.1668416731161; Mon, 14 Nov 2022 01:05:31 -0800 (PST) X-Google-Smtp-Source: AA0mqf7sZnxZjO9PA2WoU/6SFgkFehlEaEQRXZ25UkYLSrPfGtQBu33zNpdq9IZYvVadzLyMtvS+nw== X-Received: by 2002:a05:600c:1d11:b0:3cf:a6eb:3290 with SMTP id l17-20020a05600c1d1100b003cfa6eb3290mr7351090wms.116.1668416730828; Mon, 14 Nov 2022 01:05:30 -0800 (PST) Received: from ?IPV6:2003:cb:c703:d300:8765:6ef2:3111:de53? (p200300cbc703d30087656ef23111de53.dip0.t-ipconnect.de. [2003:cb:c703:d300:8765:6ef2:3111:de53]) by smtp.gmail.com with ESMTPSA id p2-20020a7bcc82000000b003b50428cf66sm11744715wma.33.2022.11.14.01.05.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Nov 2022 01:05:30 -0800 (PST) Message-ID: <3d3e48cc-687c-8d4e-1e33-c34fb76c284f@redhat.com> Date: Mon, 14 Nov 2022 10:05:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v9 1/3] madvise: use zap_page_range_single for madvise dontneed To: Mike Kravetz , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Naoya Horiguchi , Axel Rasmussen , Mina Almasry , Peter Xu , Nadav Amit , Rik van Riel , Vlastimil Babka , Matthew Wilcox , Andrew Morton , Wei Chen , stable@vger.kernel.org References: <20221111232628.290160-1-mike.kravetz@oracle.com> <20221111232628.290160-2-mike.kravetz@oracle.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20221111232628.290160-2-mike.kravetz@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668416737; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QQXjHcPTPGjzJPcozw9XlMPufcfNMdzCPnNa7JaQbHE=; b=IgFhDgUCFiz/ItQM4iVWzMrsiDZCvkp1H1aK4ipFmF4Fl87pByhJAV2yiBBS8GUyd7AC0T 4mCwjAkrkyhUnU1CO9LOKUdhcZRSSte1tEjxCBto8BDNhEUyKTdMw+Qp+6krCrJT+qL9AD eiVw9evWy6OcKIiz2rdbJbNYKGIJU2E= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BjRpWZgq; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668416737; a=rsa-sha256; cv=none; b=lGvujYxZxLHFCHPR9hys253ebRiVuWM3q9qeLqMe3776aCxdSlUQjUsFjNDbKP+oEPj3rh McpT+PlP0AI2XWjE2tTgO/UWN1LMXVnWP/6/jR3IRsekolKJlrc0moRVGcSFtEGBx4fheI Bjbv2Wim9r6BGRi8oDdkzIqSl0zjayM= X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 35FA5140008 X-Rspam-User: Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BjRpWZgq; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com X-Stat-Signature: caisjrrx4p47wohryp9asoomz8e83nhj X-HE-Tag: 1668416737-645647 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12.11.22 00:26, Mike Kravetz wrote: > Expose the routine zap_page_range_single to zap a range within a single > vma. The madvise routine madvise_dontneed_single_vma can use this > routine as it explicitly operates on a single vma. Also, update the mmu > notification range in zap_page_range_single to take hugetlb pmd sharing > into account. This is required as MADV_DONTNEED supports hugetlb vmas. > > Fixes: 90e7e7f5ef3f ("mm: enable MADV_DONTNEED for hugetlb mappings") > Signed-off-by: Mike Kravetz > Reported-by: Wei Chen > Cc: [...] > > -/* > - * Parameter block passed down to zap_pte_range in exceptional cases. > - */ > -struct zap_details { > - struct folio *single_folio; /* Locked folio to be unmapped */ > - bool even_cows; /* Zap COWed private pages too? */ > - zap_flags_t zap_flags; /* Extra flags for zapping */ > -}; > - > /* Whether we should zap all COWed (private) pages too */ > static inline bool should_zap_cows(struct zap_details *details) > { > @@ -1736,19 +1727,27 @@ void zap_page_range(struct vm_area_struct *vma, unsigned long start, > * > * The range must fit into one VMA. > */ > -static void zap_page_range_single(struct vm_area_struct *vma, unsigned long address, > +void zap_page_range_single(struct vm_area_struct *vma, unsigned long address, > unsigned long size, struct zap_details *details) > { > + unsigned long end = address + size; Could make that const. > struct mmu_notifier_range range; > struct mmu_gather tlb; > > lru_add_drain(); > mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, vma, vma->vm_mm, > - address, address + size); > + address, end); > + if (is_vm_hugetlb_page(vma)) > + adjust_range_if_pmd_sharing_possible(vma, &range.start, > + &range.end); > tlb_gather_mmu(&tlb, vma->vm_mm); > update_hiwater_rss(vma->vm_mm); > mmu_notifier_invalidate_range_start(&range); > - unmap_single_vma(&tlb, vma, address, range.end, details); > + /* > + * unmap 'address-end' not 'range.start-range.end' as range > + * could have been expanded for hugetlb pmd sharing. > + */ > + unmap_single_vma(&tlb, vma, address, end, details); > mmu_notifier_invalidate_range_end(&range); > tlb_finish_mmu(&tlb); > } Acked-by: David Hildenbrand -- Thanks, David / dhildenb