From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C28EEC021B8 for ; Wed, 26 Feb 2025 15:35:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3AB8A6B0082; Wed, 26 Feb 2025 10:35:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 35C0C6B0083; Wed, 26 Feb 2025 10:35:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1AF33280001; Wed, 26 Feb 2025 10:35:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EF0BB6B0082 for ; Wed, 26 Feb 2025 10:35:19 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5C6791C8DB5 for ; Wed, 26 Feb 2025 15:35:19 +0000 (UTC) X-FDA: 83162494758.16.8B8AC34 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id C5EF82000A for ; Wed, 26 Feb 2025 15:35:16 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KYSfio9Q; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740584117; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GLtL1iYvSdMyja7reFfUkLJoE1s+u20TWnWvDVhqKm8=; b=506yuPp+UV9tb8hCWKQjvOiAqkPBuuh5fhEBlsAnfiNZW/mhv9HxN1avGg/uiQni4n5CrF tnVnifvLUNQCh7Hxg1VtxP7MqpsDUbeECzoYp/hJbJ1TctUU1zhV27TZdIgkKWaTPlxpmu Lql6zNv3HvkDggF5JN4/mCG3/Uoxw1k= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KYSfio9Q; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740584117; a=rsa-sha256; cv=none; b=2cw4HOMv8RqKyvnrhJ3LE2Spi7d5f2TWi3/tasRaDzTzpLTDA7v75Owy1IEYKSRQ1wxSTf lXgxrcibGpgncYIiYikTR1IYSjmXMynE/xgN4H/P1OO67yh98+VKwryI9JnPBpMsiONBoY fhBE3H78u6VdPqWhESOzm2rq5AAOZG4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740584116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=GLtL1iYvSdMyja7reFfUkLJoE1s+u20TWnWvDVhqKm8=; b=KYSfio9QH/Gf+duqjFCUkps5yvji6vU8bKApKj0aQWGt5aGiH8fy/yLyt8YKQypFLJ55cW 2GG6Vbi+ePizohOVDPnEYQlS7MKKtpihIm7QtANN8Rh7FF8O8+U9uIdLID56GUy0k29ZD8 yIunorZLqPvoN314KISXSYfxEvfJ0n8= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-62-LH7OnyMZMFO4hZ6IRx8jEA-1; Wed, 26 Feb 2025 10:35:14 -0500 X-MC-Unique: LH7OnyMZMFO4hZ6IRx8jEA-1 X-Mimecast-MFC-AGG-ID: LH7OnyMZMFO4hZ6IRx8jEA_1740584113 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-38f51a3a833so2754422f8f.2 for ; Wed, 26 Feb 2025 07:35:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740584113; x=1741188913; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GLtL1iYvSdMyja7reFfUkLJoE1s+u20TWnWvDVhqKm8=; b=RW5gLp9gGnr/F+BDu9WqlKVSX670C0plnYb5K+PQlpLI9qtnrxLzaa7UZ4m51ilkBJ 3C2eRMqw8vp4LdWffhnY9dnbOhBeW1IJTuTQLYQIVnu8LRCVe4yaB/ypVTYzo1sGY4NN yaaU5wUAcYRVDQMuxm6ewzKtu4ylrlAe+Tzv/HrR1LbjH9G0ghVv/dk4T6RWCp51IlOa W7oWIgjfWxSWrPzaiuF3wKw3GAse453O3aTq7w/jnrDxirvLH9O5ZKPvJHeh77rvMTIZ rxjVqFDXfEbkjiBkPT93EnsGv00cXjBQYK7lWVufv5vp7OvESU2DheWK1qDrLONNf+Cm +VVw== X-Gm-Message-State: AOJu0YxAndoK48Csfv7UekwKdfJgXjQishEnZkquG6xoZnY9o8UhUPKT 9znwgujEiHciMKA16G0lwbwrwZyXFf2YMqjRgev4Y8mzipSAQyL2YsbxlWQtBzy9+DUH1r2ZCc0 5zcKX5LICbyvzVjTAuTeC7fGDuCmU+uImfV1yyZ5UDvM4fZZc X-Gm-Gg: ASbGncsrmutY9xyqBIv1vaE/O8pSDxsygyYf+qfnmma93ieK7r4h6nQ1JjvxSMI0tJd 5YPlVf1AKp/PLTbOm7ssGUKckSA2//EflwKbjZF/l+CmcZqpGIIKxJpUaNkYU7ULN8JtOH1sADE pBR+B1WSb+aBtxfxzivZKMU6omMqGsOLuRRHpssFIW2slpnpaFRp6wcbe9xCsW0Nz1+lzj4iMJQ pWVNHF9oZDrK9kcs02j5arqwIFKTXTbo8I49pRrgV5yQvAyDy9nwSR2WGuvndQAGh8EuiyTx4nz BKKY5jSaJwt7GI+20znHu0WbnkJdP5xpKiMhvF2gIe8KS3Y7cn9t5w/yzsFHMJkQcmyHExotzDx lKtWwTNzuQLOJ6yqaOirOn0CJ65CH4F1IX5gc0JY6I10= X-Received: by 2002:a5d:59a7:0:b0:38d:e304:7478 with SMTP id ffacd0b85a97d-38f7082b185mr23251360f8f.38.1740584113448; Wed, 26 Feb 2025 07:35:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IFp3v+bzi9Bw7o6djX9Ddt+sNpMhqZb5smTuPUCjkfiZJUnTn4b/UNLDawFdnr1VzSuvm/7yA== X-Received: by 2002:a5d:59a7:0:b0:38d:e304:7478 with SMTP id ffacd0b85a97d-38f7082b185mr23251341f8f.38.1740584113107; Wed, 26 Feb 2025 07:35:13 -0800 (PST) Received: from ?IPV6:2003:cb:c747:ff00:9d85:4afb:a7df:6c45? (p200300cbc747ff009d854afba7df6c45.dip0.t-ipconnect.de. [2003:cb:c747:ff00:9d85:4afb:a7df:6c45]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43aba539466sm26915835e9.18.2025.02.26.07.35.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Feb 2025 07:35:12 -0800 (PST) Message-ID: <3d372e93-599b-4072-955c-44c98eca469f@redhat.com> Date: Wed, 26 Feb 2025 16:35:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: swap: fix build warning when CONFIG_SWAP is not set To: Kemeng Shi , akpm@linux-foundation.org, kasong@tencent.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250226182511.592796-1-shikemeng@huaweicloud.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250226182511.592796-1-shikemeng@huaweicloud.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: n88-Hoxduxg1cjbpbaADRm1U12YRqCVUbFj1RDFGw64_1740584113 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: qeczfuhhjpo7di5z7jp49b3fkmk1yr3e X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C5EF82000A X-HE-Tag: 1740584116-602260 X-HE-Meta: U2FsdGVkX18vegVPtZ5YMLQ2it/Ht3NfUnrvycHFLUmSJGr7b78eO/BU8bzwCaqc/7dN3l2kd2t3aG6ljsVHS46Z8YeCpO3dlneKZQLKkXQ+yPd+OZkIDylU86TZB+7qhc3h7cxM2Ot3uU/Kdcd6cMiFHySDpn71+tu9ykI8JJzoE7bu3iPYqoNpaLFt5H4E4aTu/pTSvwHfTy9jQjZyk5NiUBVjPyZ4lEaBXDBQZeLVj53k8urrUoDJcu2KJm1jkYZE06KFqXpFfglCFXqKXHm6RgMTvR9bQ5g+KhCYzppL+T4eSgRXP3RKXRIRBvQKY3q7g6LAPcKMKOaSCTHFEBiwWEjFXvYk6QgXCK3Q03/I+P1cnSmU5ek60+4A/zweVd9hLWllKj0Ddo4yVrcFjALqNt5lWAnUs71rURSELhLNuIkWpWbOGcScepI/ayDzeSVm5XXY6zT6zm8ZaBXfKj8ACmCyKpFGV6udfie4J50TZNJrqA3AJUr05MzMg3P0imRh5jXyBWBFhYGM0EJc4oxsQNn2O7N3mmu+MLfg6RFp/dW7w2S3o1Mqjy3cRQ/cHUS2tzlnPTt2wAZJ4Ss7/jtShKuLIvQUzsEfEV0j3LrkdrYwUkj5u3Dc3I/ceuIuyQdrS6yyhk4TpGC67p4wUjn13Qxmh04jAm0jTLpPBOtWbx/bzZ2t3gi6VX8pC1rvbACh+mHXp4Werf35VFpHJth22GEXnaAGhL6WdbJh6hPPm7On+/uGcoaNEyzOXUk8kuQCsiEKmIfmk4nqdM+bW7L/R1uMPnxQT5cQ1ZVujyRt8LffPSMLTFaNmic9kt3avwdwk4dWF7ji4SOhUm3sJA8hFBtYzbgYr9W7Dlm6my2WU26TZ+ZiFRvRvgYuOgX4MYYpPogMJ8OMiAawGgLJYjTO+XpAye8/1DUoRqpTRdiSNvEGNQDspjBJfQ6q/zWZDR1VBuRPHNafNVX9CSz 44TYbGLl AEsArwF/r2kb5rafPsGzKZgfrkhL6CMrngQ/ALLDlJlGRGndbL1oaxgNMkegmdDlH3Mc5BHGcraeTje7uOhvFposRqLTsSacgyI+94fh38MHff93CpJ3zKTo/Rynbcpn17pGGLBkmwiHUlciBj8ksX6sde1ACekTzGmgNzYAGAsSVuawZ+ufrGAnjE278z37QQUvGp0CXbQ98ANrti5DiJMu0fb83jI2A/XSgsk4S3r1kDVv1GFQ/iAOTE6IJV8SuPcVDipwMmzqx1iNKcJFGiMEAo1pj546vdomh1rYJtDq+1f2PTXNTwgPDMFYgkNnNcp9t4KsFT2t+TJk33G3K9qwnXxa6LZaHFNeMUU3iQ3Ds3DyxtJqI2oBJpnuyaD1MfcyNwTDlSRy3gXLfZqmY641R+ZgwAcoX3RLVRUB3oGE9PDl8URdEzzOCfR7CU/UVZ9e/u+yfSIgtocetAuTg2Tk+leUlQew8326TcwvQM9UggcYNbBPsfQMw5aMaYKzonZ0p2VXPzPVRuddInWQmdW5HkSsfuBkvnYG1uvGTsa9Ik0Fbtyt+k+3nM5pniEEJxgai+kavRehZLd8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.02.25 19:25, Kemeng Shi wrote: > Fix build warning that folio_alloc_swap is defined but not used when > CONFIG_SWAP is not set. > > Fixes: b79768ab943cf ("mm, swap: simplify folio swap allocation") Not a stable commit id from upstream / mm-stable, so this should be squashed into the original commit. > Signed-off-by: Kemeng Shi > --- > include/linux/swap.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/swap.h b/include/linux/swap.h > index 3a68da686c4e..d1f5414ea537 100644 > --- a/include/linux/swap.h > +++ b/include/linux/swap.h > @@ -587,7 +587,7 @@ static inline int swp_swapcount(swp_entry_t entry) > return 0; > } > > -static int folio_alloc_swap(struct folio *folio, gfp_t gfp_mask) > +static inline int folio_alloc_swap(struct folio *folio, gfp_t gfp_mask) > { > return -EINVAL; > } LGTM -- Cheers, David / dhildenb