From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54110C54754 for ; Wed, 14 May 2025 23:43:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 839886B00C4; Wed, 14 May 2025 19:43:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F9586B00CE; Wed, 14 May 2025 19:43:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FD866B00CF; Wed, 14 May 2025 19:43:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2692A6B00C4 for ; Wed, 14 May 2025 19:43:13 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 574201A11FF for ; Wed, 14 May 2025 23:43:14 +0000 (UTC) X-FDA: 83443141908.15.E748EDB Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) by imf18.hostedemail.com (Postfix) with ESMTP id 88F341C000A for ; Wed, 14 May 2025 23:43:12 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=1lyph3wx; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of 3jyolaAsKCMAgiqkxrk4ztmmuumrk.iusrot03-ssq1giq.uxm@flex--ackerleytng.bounces.google.com designates 209.85.216.74 as permitted sender) smtp.mailfrom=3jyolaAsKCMAgiqkxrk4ztmmuumrk.iusrot03-ssq1giq.uxm@flex--ackerleytng.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747266192; a=rsa-sha256; cv=none; b=JLOFE0GAxi1oRJfJnhVqIK42EljcQtm6b/LtnmGb1G7RiUIfrbl08oc/qPHgNf0Mz0YOgK u6zIVoHAfwbbQ55YE/53KbPXzD7mdh6kSfud1zdVopxJXRQ2atpxkjrUVRFxIO0XIp+Aiz d2fxl6gqgh67ldd+6RZapDffY+VwNkM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=1lyph3wx; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of 3jyolaAsKCMAgiqkxrk4ztmmuumrk.iusrot03-ssq1giq.uxm@flex--ackerleytng.bounces.google.com designates 209.85.216.74 as permitted sender) smtp.mailfrom=3jyolaAsKCMAgiqkxrk4ztmmuumrk.iusrot03-ssq1giq.uxm@flex--ackerleytng.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747266192; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XIQY9yLRzDdCwjnfungXTg71dAj8IwxkOejXFn+6ono=; b=tQu/9Fv3sM7uzymCgicU7hC8Tpt0R5UCYzRMPYh3Uc9GY51YkyQpgWOa42HKZmzsy97ItE 6wUl1xqreSMzUEzLtonWm0tDqiU6Bw6j/hO4onxG19GPvCdY5tMH8xDgp3iJcBb2ebH/dJ i38at2XoBQOs3G2IbT+kCsuuPs+CQ2I= Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-30ad109bc89so371195a91.0 for ; Wed, 14 May 2025 16:43:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747266191; x=1747870991; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=XIQY9yLRzDdCwjnfungXTg71dAj8IwxkOejXFn+6ono=; b=1lyph3wxDc5VrkWtx8ZXgFwa6U08hME8gWnbygcmjZqWpLCdSkl8MXccSTTXPP7SaS NcomFDobDDSbXM/XZvVkLYJhJSidhRjcJVh0wWy87ZWjG3H2CH1vmLfcTyxEcA2Ree1p Uvv49/wcPo3KN/DVrzXiBRRG0Qm8cFTnGiQOslOiTkweG4EC7Zv7T6RFRVwl2qcJOSSA 4k1UTcxgCBmXoUTP+yxbFYytWI2K0uocidJvjMrvqPfzOp3J+WUSNtPsOhNgbXQsz7xL ZFsXAWt6R+RMMI7fDSLzI3WzwHEi7s8s2yPZ2Z9Ko1dSCxdRmTElUTl5OIJEj9fNiiIH 0+eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747266191; x=1747870991; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XIQY9yLRzDdCwjnfungXTg71dAj8IwxkOejXFn+6ono=; b=AxGThvfGz83LANPJuLbZqtBgiWNF6Zj1XOkBMxYRuNQEJWfalSdC9qVV3fD87RGapT KmKxEiTaX0A/Vm/UAQSvwlDOUcim0wN6ks61GKzPkYf8H7V4IAE4FiYQ3c7Y1UDpLMCi 27QAzrG2vJMBknvBJKButll1inOnYltXgE/o8BNVBtE8LJBn6lmU9luG067deChiEFWv 2ORbONQWj+bMtzxHfrC5IK1mNbRynD9rsLv0K6z3uKKOL7e7n5iG48xiXQCT8vlkijM+ a+ML0rDHII3/oIazq2m9zAQyxGnc9CLNB/RpKohRDcvxkCUWpSCiYU6EKK1uZQHUhAeg lX+g== X-Forwarded-Encrypted: i=1; AJvYcCWxWpWhSyAcT1rrs4lSoH9OyapO3eslR6H3DF8hLOBSHDzmXyuTZIoLU1FFAgQoRVtleM7BJuxDhw==@kvack.org X-Gm-Message-State: AOJu0YwTLYCI0eX6lAMasRdFy6esCLaflsSt3aGffoW2n6Q54opqPtEB +lTEb5sX5aDpVc5anTYuOyRPYm/0cAaZB4L3BzmN16FDjU0U06RKSNmDdPUtGyq5p/jUtSlrhAD nKkoj+E8bKGf1oHuClC9BBg== X-Google-Smtp-Source: AGHT+IHC0afSzx4CRGLb+NEtt5FopkBc14R3Tsx3Oo5v/U8eDsNNnam5RHpBwQ1p1qHPCM63buWzU71Ko18fm+qY7w== X-Received: from pjbnd11.prod.google.com ([2002:a17:90b:4ccb:b0:2fa:a101:743]) (user=ackerleytng job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2d4f:b0:30a:3e8e:12cd with SMTP id 98e67ed59e1d1-30e51914e56mr638587a91.22.1747266191346; Wed, 14 May 2025 16:43:11 -0700 (PDT) Date: Wed, 14 May 2025 16:41:48 -0700 In-Reply-To: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.49.0.1045.g170613ef41-goog Message-ID: <3d2f49b409f1d6564eaff49494789908eb9b74e5.1747264138.git.ackerleytng@google.com> Subject: [RFC PATCH v2 09/51] KVM: selftests: Test faulting with respect to GUEST_MEMFD_FLAG_INIT_PRIVATE From: Ackerley Tng To: kvm@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-fsdevel@vger.kernel.org Cc: ackerleytng@google.com, aik@amd.com, ajones@ventanamicro.com, akpm@linux-foundation.org, amoorthy@google.com, anthony.yznaga@oracle.com, anup@brainfault.org, aou@eecs.berkeley.edu, bfoster@redhat.com, binbin.wu@linux.intel.com, brauner@kernel.org, catalin.marinas@arm.com, chao.p.peng@intel.com, chenhuacai@kernel.org, dave.hansen@intel.com, david@redhat.com, dmatlack@google.com, dwmw@amazon.co.uk, erdemaktas@google.com, fan.du@intel.com, fvdl@google.com, graf@amazon.com, haibo1.xu@intel.com, hch@infradead.org, hughd@google.com, ira.weiny@intel.com, isaku.yamahata@intel.com, jack@suse.cz, james.morse@arm.com, jarkko@kernel.org, jgg@ziepe.ca, jgowans@amazon.com, jhubbard@nvidia.com, jroedel@suse.de, jthoughton@google.com, jun.miao@intel.com, kai.huang@intel.com, keirf@google.com, kent.overstreet@linux.dev, kirill.shutemov@intel.com, liam.merwick@oracle.com, maciej.wieczor-retman@intel.com, mail@maciej.szmigiero.name, maz@kernel.org, mic@digikod.net, michael.roth@amd.com, mpe@ellerman.id.au, muchun.song@linux.dev, nikunj@amd.com, nsaenz@amazon.es, oliver.upton@linux.dev, palmer@dabbelt.com, pankaj.gupta@amd.com, paul.walmsley@sifive.com, pbonzini@redhat.com, pdurrant@amazon.co.uk, peterx@redhat.com, pgonda@google.com, pvorel@suse.cz, qperret@google.com, quic_cvanscha@quicinc.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, quic_svaddagi@quicinc.com, quic_tsoni@quicinc.com, richard.weiyang@gmail.com, rick.p.edgecombe@intel.com, rientjes@google.com, roypat@amazon.co.uk, rppt@kernel.org, seanjc@google.com, shuah@kernel.org, steven.price@arm.com, steven.sistare@oracle.com, suzuki.poulose@arm.com, tabba@google.com, thomas.lendacky@amd.com, usama.arif@bytedance.com, vannapurve@google.com, vbabka@suse.cz, viro@zeniv.linux.org.uk, vkuznets@redhat.com, wei.w.wang@intel.com, will@kernel.org, willy@infradead.org, xiaoyao.li@intel.com, yan.y.zhao@intel.com, yilun.xu@intel.com, yuzenghui@huawei.com, zhiquan1.li@intel.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 88F341C000A X-Stat-Signature: 5k1qzzigsiijg5ukyeox4zu3fre9497p X-HE-Tag: 1747266192-585959 X-HE-Meta: U2FsdGVkX1+Om70B2T7ynIBapTY5tWMSGid0O8ndQ9W0duP29vKOkgcYqqw1mGgCVWiJn7uaPrH6ewlO18E2FxV6kbdqEUAOrTGc0+NXA9AD0av4ih3zUPX/FW/5ISKRZaQVWpVV7AGX1kT/gBw8p2kpVL5LSClhQ41NueUNUD8mdSnV3f5INl6OYUFQFr89NgCCnplSIcwNWTAWu/53yhr/W1wD46208+b9OmCzUk0sFNt62dUYkR+GlcvYWtfxxkqwjVMRTshmnTmIKjqbzzg3bfZAVAlOmi4LXvHqxfsR++kJb0hWojdWk+zGoYw9DrYd51K7CAh29NVd5hbC3kpH+9ps/+8b1NBcxon/y9jWnkTSo22L1C0oOMx7Xaux9YrgeAVE7LuzZIuE+e2AtcMey5fhvDHd6sKiQm/hE+oeUiy3+IfyV/3dW0x2DRqTUaoZySVnvUNfFdzxJ+4WWpc+IMa0K/xHJFxIZw6Gmd5Iwb6hmfrg7ZDo/k+9fn8HOEbY9YMdHtg4uwiEcofuLjbaiGU2NTSl2DMr6/NotIPNirvKBh4nYqawVk8SZOzyl+Rumj208ba05ENP9vFP4WnddjvOkiJLUtVaL1nvDjDl5zgDNiUkqPfEokyaEkTsvTmiNE4rx9NBxI9dOu6XSXudeqqwIImSLdIJLt2RPHYW+eXCGG5tYsFaR0RXg2WoMCppgJcKwwHIRV+2phz1OBKrAJer7HIgvTGok8vF1Goe/uh8ruqXi/rfEmNqcjsN5BGN73moYSu8GUlODyrDxnNC7YjJRUvw/AHgzvFpid708G2h+f2FR7Lzx02wMAbg28AIBO0JSCbfSqxzVgyHEgouXv8jZr2buVwZ/NQbeSeDI0yz1DDtDYZiq6w7w9Zz65s9vRqpbu/it5QiKlJLNlx81qHkaqKmUqTis2cr/ssO9Ly3oU+chkkNTvxlszlVek7kS4ZgysMMMwA6J4j Dfr5Vc6M sMbBLniMO1C10d4DD5WJRB9HSFF5LOBUWtInJynHZhngC2xKs+3Re0i2NeHnTUwtmB/iBu9ubU84vQZWUzkOBQOOUzx2vSDit1ko/RZaf62dDd0sI+xR54hnmQUCGHd/K2TbqzcDqt1kNMVUl6eZ5nVsl8edjpkB4J4jKeYBPCoMb+bphbsY42SxrBfEMyZy7RkkjAkxKFmwhlqRZS8oWsvfDopYUwb8bD8xEA/SuRDLS9vFYYeIJXOsICmga2cYeRd7nxDkXWu+aJQS1gyKoYoPjaM3/4cXvMikARXU5fjjuGx4YnWoRuii4Ssmyy2Okjl6NDYfrWEaU9iTFC6gg4IrA6Ui4AiUTgZL8dLhKiavznkkDNy5lPADgvMGCwaaVDAmEFepfIndWoGDUChuCVOHLaiGKIJgMNs1A+pESQRCa9n0GPHP/0CyFuKPVzEo4fXo4lAl0D+lOoVONsDphAE8x72OM1FqYTaXjy03VV/e2aRaP/T0uc/MxN+sh1zC+LCHFcaVmVyfuHSIAbYnjjAi9EeAAAAuYQpc+RaOfYFCvUrlde2h20UluvNl2UVeFZ3t28znM7F8cEaKpHIXZs7B3LsDMKZlhvWt6AtSUjorYrD8uttTLblyR74+eRVmRERPUCeY2Jlk8DJ0wFNel7Cihp23SSi24HeilirYgY8SHP2DC+ugDU23fSKfuQFLxtNpe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Test that faulting is denied when guest_memfd's shareability is initialized as private with GUEST_MEMFD_FLAG_INIT_PRIVATE and allowed if the flag is not specified. Signed-off-by: Ackerley Tng Co-developed-by: Fuad Tabba Signed-off-by: Fuad Tabba Change-Id: Id93d4683b36fc5a9c924458d26f0525baed26435 --- .../testing/selftests/kvm/guest_memfd_test.c | 112 +++++++++++++++--- 1 file changed, 97 insertions(+), 15 deletions(-) diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c index 51d88acdf072..1e79382fd830 100644 --- a/tools/testing/selftests/kvm/guest_memfd_test.c +++ b/tools/testing/selftests/kvm/guest_memfd_test.c @@ -16,6 +16,7 @@ #include #include #include +#include #include "kvm_util.h" #include "test_util.h" @@ -34,7 +35,7 @@ static void test_file_read_write(int fd) "pwrite on a guest_mem fd should fail"); } -static void test_mmap_allowed(int fd, size_t page_size, size_t total_size) +static void test_faulting_allowed(int fd, size_t page_size, size_t total_size) { const char val = 0xaa; char *mem; @@ -65,6 +66,53 @@ static void test_mmap_allowed(int fd, size_t page_size, size_t total_size) TEST_ASSERT(!ret, "munmap should succeed"); } +static void assert_not_faultable(char *address) +{ + pid_t child_pid; + + child_pid = fork(); + TEST_ASSERT(child_pid != -1, "fork failed"); + + if (child_pid == 0) { + *address = 'A'; + TEST_FAIL("Child should have exited with a signal"); + } else { + int status; + + waitpid(child_pid, &status, 0); + + TEST_ASSERT(WIFSIGNALED(status), + "Child should have exited with a signal"); + TEST_ASSERT_EQ(WTERMSIG(status), SIGBUS); + } +} + +static void test_faulting_sigbus(int fd, size_t total_size) +{ + char *mem; + int ret; + + mem = mmap(NULL, total_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); + TEST_ASSERT(mem != MAP_FAILED, "mmaping() guest memory should pass."); + + assert_not_faultable(mem); + + ret = munmap(mem, total_size); + TEST_ASSERT(!ret, "munmap should succeed"); +} + +static void test_mmap_allowed(int fd, size_t total_size) +{ + char *mem; + int ret; + + mem = mmap(NULL, total_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); + TEST_ASSERT(mem != MAP_FAILED, "mmaping() guest memory should pass."); + + ret = munmap(mem, total_size); + TEST_ASSERT(!ret, "munmap should succeed"); +} + static void test_mmap_denied(int fd, size_t page_size, size_t total_size) { char *mem; @@ -364,40 +412,74 @@ static void test_bind_guest_memfd_wrt_userspace_addr(struct kvm_vm *vm) close(fd); } -static void test_with_type(unsigned long vm_type, uint64_t guest_memfd_flags, - bool expect_mmap_allowed) +static void test_guest_memfd_features(struct kvm_vm *vm, size_t page_size, + uint64_t guest_memfd_flags, + bool expect_mmap_allowed, + bool expect_faulting_allowed) { - struct kvm_vm *vm; size_t total_size; - size_t page_size; int fd; - if (!(kvm_check_cap(KVM_CAP_VM_TYPES) & BIT(vm_type))) - return; - - page_size = getpagesize(); total_size = page_size * 4; - vm = vm_create_barebones_type(vm_type); + if (expect_faulting_allowed) + TEST_REQUIRE(expect_mmap_allowed); - test_create_guest_memfd_multiple(vm); - test_bind_guest_memfd_wrt_userspace_addr(vm); test_create_guest_memfd_invalid_sizes(vm, guest_memfd_flags, page_size); fd = vm_create_guest_memfd(vm, total_size, guest_memfd_flags); test_file_read_write(fd); - if (expect_mmap_allowed) - test_mmap_allowed(fd, page_size, total_size); - else + if (expect_mmap_allowed) { + test_mmap_allowed(fd, total_size); + + if (expect_faulting_allowed) + test_faulting_allowed(fd, page_size, total_size); + else + test_faulting_sigbus(fd, total_size); + } else { test_mmap_denied(fd, page_size, total_size); + } test_file_size(fd, page_size, total_size); test_fallocate(fd, page_size, total_size); test_invalid_punch_hole(fd, page_size, total_size); close(fd); +} + +static void test_with_type(unsigned long vm_type, uint64_t guest_memfd_flags, + bool expect_mmap_allowed) +{ + struct kvm_vm *vm; + size_t page_size; + + if (!(kvm_check_cap(KVM_CAP_VM_TYPES) & BIT(vm_type))) + return; + + vm = vm_create_barebones_type(vm_type); + + test_create_guest_memfd_multiple(vm); + test_bind_guest_memfd_wrt_userspace_addr(vm); + + page_size = getpagesize(); + if (guest_memfd_flags & GUEST_MEMFD_FLAG_SUPPORT_SHARED) { + test_guest_memfd_features(vm, page_size, guest_memfd_flags, + expect_mmap_allowed, true); + + if (kvm_has_cap(KVM_CAP_GMEM_CONVERSION)) { + uint64_t flags = guest_memfd_flags | + GUEST_MEMFD_FLAG_INIT_PRIVATE; + + test_guest_memfd_features(vm, page_size, flags, + expect_mmap_allowed, false); + } + } else { + test_guest_memfd_features(vm, page_size, guest_memfd_flags, + expect_mmap_allowed, false); + } + kvm_vm_release(vm); } -- 2.49.0.1045.g170613ef41-goog