From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8698DC54EBD for ; Mon, 9 Jan 2023 11:46:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA6408E0003; Mon, 9 Jan 2023 06:46:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D56268E0001; Mon, 9 Jan 2023 06:46:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF7148E0003; Mon, 9 Jan 2023 06:46:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AEC9B8E0001 for ; Mon, 9 Jan 2023 06:46:18 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 87A0E16081F for ; Mon, 9 Jan 2023 11:46:18 +0000 (UTC) X-FDA: 80335082436.02.7D2C332 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by imf24.hostedemail.com (Postfix) with ESMTP id B849B18000C for ; Mon, 9 Jan 2023 11:46:16 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Ko611myl; spf=pass (imf24.hostedemail.com: domain of ttoukan.linux@gmail.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=ttoukan.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673264776; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D+muiZeRodWSdkGCQbmoSfuYJGII8UbIeUoLS/b6C+I=; b=WcAbv0Wxy8YVP+i2nVqWuzuxh4fbK2idudhle+vVNo111IaXlfmprMr1bPz4X3ituDht9J BYiY+qPjNGOmHnupAWMopGNJaq+qv6FVIo0KUgRwHhXlCxsW0n0tTAAwX3YummtsS39mCu 3+gbYfXdZihQD8nyE2UUB+FtVs5l4AQ= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Ko611myl; spf=pass (imf24.hostedemail.com: domain of ttoukan.linux@gmail.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=ttoukan.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673264776; a=rsa-sha256; cv=none; b=bMndG1GsETziFYte1mzBAfJWb3jrD+E+abRsOv2ym0GsiwoAlmlOLuLawho2tY+sTIfNml F87jECa6k9erjsRP9k+S2TYejp8C8VTXWfML0rEG+pqpfR4JLgW9FTAI4knvghgkNvrmD8 B+US8i0Pju4EUwZGfiyt65W1gRsJ+pY= Received: by mail-ed1-f54.google.com with SMTP id v30so12081819edb.9 for ; Mon, 09 Jan 2023 03:46:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=D+muiZeRodWSdkGCQbmoSfuYJGII8UbIeUoLS/b6C+I=; b=Ko611mylRP+u+n9GKoJjXB5WjWuyXhCN6znGhD3ifhT+bb3P66tvUnW92lps9qIrVv wsIRS3bP0+GFLE8GKK4U623KGsd4Spe9MMCitcgWinq019sms/afeUIEdlao4Spaft9k wUC4oFoRROEkHlPvUnxSj+bCsJTkBfh6GQ2MkoUZIp9oDn6iuNitXywxtfvloRXon9Sn gviMd2axNbEt5P0hGP5NssEY8Yp5SGA+UmkWfvSHVWqe9ZOw+uMMR8QUnUoFzdTCGiwX zshF9n0jmLgUpbm4CTuyUBq4vy3dYsErtmslQUsZ/Cy8tS972SGVOHfiMBaqC/aQedgE SLmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=D+muiZeRodWSdkGCQbmoSfuYJGII8UbIeUoLS/b6C+I=; b=pDUaPu0rCC5GEEgwruOCjg0HNx51tWfXp6qEq45fnNVqM1rUY90tvMWqwH/ygv0eBR BEXVLQjPPvyVSSkkwxpnHtHyiuAQyBw82NUyc1iEv43vpeQjybpG3edAy3etgLdJJvHE Z4BgjAScSWIxuhbe1KfIqcw8w06BWBlE592pyvYNgabG8xGjSrayYtI3tDZ0cZnGgEqL Y/i4gMEZS79SB7YJFjJZq/fi4MEucvKuxil17xwUg2ClnGqOktuncRl6fVYnlZEnkj/W VwulBfAdvQN0JncBGjFB0frtmkNDgw9Pit96Qm+s6/nfLWErDmkvXdPbbC6uVkCrKaEO TSBA== X-Gm-Message-State: AFqh2kqjAG2beINZxP+/v0I2H/10QT2Nzx/8zO9cn2iBBRuqdwLxkM4r zdaZTIlD0uLKVAJGTrV+3jw= X-Google-Smtp-Source: AMrXdXsvpl54//VKNGLg1WYd0fr576hTC2kKgjV2gAQCjdqSWcucTid0NkpQ/sdfp+n2SPm7wT43ww== X-Received: by 2002:a05:6402:b31:b0:497:948b:e8 with SMTP id bo17-20020a0564020b3100b00497948b00e8mr7710306edb.6.1673264775197; Mon, 09 Jan 2023 03:46:15 -0800 (PST) Received: from [10.158.37.55] ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id u9-20020aa7d889000000b00457b5ba968csm3644898edq.27.2023.01.09.03.46.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Jan 2023 03:46:14 -0800 (PST) Message-ID: <3d2db7f2-9e3c-929c-de41-c3f0011839b8@gmail.com> Date: Mon, 9 Jan 2023 13:46:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 24/24] mlx5: Convert to netmem Content-Language: en-US To: Jesper Dangaard Brouer , "Matthew Wilcox (Oracle)" , Jesper Dangaard Brouer , Ilias Apalodimas , gal@nvidia.com, Dragos Tatulea Cc: brouer@redhat.com, netdev@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt , Saeed Mahameed References: <20230105214631.3939268-1-willy@infradead.org> <20230105214631.3939268-25-willy@infradead.org> <6ebfda57-3a01-7fe2-4a95-65108a02e887@redhat.com> From: Tariq Toukan In-Reply-To: <6ebfda57-3a01-7fe2-4a95-65108a02e887@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B849B18000C X-Rspam-User: X-Stat-Signature: auif5ug7zarqyq4xp968o7q4f8d33ie7 X-HE-Tag: 1673264776-556394 X-HE-Meta: U2FsdGVkX18BvasNmgA2sG/nzlpxe3MfJZBnzQtvJ62oepcvIJVT8DCDYeqSdBznBwxyKjeTLRk1fcl+vhUmm9JkotM+K8vw+wV1FO6HRL3TnE+M5nGJe6/NrGmr/WxKv0CVRfl+ECXV6Q1PUxup6Z5+NQjSWfn6f4J69HsxJe6t3KUVKZDy+iP/p9hJy/am3b3tvWsIKPHQ1cLrasMx8dnTPKMHOkD+vFJEDOa6/gMi3RRlNkbHMTXNJjNVZjLDiK4L2w/8JqWDs2LTZfwZKYuFdh91jRKWV2uPCPRSPA9iVreYQilu00mmykY8sUA59Hl+GsvfsivgJOx6r4J1H5ML+ePJ0zQvNekrk8e3+Ym6VEm4ly+a9DjCMAQ1MGYWdAYoEoj0UrroWFogq8oyqkyE6NLVTa4Ki7Urn5Ig9JQf3sOOQPTg7R2+RMPGVUD3qlx9z9PwVzOwptV7Xg/svgWcOGKiOfy+s6of+L1mjd2Ttn1mkiPcE41+FRIKBcwmm+2iV/RQlLRbwvJWbz7AV92fHXw/EPvPs/22oyR/KfcsRQaSFKhYMVZukKZlv60KJe8A6L5/faWj8HcI25IonYD3mmPwusxFfY2XUtu1bREDlblk/B/3y7t9cavZDJfNuo4865uvF9T/NP+5VMn+Kimz6Y2rC+OBjCkZ1VNJS8kbQxOOHkx9ltzHJU5Uhg4r6IN0HAuc2YhQfG06tcYY+oGRWLJydivPDsY2GhB5C1rtaQ2ip97lnbONXtPTAyZzFjfPsr5jQ+LufRZmVJkqAbM9Xpwlc5+yhnYWplCi5lvmZLmDuhjm5X2ceK3nr7RJ3jMWRwaXlj372MwdYttSb7+2AVcaIycvl59FGs/5n65SJz8aK/gqiDt1VRrHxjTxHhIq1cACpeTHu8x1koVfaZ7T6ImleMD+k0gmpA35hl1670wyh/vmwXnkdhhA3aF8zkzfY0+D1y6tQVNQU5Y c50AEOG0 IKoWqDQz0iieGW7VVq6s7b7DYOM0qp22KOzM/rq6aDlzC8TcMvkI3dPPZtkxaipWn2sKwWn73oO7N207n0QF4OreVNVYcElSTEqCX69yUkrbtskcDOlEX5ml46A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 06/01/2023 18:31, Jesper Dangaard Brouer wrote: > > To Saeed and Tariq, please review. > Adding Dragos, Gal. Hi Jesper, Thanks for the ping. I'm on it. > This reminds me, that IMHO we/nvidia/mellanox should remove the local > mlx5e_page_cache functionality, as SKBs can now recycle page_pool pages. > This should simplify the driver and we get rid of the head-of-line > blocking issue with the local page cache (refcnt elevation tricks). Totally agree. Dragos is currently working on this task. This should clean up significant amount of code, and improve performance. We target this for the next submission window, to kernel v6.4. > It might look good in microbencmarks, but my experience from prod > systems are that this local cache isn't utilized.  And I believe we > should be able to get good/similar microbenchmark with page_pool, which > will continue to recycle and have no HoL issues for prod use-cases. > 100%. Thanks, Tariq