From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E417C4320E for ; Wed, 11 Aug 2021 09:36:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 993F160FD9 for ; Wed, 11 Aug 2021 09:36:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 993F160FD9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 42D0E8D0002; Wed, 11 Aug 2021 05:36:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3DDA96B0072; Wed, 11 Aug 2021 05:36:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CDC98D0002; Wed, 11 Aug 2021 05:36:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0068.hostedemail.com [216.40.44.68]) by kanga.kvack.org (Postfix) with ESMTP id 1282D6B0071 for ; Wed, 11 Aug 2021 05:36:09 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9DD081807EE91 for ; Wed, 11 Aug 2021 09:36:08 +0000 (UTC) X-FDA: 78462293616.10.5482445 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 3F814300F449 for ; Wed, 11 Aug 2021 09:36:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628674567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fAL7lFqNaCWC9sPJWFoOY2QAZTbHbZLMj6qk/rK8uKs=; b=Bx9E5KuNYuBTq5M16xVJKYT9PSy28O86kfajk6zQCGCm8xMrkiK5Mws75AYsi9dgVKvc2q f7CrCGUg3KxwrpjXUPCXYiPyk0+VFZCSoizfL+7RcW4Lh6Zqnss3qCwRx02+uXg83IpYLt P0S5cPj/SQhIXkzzutnx5Fv0g4mun0Q= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-455-SxieqztmO761juKeNB0GHQ-1; Wed, 11 Aug 2021 05:36:06 -0400 X-MC-Unique: SxieqztmO761juKeNB0GHQ-1 Received: by mail-wm1-f70.google.com with SMTP id l38-20020a05600c1d26b0290259bef426efso378935wms.8 for ; Wed, 11 Aug 2021 02:36:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=fAL7lFqNaCWC9sPJWFoOY2QAZTbHbZLMj6qk/rK8uKs=; b=ttMfWxKJp+lZbEiN4wRbdlt/Onlw+anp3mL4IHl2UZjA/8HwrqVqvcOIUdoVIlT1yo QmaBKo9fonMy9auxtRemccQYJOcI0CPFEnTDHBZJyGpdlGQ/NTPpRMmHH3lZM7CYjpac j8jukhraz98mdXh6g7BP76TK4vASYP+hutU7pqwxHjt+lbhyaDyLPDnUeXRJLveZJl5z ACRXfnny165vPsSogbW0gh7ApnR11qOG/8J7GFA2SdPrvqQs6J8+G27pZ1qgH4vjwPfR JlXE/1VIAvZW5TFEAkWyzRApHo6c8YiReSrPsVd0x/pP6+BUBcuSbrvyZT/60ggUhujy ZmSg== X-Gm-Message-State: AOAM533dygKcCtqfIBgXRc0wnd0WTw1XPXpsVcfde5CucJZmcV0zp2fC 2QHAbGfinxAv7+5wbIVrmV3Ahn7U+lsm51AueMP1SeUv66kiixGzqEWECuyqP/CK2oGAMId9D7v sGJtcTtzTVOM= X-Received: by 2002:a1c:20c5:: with SMTP id g188mr7314392wmg.142.1628674565340; Wed, 11 Aug 2021 02:36:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxicKBXa5SX1egzEWmTZsOp4H8+byabbdag6mjhyCrCsn4UXxoDBgtqsTunuMaWIsRg6uEBYA== X-Received: by 2002:a1c:20c5:: with SMTP id g188mr7314372wmg.142.1628674565128; Wed, 11 Aug 2021 02:36:05 -0700 (PDT) Received: from [192.168.3.132] (p5b0c64a0.dip0.t-ipconnect.de. [91.12.100.160]) by smtp.gmail.com with ESMTPSA id l18sm6275309wmc.30.2021.08.11.02.36.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Aug 2021 02:36:04 -0700 (PDT) Subject: Re: [PATCH] memblock: Add missing debug code to memblock_add_node() To: Geert Uytterhoeven , Mike Rapoport , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: David Hildenbrand Organization: Red Hat Message-ID: <3d2ce3dd-5032-89fc-822d-5288a9c460b9@redhat.com> Date: Wed, 11 Aug 2021 11:36:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Bx9E5KuN; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf09.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com X-Stat-Signature: o4od8ebzoxy4e9f46hycj6mhysuib3ck X-Rspamd-Queue-Id: 3F814300F449 X-Rspamd-Server: rspam01 X-HE-Tag: 1628674568-230989 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11.08.21 10:54, Geert Uytterhoeven wrote: > All other memblock APIs built on top of memblock_add_range() contain > debug code to print their parameters. > > Signed-off-by: Geert Uytterhoeven > --- > mm/memblock.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/mm/memblock.c b/mm/memblock.c > index de7b553baa50004c..57a9849a5d820c34 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -665,6 +665,11 @@ static int __init_memblock memblock_add_range(struct memblock_type *type, > int __init_memblock memblock_add_node(phys_addr_t base, phys_addr_t size, > int nid) > { > + phys_addr_t end = base + size - 1; > + > + memblock_dbg("%s: [%pa-%pa] nid=%d %pS\n", __func__, > + &base, &end, nid, (void *)_RET_IP_); > + > return memblock_add_range(&memblock.memory, base, size, nid, 0); > } > > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb