From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C5A2C25B78 for ; Tue, 4 Jun 2024 13:14:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9CB786B00B2; Tue, 4 Jun 2024 09:14:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9544E6B00B5; Tue, 4 Jun 2024 09:14:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A9146B00B6; Tue, 4 Jun 2024 09:14:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5ECB66B00B2 for ; Tue, 4 Jun 2024 09:14:36 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D0C2C1C0C79 for ; Tue, 4 Jun 2024 13:14:35 +0000 (UTC) X-FDA: 82193250510.14.7332E5B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 39F0514001C for ; Tue, 4 Jun 2024 13:14:33 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TMCmZCxy; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717506873; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LQiuJa6XjEMGh17HerZFZUVv0NCVs36LUrZfs91xsUU=; b=qbSfRSvRbH9eBXJolXpeyI2AeBatx7hPAYuKSwIksWJ5L7J4IX0feVS12NsQBOgElhihgS 1f5pZDl7MTlHIJNV+rL5D/EPCqJo9EeieM9TtMlDZZFx9j6wMxGNtqXae3e//D3KWl4+A7 O1+wuilpZhyiZXN9pzGptrXNc/kpwKY= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TMCmZCxy; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717506873; a=rsa-sha256; cv=none; b=Zhrn1FYC3wJEwCb8fdcbCwKikwDrzD7TlnjXs4mz0d/2BfKoV2E8scVV7f2bnMCpMdCqFn KJaK8/0XZR7m3/4IBdSTFCP8bXCDw4+v1iqIsABOq/oquWkE5aZlQF967eSZiGL6uhMXj2 rPtXLe//B0hlX27dXLfMisj9vl6ns7U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717506872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LQiuJa6XjEMGh17HerZFZUVv0NCVs36LUrZfs91xsUU=; b=TMCmZCxy0dPTSTcJj7sirYz1LozUKxSu4I4vLAz5deEOxlXvRCWY06WuEoTMG8KDM+um90 xpSEfKgL+MMBbuJbGl+ghNAfMKSM13ta1QG5Qm0Adu7yDEHhQ7HNgFt+5u36yOg5aq5ww+ XwwWBfW0i5znVkQ2S1FDUpANrw3kjts= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-98--QmUwa0fOGOE6PrAcd-l2Q-1; Tue, 04 Jun 2024 09:14:30 -0400 X-MC-Unique: -QmUwa0fOGOE6PrAcd-l2Q-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4210d151c5bso42396205e9.3 for ; Tue, 04 Jun 2024 06:14:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717506869; x=1718111669; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LQiuJa6XjEMGh17HerZFZUVv0NCVs36LUrZfs91xsUU=; b=kJ21GvKx+A+upsqaMfFu/zPx3qeUZ+CUZcssBpExGBZKiEXASQ0c0zXM8ma4WGGKC0 NZesMeUyCJWjR5BXecIcch5ec+Pu6t/7VGtTo59tKMzqgWt8nNcY+0VE0Er24WnhwFQp oo4hriKaFQCC1JlwaZ+QO2PHcTcCx3+HXJN49tRkZ130F/IwOePHGB672H6FY5xH5gLX Rx7CyD+WB2Lb7RRdRA/5OJJ4Eam6IZ6fk5Tta4amG+T3VeMJWcqD/qW2xrPb0dsoXQ/7 t/Oio+sv4BNK5LOhXvtfYnBxNOuc9NCYl4Dqr6N7UfyOusKeie5O1Zwd/kyijUNO93lU jfyQ== X-Forwarded-Encrypted: i=1; AJvYcCWRfb+IUgyVPqwC3n1mObV2Cb5vYWAa9Xc7XoBbkKqzPY05SUvt8DZfIYqzhnN2Y6BnCRJVVza/QWoBtR8bnRGV8iI= X-Gm-Message-State: AOJu0Yyu+f1NPk9qUpqj6HEI8/9pEyT5eahW/rfBeFYidQ4+hqeTGj77 exEc6SnjNAxW4GcEOCphMpjcrPSfgChOWKip51xOl+x0EExxi2GRwGfGAYVKUQ5+IW9cjFmh52G 4AU2vLCH63cHxTrOMup+Wi5F+Zda9NI9VawacASpyGvE+oA1u X-Received: by 2002:a7b:ce10:0:b0:421:2a14:3132 with SMTP id 5b1f17b1804b1-4212e0a52c3mr100630205e9.25.1717506869323; Tue, 04 Jun 2024 06:14:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE5wn67LsGXw7ypMf8z9AKW2X8rC2HJnPZGHC9fa6Le3AhDS/bTwE5fFsT6+1/khMWDkAeS4g== X-Received: by 2002:a7b:ce10:0:b0:421:2a14:3132 with SMTP id 5b1f17b1804b1-4212e0a52c3mr100630005e9.25.1717506868895; Tue, 04 Jun 2024 06:14:28 -0700 (PDT) Received: from ?IPV6:2003:cb:c73a:3a00:a025:9b06:549e:c16b? (p200300cbc73a3a00a0259b06549ec16b.dip0.t-ipconnect.de. [2003:cb:c73a:3a00:a025:9b06:549e:c16b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35dd04d94f1sm11446657f8f.49.2024.06.04.06.14.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jun 2024 06:14:28 -0700 (PDT) Message-ID: <3d2ad8a3-30c6-41d6-841b-e8c376d01da3@redhat.com> Date: Tue, 4 Jun 2024 15:14:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/10] mm/ksm: skip subpages of compound pages To: Alex Shi , alexs@kernel.org, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, izik.eidus@ravellosystems.com, willy@infradead.org, aarcange@redhat.com, chrisw@sous-sol.org, hughd@google.com References: <20240604042454.2012091-1-alexs@kernel.org> <20240604042454.2012091-3-alexs@kernel.org> <8d3a60d5-06c5-4df4-aeda-2fbec45a8ae0@redhat.com> <00dcd224-6333-4f1e-9087-bdb5024ac236@redhat.com> <9f4f6f0e-81e8-4bd0-9f20-412a543a452d@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <9f4f6f0e-81e8-4bd0-9f20-412a543a452d@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 39F0514001C X-Stat-Signature: 5kxf5jdszx8pas3kdxkubur5xj1nqyx4 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1717506873-930915 X-HE-Meta: U2FsdGVkX1/D7igjvPUZEeMYH066GGp4DBjFBsEg04iEoIw+I4iHCro9mv+1sNiESsUatPW5vRDkejHCU7CbHHRde6E13E2dD/2q/VrW4MHxmwyRk+Q79kkOpopSjpetq7gbiOJ1LKuzexZCSi+THQET5CZ+9gz4Ip/tAcyGY4TRF9v1ppC6egsjlFIHRZrww8aENBN7oW2MPvVGd+xnNJCYlpDP2X/xJn+G2h6UJ2byVZ9vRyvO3pzuGBmyZTIgSlyt/w+3WF4ZoGfGkC5iHked959lpAlud/fi49HTn2KHElF3xusUwY/NA19yi9NPkigNP/8Tk0DngIZnGVE8ZabnqRbtwdLBKtMP9cATGkqVMmziuZT2tL6ekwswmy+su9UzmuxD4FQhSneZi0PpeF4XguvAgKbec1NkYiR2MLgrvNVrOflTSHrzHl8fWYrukIFRGMnmElXb246OfmidP2QPqNyHpI2igTqp+HWW4JcXFzgJDcMY3DEURflsAQ0FvrVFCBffKbR78PBqamSiDo4neOfKxTINYcuT13Quj+g9roDacIkTfHJ5T5FcQckq3/8XjwAdfLc6BxySK2F41+HS9prHT0soVvDdQy0jXylX96YI59btOy6H7ycUE4sD7n9+o9mz3RNxuzgPs+l03Bzcz/Jn8W65FUnChlBKxmI52XppMx4oxZnclrYKsSefjZN6wH4GVy6rvN+ZmQvO1kKz5kEzv/5f5f1F/PKSHV78MsqpdgjQpyuWgojOe8GQKKCSDpaqG1I+PPsHt7r7pQ39ScMFyuvvNm5OS9JLBKbizu/rlXUKEEQZl6vwXYf77hf32WEGp3ckj4Nq4obkWuKrIwCd2sunE8gHSEz+H0553mZZUO7gLXdkIBETaJFK+URhwjbzqNZFrTBbPd/p8jtUVCzugebpM759bDkP8EYtmCXaBQG8SIRv4NnMzh/955TlTuZLqO7Soja42vc WG/NvbJR NUqnoIBy6+N18zayaLAuNlzs1U/mj89ZQ4gJJfxLDNceR6yF2ECIEolnjKmQNccdPHmVYvfBtCXyv/c4iMUJaQ2xm846N82eXO9Zd13mV+MoezPYs44Mrg1TGWW/zZsM1TQCt/9Fhd39OAYozXw7HoWy54dCirL59iG5xz3tZDEnlMIkjlnDu7S+/Vhm8AORS5rqB4OmMWvE4zdRPfELE7SFcRzVK6rXGSh1NPRcZ21DkximSpAxvzpLWPo19YxZei7pEzJEdo4IysHyh2tSp2jIK/JgVVGjpYzsik0+MAJ2MH4UAbw29fRDRoq1ecZRBGvllhgsXQR6oHLFh5DoATkrtsO8PX6nDtRwf9fpWHB6WBtJxlOC2L2ujesi7BShzLm8A/pFXIoIVgR+oapHFfEFGJCKP2UiD60rXuHqDStUaT5Y7FqxQEnZVrOoe3lmytRibEUejN37tVJfHxlHvD15krRgqye+zryNolBN555XbxsyHKYvUCNmURYh0nvP+deyG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.06.24 15:10, Alex Shi wrote: > > > On 6/4/24 6:43 PM, David Hildenbrand wrote: >>>>> >>>>> @@ -2680,7 +2685,7 @@ static struct ksm_rmap_item *scan_get_next_rmap_item(struct page **page) >>>>>                } >>>>>    next_page: >>>>>                put_page(*page); >>>>> -            ksm_scan.address += PAGE_SIZE; >>>>> +            ksm_scan.address += nr * PAGE_SIZE; >>>>>                cond_resched(); >>>>>            } >>>>>        } >>>> >>>> You might be jumping over pages that don't belong to that folio. What you would actually want to do is somehow use folio_pte_batch() to really know the PTEs point at the same folio, so you can skip them. But that's not that easy when using follow_page() ... >>>> >>>> So I suggest dropping this change for now. >>>> >>> >>> Hi David, >>> >>> Forgive my stupidity, where I jump over normal page that not to belong to the folio? >> >> IIUC, you assume that the folio is fully mapped by all PTEs that could span it, and that follow_page() would give you the head page, correct? >> >> As a simple example, assume only a single page of a large folio is still mapped, which could be any tail page. You couldn't jump over any PTEs. >> >> Or am I missing something? > > Uh, thanks for explanations. for what's we concerned, the following code could take care of the FULL or ERR pages. And it still keep the step of single page. > page = follow_page(vma, ksm_scan.address, FOLL_GET); > if (IS_ERR_OR_NULL(page)) { > ksm_scan.address += PAGE_SIZE; > cond_resched(); > continue; > } > And after the above code, step folio_nr_pages on address should be safe, isn't it? Not sure if I follow. Let me try explaining once again: Assume a PTE maps some tail page of the large anonymous folio. The other PTEs around it map some other anonymous folios, not pages of that large anonymous folio. Without looking at the other PTEs you don't know how much you can skip. -- Cheers, David / dhildenb