From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FF2EC4332F for ; Mon, 11 Dec 2023 20:21:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D33336B0203; Mon, 11 Dec 2023 15:21:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CE2C36B0204; Mon, 11 Dec 2023 15:21:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD18C6B0205; Mon, 11 Dec 2023 15:21:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AF6596B0203 for ; Mon, 11 Dec 2023 15:21:51 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7F7491607A3 for ; Mon, 11 Dec 2023 20:21:51 +0000 (UTC) X-FDA: 81555658422.02.139352B Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf01.hostedemail.com (Postfix) with ESMTP id 9965740009 for ; Mon, 11 Dec 2023 20:21:49 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IsnscW4Z; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of broonie@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702326109; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XKcK9tMFiKLbbKIb+x31FumRMH7OHV6xZlyt/EwijRg=; b=RycjeS8T26j0ffUqUxGpsRDDJCdJDHaU/oCS764BnhfJjz4kJQAkUu0XJLKrhtQbeLOxZW 5f/JSdmk0ZKg4sv8MRVYIOeG2tMsHsx6li2BqbpD6nhT+Pw0K1AJNEhdnyuW9uHZeDmGZU RvzdXQKg5cYELOuxAM7/JLymjwoPX2E= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IsnscW4Z; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of broonie@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702326109; a=rsa-sha256; cv=none; b=NSG+WVqhZpsj1R+WAUHfCvh3hfiNcTGgKB5qHv28TMNvufu1iDkRXUXkValtsgK1r5se3o QAfwx8btdYz5fmwJ6Wlx0gMG8SVaeeUecy4frwYhglacU+F98+Odmyaub/h8apL2OL47IS q4mIb9cnnNPwrzbigASRUvtv3zHtpQ0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 1E5BFB8103C; Mon, 11 Dec 2023 20:21:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB20AC433C7; Mon, 11 Dec 2023 20:21:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702326107; bh=rBpsBQzFgdCR4uHw0YOyenL0nzKHxfcOgHqKnrLFUgI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IsnscW4ZZ5eBgpkU295ZqeOTsNn9/RTDGLj7cdzfkE8r9Ykj9rjeLJWZOosb66RpM PcruomYoMTgkCOxzS7igzpPDXBSXxzbMKwDpyKmEn52XohKoXrPW+E4FaeTUTZn/vf TE3qxb83kDoO9+z3I2BE7RP6RRCqeG9Oazz/sB5uqVqZtClli7+l5e1u5pkoTigTEa V3YMc/Mulx67x28a+6szulTMl72N2/2hfHpb/71TBZBlG9ScNb/+3rwtjq8LhVoRYf 6jiEm7qGsyygnUZxQkZrZl+HWG8LWyMUyl4ymFPGxjkqmV0MNZZL8RX+rQMmNkD3Hl 7I/AKm1Q3PoWA== Date: Mon, 11 Dec 2023 20:21:38 +0000 From: Mark Brown To: John Hubbard Cc: David Hildenbrand , Suren Baghdasaryan , akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com, lokeshgidra@google.com, peterx@redhat.com, ryan.roberts@arm.com, hughd@google.com, mhocko@suse.com, axelrasmussen@google.com, rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com, jannh@google.com, zhangpeng362@huawei.com, bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, Peter Zijlstra Subject: Re: [PATCH v6 5/5] selftests/mm: add UFFDIO_MOVE ioctl test Message-ID: <3d22f342-280f-4a44-87f4-8cca291cfce7@sirena.org.uk> References: <20231206103702.3873743-6-surenb@google.com> <50385948-5eb4-47ea-87f8-add4265933d6@redhat.com> <6a34b0c9-e084-4928-b239-7af01c8d4479@sirena.org.uk> <3240f4b5-081b-4075-851a-7d1cd86f4333@redhat.com> <3eadd79c-c02a-495f-92c0-0315046ef59f@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2t6rLyxDF+xX0gNK" Content-Disposition: inline In-Reply-To: <3eadd79c-c02a-495f-92c0-0315046ef59f@nvidia.com> X-Cookie: Better dead than mellow. X-Rspamd-Queue-Id: 9965740009 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: zgmkt1ok38gd5j5jnekmgowgrgcydnbj X-HE-Tag: 1702326109-522210 X-HE-Meta: U2FsdGVkX1+1/amIDzJRZ5A4jU2hviVfTFcEpF2ErW6Hn3HQVgn8rokxB7SMTKZ5Lcn4eYEuelnlximXkx7ur8QbiD9JFZYqRW+Hc5YGcA19hk5FVGH3i2aLCe4S56XBqVJ399hNOrDzmXkPpRlIiK8tA150kVDGtfIF1dPh1PmAIyw9lulX1YYGj5A0uOoUkkKF9juUqOQHa/G1MQEzDWcTp1Xrbz/EuFX/abNKTr+3KBelbceBDlQpkhYYtFV2xiQVMWXrSQP+tE23+ZtAkDHgljJS8wEoI3D3S0ZubkWWGSkKgvTSbOwOCtNi3XsAqE6V1q7miA5x3eik//bILVJVrPK13JHRanMR3kcH/WvynDfV8Y7YvNU7RND5rB4RSSVUGZU5U8GZliBlZAZnAFLjbMG7TazpEzO/Ddl2yuHq3d3lMSn2JmOWA3+QNqMXwOePBxWZkvhc6eBJEGTaHWHKeSRhYQGsN6LkYQmFv2KniIOJeucvjAlkhBLOYVwysssEDlV0Fx0QGqL9D9MZPHw8MUkp0g2n6DG6LvNJCBJ8WZ26HkC/uOWp/1eFrdZVAkkq8c0wgbBUMh/iiK8MSkgZG3TTr8B0ynyV89YVlXf/CqFL+EF28/ykZXVYnhMkrBqbWtErRLiKuAjU9d3hhEFM6YOL0wspT4N4RGA3HNtTopL+L4vif+9X3kJlOUBywZ+rAhDVCPC+MEzKCDhHm3JFT3ImRhCrVyOsyUC8EyyLAhcbT9A03UJoGU42n+Qr7WyDJ/43fkZnXqnlQ7Hl4ogAmfr1dGKam90yAta7mjN/PGQN9RC0WbpzfDN/jX8d08S5N2CJyglvEX8DJP5BY8jL1V0WoYPKnBo8UhKZtoISvqUSunYWYRs8Bv0mHfUViUDLOnphvWaayfaSPKLtxwTt69RQoLLgmPV8qysafqmrsHr4LJ5jBVgcGzcTFQ3QRDkVmqY0Cbf5k1aW5lE exxC9YYX 5SPryRmw9Is6gU/uwicWp7lyZ2Gvyx50WIKxKrt4HhlvoRvTEPtPkLguDHq16g9DIcc6WhczMckE3zAzuYaBM3S6XQgkqJ5sebWlY+kl8S/YKMHi3C/BnbH/nlXBEbOxwc322l9YjdXHdlL08dC/ANOOe3TfulghDhSJOMcYJIigkyjgPynE+9qWfRdMtRmCrLFpeJMwWhHVYtOhZdlgisqC8BqNn9f2OfMeG8sHEuRO//9tQOaj1mR1+QA5IRjkNPO7vAEaRgehMheY4dUyMclaHOuu+jFIleAKW0Dg55OY/iZQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --2t6rLyxDF+xX0gNK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Dec 11, 2023 at 10:46:23AM -0800, John Hubbard wrote: > Or (4) Hack in little ifdef snippets, into the selftests, like we used > to do. Peter Zijlstra seems to be asking for this, if I understand his > (much) earlier comments about this. I can't help but think that if we're having to manually copy bits of the uapi headers (which are already separated out in the source) into another part of the same source tree in order to use them then there's room for improvement somewhere. TBH it also doesn't seem great to add additional variables that depend on the user's build environment, we already have enough build issues. It ought to be mostly tedious rather than hard but it's still a pain, especially given the issues we have getting kselftest fixes merged promptly. --2t6rLyxDF+xX0gNK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmV3b1IACgkQJNaLcl1U h9D6XQf9FJcaZ/aSuBGP4yhVAKDtuYM+O0Qsar4MJCFGlNRbAu/ep77u/lb6SiNm LU23BBBAiqPUIKnMW5exn+9u4d7eZg/jgUqktFGJQUooAZXP7tesJ2juToB11Von QMaHZ51yQWx/4vduSYWRr1jeH6bKVsC4iUQD8NAxCP7NgC5DqzoKkZUshRIJ1UPa m+TgJ2pDfv6sHcEeBnNvfGIUR7AtUlR+CyGsoRs+vv1EUYGuOmV46mf4w34U1FUc cSDhODvruTSYW8nNp0yvLcfzC+vgcC6N24IvLy06fYwhVWLsPx3dL089H+FYubVt 1ik547NSpFhk2Unxhvfsaj1pgPYtCA== =lcNl -----END PGP SIGNATURE----- --2t6rLyxDF+xX0gNK--