From: David Hildenbrand <david@redhat.com>
To: kbuild test robot <lkp@intel.com>, Qian Cai <cai@lca.pw>
Cc: kbuild-all@lists.01.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [linux-stable-rc:linux-4.19.y 8055/9999] mm/page_owner.c:276:10: note: in expansion of macro 'pfn_to_online_page'
Date: Mon, 16 Dec 2019 11:11:15 +0100 [thread overview]
Message-ID: <3d1f05e9-5c14-b847-347a-47446d93ecd3@redhat.com> (raw)
In-Reply-To: <201912140653.cnNEAubP%lkp@intel.com>
On 13.12.19 23:08, kbuild test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> head: 312017a460d5ea31d646e7148e400e13db799ddc
> commit: f712e3066f75996f49b60145f0329f9e078eeabd [8055/9999] mm/page_owner: don't access uninitialized memmaps when reading /proc/pagetypeinfo
> config: ia64-randconfig-a001-20191213 (attached as .config)
> compiler: ia64-linux-gcc (GCC) 7.5.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout f712e3066f75996f49b60145f0329f9e078eeabd
> # save the attached .config to linux build tree
> GCC_VERSION=7.5.0 make.cross ARCH=ia64
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> In file included from arch/ia64/include/asm/ptrace.h:46:0,
> from arch/ia64/include/asm/processor.h:20,
> from arch/ia64/include/asm/thread_info.h:12,
> from include/linux/thread_info.h:38,
> from include/asm-generic/preempt.h:5,
> from ./arch/ia64/include/generated/asm/preempt.h:1,
> from include/linux/preempt.h:81,
> from include/linux/spinlock.h:51,
> from include/linux/wait.h:9,
> from include/linux/wait_bit.h:8,
> from include/linux/fs.h:6,
> from include/linux/debugfs.h:15,
> from mm/page_owner.c:2:
> mm/internal.h: In function 'mem_map_next':
> arch/ia64/include/asm/page.h:118:36: error: 'max_mapnr' undeclared (first use in this function); did you mean 'dax_mapping'?
> # define pfn_valid(pfn) (((pfn) < max_mapnr) && ia64_pfn_valid(pfn))
> ^
> mm/internal.h:385:8: note: in expansion of macro 'pfn_valid'
> if (!pfn_valid(pfn))
> ^~~~~~~~~
> arch/ia64/include/asm/page.h:118:36: note: each undeclared identifier is reported only once for each function it appears in
> # define pfn_valid(pfn) (((pfn) < max_mapnr) && ia64_pfn_valid(pfn))
> ^
> mm/internal.h:385:8: note: in expansion of macro 'pfn_valid'
> if (!pfn_valid(pfn))
> ^~~~~~~~~
> mm/page_owner.c: In function 'pagetypeinfo_showmixedcount_print':
> arch/ia64/include/asm/page.h:118:36: error: 'max_mapnr' undeclared (first use in this function); did you mean 'dax_mapping'?
> # define pfn_valid(pfn) (((pfn) < max_mapnr) && ia64_pfn_valid(pfn))
> ^
> include/linux/memory_hotplug.h:225:6: note: in expansion of macro 'pfn_valid'
> if (pfn_valid(pfn)) \
> ^~~~~~~~~
>>> mm/page_owner.c:276:10: note: in expansion of macro 'pfn_to_online_page'
> page = pfn_to_online_page(pfn);
> ^~~~~~~~~~~~~~~~~~
> mm/page_owner.c: In function 'read_page_owner':
> arch/ia64/include/asm/page.h:118:36: error: 'max_mapnr' undeclared (first use in this function); did you mean 'dax_mapping'?
> # define pfn_valid(pfn) (((pfn) < max_mapnr) && ia64_pfn_valid(pfn))
> ^
> mm/page_owner.c:470:10: note: in expansion of macro 'pfn_valid'
> while (!pfn_valid(pfn) && (pfn & (MAX_ORDER_NR_PAGES - 1)) != 0)
> ^~~~~~~~~
> mm/page_owner.c: In function 'init_pages_in_zone':
> arch/ia64/include/asm/page.h:118:36: error: 'max_mapnr' undeclared (first use in this function); did you mean 'dax_mapping'?
> # define pfn_valid(pfn) (((pfn) < max_mapnr) && ia64_pfn_valid(pfn))
> ^
> mm/page_owner.c:544:8: note: in expansion of macro 'pfn_valid'
> if (!pfn_valid(pfn)) {
> ^~~~~~~~~
>
My patch replaced pfn_valid() by pfn_to_online_page() - which indirectly
expands to pfn_valid(pfn) again. This seems to be a pre-existing issue
(I mean pfn_valid(pfn) seems to be completely broken here).
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2019-12-16 10:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 22:08 kbuild test robot
2019-12-16 10:11 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d1f05e9-5c14-b847-347a-47446d93ecd3@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cai@lca.pw \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox