From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08A0BC021AA for ; Wed, 19 Feb 2025 08:31:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89791280207; Wed, 19 Feb 2025 03:31:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 84856280205; Wed, 19 Feb 2025 03:31:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C243280207; Wed, 19 Feb 2025 03:31:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4BC57280205 for ; Wed, 19 Feb 2025 03:31:58 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EF20D14130A for ; Wed, 19 Feb 2025 08:31:57 +0000 (UTC) X-FDA: 83136026274.12.D581C8C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 81A7C80014 for ; Wed, 19 Feb 2025 08:31:55 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MOw1Xxcz; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739953915; a=rsa-sha256; cv=none; b=CQ1sv8sYrSCsF9qKbAtAIuD3+rCenV13QSlpPRyLh7+DSx+I6gwsiNi1pI40IVDVeoQJiS 6KdxbOZwsqIBAYe7y+MLfTcbF0eV7u9fGtgQ2JfY4yK5hWydPYrMyFcBG2bUjPz7T2Fth/ fxfL5lsAGiLvr8CqMyrUQ0AI6iJDtko= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MOw1Xxcz; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739953915; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4JbRdqdYJQdJMppsYc3IVc1lHy5Cz2pY+l6GdpwErAU=; b=I4lslwi6XbMZQd9U/oyMieDj1yVoPr/iP/77d248gSBWAm8wNDEVwIRjxesj6uBO+esQ1u Y/DeDfnr9WvxfyYXWQoeglxucVcdvYZbPW+jMQKtycb1Efd+ST3LXtqBCs7li6ibOuFT/c RIEentKiefyZfPF2KI7sqPFRNxpv2P8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739953914; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4JbRdqdYJQdJMppsYc3IVc1lHy5Cz2pY+l6GdpwErAU=; b=MOw1Xxcz3k5xm9yo1H5PPbPlgjoOzkDwduXRe/l1QHypN5yUNc39YVmx8GsQKKBnwABDmX d5UmJTJsp7ba58oGY4A1iQb4QnH8SW6xG3TZ+1L+bnw9TGij1HBvs+IsBVWJOTUqqGI2j1 RQJwuiZKgY2w0BSv9q+FZm6FT+h2nZ4= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-177-eNr8zZ9SP0K6NIuQHbZjhQ-1; Wed, 19 Feb 2025 03:31:52 -0500 X-MC-Unique: eNr8zZ9SP0K6NIuQHbZjhQ-1 X-Mimecast-MFC-AGG-ID: eNr8zZ9SP0K6NIuQHbZjhQ_1739953911 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-38f443b4949so1481876f8f.3 for ; Wed, 19 Feb 2025 00:31:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739953911; x=1740558711; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=4JbRdqdYJQdJMppsYc3IVc1lHy5Cz2pY+l6GdpwErAU=; b=jmAtcRYmQrnmSSwtnob2PCbEqnTcUBDULIol9Ce3pEYHk8Da8oPQk1JwSUEJD881uB VuYLhh1phZnaPiEixiZoOBYWhZuQdE7UrvQUW9qEYJ41lLK4VQkFw5UX1U0sP3YE4l3e ntmMzGAJAbZ4HMyfI4K6yGM6iFGByKs62GC2UfKBZ+VLgc18xpDqKADfPV9500MGTkkt r8Tdw4dK0EefVCWWKqX3enswVrHswP6s+fKdMZceoIUrY/BoGpEdD8zlY0ugPlSS3Uwl YdqBJDyyBpjiyEblD0NTtp2NqRLIyo+MoElPrb3iRJVyjyAkAksqa/k+ObSWqY1tOIPb LocA== X-Forwarded-Encrypted: i=1; AJvYcCVcdTuBR9agXzMiu5IVw1rbaUTNLKXc8bJ0DReuA8p6mnTmQYBjxaR0Ug5InRIQ8Rml96bF9m3Nrw==@kvack.org X-Gm-Message-State: AOJu0Yzokux5urwg1jD4UjxWz3uYnf5sC4wvvgMbomI10BfUAW1i4Bob BorJw8q8miA8mh3DhP89QW4q+GO+re7j34f1QMGyKNSrYE3vbIiRThtVZXIbkpXbb/865sG8e2X REpzFnVTLgmNckJvxuYM6lpBvV0K35qBF5teffD0otfDrethN X-Gm-Gg: ASbGncue3N3RmEcc0JHfcRatxNp429ysT1PTjO8glkV2hWPDyGKnSG5gnElgbp3bayY 2vTnFWKWxvmovYAQCJeZGfK9nGD5De9lGJGbyd3lsOYrhRcy27ZgvxJfrCNTxxd8rGyJ0JcxC6J voafA2VbNCmkhJv2T7mKhHmhZ0MdjBghE5l2vkdiuM/oDHom4z880PRKGxsLKxO1+sXFd238OqN gYwxERssG3mTbfCGZpDNHNWI8cR7V5iYGWES18EkAxB6Ak50vgqDk7foeLI5JNu4Ox9LR636bRs tqS/QbJZMV1TbOS8pjuRKP7UpRXjaluWYIc= X-Received: by 2002:adf:ee92:0:b0:387:8752:5691 with SMTP id ffacd0b85a97d-38f34171107mr11521952f8f.47.1739953911497; Wed, 19 Feb 2025 00:31:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IFK2yPpWvl6gawDQ+6Z/O1hl+oXMmm08C5dns5ahFLa2iCT5uUa7byqQ4lD2sIg9VRBudkicA== X-Received: by 2002:adf:ee92:0:b0:387:8752:5691 with SMTP id ffacd0b85a97d-38f34171107mr11521934f8f.47.1739953911145; Wed, 19 Feb 2025 00:31:51 -0800 (PST) Received: from [192.168.3.141] (p5b0c68c8.dip0.t-ipconnect.de. [91.12.104.200]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38f258dcf08sm17434852f8f.36.2025.02.19.00.31.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Feb 2025 00:31:50 -0800 (PST) Message-ID: <3d1315ab-ba94-46c2-8dbf-ef26454f7007@redhat.com> Date: Wed, 19 Feb 2025 09:31:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/6] mm: Provide address mask in struct follow_pfnmap_args To: Alex Williamson Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, peterx@redhat.com, mitchell.augustin@canonical.com, clg@redhat.com, jgg@nvidia.com, akpm@linux-foundation.org, linux-mm@kvack.org References: <20250218222209.1382449-1-alex.williamson@redhat.com> <20250218222209.1382449-6-alex.williamson@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250218222209.1382449-6-alex.williamson@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: fHyqahk0QVoJrLa-apx-iDaXt0nTmuPYI7NSh_PjKxw_1739953911 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 81A7C80014 X-Rspamd-Server: rspam12 X-Stat-Signature: enwu6wxougznczytaw1htkqu6ghj6ork X-HE-Tag: 1739953915-122488 X-HE-Meta: U2FsdGVkX19GcPUvJuHKjjKUfyWhgiqwb3mOB4USid/U7fIPQ26jdEnvHQiGpOdTDiaKwbITq6K1d/FqUjKOI0VvaLQ/KeRkc57jB9CXcpbEECs/Ik2345aZZZpLT9CUqGmhKEE/mQyLkA7OxSQ7uBncWYPb5IhPseTTKLFob8CQH+xAjW6wI6N0saj44dt0Hhi8lLZPh9m9nTswz3BoiLm16nkO5VSlKgOR9RHcm1HnR74dkDLm1ahpa9pNOtyvR+MOdpdWw6u4yFerDgHhHCB6wm2He7TGzApcXgH9XQKI7lYnnSzo/66hJHjULedTg0sb5ZfWU0sbcP0b2gzsS4Lh9lf/4yhlXnE0UQ5JWun4kVVZ3w0MPBq5Kgldq7Ht+6WuK7X6RC71qFteMG5JjpsEKn87+0UNAXcSDjKU2LOOD4hP8WMBoNW7fQ9vosjM5YMktU/Ge0tRop0Sc2mxHYhwtuNLQzEFMAm6D6uLTPdg+jJsK+ejDymR+AltP6xlwg8joLZ44Axc3NePY38P/Nkz1ZF/Hpp+ZhKthSnMCvoHo68dBKlLDYTGXMNW5ZoARNJmDzjVzTz2Qs9Ivvjt9LUKWmc6u9mD0T0C2r/NTJiktSNjyiLGJkHnmUC2JweWr3j1c+SM9lV5TjOa+mMQD88riY+K2B3iReAaBr4e90243yY1Gdha2mlraeV3uWOkstOl8hsxCWwq2eDtiSp05k4GC9OIxQqcRWpIeeKqjgUDmMwqpFTcsWhDD3Lxh0rxt3Cq3/dy5Zx4pnbbX8lZWwmkVm735afYYrUBuH57uwb1X+HJRfBdKZ/Z2nVRHw8eq2+9iMOKsMvYUlWIXQirD+M22ds7IxFvbgKQaqCUtXJD0lkiqso/zGmcpBTed4JLLtDY/DuPMuaIZpuUMsFFJlB0++PPHYuDTalOLQ4lm/n9bcgxPcfmZmArDx0xy8gB/r1or+UTYBuzOCNnfOz aXI0G92c mR1NXHB2vMqD16TcUJuVJIqXKn3Wxa+DUx5A8x3HNW0+3iDGq+vNwHvXgRbDgfmKu4jU+SrkqbAjFwoYyGXhkKGOeqCTDwW83qLw+xY3UOPIla6HkDY/SMgE7RK/CT/u/srTcheQkdBv14Gxih/AdmLXZGqcP08M/ilNdSWaswgI34wr2z0HyIuid+xTbwIhgzJStifK0MWadCaWn60RfykUoOCuD3sMMibn2GUGE6zdKdTeGcQgCaFwz/tJmhJpc8tNUXpi9JrPxDjjwugkwhieqKto+k3PCu/43baxHZUmo0SILVyhsITcGK5SOqbSn3pq/bkxGrJEuZQLDYqhDFKwY0s0c5ADe+rJOKod1z4LUT7T8miGYgRW1Ax2QFQ/pw0t9mq8h4V8AL6921/KOmdgwzWj4Gmi2lDwR9HpzcthAV25Vkv1J4NyThG1VEbUf7qQ7rH6I/00eJUD7iAK+srHKX/g2HA+XndbCc/K53ubLELR38vQrQ4KmQYwWTo7yrrfEab0X4DW24dJzjR/6sER0UEKIbAIVvnr4K3H+EJRCoTFsTTZ4SpNvqrE69zVb5VBO1zoIdUoqo6o4rjGGvVBLIhkW47gWGTkHTGEFScW+M1q+haRodCcorLOPQzgXvVuD1Ar3x74XPwoEfnRwo/s3QkxxGgKZD80h4pscRpEdWelCHMPnRsKWPA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.003648, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.02.25 23:22, Alex Williamson wrote: > follow_pfnmap_start() walks the page table for a given address and > fills out the struct follow_pfnmap_args in pfnmap_args_setup(). > The address mask of the page table level is already provided to this > latter function for calculating the pfn. This address mask can also > be useful for the caller to determine the extent of the contiguous > mapping. > > For example, vfio-pci now supports huge_fault for pfnmaps and is able > to insert pud and pmd mappings. When we DMA map these pfnmaps, ex. > PCI MMIO BARs, we iterate follow_pfnmap_start() to get each pfn to test > for a contiguous pfn range. Providing the mapping address mask allows > us to skip the extent of the mapping level. Assuming a 1GB pud level > and 4KB page size, iterations are reduced by a factor of 256K. In wall > clock time, mapping a 32GB PCI BAR is reduced from ~1s to <1ms. > > Cc: Andrew Morton > Cc: David Hildenbrand > Cc: linux-mm@kvack.org > Reviewed-by: Peter Xu > Reviewed-by: "Mitchell Augustin" > Tested-by: "Mitchell Augustin" > Reviewed-by: Jason Gunthorpe > Signed-off-by: Alex Williamson > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb