From: Alistair Popple <apopple@nvidia.com>
To: Andrew Morton <akpm@linux-foundation.org>,
will@kernel.org, catalin.marinas@arm.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
robin.murphy@arm.com, nicolinc@nvidia.com,
linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org,
jgg@nvidia.com, John Hubbard <jhubbard@nvidia.com>,
zhi.wang.linux@gmail.com, Sean Christopherson <seanjc@google.com>,
Alistair Popple <apopple@nvidia.com>
Subject: [PATCH 1/2] mmu_notifiers: Restore documentation for .invalidate_range()
Date: Wed, 24 May 2023 11:47:28 +1000 [thread overview]
Message-ID: <3cece716fc09724793aa832e755abfc9d70a8bb3.1684892404.git-series.apopple@nvidia.com> (raw)
The .invalidate_range() callback is called by
mmu_notifier_invalidate_range() which is often called while holding
the ptl spin-lock. Therefore any implementations of this callback must
not sleep. This was originally documented when the call back was added
in commit 0f0a327fa12c ("mmu_notifier: add the callback for
mmu_notifier_invalidate_range()") but appears to have been
inadvertently removed by commit 5ff7091f5a2c ("mm, mmu_notifier:
annotate mmu notifiers with blockable invalidate callbacks").
Restore the comment to make it clear that .invalidate_range()
callbacks may not sleep.
Signed-off-by: Alistair Popple <apopple@nvidia.com>
---
include/linux/mmu_notifier.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h
index 64a3e05..447d757 100644
--- a/include/linux/mmu_notifier.h
+++ b/include/linux/mmu_notifier.h
@@ -200,6 +200,9 @@ struct mmu_notifier_ops {
* external TLB range needs to be flushed. For more in depth
* discussion on this see Documentation/mm/mmu_notifier.rst
*
+ * The invalidate_range() function is called under the ptl
+ * spin-lock and not allowed to sleep.
+ *
* Note that this function might be called with just a sub-range
* of what was passed to invalidate_range_start()/end(), if
* called between those functions.
base-commit: 44c026a73be8038f03dbdeef028b642880cf1511
--
git-series 0.9.1
next reply other threads:[~2023-05-24 1:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 1:47 Alistair Popple [this message]
2023-05-24 1:47 ` [PATCH 2/2] arm64: Notify on pte permission upgrades Alistair Popple
2023-05-28 0:02 ` Jason Gunthorpe
2023-05-30 8:05 ` Alistair Popple
2023-05-30 11:54 ` Jason Gunthorpe
2023-05-30 12:14 ` Robin Murphy
2023-05-30 12:52 ` Jason Gunthorpe
2023-05-30 13:44 ` Robin Murphy
2023-05-30 14:06 ` Jason Gunthorpe
2023-05-30 21:44 ` Sean Christopherson
2023-05-30 23:08 ` Jason Gunthorpe
2023-05-31 0:30 ` Alistair Popple
2023-05-31 0:32 ` Jason Gunthorpe
2023-05-31 2:46 ` Alistair Popple
2023-05-31 15:30 ` Jason Gunthorpe
[not found] ` <31cdd164783fefad4c9ef4a6d33c1e0094405d0f03added523a82dd9febdf15f@mu.id>
2023-06-09 2:06 ` Alistair Popple
2023-06-09 6:05 ` Alistair Popple
2023-05-24 2:20 ` [PATCH 1/2] mmu_notifiers: Restore documentation for .invalidate_range() John Hubbard
2023-05-24 4:45 ` Alistair Popple
2023-05-24 3:48 ` Zhi Wang
2023-05-24 4:57 ` Alistair Popple
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cece716fc09724793aa832e755abfc9d70a8bb3.1684892404.git-series.apopple@nvidia.com \
--to=apopple@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=seanjc@google.com \
--cc=will@kernel.org \
--cc=zhi.wang.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox