From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAE26CF2591 for ; Mon, 14 Oct 2024 01:33:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 256AF6B0082; Sun, 13 Oct 2024 21:33:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 20FC36B0083; Sun, 13 Oct 2024 21:33:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CDA56B0085; Sun, 13 Oct 2024 21:33:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E2D266B0082 for ; Sun, 13 Oct 2024 21:33:22 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CC49240A95 for ; Mon, 14 Oct 2024 01:33:17 +0000 (UTC) X-FDA: 82670484876.30.42C6E92 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf27.hostedemail.com (Postfix) with ESMTP id F18EC4000C for ; Mon, 14 Oct 2024 01:33:13 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of yukaixiong@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=yukaixiong@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728869458; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EDxVJIrbRYtYJqfvja0anKG6ieQhxZxO0Zq1mN9eikU=; b=lFZrVQlddNtrjvh9lOBMMW6cWfdEBrD4WGVKRZ2P3jGhSu3qaptDuSIML59spsXo8KBFeJ /QoAuncaB4212fFI39DX3QTtDyReN2X3Gt10s+L5H3akji+onukTdKulXhfkPSHdzKEkYJ py3Rd4gSnlrL318IxK41URIcqddZ2qc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728869458; a=rsa-sha256; cv=none; b=U3Ef7SZmvkKt1tmY2VPnP8aSQifcEUr0IFJU192D6mYE28NvC4ucrdwk6xTodBiJxSUGqP G8tiE32nfs3mgSwPryOCpBl9u/G+CqtLZz+T01fdmUpbVcbmhV4e/I9I3t7euG1dnfOF4r IUP4djkDBHzeUB4sLIqOTv/I/9rq8aU= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of yukaixiong@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=yukaixiong@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4XRfqP4pDzzQrfD; Mon, 14 Oct 2024 09:32:33 +0800 (CST) Received: from kwepemh100016.china.huawei.com (unknown [7.202.181.102]) by mail.maildlp.com (Postfix) with ESMTPS id 675AF140137; Mon, 14 Oct 2024 09:33:15 +0800 (CST) Received: from [10.174.179.93] (10.174.179.93) by kwepemh100016.china.huawei.com (7.202.181.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 14 Oct 2024 09:33:11 +0800 Subject: Re: [PATCH v3 -next 00/15] sysctl: move sysctls from vm_table into its own files To: "Liam R. Howlett" , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , References: <20241010152215.3025842-1-yukaixiong@huawei.com> From: yukaixiong Message-ID: <3ce4d2b1-02bb-f5ac-dbb9-729fe3d10f62@huawei.com> Date: Mon, 14 Oct 2024 09:33:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.93] X-ClientProxiedBy: dggpeml500010.china.huawei.com (7.185.36.155) To kwepemh100016.china.huawei.com (7.202.181.102) X-Stat-Signature: 8hi5wr9pj67qt5zgt3pf56eugrdp61hr X-Rspamd-Queue-Id: F18EC4000C X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1728869593-331989 X-HE-Meta: U2FsdGVkX1+3cVXGIqboZJIA4WeC/yK2ErUEizvu6sIsqinG/ekb0N3E/+pStIyfxPZ9i862X46strAHfbgaGwE95PN1LdQDDnn/jwAsu+3EdD8o5bqoizyBX4aJqqjCjItM4UIOreDIt+3BMra9rXwNhP1Nb6Nyscb8fsL6ASONr0qRS8IvkxGFXjR+zf5Wfos7R44aUyQ1tkhlYB6GBJTGMtbKJe/e4UtTG7z6vwg0bAWGP/zL07RWKi2jhFGb/yTPRdnBgNbSlUV9C8JaA2qrmYqB45tJqINYay1Y5e/VJVzMblnvFn9NNUbgq2SafTgjCrHsMI8rkShHXnjqHNPATxmg1wkSzuQG0r0G/5sBdM2GE4sYA5sAWIvrs2DlYSN4B6pgiMPDAs8K6/6yg+oJZF+lqUlpY2GFSDK1C9rig+PaCS6lcrZVWBkWtu46c60UHr43I/+iidmSM6vQbiyUBkn1UyvogxouJIFKRex72C5H3MQPoxC4RvEeilNKJissS6h4Cri5kUpQ7yKiBJGWjLyHON+4nsPl9i5sgNcMGhuwvKol/f/JTh4n3VG3stGQv4FkcATnj4RwNU6mRVS5xWXRIwu0ncgZ8MxZUoa/UBNImVBsK8tsOvX6u/w5jOqnSIpvPzm21BE4djC9UOq2MqI0MfZPb56EFZcKR+7ixMXljsf1m2Hni3irsVpXaj2f7PIOH97ZUaI32hkidiqF4qPppBpD5sH7EgHhdwLlgNWi+jIotWpD5n4177FKU+24y6CxrRbqgMKzFC9NqlJqTA4x8UGf+aHQ2Uv4vkLNP0H4QB2JRroxKhecUfjiyF+YMPwuuH1QAZz68WL1fnnFDzDirwqqahADlobnLXCBGthK4wLQSeZRj5kTmb06IiCMaDANMPIob67bujSEDyWg0WpWwezeFKC05fW/UeRuRT6YUdjzok7row3KH4d9AAdkxrIiNrPw4qX2Nn0 H8aHqX+N byUtjL0uxJuvLUSm6KTR3STe9fsYYCUgPDuONiGtY2F2tHwlKUG02/pr5woys4MRjlZwookGRnzp/uZapCxxpI1kmheQwgyGWUO6sPAZWGzVDv5EBaRoOq0yEYptRiohBdS5metBkMznSHmQVIX8Pd8qyJiIbGwMzUryiIMER/ebRniRXI33vRnrnQNZeKAcWr6BvGS91chi1rl4yEALFqMez5v6o4D0YgoNs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/10/11 21:04, Liam R. Howlett wrote: > * Kaixiong Yu [241010 10:11]: >> This patch series moves sysctls of vm_table in kernel/sysctl.c to >> places where they actually belong, and do some related code clean-ups. >> After this patch series, all sysctls in vm_table have been moved into its >> own files, meanwhile, delete vm_table. >> >> All the modifications of this patch series base on >> linux-next(tags/next-20241010). To test this patch series, the code was >> compiled with both the CONFIG_SYSCTL enabled and disabled on arm64 and >> x86_64 architectures. After this patch series is applied, all files >> under /proc/sys/vm can be read or written normally. > This change set moves nommu code out of the common code into the nommu.c > file (which is nice), but the above text implies that no testing was > performed on that code. Could we have some basic compile/boot testing > for nommu? this patch series has been compiled with CONFIG_MMU=n on arm，and produce nommu.o without error and warning. But I don't have machine to do test for nommu. >> Changes in v3: >> - change patch1~10, patch14 title suggested by Joel Granados >> - change sysctl_stat_interval to static type in patch1 >> - add acked-by from Paul Moore in patch7 >> - change dirtytime_expire_interval to static type in patch9 >> - add acked-by from Anna Schumaker in patch11 >> >> Changes in v2: >> - fix sysctl_max_map_count undeclared issue in mm/nommu.c for patch6 >> - update changelog for patch7/12, suggested by Kees/Paul >> - fix patch8, sorry for wrong changes and forget to built with NOMMU >> - add reviewed-by from Kees except patch8 since patch8 is wrong in v1 >> - add reviewed-by from Jan Kara, Christian Brauner in patch12 >> >> Kaixiong Yu (15): >> mm: vmstat: move sysctls to mm/vmstat.c >> mm: filemap: move sysctl to mm/filemap.c >> mm: swap: move sysctl to mm/swap.c >> mm: vmscan: move vmscan sysctls to mm/vmscan.c >> mm: util: move sysctls to mm/util.c >> mm: mmap: move sysctl to mm/mmap.c >> security: min_addr: move sysctl to security/min_addr.c >> mm: nommu: move sysctl to mm/nommu.c >> fs: fs-writeback: move sysctl to fs/fs-writeback.c >> fs: drop_caches: move sysctl to fs/drop_caches.c >> sunrpc: use vfs_pressure_ratio() helper >> fs: dcache: move the sysctl to fs/dcache.c >> x86: vdso: move the sysctl to arch/x86/entry/vdso/vdso32-setup.c >> sh: vdso: move the sysctl to arch/sh/kernel/vsyscall/vsyscall.c >> sysctl: remove unneeded include >> >> arch/sh/kernel/vsyscall/vsyscall.c | 14 ++ >> arch/x86/entry/vdso/vdso32-setup.c | 16 ++- >> fs/dcache.c | 21 ++- >> fs/drop_caches.c | 23 ++- >> fs/fs-writeback.c | 30 ++-- >> include/linux/dcache.h | 7 +- >> include/linux/mm.h | 23 --- >> include/linux/mman.h | 2 - >> include/linux/swap.h | 9 -- >> include/linux/vmstat.h | 11 -- >> include/linux/writeback.h | 4 - >> kernel/sysctl.c | 221 ----------------------------- >> mm/filemap.c | 18 ++- >> mm/internal.h | 10 ++ >> mm/mmap.c | 54 +++++++ >> mm/nommu.c | 15 +- >> mm/swap.c | 16 ++- >> mm/swap.h | 1 + >> mm/util.c | 67 +++++++-- >> mm/vmscan.c | 23 +++ >> mm/vmstat.c | 44 +++++- >> net/sunrpc/auth.c | 2 +- >> security/min_addr.c | 11 ++ >> 23 files changed, 330 insertions(+), 312 deletions(-) >> >> -- >> 2.34.1 >> > . >