From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CBC1C001DE for ; Wed, 5 Jul 2023 17:16:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4EDC8D0003; Wed, 5 Jul 2023 13:16:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CFFCB8D0001; Wed, 5 Jul 2023 13:16:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA0A78D0003; Wed, 5 Jul 2023 13:16:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A8A1B8D0001 for ; Wed, 5 Jul 2023 13:16:14 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3EDDBA04A8 for ; Wed, 5 Jul 2023 17:16:14 +0000 (UTC) X-FDA: 80978211468.03.3125527 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 5CAD4100027 for ; Wed, 5 Jul 2023 17:16:06 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=itHRMICn; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688577367; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T35piQgq4+7zJ5KZwE9xl6DoVBjgPCYheAfovtVFOD4=; b=5ytH+F9aIoQtInBy7d1betl4wCzXaGmbOQzM/4hLwH0yBpuyC+zXwJqR94l3S2tfCfET+M lIbZAkXg7HEcL+FSqJV3g77JODXSL5q/dEPacZtdmDl3mJ2frC870fSjgm9WWmqBa0xJws wNQLHefP+r/vsFnuNeDif4R2HfOf0Cs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688577367; a=rsa-sha256; cv=none; b=gQBJ6ecIzGWm3SklLQCynsfzFF6C9Zr/vOQJfgIhVI20YsXQP/kvhtWl7P4BHTaRsxk/od xOaVeYw1cK55xTD0yUw+TojiT9tMBMCtbwHY36dlLCH7HvnzGeDLnRWLXOWVuJG6RonZMO fsDA3blOk8oJucDYrexjLADQlS4yTn0= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=itHRMICn; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688577365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T35piQgq4+7zJ5KZwE9xl6DoVBjgPCYheAfovtVFOD4=; b=itHRMICnkB7pLN9/Pu5vpN+XrSTGcjTYyImdDtP8wVqPSI2aKwSIg53XCcjLLlYN/z4hY1 6vMlN7OFW3N9pG93I/UuYjzM539cpOTW0xecg9rtJ/GnL0fP+tbL4jHE996H/CciwxovbT Lmv/H8uZeSWd6c7oOn18RY+rsIxhlqk= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-280-bwJnj1dtOJu1Va9hJ-_5uQ-1; Wed, 05 Jul 2023 13:16:04 -0400 X-MC-Unique: bwJnj1dtOJu1Va9hJ-_5uQ-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3141325af78so4546266f8f.3 for ; Wed, 05 Jul 2023 10:16:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688577363; x=1691169363; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=T35piQgq4+7zJ5KZwE9xl6DoVBjgPCYheAfovtVFOD4=; b=E+38fhUKEeyf1x7eDLAIfRN0/AojR3do+WtqqxvcRmlWXdawzIEB5BAUctmhMoVAWT Fyouo3IqCkEy0Yif3ddUzFu1VvHCWKHqOOAr7WwKQLUdFxCZguP0DMUDyUva+AtI5KYM uERLNuES/nWF56szTV+uiEcEbHc0btgMTszJG8uL4SC19VwVFVd0UVEZII5WCawDPsCn 8oEO2UyQIXpniIe0m1cFlfsAji5qjTxIziESAnhIFHGVx4ujPNVQDXCVTXpOcYsKv+uv t4bK19njnocSgtm1AhcYeBpk785Ode4O47+jvK5adn3FPpmqXCBTARvmNHCGbFcrqyFk 7bxQ== X-Gm-Message-State: ABy/qLY4iSIykkmRdwR5E+I/uF9RlM1D7K0eYEGTIyvmCmAYcRNK0X4s iGBD+devcU1JQ7w42aoI46PgktV//E2pzXR1egVxCm4r1h1QPa0k2EKnphL2rwxqPvWYCGejYx2 WedKGBRYorpw= X-Received: by 2002:a5d:55d1:0:b0:314:3b9c:f02f with SMTP id i17-20020a5d55d1000000b003143b9cf02fmr6981146wrw.49.1688577363540; Wed, 05 Jul 2023 10:16:03 -0700 (PDT) X-Google-Smtp-Source: APBJJlEUfAcMRX29HqJCQ1c1CH56suwm4NfOCQ9BPaxEr09A1xPnlHPvpu8OfU/EAZeHFIGE5k7pgw== X-Received: by 2002:a5d:55d1:0:b0:314:3b9c:f02f with SMTP id i17-20020a5d55d1000000b003143b9cf02fmr6981094wrw.49.1688577363129; Wed, 05 Jul 2023 10:16:03 -0700 (PDT) Received: from ?IPV6:2003:cb:c71a:1c00:e2b1:fc33:379b:a713? (p200300cbc71a1c00e2b1fc33379ba713.dip0.t-ipconnect.de. [2003:cb:c71a:1c00:e2b1:fc33:379b:a713]) by smtp.gmail.com with ESMTPSA id n10-20020a05600c294a00b003fbaade0735sm2682596wmd.19.2023.07.05.10.15.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jul 2023 10:16:02 -0700 (PDT) Message-ID: <3cdaa7d4-1293-3806-05ce-6b7fc4382458@redhat.com> Date: Wed, 5 Jul 2023 19:15:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 2/2] mm: disable CONFIG_PER_VMA_LOCK until its fixed To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: jirislaby@kernel.org, jacobly.alt@gmail.com, holger@applied-asynchrony.com, hdegoede@redhat.com, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20230705171213.2843068-1-surenb@google.com> <20230705171213.2843068-3-surenb@google.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230705171213.2843068-3-surenb@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: bkjujc7sou6y1x796asut7dx5qon8ob9 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 5CAD4100027 X-Rspam-User: X-HE-Tag: 1688577366-471308 X-HE-Meta: U2FsdGVkX1/SpR/IG3bvu0t7XZAJZxpwg6YRknBMUfQbFewRLAtrx7b41EO1zpiJNz8jsG4AtYw8eYGDdIG0HtPkP0xpogwTRfzzi40I9dIltUwp4ap9gfa3MFrSHjArlLA+QLT9BD6KaWZMs3yGd/TIoUvn2wBbR89Z8VNa+vbtltNdRxNTXZd5iZ/1YENN6jz17gqFphFv25niJKccaoEqi5TrMcyIWxDwLzRDAjkBfw96BIqLkDgUKc/Vc35S3Wa0d2Pd385PxKu03iT9kxPKhwUW7cujnNKETIiyz4m2/nmZkO8773XkCPi26NmU4qR8IwIxommUrV5IMOLly9ItDW1C8bfD3rVp+rwj2Uofs/LUHpoqo0GZsPcSHsV35sroXU01N9DAmBlS/gf4jUgL7Y8mHKQPMIchDxW6+yuiM7/cTVjVZsaxvHhevuM4Bcwn3NTWAVxVVgUHEd0OJ7gSukGQZe3pLcnwByYJv4Ku/aNptQmUXRyOihZjuwOmVrbZP79oA4vwR5UeatzHjtzc6Wl++f8kNeQ6FQ/0uLTHc0uxWh0O6fUCgQ5Q3dhQSvaRe8XWwY7sJPxFZuc6uqTdjXPfoVNQv4oxyTwf4L5Q33xuNNjkaUVzi7qqFeehEQ6rQl4bBRU5QXfp7b4rNIj22QVkLGueadOA3GCJCGQdporYhpbETIItDW5kYKtfDuqiV4ACDEmlLWlLwytQqkQ6XH2z/e8YIiTu221RrTmpaLDHqwaL6QD320J6dTDMwkhHau9ZLRrFZfoe3xn0/eoy0PMzPu/5Z7i3yBKf5mkdttgNCHvEGb8GD/w5mwnDPD7hUDMitKIC1dEpc4lq+0Qf8EuXJVkQP8gljvf3lMf9dpx1fEUo+pn2DmN4Fj19rggsfc9rybdU2R/dpDrtgUtkrxidsK0KiMXPEWGfUZQbqfejMHLzFSFRGLHdM5k+MrSpUfIEE9hFF8Ti3rs lbwVhP7H cgla5pdi1tE/mqHBWtqlDtJCzlJGIAK7bOHKXi2U0QN1UxN4jTrt2drvTxxqr2DFxJ3XYXZgGT3JxBx1yh6a6pa2JNNPezUzIk9SsrGOisEfb8jP122RHu5ALwO8rlbDEQPPvNPjRlngin5syN3e3Gn2zIuN6Qqu84M4vlQSF8GiyQ+qvPthMFGhhiZzTNQ1qmApAGS7dksGR0YvWYuZUUSRsxZJPlDbyWzMcvbQONWlX2+Qbf75ONlo1Y7qsxVn02I3oITbtpW+oFcCRncp8LsVYKV0vSgHxpR2P3/JXvWOs/n13mOg7GoRoCoCiGTzqor7qnh07hm19AYEWGst+3QdxhaxatNDKsyZ3uoP5Roves8xtfuwlnCAHC9ia0IB/kHAUsoX7ZoXdJY4mm3KH4J3qHg+oTTrzxuQ+cAN2LiEQCNP7uSx4erVUUPept/je36KaLT79ufHFXdBR9BW/+Mp3nogSaPF79TA6ewXFmToNupPGJzkGdjNzM5jTDRpuTIw/+nUHoQgRIy27N2V6sZGrb8FU7/XIU3Dxbw/mbkhrv37p0Zm6dgNlDUQL6H98/eFnew9f+RUXmlm27p5IEUQqlcGtKpIfJsml X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05.07.23 19:12, Suren Baghdasaryan wrote: > A memory corruption was reported in [1] with bisection pointing to the > patch [2] enabling per-VMA locks for x86. > Disable per-VMA locks config to prevent this issue while the problem is > being investigated. This is expected to be a temporary measure. > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=217624 > [2] https://lore.kernel.org/all/20230227173632.3292573-30-surenb@google.com > > Reported-by: Jiri Slaby > Closes: https://lore.kernel.org/all/dbdef34c-3a07-5951-e1ae-e9c6e3cdf51b@kernel.org/ > Reported-by: Jacob Young > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217624 > Fixes: 0bff0aaea03e ("x86/mm: try VMA lock-based page fault handling first") > Cc: stable@vger.kernel.org > Signed-off-by: Suren Baghdasaryan > --- > mm/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/Kconfig b/mm/Kconfig > index 09130434e30d..0abc6c71dd89 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -1224,8 +1224,9 @@ config ARCH_SUPPORTS_PER_VMA_LOCK > def_bool n > > config PER_VMA_LOCK > - def_bool y > + bool "Enable per-vma locking during page fault handling." > depends on ARCH_SUPPORTS_PER_VMA_LOCK && MMU && SMP > + depends on BROKEN > help > Allow per-vma locking during page fault handling. > Do we have any testing results (that don't reveal other issues :) ) for patch #1? Not sure if we really want to mark it broken if patch #1 fixes the issue. -- Cheers, David / dhildenb