linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: "Liam R . Howlett" <Liam.Howlett@oracle.com>,
	Jann Horn <jannh@google.com>, Pedro Falcato <pfalcato@suse.de>,
	WangYuli <wangyuli@uniontech.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/testing/vma: Clean up stubs in vma_internal.h
Date: Tue, 26 Aug 2025 21:45:52 +0200	[thread overview]
Message-ID: <3cca6ae2-6387-4d03-a4c5-9e2374fda687@suse.cz> (raw)
In-Reply-To: <20250826102824.22730-1-lorenzo.stoakes@oracle.com>

On 8/26/25 12:28, Lorenzo Stoakes wrote:
> We do not need to references arguments just to avoid compiler warnings, the
> warning in question does not arise here, so remove all of the instances of
> '(void)xxx' introduced purely to avoid this warning.
> 
> As reported by WagYuli in the referenced mail, GCC 8.3 and before will have
> issues compiling this file if parameter names are not provided, so ensure
> these are always provided.
> 
> Finally, perform a trivial fix up of kmem_cache_alloc() which technically
> has parameters in the incorrect order (as reported by Vlastimil Babka
> off-list).
> 
> Reported-by: WangYuli <wangyuli@uniontech.com>
> Closes: https://lore.kernel.org/linux-mm/EFCEBE7E301589DE+20250729084700.208767-1-wangyuli@uniontech.com/
> Reported-by: Vlastimil Babka <vbabka@suse.cz>
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>

Acked-by: Vlastimil Babka <vbabka@suse.cz>



  reply	other threads:[~2025-08-26 19:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-26 10:28 Lorenzo Stoakes
2025-08-26 19:45 ` Vlastimil Babka [this message]
2025-08-28  0:55 ` Liam R. Howlett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3cca6ae2-6387-4d03-a4c5-9e2374fda687@suse.cz \
    --to=vbabka@suse.cz \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=jannh@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=pfalcato@suse.de \
    --cc=wangyuli@uniontech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox