From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6714FC77B7F for ; Thu, 27 Apr 2023 14:39:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D35706B0072; Thu, 27 Apr 2023 10:39:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CE6166B0074; Thu, 27 Apr 2023 10:39:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BAD306B0075; Thu, 27 Apr 2023 10:39:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AA5516B0072 for ; Thu, 27 Apr 2023 10:39:18 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5D925120293 for ; Thu, 27 Apr 2023 14:39:18 +0000 (UTC) X-FDA: 80727428796.28.B1F141B Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf27.hostedemail.com (Postfix) with ESMTP id 0F1684002A for ; Thu, 27 Apr 2023 14:39:14 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=cYFyY+id; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ksdxb+7k; spf=pass (imf27.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682606355; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gCaK1kQTBnKVzZEqwaD7vAZ7IWvkRl+dKm9iAKEVDFI=; b=50Kh0+ik63LOEGqp0ERrP+bOvaliqdhz6/ywoqfcoQJlvgpcJIu3i2pQWNsUq2E0a/pVl0 wivU7vg8kWH/+/ZD8j+BOjy7YU5c8NVNTEl3Sjog8x4DrXzquPwZ1DnkrLyEf7yzAgWKS+ d7jMwPsaX3MqRN22tgC9pLPlx/hGXxM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=cYFyY+id; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ksdxb+7k; spf=pass (imf27.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682606355; a=rsa-sha256; cv=none; b=DI3ZayRG8dpAtCch1ZM3mWy+GAauAQFSJbOv9p2NRqF/A5Jq4OZq6+ra05dIoDgVI7d5ke 7uU+A7tzrABCI+gBVAnjcOqONcTjqDniCYiujA0GkKCDwg/m592M2dFthXrlnWpbhbiXxi NUoDNxVjUAMqVge94V/pP29VKHRPYBA= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BC0611FE4C; Thu, 27 Apr 2023 14:39:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1682606353; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gCaK1kQTBnKVzZEqwaD7vAZ7IWvkRl+dKm9iAKEVDFI=; b=cYFyY+idWuItPkjEMcolMKnRrKN5hEPoZRc2eEE/bPlofPmIQPI1cC751gP6De6adKLs6o FgkTN+b1VmccmmgW629pqDEOpxKu+zJinioe2buqHocyPh1xpvQKUR3k+fP1wtOa89obNa PnV+EoMCLpRpPAoC5JOjVUcvogVliG4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1682606353; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gCaK1kQTBnKVzZEqwaD7vAZ7IWvkRl+dKm9iAKEVDFI=; b=ksdxb+7kXsi4bLJ3SCvar5BCQBjnV93jUSmVL1D6/Ox2SZTBKLLjnm4xOq6e/9rBJebXZL /x1Oz9hw/pB6VHAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8F45113910; Thu, 27 Apr 2023 14:39:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id G/5LIhGJSmRjIAAAMHmgww (envelope-from ); Thu, 27 Apr 2023 14:39:13 +0000 Message-ID: <3cc6e10c-f054-a30a-bf87-966098ccb7bf@suse.cz> Date: Thu, 27 Apr 2023 16:39:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH for v6.3 regression] mm/mremap: fix vm_pgoff in vma_merge() case 3 Content-Language: en-US To: Greg KH Cc: Andrew Morton , Linus Torvalds , "Liam R. Howlett" , lstoakes@gmail.com, regressions@lists.linux.dev, linux-mm@kvack.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, Jiri Slaby , Fabian Vogt , stable@vger.kernel.org References: <20230427140959.27655-1-vbabka@suse.cz> <2023042719-stratus-pavestone-505e@gregkh> From: Vlastimil Babka In-Reply-To: <2023042719-stratus-pavestone-505e@gregkh> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 0F1684002A X-Stat-Signature: rrpk7uud9xz9iyfth7dshnxbnrt7xj5h X-Rspam-User: X-HE-Tag: 1682606354-974262 X-HE-Meta: U2FsdGVkX1/5gXFnlAPeTXvzSlvARvnJDSl/MF2vUXpDNZfQf+R3RRBashgkyayHFL2uXUuRKPz+aKVBIpV0rHASt4y5Ikd7BWrrooA9hsrn+rz6vh7JXm+jGFuTukxutzWXK97tPpG2mrVNwAbL8GTURDIHcWXbghzTDY5Lr71HWDUstfDZKrRydzVySyuT+sR/6gDRJdLNgpmsqCHA0TSTZUXoZVsh/EDZaYZkS7UtBrwM8Y3jGFOCojKDxTM2c8NjEy4Scc1CxoCYHj34MKzIwg3EcQLsydNWjCcettBvz71xWYgRRJgnjDlphIEUg+D8BmmHWAHza1T2grvvZtUZRhNlZ2iCrY8HpRJBfL1ebeRHfdbiI90VnXMdYzAp2kEJOcszylnygaz6bP37lCJNRLNzNdWveOjm90xjHIFwPFANKFhUIUMHoBvlZ2znFDjDrHZziZ21Nvj+1zMvm1R2IWYMXh+Gt7k5dhUXHjbMafz5gqZivWJHbWxVMyJTgt62aF0o6sb3yPY6cJ+uXkQwDZEMPsBeB1jbUhHJ+G9ENGC4VhJnjou2a/nwdgWYy7sw7xcZhNQWlhS8c6X3i+Pktg4rAEJ/0qtB9bICKtsRYh4O+wIpX4R28rEt5fJZDSRnkSGICgAilmxM/GOn6E9IjXOArm0PBj0v+y0G2Owhktgne9nXtPw3/ImAwQs3U/Mt14mRqgDVDDIXFzeeG+SJTUc/hYPj5udMSOsYMna6zEwSV38KLfgfzTypQVVcD4iYZrhDNEXKaKgQd3IFBKX0QVUKjdWNsKoS3Z1oNcugvcZ1eirjLCg0ZGP+2lNPcdaMLuEdALv95HcgvQa1L3raBmpoC0Q8UuMgap0NuEPAJvzoMfTM6LSGrL6LGsKeDBqAef9LU1RHXI8qcMsF2uu9N/HGZymZhsxhUz4OSByKfZ4zi6NexnykbykkCml6hJWJ7E10Dnq8yqh34+T XEROv2JN xzpFtMU/pMmTFo/bE5mmZSV7gBDb7iyVFLOUeHkw3tzDca2NJ41YPXhZH+99jNSQDzcXKkFGqjs2RQWvmVS62fsjguTmqEqpgonxhNvXzjyRtqqYQ05gSgudIY0asmo5bJgPuP/W4bUfJ1pHhzLLvpErFvY8BXsREca3vSpbvGPnNAhZqNL/XkBNibxmnpGEP9ZPHHCIqWSLgREVKwJIhgTCzdaBuEtIrGMZap6HUsn+sVzh6hgH5F93dxSh5JLYtPrU3YjO6H4qBEWUA5goEFgjXVI0CyeQ4R3itRaW8wCrykzfFNQUuMq8e/gQrt3X8hHEvdgIpYf1XuO2gf4EcCQZJnEyDF3guF1aUgyfl8QRNvu8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/27/23 16:27, Greg KH wrote: > On Thu, Apr 27, 2023 at 04:09:59PM +0200, Vlastimil Babka wrote: >> After upgrading build guests to v6.3, rpm started segfaulting for >> specific packages, which was bisected to commit 0503ea8f5ba7 ("mm/mmap: >> remove __vma_adjust()"). rpm is doing many mremap() operations with file >> mappings of its db. The problem is that in vma_merge() case 3 (we merge >> with the next vma, expanding it downwards) vm_pgoff is not adjusted as >> it should when vm_start changes. As a result the rpm process most likely >> sees data from the wrong offset of the file. Fix the vm_pgoff >> calculation. >> >> For case 8 this is a non-functional change as the resulting vm_pgoff is >> the same. >> >> Reported-and-bisected-by: Jiri Slaby >> Reported-and-tested-by: Fabian Vogt >> Link: https://bugzilla.suse.com/show_bug.cgi?id=1210903 >> Fixes: 0503ea8f5ba7 ("mm/mmap: remove __vma_adjust()") >> Signed-off-by: Vlastimil Babka >> Cc: >> --- >> Hi, I'm sending this patch on top of v6.3 as I think it should be >> applied and backported to 6.3-stable rather sooner than later. >> This means there would be a small conflict when merging mm/mm-stable >> later. Alternatively it could be added to mm/mm-stable and upcoming 6.4 >> pull request, but then the stable backport would need adjustment. >> It's up to Linus and Andrew. > > That's not how the stable tree works, sorry, it needs to be in Linus's > tree _first_. Sorry, I wasn't clear what I meant here. I didn't intend to bypass that stable rule that I'm aware of, just that it might be desirable to get this fix to Linus's tree faster so that stable tree can also take it soon. > thanks, > > greg k-h