From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44CCBCF34B0 for ; Thu, 3 Oct 2024 14:49:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F6506B0427; Thu, 3 Oct 2024 10:49:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A5E16B047B; Thu, 3 Oct 2024 10:49:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 746796B047C; Thu, 3 Oct 2024 10:49:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5082A6B0427 for ; Thu, 3 Oct 2024 10:49:19 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E9E68AAC6E for ; Thu, 3 Oct 2024 14:49:18 +0000 (UTC) X-FDA: 82632573996.26.885702B Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf18.hostedemail.com (Postfix) with ESMTP id 967321C0009 for ; Thu, 3 Oct 2024 14:49:15 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qeHROMZH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=+tRuteZ5; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qeHROMZH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=+tRuteZ5; dmarc=none; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727966850; a=rsa-sha256; cv=none; b=0JTPXgM3d8V3wpkudeVBi7JuVxf5xMxO814vDCRwhFtg3RJUDyVQP4ky86JwY4KIo851ai UPgpmPH1tNNQtGoTpSCXsBIW7UKo+6lUPpWCmGB29TdvLXnhSCt2+haXboxU3+d20yN0LN gfCDNoREY4YnNvrZSq2LKPw5ZHPTyVo= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qeHROMZH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=+tRuteZ5; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qeHROMZH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=+tRuteZ5; dmarc=none; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727966850; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PUMSKIIV3Gvmq2NSihehWA898ICrNIc6geNfrWzL1zI=; b=IwaRd+GwKgsekjAlHAb2WOYJ1xkzuRE2cwca38JF9NB4f/kmuwqLBkJiBs03LczCa9Fntm 5wf13IfjVTKnWFSdhBedZWvkIbYbTSAi3tXrnd9BPUkVAzwhRRklseZuslooa9lkHzPpaD tmKASeTNLtTySyszr4/Dl6Z590hgV0Y= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 013581FDF2; Thu, 3 Oct 2024 14:49:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1727966954; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PUMSKIIV3Gvmq2NSihehWA898ICrNIc6geNfrWzL1zI=; b=qeHROMZHxrOjU5rnLREWSoSLcpYZOEq3TfiUyeGwWNNewsDtKMvKTfYWEEBy2eMJ8QUz94 74WvQd+a+Z22hWjsnDJ+mgY5fZWvVcsgXxyEwxpz5KV4N/cTG1JzyNqYvn+HxcGq7HxI6O HdwdLOuohXQ83v0BJisO7j8oh+yfWgA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1727966954; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PUMSKIIV3Gvmq2NSihehWA898ICrNIc6geNfrWzL1zI=; b=+tRuteZ53PeYU6XFs6ugM0a/hFpQ+fyBxSQ8a8mrlo2D4CVLuauyVxyeAtW+v6CQAxGdNS 8GCiuZsbJ6MlpnCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1727966954; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PUMSKIIV3Gvmq2NSihehWA898ICrNIc6geNfrWzL1zI=; b=qeHROMZHxrOjU5rnLREWSoSLcpYZOEq3TfiUyeGwWNNewsDtKMvKTfYWEEBy2eMJ8QUz94 74WvQd+a+Z22hWjsnDJ+mgY5fZWvVcsgXxyEwxpz5KV4N/cTG1JzyNqYvn+HxcGq7HxI6O HdwdLOuohXQ83v0BJisO7j8oh+yfWgA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1727966954; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PUMSKIIV3Gvmq2NSihehWA898ICrNIc6geNfrWzL1zI=; b=+tRuteZ53PeYU6XFs6ugM0a/hFpQ+fyBxSQ8a8mrlo2D4CVLuauyVxyeAtW+v6CQAxGdNS 8GCiuZsbJ6MlpnCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DE9D113882; Thu, 3 Oct 2024 14:49:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id odPmNemu/marVAAAD6G6ig (envelope-from ); Thu, 03 Oct 2024 14:49:13 +0000 Message-ID: <3cbe26aa-1f6c-48c3-ad5e-203c98333dab@suse.cz> Date: Thu, 3 Oct 2024 16:49:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: percpu: fix typo to pcpu_alloc_noprof() description Content-Language: en-US To: Jeongjun Park , dennis@kernel.org, tj@kernel.org, cl@linux.com Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Randy Dunlap , Suren Baghdasaryan References: <20240924152412.118487-1-aha310510@gmail.com> From: Vlastimil Babka In-Reply-To: <20240924152412.118487-1-aha310510@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 967321C0009 X-Stat-Signature: 1t5bk5zw5dgmceaki9twbnuza91q955y X-Rspam-User: X-HE-Tag: 1727966955-401738 X-HE-Meta: U2FsdGVkX18MqbeIzvYLXJ0I6D1KAzf2GeYF32zF7rsVI7FOe2u+Bwkf239hFDV57wSfq0FC7Hg/mBCajb/0nwmIipiKv8GHRn1R2sT5/MQ+LcMktMsMgfVRg6MDVGgejyS7Xqki0KCDsJMJGEqXYUgiTn5BUWhtPAtwCAeQ7PJJ8VFiZO3P9Hl/MGCR9+YWHMQ6s3Guji/w7FChoX4LR0Nz/Tz3YQx03q/dXcwbZ5lZ0aVDwMBCJPDCRgPnjIgIvT85Y0dxQlwJQ3tfUyt3fYMZEyy3mpNTj73/RPEMT5sfEjLJbyRmAnLREOOEssWtWXQgpDO2irwQAryxAV9PW+qbMzRAL7R2DH0pSZbeoTqTjG5Dg5D63g+26KZaTFObA40/DqMtiw12isYTqUoV6sCE7QSzj8bPirKSx3cfrGGYXFp9CpwvGbEi5eUgYA8zK0g4Gpvn8iU08MVvOBHlH9+5bQ4AXEEw5qYiD06G5HxIItRG2IsRevGimXexmcqBQbUmbcnM1b+JoyRE8CqcnM+LHM2V3OrpLPff2r7eyo4UxqC8XfJorGUJHBpVGAMBmV2pMp8loCFrkEh4ZmOD9O2W7iojAH1tPXQkivfkgscteOtIX43iv4PtCUcb/BG+7CyVtMQ67qqCGjnPSTCaY+zMKwM2UiKmKt5Tmqzx37Cmj9h+sNl4eY+o3vNe2BMzlNGdL0KdEszt48zqDif7E7zDr/7WonXU/UipLaoq0LShSXSYEQo1PgXjNGGod5U8pq6Q9op14Y7PErpuXWbWffzKG57ztrxrU5mQfbS8VRIAGJeugheMJdCMZEZKrzW1VVmopsoJMSh7D6pdoz7fLPVJlA83QLnUgwGhZ/ROoJFagDH6fuTL/eIEc5gQT8uzozxp7fT86P+xsThNAG5gy57w546wQRvXBijEyYAsJYcKSVOieDhETApz7qmJ3ERTw6+3/t4DX6VjNc452ur EydDvwyK GnBMtHSkS+zXoiMHNp89wnzFR7arluW3hR3cohiE3vlAGYHXYvuzs40njZp3rzLfrlTWtbLoCPp0VQCtwibziW6bMIz1T3dCZDUcRROTdRdKZL6ve+gqZXvCkMVDJBZGyES3pDZOljlHyqf+pdW3HpYew8pig/ZI6JD5zs0fpSoHc9L0RC2I+xtyUHRPJ+mNGF0hTxcHwj1sy2tf18U7AZCDJWaOzOxVabLpEDQRDT6OsFldyugy8qONbLSgumAVi4aiJ2f5JlV1vY95vXaYdmfpoWrvhU3G+EHPFWApdH3/rLftb7ZMNAiaO8C2hkI03ZTekwAgiCTCzedUgo6XsSYEFr2FHfUdI+sHX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/24/24 17:24, Jeongjun Park wrote: > In the previous commit, the function name was changed from pcpu_alloc to > pcpu_alloc_noprof , but the function description was not changed accordingly. > The function name should be changed to pcpu_alloc_noprof in the description > as well. > > Signed-off-by: Jeongjun Park See 51a7bf0238c2 ("scripts/kernel-doc: drop "_noprof" on function prototypes") So in fact we can't do that now (as the bot reply suggests), even if pcpu_alloc() doesnt seem to exist - all the hooks wrapping pcpu_alloc_noprof() are named differently? > --- > mm/percpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/percpu.c b/mm/percpu.c > index 20d91af8c033..7081b0ed59d6 100644 > --- a/mm/percpu.c > +++ b/mm/percpu.c > @@ -1726,7 +1726,7 @@ static void pcpu_alloc_tag_free_hook(struct pcpu_chunk *chunk, int off, size_t s > #endif > > /** > - * pcpu_alloc - the percpu allocator > + * pcpu_alloc_noprof - the percpu allocator > * @size: size of area to allocate in bytes > * @align: alignment of area (max PAGE_SIZE) > * @reserved: allocate from the reserved chunk if available > -- >