From: Vlastimil Babka <vbabka@suse.cz>
To: Jeongjun Park <aha310510@gmail.com>,
dennis@kernel.org, tj@kernel.org, cl@linux.com
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Randy Dunlap <rdunlap@infradead.org>,
Suren Baghdasaryan <surenb@google.com>
Subject: Re: [PATCH] mm: percpu: fix typo to pcpu_alloc_noprof() description
Date: Thu, 3 Oct 2024 16:49:13 +0200 [thread overview]
Message-ID: <3cbe26aa-1f6c-48c3-ad5e-203c98333dab@suse.cz> (raw)
In-Reply-To: <20240924152412.118487-1-aha310510@gmail.com>
On 9/24/24 17:24, Jeongjun Park wrote:
> In the previous commit, the function name was changed from pcpu_alloc to
> pcpu_alloc_noprof , but the function description was not changed accordingly.
> The function name should be changed to pcpu_alloc_noprof in the description
> as well.
>
> Signed-off-by: Jeongjun Park <aha310510@gmail.com>
See 51a7bf0238c2 ("scripts/kernel-doc: drop "_noprof" on function prototypes")
So in fact we can't do that now (as the bot reply suggests), even if
pcpu_alloc() doesnt seem to exist - all the hooks wrapping
pcpu_alloc_noprof() are named differently?
> ---
> mm/percpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/percpu.c b/mm/percpu.c
> index 20d91af8c033..7081b0ed59d6 100644
> --- a/mm/percpu.c
> +++ b/mm/percpu.c
> @@ -1726,7 +1726,7 @@ static void pcpu_alloc_tag_free_hook(struct pcpu_chunk *chunk, int off, size_t s
> #endif
>
> /**
> - * pcpu_alloc - the percpu allocator
> + * pcpu_alloc_noprof - the percpu allocator
> * @size: size of area to allocate in bytes
> * @align: alignment of area (max PAGE_SIZE)
> * @reserved: allocate from the reserved chunk if available
> --
>
prev parent reply other threads:[~2024-10-03 14:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 15:24 Jeongjun Park
2024-09-24 23:50 ` kernel test robot
2024-10-03 14:49 ` Vlastimil Babka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cbe26aa-1f6c-48c3-ad5e-203c98333dab@suse.cz \
--to=vbabka@suse.cz \
--cc=aha310510@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=dennis@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rdunlap@infradead.org \
--cc=surenb@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox