From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 852F2E81DE9 for ; Fri, 6 Oct 2023 12:18:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E6D98E0018; Fri, 6 Oct 2023 08:18:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 197F28E000B; Fri, 6 Oct 2023 08:18:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 038058E0018; Fri, 6 Oct 2023 08:18:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E78248E000B for ; Fri, 6 Oct 2023 08:18:19 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B6205160696 for ; Fri, 6 Oct 2023 12:18:19 +0000 (UTC) X-FDA: 81314939118.25.67DB61E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 909D7C0015 for ; Fri, 6 Oct 2023 12:18:17 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XPJye5a1; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696594697; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dbw4MOmjZC51ejikUmCxHLL4GruOz1Qm7tMoP+Z0mHA=; b=SutzM30INfSgKGwM1qvxYgr8/2uKARMsAseCSArqSHU6eQogs8zlspYLFHEn/LuOXzbWxV 3HaPYcUFXy9wS9y5/d2mW3rTji8LOtbpGO8/hx9U2ptvQTsDRQwTHb0DcR4P+2NdIaMjDc hmUyGxxMAx2Tq8TqNEBTDG9OgEuSOXA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696594697; a=rsa-sha256; cv=none; b=1eRVrFDV6DlTT/1QiLrgAAICponcGHSaMmHQ4crsgw/VJbCqfaYDj27a6pL7Rk+uB+gvi5 MUV/WXnRekRdwEaCWHt7OJ0zMuMyc8s+Z4253INXq9QhVQ1gzTY22Q4FU0KvKIbetCuGun I0J/6agEatCIvjlh2hSclI8Za2l3oAY= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XPJye5a1; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696594696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dbw4MOmjZC51ejikUmCxHLL4GruOz1Qm7tMoP+Z0mHA=; b=XPJye5a1Qc4OE6/5i1EFoHo30LBr75FvPdqf3HcQlYExBp3PwXl8LUFsz4HEg/ypi8yVa0 2YbDdHdNjKwLQ8xh1u1padvvxKpCRmdFObKxKUO6CNpEcU1ktshkRQ1c87XBzevr3EPo0I 0WHq317NKofAlLquLvJMGSin43bcnxE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-678-yKqz8LzaNDmAd416HtPHwA-1; Fri, 06 Oct 2023 08:18:15 -0400 X-MC-Unique: yKqz8LzaNDmAd416HtPHwA-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3248ebee5f4so1320236f8f.2 for ; Fri, 06 Oct 2023 05:18:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696594693; x=1697199493; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dbw4MOmjZC51ejikUmCxHLL4GruOz1Qm7tMoP+Z0mHA=; b=ncflsGI2CI1fm6/BOJkxCRuhT4aWYpVdGhQLkCXX1kb8teNzB2tUIT18MSJ55rFStt m31SkShdCtYDVXjyqWYgo805RQ/fzJZDuI7HJIRsgbmSDrvjZbdX5zryc4vSmsrd7h/v c0fH+botN2X/fWpRFZfY6nI9BFQZI93lyGac51gTRM8656kkZwapXiHYwN/65aX0Gobg gqa3fbn3v0Ym6fpjOXuTAK9a3hD/yY14RLeKA8omUqGPHtM3WLaJzb4A+EKDlaO+d4f4 tuwWDNHAV3r906uMw4hWX0AUQWVbYtUBgjJ4Jb6kmoqaNI/lfuoOg7IPTwCB5dQgshc2 Mk1Q== X-Gm-Message-State: AOJu0YxxYP7tDzYeNy0Wv1EnqG3j/947XThAtfipscWkJKRwxuNIE2hI 9D4ZnM+BwdBTrpHkRzmuNBPzsSj2+wrH77MLISIsj4mTA2BX0WTpEpqQljuOIy8LRnGYJfW/zI9 Tc358Ah0H96yio+dpKyk= X-Received: by 2002:adf:e8cc:0:b0:322:da1f:60d9 with SMTP id k12-20020adfe8cc000000b00322da1f60d9mr7590365wrn.47.1696594693334; Fri, 06 Oct 2023 05:18:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFc6SbTTZSfwrLVAys/qqFPp5hvwHwl88AuA1jeLh9rz9lTN3c+wJWP4s2tjE8cErcaLFUGCA== X-Received: by 2002:adf:e8cc:0:b0:322:da1f:60d9 with SMTP id k12-20020adfe8cc000000b00322da1f60d9mr7590346wrn.47.1696594692925; Fri, 06 Oct 2023 05:18:12 -0700 (PDT) Received: from ?IPV6:2003:cb:c715:ee00:4e24:cf8e:3de0:8819? (p200300cbc715ee004e24cf8e3de08819.dip0.t-ipconnect.de. [2003:cb:c715:ee00:4e24:cf8e:3de0:8819]) by smtp.gmail.com with ESMTPSA id u6-20020a05600c00c600b00402ff8d6086sm3642880wmm.18.2023.10.06.05.18.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Oct 2023 05:18:12 -0700 (PDT) Message-ID: <3cbd358e-501a-217f-6482-e20b55e7c728@redhat.com> Date: Fri, 6 Oct 2023 14:18:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] mm: rmap.c: fix kenrel-doc warning To: Matthew Wilcox , Muzammil Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20231006113948.51673-1-muzammil@dreambigsemi.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: fzn5yowtpc7hhjng46astk8swhnxn1j5 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 909D7C0015 X-Rspam-User: X-HE-Tag: 1696594697-111283 X-HE-Meta: U2FsdGVkX19VPfYvJ1YJCvGdVINN6iOCEEnwLr+pcsxvYsY9ABQA2K3r9rNUZQtiP3GVlUZgbcihFf7it5CVRgM7rbFJkZJNnPy2eF3PKzO12/6v2bRERYEy+Xg08BWU0lkgEBKCKZz/DLr76oDiWQ7D/9UP47zg6SuMoAyf2cRs5xb4l6MfrGMKWL38ohWCbJvTA5I7jlRCeG/KXfsd4+EtUt2m4Gm0sTeiu1dQgkLkgX1e6gIy+mnN0XxeUULc7aT507bfHm11WZsna76myq3Z9A82uwWxAcsfTupRfOv35pHqD+BOA0RdNhGmP2FKbHhxf/xdCytCe5dqHe3TbYsIuwxkTpVetBpei8vCHUkr2xbXkQ0g6LUA609eoz63jV1TIaMYrKR+IfL7uVOXrqqspWkg1KZWrOPVqoW9V05Wkolubq806fUrXpO4ASfX/9/lGDZhgXJEHtHbZH2PwiLouCxLhoznEgtel+TjcXOe4FfJq2k5Wj0Q0FZA9UytO8l0daXHL/PR5D/vGBsi9v0r4jfGTvxwoOuK4WydpL/uTPIF9oGbnBvfWEoNsNyNvYlCcGv5NXv9UDYLpDeA/Nbmz9aiYUuyWzTH8yEA3I5A56zUsFxQj79YHAfXfseCmodVrD4EnQlM76ciDl0rmH30+VA8tVL5ZbSv13NgO+YCY8GLJAKR/Ex2kpJMJ/MCS2Hah3hOGpq65yer7JnOli9nlSChjapX82CT95U7GiwbVpeSuX0HGJ5F69oYy5Abd2EAG3KzJbQ4DyouNqm+yD+RjDcXQZdUvEkuMTLlOHkaAs/jX3N9VlaQ0lEdxNF/dOBthvDKb+tYwPGJh55QS56nIzfCBjg5pRxmgo8jWExKBK9S2iTcTujDEsIexiHPV9FeilEHbMRIA5FmOQASsB+nT859+ZmYIiCcffdFhhwW0UahFsBoJZE3Qfvj/QNg1ah2xa/fV/lW94HqZRy Cq8IrW4I Shv3vxTfG9oxjj5ry3sWxZAA0XinMjOj0sXzkWSvOUiaAdHKMerSIN2DOh51q57ghaNQt0kTOifXRJyrPiURnToxScnh0fqYeCmp6BH7i+QOQWe4xSqWQapJJ+I5UVuTHchFp8nR/P+mpmozfFFxXCBGCmQjDULFAtip7DunAi8GpcDS6dlCCJ8w0e1cNvWiXbGsca1HsFKcGGsZk1uxyrs9KxM1pXV1PsqFoNitdcK1w8BnhKsnhFKw+zgz/8pkcbAXsBTnCnv2pIUQx+zQhNzE5M0NJY6z5C7ZOi8kW/PikL8akvLw9nwPPv81i60ItebKM1HKJHkLunGdsrvgig36th7itJ7Qfj+NeNvC3NtCBCs9N5sWmjXPjlzCd/dFwZGb7+Ub/f5R3COuzdNZCdtS4ahW0OHVWXUnbFM1dxKsbspcMMXxfWSP0OacIoiYTrzx5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 06.10.23 14:16, Matthew Wilcox wrote: > On Fri, Oct 06, 2023 at 04:39:48PM +0500, Muzammil wrote: >> /** >> * folio_move_anon_rmap - move a folio to our anon_vma >> - * @page: The folio to move to our anon_vma >> + * @folio: struct folio - Represents a contiguous set of bytes. >> * @vma: The vma the folio belongs to > > Why did you change more than just 'page' to 'folio'? I think the > other changes you have made to this line are not an improvement. Oh, I missed that. indeed, just s/page/folio/ is sufficient. -- Cheers, David / dhildenb