From: David Hildenbrand <david@redhat.com>
To: Matthew Wilcox <willy@infradead.org>,
Muzammil <m.muzzammilashraf@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: rmap.c: fix kenrel-doc warning
Date: Fri, 6 Oct 2023 14:18:11 +0200 [thread overview]
Message-ID: <3cbd358e-501a-217f-6482-e20b55e7c728@redhat.com> (raw)
In-Reply-To: <ZR/6sZmNMpMkfxKf@casper.infradead.org>
On 06.10.23 14:16, Matthew Wilcox wrote:
> On Fri, Oct 06, 2023 at 04:39:48PM +0500, Muzammil wrote:
>> /**
>> * folio_move_anon_rmap - move a folio to our anon_vma
>> - * @page: The folio to move to our anon_vma
>> + * @folio: struct folio - Represents a contiguous set of bytes.
>> * @vma: The vma the folio belongs to
>
> Why did you change more than just 'page' to 'folio'? I think the
> other changes you have made to this line are not an improvement.
Oh, I missed that. indeed, just s/page/folio/ is sufficient.
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2023-10-06 12:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 11:39 Muzammil
2023-10-06 12:16 ` Matthew Wilcox
2023-10-06 12:18 ` David Hildenbrand [this message]
2023-10-06 12:17 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cbd358e-501a-217f-6482-e20b55e7c728@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.muzzammilashraf@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox