From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1113C3ABB2 for ; Mon, 16 Sep 2024 06:32:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4699D6B008C; Mon, 16 Sep 2024 02:32:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F2206B0092; Mon, 16 Sep 2024 02:32:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 293096B0093; Mon, 16 Sep 2024 02:32:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0661F6B008C for ; Mon, 16 Sep 2024 02:32:48 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9567814016C for ; Mon, 16 Sep 2024 06:32:48 +0000 (UTC) X-FDA: 82569633216.22.E7ED5F9 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by imf24.hostedemail.com (Postfix) with ESMTP id 82506180002 for ; Mon, 16 Sep 2024 06:32:46 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=kKRVD98Q; dmarc=pass (policy=none) header.from=collabora.com; spf=pass (imf24.hostedemail.com: domain of Usama.Anjum@collabora.com designates 136.143.188.112 as permitted sender) smtp.mailfrom=Usama.Anjum@collabora.com; arc=pass ("zohomail.com:s=zohoarc:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726468245; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2utergmwaDia08m6LN7t4dPgvnAwmwLOjnXGjzsRf7Q=; b=u4hpQgab+n88lrg0brm0rpQpbH5azAekrYp7jYIKto5DctjH/Qm0jHiffGnrkAjRxp/o/k GvwrHOFGwWvABk7XeQpQWLCxzoiv9TXxxcmiEzyVAgofod7C0o62+iN2bfz7bnvlWCmC86 vFVJpKHjP64GHdw273qjp1995A8KB8c= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1726468245; a=rsa-sha256; cv=pass; b=sYdgL/0b6NV46k3j6985K4qInGae7vcw7zBxDjEZrGVM4LvQvdy/2Mti2B2332eJQdued9 y74WqOQyxxxSs7Q5+P1h8n1FGYTyj7sXief96Lsj9MdoO1PHlgw4fDk88dEhF5j9ei4FuW wiy4piZw4CJy3+FarJK/Vb9uW+Rl4zY= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=kKRVD98Q; dmarc=pass (policy=none) header.from=collabora.com; spf=pass (imf24.hostedemail.com: domain of Usama.Anjum@collabora.com designates 136.143.188.112 as permitted sender) smtp.mailfrom=Usama.Anjum@collabora.com; arc=pass ("zohomail.com:s=zohoarc:i=1") ARC-Seal: i=1; a=rsa-sha256; t=1726468351; cv=none; d=zohomail.com; s=zohoarc; b=S8NTHwkOE1u6lfxkSptXXRdSSwvIN+gWBEUVLExRZfly56WRXNBuG9p96nm9bp4eOPCwNL7pKA6L+vfPAuEKG4+oSzyFyIJ03GyKmzBMdUELjXBt7fpgednbYNA1cO799MuEg19tDsVl01yu31n21NqznSZvAASqi88pmyrvd1g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1726468351; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=2utergmwaDia08m6LN7t4dPgvnAwmwLOjnXGjzsRf7Q=; b=maQZW938tvN5JCYXToS01Hk2liEbUcEAMJydKy4e3+SaZTUdecC13I7yFq9nOecmRJThvuF3DUjw4ygPXiNSLypSSRLG1SpAJ0Zc1KxFrWy8kCZNdXWCRXQl1RNIhvbZ957gYBrGUkae72cCihTrox/NFVbf8d4Vcdx8McXIk6Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1726468351; s=zohomail; d=collabora.com; i=Usama.Anjum@collabora.com; h=Message-ID:Date:Date:MIME-Version:Cc:Cc:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=2utergmwaDia08m6LN7t4dPgvnAwmwLOjnXGjzsRf7Q=; b=kKRVD98Q8L76jTz/4ykCP0cjACRAXAdgjCOjffSaVMdNQyCNQitoGVVnkcAmNAcu J7CEKlQNjbLviTYu/s2onsaEtxx7WGEiVFu72Qv4YCdQyU349ydEsYD7FqFtwqjGLOG EM+nzqFFK1uF6x+9URY+sKhCpcOoPYFXHm4D3ZJQ= Received: by mx.zohomail.com with SMTPS id 1726468348435996.2519911765199; Sun, 15 Sep 2024 23:32:28 -0700 (PDT) Message-ID: <3cb9d266-4d4b-4031-8603-da7fd9e3ad47@collabora.com> Date: Mon, 16 Sep 2024 11:32:20 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Usama.Anjum@collabora.com, kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] kselftests: mm: Fix wrong __NR_userfaultfd value To: Shuah Khan , Andrew Morton , Shuah Khan , John Hubbard , David Hildenbrand References: <20240912103151.1520254-1-usama.anjum@collabora.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 82506180002 X-Stat-Signature: b8d6s7zx66dnyywz8goznr7g33yi6jrx X-Rspam-User: X-HE-Tag: 1726468366-575690 X-HE-Meta: U2FsdGVkX19cX6bq4SC9759JHiG9t+tVTb5W5Yc85jKec17y8yOEDEjYcTHuTpbgi8DlYVUKJC6aMBwNMkDJtxUAPIHo8Jz9GpuxxQXMx8Kqk9ugx26CHrSqC8gG4/ViWD6JOIJ7kFcjzv0eyDuhUXpIBVbL6WHvHgJGN7t/61HUxx8c4Kq3GCfnngB84u7BIKv6xrcm90B/efkaMX9qC01CIY5UB58w7FPrnlh2eUk+tFeLNBRWh6iIj6MZ9ZbMdVJ2lRlSbw+6kuxHEF89OQLqpkSrE45Mbx4V9LBK5L4qZAI7p8zo7sxuK4zJTIBeF5KpYLl4r3pCEZ8qE8n26f/+Q2R3sF90AmkwfVUeuwgzTxbPYGPq9eyNmvE8xlG/BQmen9g6E5/uUqgZcK4zUQjL49Q4UhE6SgFc4h/HQuZ69PcEHT6JmiA12dDayM4qrQdJFKU55te2NNrCp7TGZU8mQLuqTJr3+OR3Gka+JRK5+hhgZcNaepBl9cmbikdX0wqLe4hLXBCKf1x/7WsvDQ0DubE/5TPyEvCmrYWGEDisoPY0RsOu9G/ew7LYMN7e7d1mqqbunBDz8DDfY5kjklGSBKgLSmBzOINsm4T0/bne7adwNBoqbg31SqDFYKpVDRmGVnFAA7COeQt9KCz1W/0k+/O2Z5S1fRyDpSaCeNEcTmgvVcWKsQYBwme8CnWOoNL3g2gZJeJKKotWaCx7FiRd2uhYI96UkAgBy9aoOUxznUbhvP9I7CwoJVBZgcLytZCf2jNszEJpfmDis+UAiWLmyBwPf4wUTbK8xilDaSVetXWbFJFlvCjf5Y8kZwcVMeJ/osq4t2UEdGNVp7/sOKNqIUc8tGeNq/MflMeiA0R5nHJhaM8bcgsRRkKeooitP1qPzO2e08edk3I0mK/2eAOE1bq7/o57/6+1ltoScQGypeGJwdK2/gXtEtiuGMXfFi/MBntHUcSKkmHo9QL VbUqRAVI jAzj70GcFolTblA0e12N9/UtuhRz8WZkKkP896xgIC9q6fUu+0pX/VMZTXBQX7XsiJXQGkneIt4swU02JP2EQhdS6X40lcwfB3wGZm+9IPl5vdwKb+0/f+pufGd4WhckkCcVbLnUvCBnWVJRYpfbo/QwzaZlY4mx6evkHK0XHqCXosb7/1bs6f6ZcDrdOF7XoKykh2nDW3fMko59ddOxaOV3anCGnvOp1nBSMfxtnhAbL33HyF40hwxTvx24ZIwvl6NIHEZ3hNmLYz0i70QFRgL7MqeN3Tu3OnhvcTBQ/K4me1VpBzpkdPnsA/QN4C8oE5B1LCnWWTnjOUniOq2Kgh+UyWKmHpfhbr1bWM39awgLhJN3Bcpi+5CqDNL5x9O6D576gmMz1pj+llP0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/12/24 8:44 PM, Shuah Khan wrote: > On 9/12/24 04:31, Muhammad Usama Anjum wrote: >> The value of __NR_userfaultfd was changed to 282 when >> asm-generic/unistd.h was included. It makes the test to fail every time >> as the correct number of this syscall on x86_64 is 323. Fix the header >> to asm/unistd.h. >> > > "please elaborate every time" - I just built on my x86_64 and built > just fine. The build isn't broken. > I am not saying this isn't a problem, it is good to > understand why and how it is failing before making the change. I mean to say that the test is failing at run time because the correct userfaultfd syscall isn't being found with __NR_userfaultfd = 282. _NR_userfaultfd's value depends on the header. When asm-generic/unistd.h is included, its value (282) is wrong. I've tested on x86_64. The fix is simple. Add the correct header which has _NR_userfaultfd = 323. > >> Fixes: a5c6bc590094 ("selftests/mm: remove local __NR_* definitions") >> Signed-off-by: Muhammad Usama Anjum >> --- >>   tools/testing/selftests/mm/pagemap_ioctl.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/mm/pagemap_ioctl.c >> b/tools/testing/selftests/mm/pagemap_ioctl.c >> index fc90af2a97b80..bcc73b4e805c6 100644 >> --- a/tools/testing/selftests/mm/pagemap_ioctl.c >> +++ b/tools/testing/selftests/mm/pagemap_ioctl.c >> @@ -15,7 +15,7 @@ >>   #include >>   #include >>   #include >> -#include >> +#include >>   #include >>   #include >>   #include > > Also please generate a series with these two patches with cover-letter. > > thanks, > -- Shuah -- BR, Muhammad Usama Anjum