From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3989CC7619A for ; Sun, 2 Apr 2023 14:56:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 72A426B0071; Sun, 2 Apr 2023 10:56:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DA476B0074; Sun, 2 Apr 2023 10:56:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C97C6B0075; Sun, 2 Apr 2023 10:56:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 499D96B0071 for ; Sun, 2 Apr 2023 10:56:38 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1D2CC1A01CB for ; Sun, 2 Apr 2023 14:56:38 +0000 (UTC) X-FDA: 80636752476.21.EE0A664 Received: from out30-98.freemail.mail.aliyun.com (out30-98.freemail.mail.aliyun.com [115.124.30.98]) by imf12.hostedemail.com (Postfix) with ESMTP id 236854000D for ; Sun, 2 Apr 2023 14:56:34 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of rongwei.wang@linux.alibaba.com designates 115.124.30.98 as permitted sender) smtp.mailfrom=rongwei.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680447396; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qe4G8c8X43o0Y666LClyvgHV/0mZla6PG7zn+qRo31c=; b=7KRy4OqP0MZThu0f6KWOCV9pa+8vHfzD/5MbnquiwEO3KImED/3760UGKupNtTDkeRzRok X6x80rynb6n7IJ5H1TGQHXCrgyNqWEAEL2Q7bT7GZF0U50qW2PEpNsgzLxPxm/IyITrR6X n2aFiS2C+ApEEcJCO1NWgQ7uvkMdyUE= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of rongwei.wang@linux.alibaba.com designates 115.124.30.98 as permitted sender) smtp.mailfrom=rongwei.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680447396; a=rsa-sha256; cv=none; b=OdnSR3NUuWqp/KGOjqK1yFLBYD1yOASK/h3NotXUzNaP4WNptZ2Jz15ilt80/J27EGCRQE o4d661J2jgZCVz4nXLw4dy1PDMzEVJYonivWpVHSZQkqM4t5PqmAKti4s6+fmyE23Oe18F c0xt/vUqnATAhiiZhwfrmQzNxLV2hnU= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R121e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=rongwei.wang@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0Vf8O9Kq_1680447388; Received: from 192.168.31.179(mailfrom:rongwei.wang@linux.alibaba.com fp:SMTPD_---0Vf8O9Kq_1680447388) by smtp.aliyun-inc.com; Sun, 02 Apr 2023 22:56:29 +0800 Message-ID: <3cb9b024-d124-b13d-a80e-f5788b023065@linux.alibaba.com> Date: Sun, 2 Apr 2023 22:56:27 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/swap: fix swap_info_struct race between swapoff and get_swap_pages() To: Bagas Sanjaya , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-stable@vger.kernel.org References: <20230401221920.57986-1-rongwei.wang@linux.alibaba.com> Content-Language: en-US From: Rongwei Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: jfej1i3bhq4x6wsq3yis7xxgn3pshngg X-Rspamd-Queue-Id: 236854000D X-HE-Tag: 1680447394-91589 X-HE-Meta: U2FsdGVkX18IIu6Uzm0tNNlMKNS4CZvx7HZ7Hoa5r0++pUTIpj7rvWDPMyG8SfRFHKS/nAQu/zyjCMWkZTfT0FGo1T6FLPLOC66MeHyj51GOH7eejGf2qCI9KOq37LarSLRsItop68DXQGAgnPmJCDvxMIA2WC2Yq6DaXMxbnXDYX0mFYxjEsGGTKE17x4N5wXSqmPsKoblBmC5/i0uowUczvU6UqoN6d31YejRuJjuTBC8wScUDm8hRU331mDSGUQyvvilh7a6cmyoK0gcdSc9+cKV9zPaGKsJtxGkQotdX0hN5jS0b258WJghP4yojs4JQjGxHOtwxG/QDCLiBXYEaBEjTMFd50P+BDXY5RvMK0r2HuD18nnwqDqItmCOl5Nu90jIcz4wB/Z8Ayolrwi2/YZZAX+lN0nqdoq63wJDEb8Hex1hSvazvw7i8BlqBpf841MzJOlMtS1LuIlnb5JQCyQd6yuQMLqlA+9CMHvIFhyD9LpBSE8ZfILM4WYKsNfWaVg5M1dCG6YwWxSW+7HuW0sx3J+KrKrW8tuk2cpy/tBXcPIMu/y4qfu+LOTxUa75WEbo0q0jn9JKGsjdfuoBY7fv0hZoIM2Qu0kCXbtb7Wg4iyVKJjfM9kIfs9FL+nmK9Kgr3BxwDsBLAO0Cq/D1k1E4r+Eho/UxO1/neS8lfZ03tmcSCP9ZFzgu15vCWhGyDN1EOM38RHvmIrrTcShRTSkr5QeeRBHdzmFA1REhMC36ziM9hNre9Qt5t5BrVO1RT2O3yL1sVdoXykWr+zfCtilv4VNVMjdMS5BfsDcSslPiwhXvgcKBIRO8ze7GNT6rKAhhOfj2lLI/sMTDntU+jcZMZsS/pWYN9icai1n86oQgiWtmytwuJmL0BnoOZqEd5m8qLCtHa3o9hWzlhVi7McX73pN1If4h672b2/AdZ0Xh18ZgGwRHvHo4xXeafhOCsInDWTqfJ+H3h+HQ jUuP8d41 ebj5HI6IfsdJlggHV6XbVHVuU3IAFsWGu3btlfYe73I+802YI37HNrECLIYEMJ7IohpZKwxzLZcpp+yO6EdPpz/psnMozCt4DGA23hU2DJLLjFY5vaYRNiYVmcp0LGHdPrBvktw9clMb55H7e6/08oVZyxMzBNC8ePbaADUYXZ+n8uCNKKPx91f/0ZhdeZTGdrj7XZxgdkKdK5TO5B3l+/vwHbZRwBJ/q2WSDuO6jKNYh7gEzHUED3423oQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/2/23 9:37 PM, Bagas Sanjaya wrote: > On Sun, Apr 02, 2023 at 06:19:20AM +0800, Rongwei Wang wrote: >> Without this modification, a core will wait (mostly) > "Currently, a core will ..." > >> But, a worse consequence, panic also can be caused by > "However, in the worst case, ..." > >> In this patch, we lock p->lock before calling > "Lock p->lock before calling ..." > >> We also find this problem exists in stable 5.10. > So, you claim that 5.15.y and 6.1.y aren't affected, right? I think above both versions also be affected. I can check they next. > > Also, Cc: stable@vger.kernel.org on the SoB area (as pointed by kernel > test robot [1]. Thanks, next version will to do. > > Thanks. > > [1]: https://lore.kernel.org/stable/ZCiuGEkyk%2F1Afisk@ec83ac1404bb/ >