From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0B53C369C2 for ; Tue, 22 Apr 2025 07:05:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0CDFB6B0022; Tue, 22 Apr 2025 03:05:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0568B6B0023; Tue, 22 Apr 2025 03:05:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC84A6B0024; Tue, 22 Apr 2025 03:05:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BBCA26B0022 for ; Tue, 22 Apr 2025 03:05:49 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C4741B2C0C for ; Tue, 22 Apr 2025 07:05:49 +0000 (UTC) X-FDA: 83360794818.14.86DBB79 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 622FB80012 for ; Tue, 22 Apr 2025 07:05:47 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="NkL2/m+V"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745305547; a=rsa-sha256; cv=none; b=IBrlO3qQbl1RTS6Uv5iwRcJzOgawjKrcG02u0loBkL1QEby943sI1M5ZXs82egrxl62HBe UZszP2OQWVbheLB6ddSqBhr7LamoV+owQrjMG9kBZCMq1i+M3TsiU1E9E+6tT5+H0BVTCU A5GaJszacCp6D2bH19W8Ms7eZ7rIpxE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="NkL2/m+V"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745305547; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jF+wFy+WZJrXig0sm8RWiuDKt94+0heDSw+sib+cbbA=; b=U7qhVeJOBeBE1WABbXgkhyWEKCL9mKJFEPUv5WS4EW4v8vpK6Su28qYjIef8EGp0C7lsqZ 5ZVqEmtExlxTAz6HWUz3VMZYMxcodifm4sJTDA3pyWEehMPXUtlgmOUdpDPsDazZqpPGaW Q9prt6sFwtWTYOMHCrQqNvBNxBIC030= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745305546; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jF+wFy+WZJrXig0sm8RWiuDKt94+0heDSw+sib+cbbA=; b=NkL2/m+Vm+sHuRAB7kGxgaLolE6GrxYGDNPWajFQCembWC6FyUcPE8Nz68Jzog6jigrzvl OnooRFlYbF3E2ysS7QFqoMXFJZKaQSqaZcww4eTXpZ2mJE9xQceVn4xkb8x31BNcI1YZQJ WYm2NF7W8qK2A8keK2IRwLohAYCmlO4= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-478-91pz8q9_PruGDMhH1G0zyw-1; Tue, 22 Apr 2025 03:05:44 -0400 X-MC-Unique: 91pz8q9_PruGDMhH1G0zyw-1 X-Mimecast-MFC-AGG-ID: 91pz8q9_PruGDMhH1G0zyw_1745305543 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a064c45effso22711f8f.3 for ; Tue, 22 Apr 2025 00:05:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745305543; x=1745910343; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=jF+wFy+WZJrXig0sm8RWiuDKt94+0heDSw+sib+cbbA=; b=NeeHOkEcdDdepJECgkuT5heMrQ8aE+IBHiAZjtN48yT1YEh6Sw4xH6m4h7Zi0kNE/j Sxo5Oc41Ovc0RBzZZLtZet1F/BX0QwurrsvbNdP0aE2NnL5HighairNqOaVYeSPbzW8p FL+OvnX377SxamWuJsZ0YKsQRxv5cr5Ys8d0raFja6+W1VWNiZmU7zR4IpdagWm8Ab8R XVssBcQgA4epxxx1pURS0QSNFllBTb2NC8f0i+q7rKtSZ+qFxP4YubwqcsxWOlanRiTS sJnPIQtED7wBwKkRyr5NYGUfCADZcc2PzF+0Kp80mEXCircp/IL+1yTPadnUf/wvyj3w VhPA== X-Forwarded-Encrypted: i=1; AJvYcCX3mRfZ5/F0bnovfvGybYHSVp28S+0pwyDM+FH3fS7ZWhSlH3MpQieDZicRCKKJ0hslgQn4CV9/dQ==@kvack.org X-Gm-Message-State: AOJu0YxWuv9MouQTbI9zvm2HQH2nPM5PNQF68lkVz9PiwEpQTiGbDomL irI09VVT9zMufkVVtuHhh4ty7a9R1+AooXCnz+DtLjW2WIlCWMFubLneQBKpcEEtScWOvW5mtXo RQbTP3CnXUIvw3T6HUe2OTY63xJyj7TSMZCZvN6ukN5OUqG9o X-Gm-Gg: ASbGncsBI41Zua0c6vIfbINFMmcTKHqWlJr/Bs9Wb0ELBL42z3YL5Ab0ezDOa90/I/1 bll6XYpiEcyFnLKb5Kw85oA1UpjLuxSHb7KLACRkD0mRt4SZE7P/UNzcpgTWArRz5u+0Xyy/u2d fj133Muqj4ia0moTixVzZAiGmESH+shmHhVxT9lrVL7U1CeaE8sd2Jl2DVWRUehso97hSST27s0 mcZCq3xhRW2hXj6e8Djm5rq7T6TvX5fmXrlkmVs8Ywc4qIRCeIerthHNttDxLGEkqd7+ZrCNM2a Pv7YdVQuJHuJsJxWyqA/Waa87wTZzak4gQLXfxQHaoLFsxddW5VsjOYzaCnUbpqQgeUeHpwukFM RVX0Pj/a8fZlDzSZkwNPUekBndBJe6OCWYrvO X-Received: by 2002:a5d:47ab:0:b0:39c:142a:ed6c with SMTP id ffacd0b85a97d-39efbad3df4mr11838915f8f.40.1745305543523; Tue, 22 Apr 2025 00:05:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH4fD+rv1vFvSzw5y7MZVEXu2KkMb+wX9rdoQ/fOSpSvepAK7BkNGVhNuqRwxxPUqcFRd8B1g== X-Received: by 2002:a5d:47ab:0:b0:39c:142a:ed6c with SMTP id ffacd0b85a97d-39efbad3df4mr11838889f8f.40.1745305543188; Tue, 22 Apr 2025 00:05:43 -0700 (PDT) Received: from ?IPV6:2003:cb:c731:8700:3969:7786:322:9641? (p200300cbc73187003969778603229641.dip0.t-ipconnect.de. [2003:cb:c731:8700:3969:7786:322:9641]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4406d5acca9sm161960395e9.12.2025.04.22.00.05.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Apr 2025 00:05:42 -0700 (PDT) Message-ID: <3cb85c4b-7e28-4a70-92da-1d835eaf467d@redhat.com> Date: Tue, 22 Apr 2025 09:05:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 13/20] mm: Copy-on-Write (COW) reuse support for PTE-mapped THP To: Kairui Song Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, Andrew Morton , "Matthew Wilcox (Oracle)" , Tejun Heo , Zefan Li , Johannes Weiner , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Jonathan Corbet , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Muchun Song , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn References: <20250303163014.1128035-1-david@redhat.com> <20250303163014.1128035-14-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: v4TZR7qnRDob2zlLTyKOtXJktH0RTj7nwaaI2CG67RI_1745305543 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 622FB80012 X-Stat-Signature: oaidzizfsmfzkurw7twjbsz7ttk8snep X-Rspam-User: X-HE-Tag: 1745305547-106554 X-HE-Meta: U2FsdGVkX1/sByrvjbiMV6Enk7rDpL7R5RQ9i6+bErC+ks4zyroJ7k0z/AdO53SEUv+Roeq1mU9rw81BCuAs+IxPmJu0Ir1caKcToMpccHFhE4mdY6UZkkrc2s4AlQdH9eJYnPM/tkcSHlIXWtOeYfy4E2CNejH6/27Qe52ubahARot2davjhSlr2zb2hrWOo6AbZKfoKiOyMZ5fYNUMmGXg39+OhiSF/N50E5upLLQ33fXE45OKmsFS2fbxosjNHEzBNfv1wY6dEiMXdlwzJnFHNzTP5SfzTZLvaFNKPP2Qo7rz+izCXx2VHtawvJfOT9Kgifg4W0i5Kb6X0DVXl6h5E0JbxyBZCwkCLmSVNIjfWN92weP+BntNymOCse6CBu03igGlt7KK12gyDkePRpKYdec9ijEpWVWzx7cohDkhfguAROEe82X4H3GE0oappwYfl1UP0BX9MHL3p1j8khL5RaSopdiOgpN4MXZIfk60lEL6QaRjej60G1PsBnkzaiu9bEnBaFZMLy2nU7US/7sG6W5YUoznG0+z3ADNgkyLRo9JnIz/+iSLlqGmm6o/8dezN5Q11944Zmv3WRcvfW4ZXe5gL98lZeMscsU4X82DtAwUmDNvjnjlaTtellpyvCFu9haaI2aoQ8nGoJ+IznMJ4Id5NQjM/Xz9SsxpilstQdSyZkQ64sfNlF8g7mdJcH9TCpR9+y3hzIyGBGHmuUWwq8sgByCjFY3VU/YTtEw7iE5KxMGYdY4cC6/BKvyHkxc+w+gfQV1loRhtkRGsyhP+gqSb+OsupS7lwsCTC39k1ps+QbHjx3+04E+oMwRvE/C+3Tl/2rOMmcguYEKcj5RRPuOlAiiztoLaytcMG9BwXEsJRw15dQgyuI6Ek2JEVvKI7KLdtlmEqyT+0azYUhY1/PABYHH+COhLQ0S0LfSHYQY6ivI44hoqGIgQzq/KOEx4RWLcs7FPxecTq9w OWfvTmv6 cOT6ZNHM1Q6WFAz0fEmLVl2UUK9ZAQbOdmMAdeX4E+NHJV+UYLjQdFun9p6Nzh/T/7XIqSScNyZ5oBxRqR9N/zmaOyyLVM3Qv4ZX49DdpiBl64/U9nJEQhhtaCUxrwbc8lDIssPhEuwxEl413yfh6gO1iJvTDwsPhkPwzmR2ax0zt1kbGCtw3eZJQoOb/JxVLr2l1pl54aHuGLaXFcOlIYAamXGtYkL5ARsNgxRqJZnj6rLXTINhZQPfVO1XOO+hPZkEXyVIKavuArMbBqD0qe6v3vyztgisNdTjqNNdOlpscU6/G5kH2qOR4rpY4lhq3CD53I1zFG1wdO/Ciit45RtFxKo74oNEEACZVOL2nG3Qo4962spFr2rcuSjH/k5sJ7JJw20TWI/Uhf2o6fJDEy/TZj2T026ncrr5d4Bv4LNVVpDcb8Dy4/0tApUvADf6JyhuCWuR6P0PldIm/KMIhulSaKMG8vSZfuAmX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.04.25 04:52, Kairui Song wrote: > On Sun, Apr 20, 2025 at 12:35 AM Kairui Song wrote: >> >> On Sun, Apr 20, 2025 at 12:32 AM David Hildenbrand wrote: >>> >>> On 19.04.25 18:25, David Hildenbrand wrote: >>> >>> Oh, re-reading the condition 3 times, I realize that the sanity check is wrong ... >>> >>> diff --git a/mm/memory.c b/mm/memory.c >>> index 037b6ce211f1f..a17eeef3f1f89 100644 >>> --- a/mm/memory.c >>> +++ b/mm/memory.c >>> @@ -3789,7 +3789,7 @@ static bool __wp_can_reuse_large_anon_folio(struct folio *folio, >>> >>> /* Stabilize the mapcount vs. refcount and recheck. */ >>> folio_lock_large_mapcount(folio); >>> - VM_WARN_ON_ONCE(folio_large_mapcount(folio) < folio_ref_count(folio)); >>> + VM_WARN_ON_ONCE(folio_large_mapcount(folio) > folio_ref_count(folio)); >> >> Ah, now it makes sense to me now :) >> >> Thanks for the quick response. >> >>> >>> if (folio_test_large_maybe_mapped_shared(folio)) >>> goto unlock; >>> >>> Our refcount must be at least the mapcount, that's what we want to assert. >>> >>> Can you test and send a fix patch if that makes it fly for you? >> >> Sure I'll keep the testing, I think it will just fix it, I have a few >> WARN_ON_FOLIO reports all reporting mapcount is smaller than refcount. > > Hi David, > > I'm no longer seeing any warning after this, it fixed the problem well. Cool, can you send a fix? -- Cheers, David / dhildenb