From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4FC1C36014 for ; Tue, 1 Apr 2025 15:26:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B9B7280004; Tue, 1 Apr 2025 11:26:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 840F2280002; Tue, 1 Apr 2025 11:26:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6955B280004; Tue, 1 Apr 2025 11:26:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 41B22280002 for ; Tue, 1 Apr 2025 11:26:08 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9F9651403CE for ; Tue, 1 Apr 2025 15:26:09 +0000 (UTC) X-FDA: 83285850858.04.4F74D4B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 34CA3C0006 for ; Tue, 1 Apr 2025 15:26:07 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=W2awPQrJ; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743521167; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jlH13oiiWoHkFQ5bCr21py5+W8kWzhgOnMfWy0zYm00=; b=U5PDnJ8MBiYApLOedZPga63soaNRedIe7+trRbx5rN32NQj0LAKMGiCAZUeejNlkT908dJ hQJo5PjsqANkum/jnjF07y/7qNWXfLFif/ProD78+jRKuNwqfL0q1T+vMGLILg9zynKcJ6 +/6NpldMmvZkeh9g+cCy9BB6fOgF0hY= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=W2awPQrJ; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743521167; a=rsa-sha256; cv=none; b=jmiOZ/ZwRcwhDti3ki4z1ZkWAYB7cDaQyn003K5mLL7FoT5XVVTtwlTbDIRoKlMDrPGHt0 f1GT77Wn4Hsr3mviNh4rrzw29yo4AE5u76pH7yBIKT/BzA+Ms8Fy5hFPIJrcExmsob9tcB 8VPeK5nQOveiwN8kaIb7ENBFeA0BkUc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743521166; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jlH13oiiWoHkFQ5bCr21py5+W8kWzhgOnMfWy0zYm00=; b=W2awPQrJyWkEOrb/Zn1SrsHOD7YVVWUqY+dfs/0DUMm0niGhIKzxJN2TwXaTwUvUggYKzh 3O1+mtEz9nqYeJK2jL9b4EZv00yVwMsgNUopZ2SH0c+UuPx6p3mh25eJGZjKRZx2DuVbia kW5KeUlfnUH4c/u0gOnH0oeoPv69RUw= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-151-PbApp2FrN1u7fnv1dx0osQ-1; Tue, 01 Apr 2025 11:26:04 -0400 X-MC-Unique: PbApp2FrN1u7fnv1dx0osQ-1 X-Mimecast-MFC-AGG-ID: PbApp2FrN1u7fnv1dx0osQ_1743521163 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3913d8d7c3eso3008891f8f.0 for ; Tue, 01 Apr 2025 08:26:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743521163; x=1744125963; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jlH13oiiWoHkFQ5bCr21py5+W8kWzhgOnMfWy0zYm00=; b=FrsAn+sMNn90TgyKTmvJbjNpoeswT+/CIHvhAm1wRDADSzYNGtk1uKsdMklYOGX7hT gSLFmmMfEsfT5MaWhHJjLaG/I94ya+zvaOD8jDPqYMes1saiGxvvXJddu0KVgLVT+yw4 Lw+rDg/szgd3YyIml61oqO2Vkp9C5TwcnHo7UTxjSVjT6/NpXazRyhEC61bu9stAFP2L xWV/9ZkVAJv1c1laR6yvgbe7bqUWZkUfngxLbLMEygt8V8P/KBYlrZ9PERJKOGWgOuGM U5HTOTSgaYwN0+M9D3XpfutQmC9zjapuaXrrLUqW19D3QPYMNPWAoTokQGf5FL6GqHT/ 4Xgg== X-Forwarded-Encrypted: i=1; AJvYcCXiji5IZOn1ww8ScSeGaekRQBUQecAct0Zj7+5irAISlxYbXhVgehwEgmIno9ZdkFRbbtlbLQHXuA==@kvack.org X-Gm-Message-State: AOJu0Yxq+bSh1aMCgHTL9Sb6kj4D33Q1AWa9hmWN4kHh6XpSUaBy7Cg4 w5S6AEnrlYLte2Cfqfd4gudsde09Jj6xEY5O5/WymgcgVu4I39XApQKI7VngJ6ivYkzM+DQnEhA QZzuy+GqysqB5yPAxbSkUDqP8tZrJK7DySYiCgbPdRxV+y4+a X-Gm-Gg: ASbGncsrS5I7VqhsPklsBbeKp050JiUGOSrV2Zv26sG/eIPsvbqiKsxmJaQDl1sCSvk ixFkSGQgMQQC2SleqHJJgXTgeJUU20kPdnq+ghhLTORSKU/h60WnHo7imR/pWfEND+epg7Omj5v cfrDGGtNghok4SIveqNboyKEa6hjUhppVzuWFYbyff3T0C8ziBmbNMSj9x6xrx2CcLzT3v5I4ya xF9qU0wgyX0pdcrRkGT8r4KWaCP28EY929nEXiwFxj2H3sDSW9815vW8A/4W4OGdDlF0bZ9pdXD vPCW2xbiieeeXwBDaR8du3L41cxBbmE9maRp0RZ0isS42Qo4WIZWC6D0lD1/eZC3lYro7NK9U7m DVDj2b7p5vEr61LGARSQRi5oMGfydoKWVBVE+6bmz X-Received: by 2002:a05:6000:4282:b0:391:4bcb:828f with SMTP id ffacd0b85a97d-39c120de080mr11748698f8f.14.1743521162975; Tue, 01 Apr 2025 08:26:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGeFCyV5L/1NCQEnyC71IIb8zL93Nf0PP/l7NMik+DS1l6FQnTpWJ8g4IYBhjgsmOCjBijU+w== X-Received: by 2002:a05:6000:4282:b0:391:4bcb:828f with SMTP id ffacd0b85a97d-39c120de080mr11748676f8f.14.1743521162659; Tue, 01 Apr 2025 08:26:02 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:4d00:6ac5:30d:1611:918f? (p200300cbc7074d006ac5030d1611918f.dip0.t-ipconnect.de. [2003:cb:c707:4d00:6ac5:30d:1611:918f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d82efe966sm208140835e9.21.2025.04.01.08.26.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Apr 2025 08:26:01 -0700 (PDT) Message-ID: <3c90c3f5-3ec7-4ea9-b482-840f21db52ea@redhat.com> Date: Tue, 1 Apr 2025 17:26:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Rename vm_area_struct to mm_area To: Lorenzo Stoakes Cc: "Matthew Wilcox (Oracle)" , Andrew Morton , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , linux-mm@kvack.org References: <20250401122602.1738511-1-willy@infradead.org> <47aa41fe-9129-4e12-aa51-987748cff740@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <47aa41fe-9129-4e12-aa51-987748cff740@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ogJX1p8yQ7F8obMZONFpQul08t0SxD-y3751_XVLw0g_1743521163 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 34CA3C0006 X-Stat-Signature: 5syh7yrnudpmqa6b4fpaou7piwaprcax X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1743521167-234379 X-HE-Meta: U2FsdGVkX189F2IEJL96tyGc8LuU/Ctgf3aZ4u4EEa9DQvuSVKtpMZGVGguapHwp6/H/Wl2s0I028EdQDc90UA/AfwUJff/KsjIKIogdBlygdSkD7NCsqmuE8L8wWtXlSncJVOiD28mhRBjZbEK4ZipHgbMR/KyLaGyiThL9lMB1ink1c29hA6F2PSFBpX8R5HVu2If1J1CgezgVAKe/mn3Z7rMVpRqf4GevMNBDvbJjTbToUV7nEeiz2Uh3RMoS0onFreGpMdc50EDBzniDdA6FdWDlqRrCTUbfLnLnleBOZ4yitkAtMCc+g7XS+VliwzGEzKpvQBca+Y53lIXNleyDfYRaXyiADtss6uxQeLrFuIBsxeGCE4PXgG7sJy7bTUiXi6t7XEWBiOZ2TxPZCC6IgLUj+Rx7fYd9So6YTABkpUV16EKKBbPH73y75v/exGy1cA4Hx33wmGfPNvgk8UYjOuh/6rxAzRznQ9k2k4V2Wej1gec6PqwDAw2FfAIuiAazg6oro3sgPH2CzQOqocPcqAKmOzX+8AnXM8NBhCn4gR13zw614ZfldhsiyTrxamxWVV/ZCJ4XKf1rjsNixcvnCsSywyNubE6M/lqQp7fklxpFt+9l1C2Lchaj10y9YN4EjNIXVWCH+DLXe9KEny6EH3YqhXa4fy8GzLIR9Jmq2YseysPsOQRQ/ThuCeeAQSnXVBArilVTUBpvJLMZ1HuSoQA+FxrKGROJ6vWpqBzSU2c6AVsJXzlHS7gSPYXfd2xR927S03iAuEJovJEkRqMiZil2f6zNmgG+SY4u4g6huqka/z2LR/ONfmyVWZFB0wluSdNbxXL5WmenacR6MHzZgXLddpBWzzPihVFgOQLn7B33av4TXxY9Fs6iQbgvUNenJ6GEoQMpbIzxT1iK+FzyZyW1S1S9Rg+/lpxxFFcsbTftogyTzJZoDzY6bpvKAEDmaa1/Bd/p0rm9jug mvd/lKvy eJC50WzNm5OlqPTegNTBZ00Yor/f0Yc3uyFIB4KSD9LxZUAnvVkHNrmW8m3gzFgI6DItR8FL3mXy2LBtXM12X0EJqcOxVA6WDZNwR9x+OpRMThaur+G73kZWSeiNXzuVxyH3CP3CVbbvQDLLfRDZQjI5ASl3zB6n4c/R4n5478Y1PfI7/85CcRb3eEHPMvRbLssjd9dSWuTrL+eeajLDtIGx7FaJUd71iap1uTEuBL8VdcP3QHVTNIOjWYXGP1CEGlcIdWY1hU511KX9p75Lest51R+SiSTHbkbAkMrhPH54WiwzkSd/Qqop/3N2MtiU7brTKiQlVyajlwR01FVtqhNxMudTFadl/pMEHCtEbybvJ9cx7PEcJ3rCNcvYFrqY4hW9dYfAf+7yuouyfRf7qzCpJ/LCVkLk8dRRt5ibqCpmJTHVT167muLYODcyk5Rdg8KC5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 01.04.25 17:20, Lorenzo Stoakes wrote: > On Tue, Apr 01, 2025 at 05:11:58PM +0200, David Hildenbrand wrote: >> On 01.04.25 14:25, Matthew Wilcox (Oracle) wrote: >>> We don't need to put "_struct" on the end of the name. It's obviously >>> a struct. Just look at the word "struct" before the name. The acronym >>> "vm" tends to mean "virtual machine" rather than "virtual memory" these >>> days, so use "mm_area" instead of "vm_area". I decided not to rename >>> the variables (typically "vma") of type "struct mm_area *" as that would >>> be a fair bit more disruptive. >> >> I almost fell for it, until I looked at the calendar :) >> >> On a serious note: "struct vma" ;) > > We should put this in a helper struct > > Maybe: > > struct vmb { > struct vma *vma; > bool is_file; > }; > > I think this would solve a lot of our problems and probably eliminate > anon_vma or something If that solves most our problems, imagine what a "struct vmc" could do :) -- Cheers, David / dhildenb