Re: [PATCH] mm: Rename vm_area_struct to mm_area

[David Hildenbrand <david@redhat.com>]

On 01.04.25 17:20, Lorenzo Stoakes wrote:
> On Tue, Apr 01, 2025 at 05:11:58PM +0200, David Hildenbrand wrote:
>> On 01.04.25 14:25, Matthew Wilcox (Oracle) wrote:
>>> We don't need to put "_struct" on the end of the name.  It's obviously
>>> a struct.  Just look at the word "struct" before the name.  The acronym
>>> "vm" tends to mean "virtual machine" rather than "virtual memory" these
>>> days, so use "mm_area" instead of "vm_area".  I decided not to rename
>>> the variables (typically "vma") of type "struct mm_area *" as that would
>>> be a fair bit more disruptive.
>>
>> I almost fell for it, until I looked at the calendar :)
>>
>> On a serious note: "struct vma" ;)
> 
> We should put this in a helper struct
> 
> Maybe:
> 
> struct vmb {
> 	struct vma *vma;
> 	bool is_file;
> };
> 
> I think this would solve a lot of our problems and probably eliminate
> anon_vma or something

If that solves most our problems, imagine what a "struct vmc" could do :)

-- 
Cheers,

David / dhildenb