Re: [Patch v2 1/2] mm/page_alloc: use xxx_pageblock_isolate() for better reading

[Vlastimil Babka <vbabka@suse.cz>]

On 8/27/25 04:11, Wei Yang wrote:
> Since commit e904bce2d9d4 ("mm/page_isolation: make page isolation a
> standalone bit"), it provides dedicated helper to handle isolation.
> 
> Change to use these helpers to be better reading.
> 
> No functional change intended.
> 
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> Cc: Zi Yan <ziy@nvidia.com>
> Cc: Vlastimil Babka <vbabka@suse.cz>
> Cc: David Hildenbrand <david@redhat.com>
> Reviewed-by: Zi Yan <ziy@nvidia.com>
> Acked-by: David Hildenbrand <david@redhat.com>

Acked-by: Vlastimil Babka <vbabka@suse.cz>

> ---
>  mm/page_alloc.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index baead29b3e67..e534f31a6b39 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -538,8 +538,7 @@ static void set_pageblock_migratetype(struct page *page,
>  			"Use set_pageblock_isolate() for pageblock isolation");
>  		return;
>  	}
> -	VM_WARN_ONCE(get_pfnblock_bit(page, page_to_pfn(page),
> -				      PB_migrate_isolate),
> +	VM_WARN_ONCE(get_pageblock_isolate(page),
>  		     "Use clear_pageblock_isolate() to unisolate pageblock");
>  	/* MIGRATETYPE_AND_ISO_MASK clears PB_migrate_isolate if it is set */
>  #endif
> @@ -2058,9 +2057,9 @@ static unsigned long find_large_buddy(unsigned long start_pfn)
>  static inline void toggle_pageblock_isolate(struct page *page, bool isolate)
>  {
>  	if (isolate)
> -		set_pfnblock_bit(page, page_to_pfn(page), PB_migrate_isolate);
> +		set_pageblock_isolate(page);
>  	else
> -		clear_pfnblock_bit(page, page_to_pfn(page), PB_migrate_isolate);
> +		clear_pageblock_isolate(page);
>  }
>  
>  /**