From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAE5BC43334 for ; Wed, 15 Jun 2022 07:26:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E1076B0071; Wed, 15 Jun 2022 03:26:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4917E6B0072; Wed, 15 Jun 2022 03:26:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 358116B0073; Wed, 15 Jun 2022 03:26:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 27B066B0071 for ; Wed, 15 Jun 2022 03:26:16 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E3993141D for ; Wed, 15 Jun 2022 07:26:15 +0000 (UTC) X-FDA: 79579636710.17.A5C1674 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf31.hostedemail.com (Postfix) with ESMTP id 67B242009E for ; Wed, 15 Jun 2022 07:26:15 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2A6651F899; Wed, 15 Jun 2022 07:26:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1655277974; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k3JeAaNVMF2xcanrQW/ZU6P2wx6xjXOxRPoxu/fL7xo=; b=CWENStBe3S+ypC1pbgUlWdhbv5lC2N5znwoBetrptGqdKk7kSpc+w8CdeyLvR7YHb11yoM Zd6mIxtcoPkiDRbgXiXkDFD1n8UvbefsP0nRUr1G6Qd0MhpHeg7vytyU8mC/7FRr2oC9Un qgW5XRpqXMhL4+ssYJCTPPHrQXcMHVU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1655277974; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k3JeAaNVMF2xcanrQW/ZU6P2wx6xjXOxRPoxu/fL7xo=; b=qWPFWW7LTMeR+CrzetQcyDIjcVJ+5V4M6S69lSahvkWBEpBTHup1JvscXvpLzG4xhcDT13 bavSiyvbQdHEa+Cg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 043FE139F3; Wed, 15 Jun 2022 07:26:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id S0AkAJaJqWICBQAAMHmgww (envelope-from ); Wed, 15 Jun 2022 07:26:14 +0000 Message-ID: <3c899066-d85d-3bd7-5b13-d5228b7aeb93@suse.cz> Date: Wed, 15 Jun 2022 09:26:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] mm/slub: Simplify __kmem_cache_alias() Content-Language: en-US To: sxwjean@me.com, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiongwei Song References: <20220531005550.10613-1-sxwjean@me.com> From: Vlastimil Babka In-Reply-To: <20220531005550.10613-1-sxwjean@me.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655277975; a=rsa-sha256; cv=none; b=lqDGGYYQuPrU/gWnSfwRrho49Ay0Rvc0fpBkBOFWWMw8U4hZd7Ulp6aEafOEgEBwFQvnIn KvrV57HwcnukntAWtWqvA3X6jg1FYjgMBgUHThRxQ9zL6yMyv5yS69G3x6SDzCRH/UJj9J fvgb/s8iRmvK9e6O1EFf5Q6tuSoVfco= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=CWENStBe; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=qWPFWW7L; spf=pass (imf31.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655277975; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k3JeAaNVMF2xcanrQW/ZU6P2wx6xjXOxRPoxu/fL7xo=; b=NqGZ2wDD7ia6gLtN/RUNG3Rmdyi45iFf+yHJCLduCp2X+kMHgp+0diO94TZj9Rj4ZjaXA4 QyH9BBG4lXfeNNsNhyAfgiDw8LSXAt1q3Ts2qmvyFsLHoyqV3OvTND+sii+4jWF/XbK2oj G+EDKjyqGxOjnxP/0InEW6LxHVwC6KE= X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 67B242009E X-Stat-Signature: xa4de6i5asqs5myzzzexcu3qwx1ht4im Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=CWENStBe; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=qWPFWW7L; spf=pass (imf31.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-HE-Tag: 1655277975-1458 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/31/22 02:55, sxwjean@me.com wrote: > From: Xiongwei Song > > There is no need to do anything if sysfs_slab_alias() return nonzero > value after getting a mergeable cache. > > Signed-off-by: Xiongwei Song Thanks, added to slab/for-5.20/cleanup > --- > mm/slub.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index d8d5abf49f5f..9444277d669a 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -4861,6 +4861,9 @@ __kmem_cache_alias(const char *name, unsigned int size, unsigned int align, > > s = find_mergeable(size, align, flags, name, ctor); > if (s) { > + if (sysfs_slab_alias(s, name)) > + return NULL; > + > s->refcount++; > > /* > @@ -4869,11 +4872,6 @@ __kmem_cache_alias(const char *name, unsigned int size, unsigned int align, > */ > s->object_size = max(s->object_size, size); > s->inuse = max(s->inuse, ALIGN(size, sizeof(void *))); > - > - if (sysfs_slab_alias(s, name)) { > - s->refcount--; > - s = NULL; > - } > } > > return s;