From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD571C6FD1F for ; Thu, 16 Mar 2023 12:12:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EABEE900003; Thu, 16 Mar 2023 08:12:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E3509900002; Thu, 16 Mar 2023 08:12:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD56F900003; Thu, 16 Mar 2023 08:12:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B6FDC900002 for ; Thu, 16 Mar 2023 08:12:39 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8DFB01A145D for ; Thu, 16 Mar 2023 12:12:39 +0000 (UTC) X-FDA: 80574649638.04.CA064ED Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf13.hostedemail.com (Postfix) with ESMTP id 209F12001B for ; Thu, 16 Mar 2023 12:12:35 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=J5ntyVYB; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=qECEkxut; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678968756; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mHaedlz+6PJdRiBIO280UYU0+qJudLUsHrt8K4W6gl0=; b=uHhHfYzo+aw8L+Fie7/kEYh0ToOQupdonzki229nt0/pniZ/yfpahONFIPH1CfP3IcxfXE HDs3HERQWEBQSSDmnC3LFqangTQGpckSB8O4on+evyGCpggGd6ZJQArFvrbNQ/Wc5H0ZlT WfRahotsMou+1t9OySHXZAetUpkuJF0= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=J5ntyVYB; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=qECEkxut; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678968756; a=rsa-sha256; cv=none; b=goQfohq9WjY/XDzb7CfZMLIEFxMPtSunyXamnzux3x4jhIKXkNSmYRG0gasA3x2EJby4h0 nAoz9A8kE9F3F/Oje8+tA3570u6v7A+cd2ZEVFaTY0kZFNao8bTMZuujOm1xiOefB5VvdI niLcLQuDnc8aFYVdfGrkcO10lV43Fjg= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7CEE821A3D; Thu, 16 Mar 2023 12:12:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1678968754; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mHaedlz+6PJdRiBIO280UYU0+qJudLUsHrt8K4W6gl0=; b=J5ntyVYB/EyIfey+Y1gv60/GLFc0S3vRYrT65jDAsfsakX0a2cVz0tzh0plgjCxJP7RoQu Ep/5X1WkaD+ZIxLsxANNAGDRG+/K5Lo/HxPQbUtek3trMXoYOTqGGt8lRehq6aExoXsL5Y qm7A/nt4hiL38kmHST49OY7OwFhTIWQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1678968754; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mHaedlz+6PJdRiBIO280UYU0+qJudLUsHrt8K4W6gl0=; b=qECEkxutGnHzG3qHNM6078FQtmGNqd9LL2L18Sl7dTOQV+G8sGF3eQIDSo5bvv8NztbxxR 71ReDV00K7S4TwAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 564CA133E0; Thu, 16 Mar 2023 12:12:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id hzs+FLIHE2RNHQAAMHmgww (envelope-from ); Thu, 16 Mar 2023 12:12:34 +0000 Message-ID: <3c77182b-5c41-65ec-afca-42625eadfae4@suse.cz> Date: Thu, 16 Mar 2023 13:12:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 1/2] mm: compaction: consider the number of scanning compound pages in isolate fail path Content-Language: en-US To: Baolin Wang , akpm@linux-foundation.org Cc: mgorman@techsingularity.net, osalvador@suse.de, william.lam@bytedance.com, mike.kravetz@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <73d6250a90707649cc010731aedc27f946d722ed.1678962352.git.baolin.wang@linux.alibaba.com> From: Vlastimil Babka In-Reply-To: <73d6250a90707649cc010731aedc27f946d722ed.1678962352.git.baolin.wang@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 209F12001B X-Stat-Signature: 13wsjfwu1gxwxw6md9rdmzx8rema57b8 X-HE-Tag: 1678968755-912679 X-HE-Meta: U2FsdGVkX18ZBYTzpvzc9WRwtYZkK4MerDNTZL0qiqQBKLheD/o1tbTherpLQiZpXDa6SBJbJMxCwMsKlf758QBNTm7rE9gup9piOfoCIJAYEdvVXTuEfC7dHADZb/q9xayJGvCedJ4ekxLvp450Nno2x+/i3D6tpVkK4RxL4d3l4ruLs35UcqyOIqq5iKFr9JrAyLYo7pHmTkmlZEsMxzwMPfRFYuCD/b9IU2YdFNqjj3VSfxh9hTh7CZuFW+qEZXo+GgVS3cixoPgRyLOGvXNRz52uxCXqV6xy2bQ8VhPK0PoEUGimIEHSBET6jZOdrnb/JLooxOE4aJGjMFR/rfv1pqae1n4O5gJ0lN7QiG6jgjUdz8nHS55llepkjqXAlcMqKhn0s9J06HRlkm61sa6emKqaSU2kW6yzd7P4ZGn3KSkrGJoetS+CohN7Gi8J2YJadSWFDU60MOtDnKzxo4fpubEZA/Y3vdLTcYH1j2uaRhND4XmrfIemkSiahUrKqctuNvvWpTXvxuMG5rMFIBwjISaCec2Ru0YVo+i/URzEZUyiXPKd6AqWoBeXqlGo1yjqpEK6sLxMXHK2qIffYO1T3ggGl3/qYalH2IVLllVTAw9BPNCAW6R+6AkZxv4TxvLB4BIqXpRQo7mvHaXiBo4EPRnDl5nf9BE1x0FqBBN15HzaldIeGiHx42p4f01JTqphCuFp6HrwD8nwYPHRUZAaSIz4zWBzUXl0bhmM7Yy05ITfYwVDdiTo8UFn2w9CADxsbf6sf94az2lusG5eqiSVCX3esj9N3SmC9jpeiXC1AwxgLRu6DSBOR8tTnGZOB7IAfnBVl+ZwcFoAPh1ZZzUiP96VW4P48DDEerG1YKjECYWRZXX1TNW3BBxuQFO2VH6f+n9zz1XrtTU7vXtM2our2PuemjWGf/2IT7HtUwU3N+OPUY+RwmiUgiCdIaauuE+mXSIdFN0o2aWmm9i cEioot1z nHgWsP2SB6RoZNKtziTvgE6jYi5C1mii83/nI8do4Gi6B9elLxKBMt2o1F1K9bw+4lempBbA20xg/88dOFiiHw5MSOs9NouGldTvb3TfocRAQJswyBhN++qv1PhyzYkK0BoAZ87itIiUkDnfMsperLzcbRx94bhKQaaOJz/T4NdYCQOOc45Vm2xqB/FIIqWsjUY5mgLlclXATrlDLMYKXm/aVkg+tM3EBUWuCv/0shcWolcDRnB0pV29nK/SwdzJaT8cE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/16/23 12:06, Baolin Wang wrote: > The commit b717d6b93b54 ("mm: compaction: include compound page count > for scanning in pageblock isolation") had added compound page statistics > for scanning in pageblock isolation, to make sure the number of scanned > pages are always larger than the number of isolated pages when isolating > mirgratable or free pageblock. > > However, when failed to isolate the pages when scanning the mirgratable or > free pageblock, the isolation failure path did not consider the scanning > statistics of the compound pages, which can show the incorrect number of > scanned pages in tracepoints or the vmstats to make people confusing about > the page scanning pressure in memory compaction. > > Thus we should take into account the number of scanning pages when failed > to isolate the compound pages to make the statistics accurate. > > Signed-off-by: Baolin Wang Reviewed-by: Vlastimil Babka Thanks!