From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D71DD44148 for ; Tue, 19 Nov 2024 12:06:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD18A6B009B; Tue, 19 Nov 2024 07:06:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A82076B009E; Tue, 19 Nov 2024 07:06:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94A426B009F; Tue, 19 Nov 2024 07:06:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 757456B009B for ; Tue, 19 Nov 2024 07:06:23 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BF69B1203B8 for ; Tue, 19 Nov 2024 12:06:22 +0000 (UTC) X-FDA: 82802715534.24.C168457 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf16.hostedemail.com (Postfix) with ESMTP id 9E996180010 for ; Tue, 19 Nov 2024 12:05:30 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mdx8KX48; spf=pass (imf16.hostedemail.com: domain of abdiel.janulgue@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=abdiel.janulgue@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732017920; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BjIx5HKi9rJGLa+D+fv71k/Tg4v7mgWDmWtmLnRcJog=; b=8dErgDmexUSGeGxianjUcz/Kkp5w245UEaeAgUh80IO83QveIZjy6vPxsN+Vd5yiDHYm+D qKp7X6ET7OomMU+yjQABpSvO8LqJ2p5C1JSFqrTE3pWi6rtqcFA8yqiXPpPvzXRrNukKTX Y6Yr4whsiIh/wvc4jQ6HShaMzetZzjo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732017920; a=rsa-sha256; cv=none; b=KAsKmk3Obrr05PrFMA8a5xFwIoFqwvHVLjTtH+IQKBLBH+vH1Rmic+nyPk/sDzcVHYLCzv vtQyF3ZGsAwaO9GZvJyp8N80J8ks+JIBQSZjv3eO9c97QTf2fWMvHy+pSNk++l0fgTjiCD a/6gjXSo25gJtrVwawJCpWSxV/S6iyU= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mdx8KX48; spf=pass (imf16.hostedemail.com: domain of abdiel.janulgue@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=abdiel.janulgue@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-53d9ff8ef3aso1014033e87.1 for ; Tue, 19 Nov 2024 04:06:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732017979; x=1732622779; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BjIx5HKi9rJGLa+D+fv71k/Tg4v7mgWDmWtmLnRcJog=; b=mdx8KX48spPNhotutepkmZtkibchFzgNdjM6IKWbb31EY8Kt11a4kLr0ysMj+/UMic uyxRnS9tVDQsMft4VZ2aOH9zu+s0iJPajq1XVAKTEDzk/3pWJJADJQQ9LGfOuSpsKFIa 7DNbs9TROW54sjKX96db/UelLG8/70q//6VyOqEzOdHN7fz8qyceWHXD0RZ5CVC/htor F0bU/pqosf/sv6vL7rOGl8znjCza/qPLl65hntU/1D4GhjqfGrwhNgzdUfZ4dskAdUIj 5+ImjAv6au5951FG6Vosu/DTCPIyowWy6lmRYeeRjHyPN4FlUNhCKnX2v+ZdJPZJepAL xKfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732017979; x=1732622779; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BjIx5HKi9rJGLa+D+fv71k/Tg4v7mgWDmWtmLnRcJog=; b=Nl0H/HnbZsxSeo9l7lA50ySVX//8AfVBvtQLkF5Dp6bg6rAJ+1WEefQRqTq5QvkblF TRXlrW75MB3FkMLykH7Z8oHJfInLDdNVr+Xqiv4zPI/7oy+ehvMdw/RUwU96hu8mJdkt MNAzKCLJNVR7nKyymYKq6c4C3gG37fN/L9/Kq7RZw4idBndITz0dS2B/0Ot7UlUXa2tu 0zEYdz4SXRh+elHmo1IMT2kNQgh94F+q8mQvdWSjGK7XgFbCbvIRL0RwKPqpFY3uZQWm LI6X2F0mwxMcydVvovfBWNUF9wxokZcZP2Mdgvtu+dM4lly33ZZI5taIFenz1Zv/DCm9 /qfw== X-Forwarded-Encrypted: i=1; AJvYcCXCOo8r26XXA92u4vnz6B3XbtYSvecL4h/EfqGXUmGoyUJ8xK423sRfHkGvOI9oq++UI/7piX2eEg==@kvack.org X-Gm-Message-State: AOJu0YzH99gqtfBVPLInhMo8epe3zYXRvwnJoQF+HrpcxEmiy0p0AJqZ q7HVS8zFWg4DoWzh1N4K9xfSVVQTIX4c4y1B62HAgvKfVtPCxlyy X-Google-Smtp-Source: AGHT+IFx97sth5FGl9bUbO/5Yx1nzjCRvFo9L4FIoCSP5ds7MrGV+Z4Pt2t9WZBfMPASYCZFsr8g5A== X-Received: by 2002:a19:6a17:0:b0:53d:bc66:b371 with SMTP id 2adb3069b0e04-53dbc66bb44mr1972160e87.17.1732017978715; Tue, 19 Nov 2024 04:06:18 -0800 (PST) Received: from [192.168.1.146] (87-94-132-183.rev.dnainternet.fi. [87.94.132.183]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53dbd4723ffsm282180e87.193.2024.11.19.04.06.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Nov 2024 04:06:17 -0800 (PST) Message-ID: <3c546153-5677-41e6-9bbe-dbf64de751da@gmail.com> Date: Tue, 19 Nov 2024 14:06:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] rust: page: use the page's reference count to decide when to free the allocation To: Alice Ryhl Cc: rust-for-linux@vger.kernel.org, Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , Wedson Almeida Filho , Valentin Obst , open list , Andrew Morton , "open list:MEMORY MANAGEMENT" , airlied@redhat.com References: <20241119112408.779243-1-abdiel.janulgue@gmail.com> <20241119112408.779243-2-abdiel.janulgue@gmail.com> Content-Language: en-US From: Abdiel Janulgue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: tqk94nogwwpma5ud4t564otm974qfx77 X-Rspam-User: X-Rspamd-Queue-Id: 9E996180010 X-Rspamd-Server: rspam02 X-HE-Tag: 1732017930-186932 X-HE-Meta: U2FsdGVkX19+0m+ZZ+BubghwYXIcQgBq1CEh4MbNeTz7LeyXTUl3FmEWBrG7eOWzGqYQSQQjw/ooO+m9KsZGQ1OvXbmGB+KWS/0tNSNmGZ8Y0CG0m0aC+uRmJoEcTVp8SrZqnJOuiBuw1CRIfCQW1ky65sKGUxAbrRLrnfh0VVDVQSD+eHybpN0J5k9DlKW7ww2wzOSrHRFwoZX1RCcbOSssV4yqIsnLe98VPViOn9UhwWUQENkvvohMNZHoYJXJdNwBtcXyY65Y0K6M/taOys8tFpIigrkVK+dlTLvcRwxAIvyVah27S1H/qcqGypWuUyV/5nVLv3bWozsjFWyqIJLpm2GICRUiOQtLi/Of6gPJDdlx1XZMHccdhpzUyoGtkmS5nfMSKyLLU+G9aLOJU12d46p2rmdSvJLYj2YRG03zzTs3VDBjufzYK7+n0hwSTU0BIGy0F5515ir78xHuO+AGbMfqAacDU+qKyDFO03Vi9ihzLW4Y3YYIjCoRPq+Mr5NBGf+CJf8nhEHDutUBbA8zMTHgIGrGZzICuFNSow5/oaqd0UdDx+WCzlDup58/Ne4rXspVxFuAioiB1X40ZIKqPuYXGcpgp340XK6xH7aRa3BrWrN1wXTzYWcpF437gw7PwophskPq4spbAkMCYslofqxMOEdzV3Q3PRUv6vmtHsaa1k6kYAMnszFtKHRBmIywNbWLnAvQZCnNAF9Ex6UuuiAJeqXZsDhTVP1bNE8VAN9PsQuFouzspW7/w3MT9MLYhd5mou7zCPm1tEzHWkwOfJ/CezjEeS/GrsO5TVzwe/H9CDAK1MtVBVgoN82CE608PZkwbn0QNr83syUxwclmJNRwGff1MNHg1QDxTBdx0KzcO7rhNS+4eEIHKbjnI17bMlUDlnkjvABNGrmvKUWDmB30Sxov32YdJR3wEr/aKZbkOsvY7L6n5PXdqfMBgiQijBxiMByG52K10s2 Muc7j1ZK p2aCOTC/NzoY66FlLGdBjkpLrZ7O/tDkFynfLuNVJqIsXU7OlOH2Rw/3LD0d+GpJuy8vjQXaPp+FVFQqkVW0o6JmdLNwg21PToLI4nJhLo9DlfBqZQrA6lcwbI5hcB+9rxhEvza5frofTz+GTd2ho8etRlnhgqeWku8ZqQgcuD1Mnh2Qrre8skf63ZCLMFqRDx96GJXxShBwwEOxMMtGE9QL6JiPEfb8W41EktV5iYkk2jHP8xfYmMIG6SbErgKfCQttszHCX9vkQ/R6LwMNk+EN3jZYlXQWYQvG/8MHHidV17QjY8kiYtqs8sTt13cDsU+r7zB540g4lbj8+RZByIwsxSFwhRckXfSDDc5mI0UU9HELkhSvQAg07jXfRpKLIBgmAzXFzVAZVh0ngkMggndSQIusR8VDSzmX0FluUu6fsDXh5hHOOqsc9ssV23dOWxgwRqJR0U9HX514+ll5/CaFGhLE3qljSIpgAmfXvoQe9IyWkWAG5lQwf++ClMBpbRmCTQUwDP6+15TWOe8dGqWZ6vnGUTilpbeow X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 19/11/2024 13:45, Alice Ryhl wrote: >> + pub fn alloc_page(flags: Flags) -> Result, AllocError> { >> // SAFETY: Depending on the value of `gfp_flags`, this call may sleep. Other than that, it >> // is always safe to call this method. >> let page = unsafe { bindings::alloc_pages(flags.as_raw(), 0) }; >> - let page = NonNull::new(page).ok_or(AllocError)?; >> - // INVARIANT: We just successfully allocated a page, so we now have ownership of the newly >> - // allocated page. We transfer that ownership to the new `Page` object. >> - Ok(Self { page }) >> + if page.is_null() { >> + return Err(AllocError); >> + } >> + // CAST: Self` is a `repr(transparent)` wrapper around `bindings::page`. >> + let ptr = page.cast::(); >> + // INVARIANT: We just successfully allocated a page, ptr points to the new `Page` object. >> + // SAFETY: According to invariant above ptr is valid. >> + Ok(unsafe { ARef::from_raw(NonNull::new_unchecked(ptr)) }) > > Why did you change the null check? You should be able to avoid > changing anything but the last line. Changing only the line, it complains: 86 | Ok(unsafe { ARef::from_raw(page) }) | -------------- ^^^^ expected `NonNull`, found `NonNull` Unless this is what you mean? let page = unsafe { bindings::alloc_pages(flags.as_raw(), 0) }; let page = page.cast::(); let page = NonNull::new(page).ok_or(AllocError)?; Ok(unsafe { ARef::from_raw(page) }) But what if alloc_pages returns null in the place? Would that be a valid cast still? Regards, Abdiel