From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A05FAC5AD49 for ; Wed, 28 May 2025 10:49:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2030A6B0082; Wed, 28 May 2025 06:49:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B23D6B0083; Wed, 28 May 2025 06:49:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07C326B0088; Wed, 28 May 2025 06:49:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DD85B6B0082 for ; Wed, 28 May 2025 06:49:06 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 930371D3288 for ; Wed, 28 May 2025 10:49:06 +0000 (UTC) X-FDA: 83491994292.05.3E5DDAF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 33B70120003 for ; Wed, 28 May 2025 10:49:04 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hgKji96V; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748429344; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L9zdNnDwAfNYHub/SLO4R5U1ZnoXRuT66VkqLwVbfTw=; b=DJyz1iO1bcggrqQI/uO/QOLYrMGAAXhYpC4ulfJMxWjcY6Ic4pxDKO/+yVoq+s3ILajOCv AJV/ALpJQWgMMtHiqZUn1rE07F5IG4Fdwb4Zcw7jHT9z5SxfOyEU0Aj/nTRRNUhFh/hW/Z 0Cwg7jGdcebzc6qcvY46NRmnwDr2r1A= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hgKji96V; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748429344; a=rsa-sha256; cv=none; b=W70k4JZDGRgiUoI18T8TET689KqgA5E0b9yE3Zhvmrl1OtVp/rYhJbA+NXyV/CjBJskrlh oa8h0TAFb9XrVZihjbgGH/UsWzDxzZGlHd3Gr9bqNhS26ZHwSYOTpbfc/AS0Tj7lZHsVwf BgRubpBR/FYpa0Z/XodFmDDMTodPAEU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748429343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=L9zdNnDwAfNYHub/SLO4R5U1ZnoXRuT66VkqLwVbfTw=; b=hgKji96VZdmfvDLLpIdIWs8ueDqTPq1ES5pQ/dyMnz3hGMF3lkxRpHPf7APSuWvk6aJow+ aQE7bgOTDqkkDWQDIhRVXYDQIR5tnze/0HjwQ8E4KyGJOhcg31NjR0fosuwPRYnJc1ps2P TYKJcGCaM62k8Iahqs/OposwleYgsos= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-507-4btQy_GPOcmBFOkTwQBmhA-1; Wed, 28 May 2025 06:49:02 -0400 X-MC-Unique: 4btQy_GPOcmBFOkTwQBmhA-1 X-Mimecast-MFC-AGG-ID: 4btQy_GPOcmBFOkTwQBmhA_1748429341 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43d4d15058dso32468895e9.0 for ; Wed, 28 May 2025 03:49:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748429341; x=1749034141; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=L9zdNnDwAfNYHub/SLO4R5U1ZnoXRuT66VkqLwVbfTw=; b=OzCF2auzmUZH9qA2iOXMSq1srrtBcP+Tz3/NcKkA8Plqr8bV6JxnSK+IAI5frG7h/t gWCS8Uj/Dicj6JyaaddzfabWT39Ht+x0Ru3YrlY6TNAkGHayBmhwMo07YjhH1wsoD8hP 09eXGMekxfTWcJUaRJBQ+5TYJLNckPo4U9NV0oR2AFlhMH9XQOgNmk4hXLCNCWoQ/Yzn 53I3Hfd0SD0Zn8gTZoR439WAZwf2kHeGa2tWYb10/nasb8Urx5lJpmXnNdCS8ScWwB1N gM0lT2yQrpUrHHNTWZ2YYCrLQKiwWMKomZPMQ4WmWiTM8MsQi57XxiGCvVf+2FKP9sN0 SpVA== X-Gm-Message-State: AOJu0YzTh2McvRlgIamP+Xg9hQtJAFL98SIaKKGVqUzLuGh8g+T+ouuh wNqOpF0loLwkLdvWZJLMwv/3jG8Kvwb/a5K8Dq46BmhXPXD6LZFz0pEJ9A/j5du0nJAZpABZcPD ah6TtJ8KY09S0ZKGYi3brBY/bUbet8qWiXgPXDmu4rp8+x0gLAF4Z X-Gm-Gg: ASbGncu/sU0J6jXTp8EG7QMht2WMaVb3WOweIPehE59yX7ByeKqutsI15VgoGA4CkOB ul/LwM+RvZyt1oX/7Q+B8o5jRvXOJPMO/ROmrqS5MKcsQQDp3fvGoRx7fiFzXH8aDq/oPs8GaRg cQA+GL1I76XOrxzNzdPoZu13IEF025wBeCIluUE2HYyHy2P/rIKhLEkStmKZNnahdM7J8Av+v26 CC43teFlTmVnnoy9iZWpZ709/7VYysDypaQ8LXI1mT10BJdTs1zmA4sKvB4p9uE4qPc+uPx49EQ h4Cx9FcMv6/qQ8X7yelTfA53ZbP1FI3h10h6sWBxZaKYxVY2LeFxa9dgJeFfAO5JPsy48cjWR/q bfY5GGX1y2KSUsy+VDNntjW+ZTj/einPYivavdzQ= X-Received: by 2002:a05:600c:648a:b0:43e:a7c9:8d2b with SMTP id 5b1f17b1804b1-44c92f21e1fmr127213085e9.24.1748429340967; Wed, 28 May 2025 03:49:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHhLT5tb7zUh11ADM14vMwzRiC9TD0IByrsLMVhGQOhNMyEK6r+6gLgjV47NeCbATlZyERZlA== X-Received: by 2002:a05:600c:648a:b0:43e:a7c9:8d2b with SMTP id 5b1f17b1804b1-44c92f21e1fmr127212825e9.24.1748429340531; Wed, 28 May 2025 03:49:00 -0700 (PDT) Received: from ?IPV6:2003:d8:2f30:ec00:8f7e:58a4:ebf0:6a36? (p200300d82f30ec008f7e58a4ebf06a36.dip0.t-ipconnect.de. [2003:d8:2f30:ec00:8f7e:58a4:ebf0:6a36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450725403c6sm14119995e9.3.2025.05.28.03.48.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 May 2025 03:49:00 -0700 (PDT) Message-ID: <3c15a093-7c19-4c2a-a571-56a5ed4b445f@redhat.com> Date: Wed, 28 May 2025 12:48:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] selftests/mm: add simple VM_PFNMAP tests based on mmap'ing /dev/mem From: David Hildenbrand To: Ryan Roberts , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Andrew Morton , Shuah Khan , Lorenzo Stoakes , Ingo Molnar , Peter Xu , Dev Jain , Aishwarya TCV References: <20250509153033.952746-1-david@redhat.com> <232960c2-81db-47ca-a337-38c4bce5f997@arm.com> <7cb7f23a-ce9e-4664-8083-deb73ed23da3@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <7cb7f23a-ce9e-4664-8083-deb73ed23da3@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: d6Wm26UEjHtm0c3114VUiyXrOv-H9sXz2fX4CFoGibg_1748429341 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: oifcwc4brrbgwcw357jk14e4gbjm51dm X-Rspamd-Queue-Id: 33B70120003 X-Rspamd-Server: rspam11 X-HE-Tag: 1748429344-496955 X-HE-Meta: U2FsdGVkX1+CGtKfnbvK+Vlg+rgwMtcfeJIPJ4jbqi3ptDy0/Ol+2mQSeqTdK52kZSa3GC9YeiiXho1dESSjqt0FA4p+dJ6x1EVipQPlZQbdBttRQhlbqzX88au2KFONeeK52VFuiZqydZrgzbuuXKP5+UABP99btr5kc6zRFx5Sxko9Iym7gAZd9YPtcbxw02l8O9KZJlwyEGu8XdRk4GOd8MS5QLERDj3m+qxtF5zTynuUGk2g2oR8jCTWPxRiOySfG81z73bopMG16kzdza3bC2p9i6/oAY9emH1NCH9W/SHJ8MmbKkxrAvZduUz75zDhxMt+vQo6Sp+Dy0jxLpRrthylvuuOuDdgPNMatbmjpOtOTEUkIQBQ06Kf3YfRST4Psp1PuFVEWWFfWqD5I19BPlX9/W0ZwJoEVNDRq7MjVSvbIWKFfONuVtTNl1dctRPVC3dJhPkREZ1TvaNM2zTULF5xrRaH0y+SZn61rqG82AFFUdcyYu+S0t7Fvlj5QmbF28ZjPiIGJtpVCYX0jwDzT6FEqlaN8eJZVdmpgKD8noveCfrhChXChqmREln0iz1Lj+pgZtaqo6PoiWqUbkYaODUCNXJhY8oJ8dPNMJGgYFRF8S4osKOcif/GIroOqost2ye8hy7yZiJAGw9awhfKWVY86UJHZ7w5mW/+yOc5Ybo0fY+bcTWjDLCs0ZN4YBm64t1ZMxhbgwKWL52QIcT7f2FXHDG2IVZSiwUylwIppxpkkhCLIoX7hiyeRS5enIziwSc5nWUtiVwxcL5okf9UsLiQSB8ixRP7cfpoLVwu8aanG1WRALff4QLjM8XDGYSScmntfoe7gJa15/8a2oqM1PcA1SozC+781rVfM0aYeiHyOu4MUt+FIeOKMPuMRaGE5j9UJixYMbI8av9EvenImtffqepWar+RO4ydz3Tg3KKwGtQ/ly/WqFXxZArPcg7ExCJfC36H2LR4B5G nzCRdZVT rzIsrFxLSZ2s338hhPorql4PcHq9WDKKrRmHLakGllHdK5yKJssrmD2PYN5iUAYZuFn25NH+cFewmoc0NFj/Et8Sdfll8ooGxxQQBvuTQCE/YCy77sABzcRnjj3rYp10H3WV1Dh6fKnapEovIJK+/caJPpFF4zZwjHJTgDtSFkJ1CDNZYPCeNsq0cUXNzkJwkCf7A9tIJ4aKVeyEHNZa0ZnNOxgS6Y9uT5aTp0THos7YxiNaQACEEtlCNnB8EU2QhNORIF/HHrtHTnfzukjrEhKif4S9OP3rq42E+MjvRu/yu5k0fSTajpgN5tuJl/i1B1xby6kLbpDF17tqW8HeTnMOoH29bTsOxU55yXDMMgH7vVXLIBy2oecfHAIwx10wJ2GaXIosAtAWRq0GOeUExg61x7xSkoGddSPpj6DQ2H2zLGHkEUkYQomxCqlGR8N86sYOyZTofKmx4thM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28.05.25 12:44, David Hildenbrand wrote: > On 28.05.25 12:34, Ryan Roberts wrote: >> Hi David, >> >> >> On 09/05/2025 16:30, David Hildenbrand wrote: >>> Let's test some basic functionality using /dev/mem. These tests will >>> implicitly cover some PAT (Page Attribute Handling) handling on x86. >>> >>> These tests will only run when /dev/mem access to the first two pages >>> in physical address space is possible and allowed; otherwise, the tests >>> are skipped. >> >> We are seeing really horrible RAS errors with this test when run on arm64 tx2 >> machine. Based solely on reviewing the code, I think the problem is that tx2 >> doesn't have anything at phys address 0, so test_read_access() is trying to put >> trasactions out to a bad address on the bus. >> >> tx2 /proc/iomem: >> >> $ sudo cat /proc/iomem >> 30000000-37ffffff : PCI ECAM >> 38000000-3fffffff : PCI ECAM >> 40000000-5fffffff : PCI Bus 0000:00 >> ... >> >> Whereas my x86 box has some reserved memory: >> >> $ sudo cat /proc/iomem >> 00000000-00000fff : Reserved >> 00001000-0003dfff : System RAM >> ... >> > > A quick fix would be to make this test specific to x86 (the only one I > tested on). We should always have the lower two pages IIRC (BIOS stuff etc). > >> I think perhaps the only safe way to handle this is to parse /proc/iomem for a >> region of "System RAM" that is at least 2 pages then use that for your read >> tests. This would also solve the hypothetical issue of reading something that >> has read size effects. > > That sounds also plausible yes. I somehow remembered that mmap() would > fail if "there is nothing". Ah, my memory comes back, we perform checks only with CONFIG_STRICT_DEVMEM. -- Cheers, David / dhildenb