From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F544CD379F for ; Fri, 15 Sep 2023 19:35:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79BD06B03D1; Fri, 15 Sep 2023 15:35:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 74BBC6B03D3; Fri, 15 Sep 2023 15:35:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 613A46B03D6; Fri, 15 Sep 2023 15:35:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4DD1F6B03D1 for ; Fri, 15 Sep 2023 15:35:32 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1A3DA805C7 for ; Fri, 15 Sep 2023 19:35:32 +0000 (UTC) X-FDA: 81239836104.17.FC9A42D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id E6B6C20028 for ; Fri, 15 Sep 2023 19:35:29 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=F69OuaES; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of sebott@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=sebott@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694806530; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VeIdPGG8l+x3wBCIWqTbDHuqw6QPB0z5N78RMkJy1sE=; b=lvr6RXdx5rvWQ6Wl6+qXyztffWT1hYBzBtp5bhExD7sarA4ZJ7JhbWNfqkkjmW3FfXO/7D FewtXvVC3Phy+ihlKPSsRUwCbfHsZiBZ8LiAFd1leEG8TZV8mvSt1sNHhoeX9F0plr8NZV Xq7yR9qrU8/Jb9/ldF/KLkSuU2AJyU4= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=F69OuaES; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of sebott@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=sebott@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694806530; a=rsa-sha256; cv=none; b=Ay0sIDvQFuo5saAVmlNJKs/sjTjx7ESkYBlSsDO1rx1uKulGlPlvwBJtZxCkC/rMllbJ7n qno8jjV2BPCisSDXTNPiWw/m83eKblttraCKMpac9JqRAlJ0/vdMLltvikhA6guHmR2SYp /kU6ysirF68beLUO2i3d22MoP09WI9w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694806529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VeIdPGG8l+x3wBCIWqTbDHuqw6QPB0z5N78RMkJy1sE=; b=F69OuaESAsGOxmqmgfKcjoCLGWWA7tPQE7QYjGfEZVldmjw85nQbbYwvd3HXTNp/K1U+ZW Zd6VNTJeCdXd9N09xIZ34MARDaawipBYq5RwSO3uV8ZfS6ANKr4SXitAv203Evr6RvrxTd 4B15XJzPTZK5f7bT+5t2JLXovDKZbhI= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-383-fpfjvcraN-W8befVaYqXjA-1; Fri, 15 Sep 2023 15:35:25 -0400 X-MC-Unique: fpfjvcraN-W8befVaYqXjA-1 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-414d7fb4859so26980341cf.1 for ; Fri, 15 Sep 2023 12:35:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694806525; x=1695411325; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HVf1V3CzDZ5lP3pmoo5CaMEBLPRoiU7cCml7ReFuTR0=; b=nuZ2AhILxP52rcrAen6KD2fvncgF0BQ0xTL+6hdSkuG4mHu2hswmjhbgDGkqUNVBDS UPB9NQUaSKr9ayPElKN7pQccah2M6bLdwmdxr8U618hZJQruCuyNs7E2x8e5RZu3UUsG eKeDglwGzdErcin0BQwm0Y3hgi/wFgBayoOGKHga8INkt27t0ryBJ4+GYLOn/qu17pLU 9Jz91UvU1Uv2CAIAp0CNwmUNhk7ls09tkl0DQx6kRq15mY35q8F712/o4qGjluiBdacV vZta5quzOswx0fpF+mB+/vGimqGgIBP4Qv9QiBtICiGHUse8xgmkdd67EudEqU1sCQR7 lgbQ== X-Gm-Message-State: AOJu0YzpNYsWPtIRCpNy3yhd84lvOb4XA6EmJsVjLWYp63712khSOcZS qfbls7Six/xEoq1DGBOGq2ntu39BTfRE922llb64bytVuy09oZilNHd/ubeSqF4gtwmn+5qVvRf R2yJIbCQyqR4= X-Received: by 2002:ac8:5bd0:0:b0:412:1e4c:e858 with SMTP id b16-20020ac85bd0000000b004121e4ce858mr2872794qtb.36.1694806525099; Fri, 15 Sep 2023 12:35:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFhY+zLilO9nIc2jJlB/O2T5ucpf0omBdswrGZrkcwBBrWmTQQAm72M/bgntZ+AUyYEISgoqw== X-Received: by 2002:ac8:5bd0:0:b0:412:1e4c:e858 with SMTP id b16-20020ac85bd0000000b004121e4ce858mr2872776qtb.36.1694806524860; Fri, 15 Sep 2023 12:35:24 -0700 (PDT) Received: from rh (p200300c93f1ec600a890fb4d684902d4.dip0.t-ipconnect.de. [2003:c9:3f1e:c600:a890:fb4d:6849:2d4]) by smtp.gmail.com with ESMTPSA id h5-20020ac87765000000b0041514d1da65sm1349819qtu.20.2023.09.15.12.35.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 12:35:24 -0700 (PDT) Date: Fri, 15 Sep 2023 21:35:20 +0200 (CEST) From: Sebastian Ott To: =?ISO-8859-15?Q?Thomas_Wei=DFschuh?= cc: Alexander Viro , Christian Brauner , Eric Biederman , Kees Cook , Mark Brown , Willy Tarreau , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH RFC] binfmt_elf: fully allocate bss pages In-Reply-To: <20230914-bss-alloc-v1-1-78de67d2c6dd@weissschuh.net> Message-ID: <3c0f1acf-b95b-3570-bf51-7716b6209f16@redhat.com> References: <20230914-bss-alloc-v1-1-78de67d2c6dd@weissschuh.net> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="-1463795790-230173133-1694806524=:4151" X-Rspamd-Queue-Id: E6B6C20028 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: dwffq454w5bs4npycy48p711u7j3r7o7 X-HE-Tag: 1694806529-703274 X-HE-Meta: U2FsdGVkX1+vUQEfjagicEOH/6dec6wTRjdgnpPoCvzLS6342VmMmrWihgdmKUPAhwAI9MtTfqkrSn9s2+97OwYHthED2itXTaZRHRTO35i1e9zec1tJ8Bu4Tyk+/JFPPBa4KTYvbFwAWf70YWRniwUSMYDzn4lj7MH/pDXopsGjm76MLgoRLOyJErUyRCdboHdq6us8KqRCIdG4Nei9oW+rv3oFLoLwnYEgr04twVmwyYS+Nhev/5a1NHAwYUR8oRHxPQFm1lYzbDL4vNEkfiHwGa4vUnOOhDViMLwxZrHuZAaF+5ItT/a6O/+Z5224iBnZInVw744JRQmYf9oo8KJKDtHIh0W9OqN4qXEruxohVJGzpzxrenxrtllHDxGBre5XvTUDltmoQz6skxqAf4l1+j72OMKGrAt2gsFdRz0LMGQoQgTEzZ1aovOc6fshwV3aTDXDxspVRDRxU4xMocSpF/unieG2QRXILWme4EnqHQUWFeah7HV/Yuy4XkQ/TbZcOtTbRv8LzpdfxkqC4Sam+h0hHYeggLV4lke6Bm/756cBtXJqcmbny3APedpWNSpkFep77uN/GiBTYNvzdSkAS5807JGKpH3aGrxhPIADX7cMJHCjLf6Hv3IC/xL2Uc0yQ0SXsyQn2XbDVP+C/y275qEw1j/GR/mqBkoJv5AcQqT7NNd3d3xofgGLmq+4+8d9Q/h9QBArO1sZHENFNoJcwysTL1HQAJtQif7km4KKfXjge2XThByvd4WDIwd4tNv9yT5UGWul49Kbe4YX0ajag90z+wl/yZSAGjo2r+4QuuYAkp61Ubhmaz5JzPj7hAyr/41oaitw7gpAdH2NSxHQu9J3+X1uAHrZBtfUJC4zaWEUA3miPRm4Cznp4N99pP/uu5JfzXMaxpr/Fay8JIV4o02bAMuIi42ySDXR6TQfZf6Cv1KCxWgY8mfXTK++7Qhg34NSKneFtVdwyxr TOlU3fh3 SW+VAZZ8vsBMASjLbfafAgo4LOFZH1POPzrxpvs0jg944qhtcSdRcL2OO4BhUK0a+sv4Wo0JNPbfTFOHkzRDOPR5D6rmv7LbpF4N+RGb5e+1lE3rDqRPaWVoDjUVWEB1+ZNdQ5PRE5g5MgtTFw3TLOKcJNT2H2k7jd8U4JJ1QWHF8vDMy1K5By6z/F0vjtn4OqE5VQn6lDsiCETYpsnxGTx6cLmcA1DZxhiOp2G+G/Gu5K/mx3STK68pHk4SliCiENM13ig2y/2UA67helZUh5WRAz4GaoF563q6x1dQ+O49itl346k9/1C3oWAudosxoJZOILoj7Zbi7veXxO9gr0v5gDMGuQXnNh63mV5Lq96D2kXPXPofrwhqjt60TvkhVw+Y/fzatkx9uz05KIyFn8CauQYv2cWDxfqGKTE5AS8FtR9fs4jn0iI/kuaXaG/iS1KSL+gBsu9gos+XMVrV4aYcHdA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463795790-230173133-1694806524=:4151 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT Hej Thomas, On Thu, 14 Sep 2023, Thomas Weißschuh wrote: > fs/binfmt_elf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c > index 7b3d2d491407..4008a57d388b 100644 > --- a/fs/binfmt_elf.c > +++ b/fs/binfmt_elf.c > @@ -112,7 +112,7 @@ static struct linux_binfmt elf_format = { > > static int set_brk(unsigned long start, unsigned long end, int prot) > { > - start = ELF_PAGEALIGN(start); > + start = ELF_PAGESTART(start); > end = ELF_PAGEALIGN(end); > if (end > start) { > /* > My arm box failed to boot with that patch applied on top of 6.6-rc1 . There was nothing suspicious on the serial console it just hung somewhere in userspace initialization. Sadly there was also nothing in the system logs. 6.6-rc1 worked fine. Sebastian ---1463795790-230173133-1694806524=:4151--