From: Luiz Capitulino <luizcap@redhat.com>
To: Shivank Garg <shivankg@amd.com>, david@redhat.com, willy@infradead.org
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, lcapitulino@gmail.com
Subject: Re: [PATCH 2/3] proc: kpagecount: use snapshot_page()
Date: Wed, 2 Jul 2025 13:38:45 -0400 [thread overview]
Message-ID: <3c0eb35d-86e2-45ea-b933-32989c28963a@redhat.com> (raw)
In-Reply-To: <3ee3adfc-5efc-43dd-9c75-23564fade7b3@amd.com>
On 2025-07-02 02:25, Shivank Garg wrote:
>
>
> On 6/26/2025 11:46 PM, Luiz Capitulino wrote:
>> Currently, the call to folio_precise_page_mapcount() from kpage_read()
>> can race with a folio split. When the race happens we trigger a
>> VM_BUG_ON_FOLIO() in folio_entire_mapcount() (see splat below).
>>
>> This commit fixes this race by using snapshot_page() so that we
>> retreive the folio mapcount using a folio snapshot.
>
> s/retreive/retrieve/
> checkpatch.pl would have flagged this.
Thanks for pointing this out. I do run checkpatch.pl before sending patches,
I don't know how I missed this.
>
> Rest looks good to me.
>
> Thanks,
> Shivank
>
next prev parent reply other threads:[~2025-07-02 17:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 18:16 [PATCH 0/3] mm: introduce snapshot_page() Luiz Capitulino
2025-06-26 18:16 ` [PATCH 1/3] " Luiz Capitulino
2025-06-26 21:39 ` Andrew Morton
2025-06-26 21:42 ` Luiz Capitulino
2025-06-26 18:16 ` [PATCH 2/3] proc: kpagecount: use snapshot_page() Luiz Capitulino
2025-06-27 18:30 ` SeongJae Park
2025-07-01 18:36 ` David Hildenbrand
2025-07-02 6:25 ` Shivank Garg
2025-07-02 17:38 ` Luiz Capitulino [this message]
2025-06-26 18:16 ` [PATCH 3/3] fs: stable_page_flags(): " Luiz Capitulino
2025-07-01 18:44 ` David Hildenbrand
2025-07-02 17:36 ` Luiz Capitulino
2025-07-02 6:40 ` [PATCH 0/3] mm: introduce snapshot_page() Shivank Garg
2025-07-02 17:39 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c0eb35d-86e2-45ea-b933-32989c28963a@redhat.com \
--to=luizcap@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=lcapitulino@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shivankg@amd.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox