From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C85D2C282EC for ; Thu, 6 Mar 2025 13:25:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 57FB3280002; Thu, 6 Mar 2025 08:24:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 52E49280001; Thu, 6 Mar 2025 08:24:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F6E1280002; Thu, 6 Mar 2025 08:24:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2317B280001 for ; Thu, 6 Mar 2025 08:24:58 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 635041415BE for ; Thu, 6 Mar 2025 13:25:00 +0000 (UTC) X-FDA: 83191196760.21.7B6FD06 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id EDD6C20014 for ; Thu, 6 Mar 2025 13:24:57 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=N6p8caIj; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of jfalempe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=jfalempe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741267498; a=rsa-sha256; cv=none; b=RRALqwK2fnKROgFl2TPszWtX0DlsgW0+jbOr3tVbfmnBhSNgHcExJF0d9iz0+7nCEQdeuU clV+mJRc/VqmojXjZTzzt1cRUy54hL/LRDzW+1FBjZxugzwdg/kUfVfTTR/OHnazpSoPxv 9kuLio/SZKMcvYy4KCcucPfmxcEahFM= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=N6p8caIj; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of jfalempe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=jfalempe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741267498; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AMe2L544kp/d38WLjn3xMcZvhSWCOUekm7mNyssXwXc=; b=AgijGd9vODU2HaZ7fukBm3hphVAQ4trW0Hor2ypZTPj4tfjRaHTO7jZ6uYEn0xy173R5pg fmYdKFH5Dkg/hwt3svqEoCKj+DL5HV84kX/ay+/hwTnNlnYzoO2CXqA7Ox0/UJwej4jN7K 5J+JNInCLfk7OEDbDAQBudAAK5Jt0U0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741267497; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AMe2L544kp/d38WLjn3xMcZvhSWCOUekm7mNyssXwXc=; b=N6p8caIj4t4QJNjp7jBHyHuFGBFs9L7MX3V2MHPTkQqnQx//ov1Tk/VNZFgxWsHmEeCd51 fRAnayACNbhSDoDD9d4z6mBcfvFNZtS2WuuyK3V9ciaGz1ly52GEqnrnDNoQ8tl8fDRjtR s0xnOEc3Mbacy3xMSkOTCOmgHAH84mU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-662-B6dFrTqVM3S3QFxEpB09Vg-1; Thu, 06 Mar 2025 08:24:56 -0500 X-MC-Unique: B6dFrTqVM3S3QFxEpB09Vg-1 X-Mimecast-MFC-AGG-ID: B6dFrTqVM3S3QFxEpB09Vg_1741267495 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3912aab7a36so259399f8f.0 for ; Thu, 06 Mar 2025 05:24:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741267495; x=1741872295; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AMe2L544kp/d38WLjn3xMcZvhSWCOUekm7mNyssXwXc=; b=tZsfVZqNW7l1G+KAHt36SqrdBidTgR94CH2RNRBDosJ+BObP+OC4IVmJGlIS86S7ak XBgQ8yFVAUt/9scTrxjCLMw56MkgB15Tt39XP2XEnHYu4DH5gIwODeHH+SvGEbaIRw7c 0yUPEL+HcgWY4fKmR89XgaH2S9DyRGWncM466vcCnKbEie43ZzrCvwbbJHlLj0uAPKWy Knc+UnjYFg4ZxYAPU3Sh8kAEOcSRTAXS+YxAw3SbFNPcpSe++jq1wy+NSa6FGCcppWz5 Vyw9mdEIOzUtnxZV+TopwL7E1EXiWAnveni78DgxPzxgy7ZmvPdzyMt8GQLsnZwxXdUF Gc/g== X-Forwarded-Encrypted: i=1; AJvYcCXahipokz9Hw46eJsFSMdVr/E1oiF0y3eJZZuiKSlpxexHeXRxmlKr5c70wKEVi2IrIGUxoiM4ayw==@kvack.org X-Gm-Message-State: AOJu0YwNU3wDaDQOFywc5/MI1a1ZQOh4motJxFQNiTSOBQH5wk5iT+Ek 5e06aax1i7LsL4i3GEsSYDf620cv7nfj4ZrhtSYNk0urb6MsCH8udRHBxizBxE271ZA5Y+Fd3Hl UPzSrd5Rvc0lQpyLDU8V6MwHS20zApG4Nvcg9ymBRZtAfkC/M X-Gm-Gg: ASbGncubnIQ4DqVCOEXjfv4Munf7SuBYXDpUmW5ZMQ7SYT7f6skAVRbZhZowNtr/0Bq LVyORPuSERBf7Ltp9xF0vVcY+J4iLfFk9mhf49+aE5q2b7jK++huKo0r1qe2zPAUauovaqHDrkB rQIgRCq96fNMNXFvDh4T+XNry8q8DthIlB1JadXoaN/3xSbfcTJM4k3uSEzVJvlkVCwAAg088kD 7tUEJAFxz8YzZhTgOGbTa0ojQV71mxQEmm1cTBt4uW6ISnad6s0mA0cHGv7vUpLblUOBuKnSOug qirbg7Sudfofad0wf87jvaG6FKb4lWTgjHH/fzpoSCd47HtK4efELKU= X-Received: by 2002:a05:6000:42c7:b0:390:f9d0:5e4 with SMTP id ffacd0b85a97d-3911f741261mr5096862f8f.21.1741267494966; Thu, 06 Mar 2025 05:24:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IEIwqvoLsZ7nWE/oVtc7eKMKzGDa6NvX7GYnOgsSJBfK4lxmD7NxGmoi2sk4zoXn8lH+Jx7Gg== X-Received: by 2002:a05:6000:42c7:b0:390:f9d0:5e4 with SMTP id ffacd0b85a97d-3911f741261mr5096838f8f.21.1741267494530; Thu, 06 Mar 2025 05:24:54 -0800 (PST) Received: from ?IPV6:2a01:e0a:c:37e0:ced3:55bd:f454:e722? ([2a01:e0a:c:37e0:ced3:55bd:f454:e722]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3912bfdfdfdsm2117782f8f.34.2025.03.06.05.24.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Mar 2025 05:24:53 -0800 (PST) Message-ID: <3bfd4238-6954-41a3-a5a3-8515a3ac9dce@redhat.com> Date: Thu, 6 Mar 2025 14:24:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH drm-next 1/2] vmalloc: Add atomic_vmap To: Matthew Wilcox , Ryosuke Yasuoka Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, kraxel@redhat.com, gurchetansingh@chromium.org, olvaffe@gmail.com, akpm@linux-foundation.org, urezki@gmail.com, hch@infradead.org, dmitry.osipenko@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, linux-mm@kvack.org References: <20250305152555.318159-1-ryasuoka@redhat.com> <20250305152555.318159-2-ryasuoka@redhat.com> From: Jocelyn Falempe In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: UvgfkqAD2gnPqB_ki4J7w-tcp9eBppY-LLLbg_UxQnE_1741267495 X-Mimecast-Originator: redhat.com Content-Language: en-US, fr Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: EDD6C20014 X-Stat-Signature: 7q5z6m4199kajjpr3e97355ikwmm6q9g X-Rspam-User: X-HE-Tag: 1741267497-261026 X-HE-Meta: U2FsdGVkX18gjnxLU35BdWcJ5PdhKnPQuRfmQBpPG7SWAKqvm8GdpUUX9FuAV0j+4Braf2B9VoTZQJeAJqoBxsSTlPdOGpg0RtKODNVHH0cMpeVwkK8OweXk2q5c3tN4R6Fgejb30TdfUkYEffXbNw7Co8ZUSdUAQFtkB1dLapIc9RZPFqTmIpwP5ypRrtNnMiqk2ulWI3mn56ed1beBbAxx8seHrm/zyZ/LqaZyGAmPz9YQmvaUrO1cdx/eluH28IdFBK16j5cNCBQFXlpc/AkyA+v+5/kqLpqzuieTJ7IKRnCtwAAF6VHRD9ZSKK2q1J2syFGPovZI1whmR0aqc2vdcIRSh7URT3Y/8tu+QpTNEQ91WCiXjWHmOu1vHjPZV1NxkqB5STabtG1SuFHbrOuLG/5L+FuQ+sM6E6g+lBF48v1/Jh1HEb8lziX1F5dj/hvLw1nKCQ46UeA49U0RDkAtYgsXgJ7K4t1vbJtGHavNgUV96mQ0x9gNCMxDFbFKlL+2qRPGkT/sNrJJoQxd8to6cdn4vOpwsKFqCUF7xl2jU+eluVad+UMh98eNo/k8p62946Kp7Y+B9g2xZo+4dJOh4/KfAZ+nzsUzvS8DgD/NOEk9fbB8wdQs6M1xD5FGuoBbBIoO4m4YJcPHRALktUXLhbq8l82yETYE33kPgwicGix9RgcVNjo0w1k9/irpg9GWwZ/jg5zh90OZD7HAgO+rz08bIkFJ3uR46MucbN1DLc1ise/SfdB2u3dohRA9iNZ75ak6AE1ybNr/frNblGePGUUclGMIr52rvMlI7AYTncUi4Tlbi+T9IKCTRVaubcl9esD6F5ylOyNFvSKfY6imBtvbLoc6NP+5Or4ay2BKL+4z4uBjo7EhRRDn/gbgIx8mkRII56rlVi7+mS3yqDNI+WVBbWre4Tj7BLp8qgjA/G47w+LThtBEtcfVRZNCx9b+sl6dYwwwajjburF F0Ci/OQq 0Qrxw/uzoHgC90t5erGOm7pwG4OCgMBiTWf7I7Axs9fhsCX/dp+E6U3xws5o91ADfN0EbXKcsIEG8z4gU5R+WQRe45e/r5sfz+qXDD4YXWKcdQ0ef4SIDt7XUtjcD+OXu0pjQg1eO2UHaA9pliOOm2P9NsFCG0UrdDDHQsEeKf295JgbMhmJT9Pat4NwiK3ULirvL15YtDeWU93uRMCyGk7YuW4C24ljYrjtbWkEgpubsooGJZCboGUjaJA00uIGT9oJBG43UrhkGo4qJdoK+XjtuEFwHpRRZbbB0Ut7NduSEb7t9/4sVh3hT7OxvB0Sw3BnxnEMC9rVo1dH507egdsZ1qmYPw+DPbuMBdixqqC7ynI3cUu4WpTPUmoDqQWzv183AJm07zVwmF44hcTqAbhTVaaaGx8Y3jxGbH4JJHGz2GgII3YKUnNeSR3oqs0SkYtKHUlqAs3vVt8Pe+yRoWHokOw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06/03/2025 05:52, Matthew Wilcox wrote: > On Thu, Mar 06, 2025 at 12:25:53AM +0900, Ryosuke Yasuoka wrote: >> Some drivers can use vmap in drm_panic, however, vmap is sleepable and >> takes locks. Since drm_panic will vmap in panic handler, atomic_vmap >> requests pages with GFP_ATOMIC and maps KVA without locks and sleep. > > In addition to the implicit GFP_KERNEL allocations Vlad mentioned, how > is this supposed to work? > >> + vn = addr_to_node(va->va_start); >> + >> + insert_vmap_area(va, &vn->busy.root, &vn->busy.head); > > If someone else is holding the vn->busy.lock because they're modifying the > busy tree, you'll corrupt the tree. You can't just say "I can't take a > lock here, so I won't bother". You need to figure out how to do something > safe without taking the lock. For example, you could preallocate the > page tables and reserve a vmap area when the driver loads that would > then be usable for the panic situation. I don't know that we have APIs > to let you do that today, but it's something that could be added. > Regarding the lock, it should be possible to use the trylock() variant, and fail if the lock is already taken. (In the panic handler, only 1 CPU remain active, so it's unlikely the lock would be released anyway). If we need to pre-allocate the page table and reserve the vmap area, maybe it would be easier to just always vmap() the primary framebuffer, so it can be used in the panic handler? Best regards, -- Jocelyn