From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E30AE77188 for ; Fri, 10 Jan 2025 20:29:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DB376B00B4; Fri, 10 Jan 2025 15:29:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 18C2B6B00B6; Fri, 10 Jan 2025 15:29:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 005B36B00D3; Fri, 10 Jan 2025 15:29:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D618B6B00B6 for ; Fri, 10 Jan 2025 15:29:09 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8701D1A0D5C for ; Fri, 10 Jan 2025 20:29:09 +0000 (UTC) X-FDA: 82992681618.13.C841888 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf27.hostedemail.com (Postfix) with ESMTP id CBD0840003 for ; Fri, 10 Jan 2025 20:29:07 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf27.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736540947; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6vpgSl0wDz/pMqEoKcPpR1B07zsW5sx6AtGUzLSASp8=; b=og0xCmSmRv9TLA6TYNeOtG+5tusblHrVId6EnPPyl7NgT9zMg8xLnMbM81CzeTrPbcIrJv vEtqmmPEbaj0cqgkcO5SKPK5IoAdzpscdhMCkDiwKYKjIkLJ63b/vtubKfOdmkr++4qh8l Du5iB7vkiEdd70wThzV4MJa8Qx2LUu8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736540947; a=rsa-sha256; cv=none; b=z1StlaDqjKFHrPRRQs9/psackt20HZ9NtbeIYUjBU2jKCYS/mUzAJtuzp9oMKynM2Fsjyh 3n6iQN3ue5A1BLlujNhxDdwgSYlaYKLhAUGDaDuTVBzUEa/6+0PfoQzQYKF8YqJ4LT4rB8 TdjoiEE5CWP9cMoUP26vEKof49mM6Us= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf27.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tWLbV-000000006eO-3pwY; Fri, 10 Jan 2025 15:27:37 -0500 Message-ID: <3bf6f37a386ef8afeefee54202283023c0581f58.camel@surriel.com> Subject: Re: [PATCH 04/12] x86/mm: get INVLPGB count max from CPUID From: Rik van Riel To: Tom Lendacky , x86@kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, akpm@linux-foundation.org, nadav.amit@gmail.com, zhengqi.arch@bytedance.com, linux-mm@kvack.org Date: Fri, 10 Jan 2025 15:27:37 -0500 In-Reply-To: References: <20241230175550.4046587-1-riel@surriel.com> <20241230175550.4046587-5-riel@surriel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.1 (3.54.1-1.fc41) MIME-Version: 1.0 X-Stat-Signature: ihef5gjeo5q3idgtxspqcorkjcajzict X-Rspamd-Queue-Id: CBD0840003 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1736540947-320405 X-HE-Meta: U2FsdGVkX18KKEfwldBxFY1bF6pY3N5VhIYfglVqDdywh1Cmim/bSXiR9qBNTAvUez6kU/5nR5UwpD54snWhkN1mJ0tiSk9cWwqIuXiMtuGadNFtyGUR+Xe2hs5HR/+0WCs5WY9foeb9JYIPsCLzmb5cbYyUO42rZeVtbGjlvKAIoxxkD8p4rFfhjP71FsCPUMtM/jnYFRB8i0n8/+8WGIs7Jcp3YDtMVo8WUxzrB2pR3S/TIR/ZtIft0aD9y1aMf9TiOxfD7VYh5D+YpCpPKqipL9hWv1uj4cQB8BYWWsZJPcLwNVZsBfhnUxumUq64hA+I+258ip6MD6yn5cFftK6oJUS9tLGT4DJ20fOJYRUPhaiyNZc7fQU3ezdT8CMbx7wbKw0nuzHTie5FR11qYd7/Ks75JMeKNPloM/LSxlesPxAnFbzhyTlGm/wKKAM7BlDVsxbzsonjM2PNER0Fv2T1X/DeYbQmnaKc+m/Xj9L9VmcnnxWj5yHlvJdXXsgrYW0kq/MsD6JNFroJuLRr8S33WoOqzNv694EMa9lTtSMoAOs/2Q3+r3+IYW7Y3RYlbflzqdY583dKowlgyhrpAPLkve0uuWL5RPPruDJliQOY4oQT7A7xKEO0SKxHD6IDbovQQu64P4kTS4VuEesQa2XxZp+q7HdLk8JdJ5p41lQGEo4zYC5xVMPjoW2VfbmO4v0BkUWW4/iGKPAfa3h6AkghDWXY3yYi6vLuRfxMeHBWA25Ulj5jg3rNkc2lO//waIX9t42dKemiY5DLOK1z87JbmbcoCSQ2Ot7AUksSse5EO/hYpaeXZTmYpTHz9hMmeJyHtNrnb/ZwuIq3aeCvMAF+PwT0m9buU8j93Ksi9ur+HSGxNjvLYuwVJRRTTTjLMKDMv6J36Bfa0YHMA5BLFjSDius4kvvgu2zY/pQfdGvGYHTYEocF/UJRgakzqdH8tTAaCf2+M9FkU5OYOEr aA/82hrn 1GXg3jhEarXmb3lT+51P6GDLCtTMvXdFkVQKQVLdolRxyIi9JKkM/SY/+AvUOw5Ox5nPZ/TgVihXX3HetksoKPCXU8jmE+e133a25vk8+felTSxVB2MM3SGtJO7qvwcB9amp9E2KNEq4MLfXLix0uIWXp5uJR//kW5qvMq9NkpLYOYkNls23Guu/8kVgfdHSISdQ5XlWSsxEFok/oF3xosTyArBWluIeh0wCs5KMd+2WwIo2SeXhgH47r4uNs+FSU7OQPgXPBiKkbE08XA/Z7DanmdTXUasyWcGw09G0ChxMbhMdO+R3bDvCVksvuqE1AK1TDUukmZPsrV97PDDE5zko6/4S3SZW33ykIZQrt6gYkpQU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 2025-01-10 at 12:44 -0600, Tom Lendacky wrote: > On 12/30/24 11:53, Rik van Riel wrote: > >=20 > > +++ b/arch/x86/kernel/cpu/amd.c > > @@ -1135,6 +1135,14 @@ static void cpu_detect_tlb_amd(struct > > cpuinfo_x86 *c) > > =C2=A0 tlb_lli_2m[ENTRIES] =3D eax & mask; > > =C2=A0 > > =C2=A0 tlb_lli_4m[ENTRIES] =3D tlb_lli_2m[ENTRIES] >> 1; > > + > > + if (c->extended_cpuid_level < 0x80000008) > > + return; >=20 > Can this just be based on cpu_feature_enabled(X86_FEATURE_TLBI), e.g: >=20 > if (cpu_feature_enabled(X86_FEATURE_TLBI)) > invlpgb_count_max =3D (cpuid_edx(0x80000008) & 0xffff) > + 1 >=20 I don't see X86_FEATURE_TLBI defined in the tip tree. Which CPUID bit does that need to be? > Then you can squash this and the previous patch. Heh, I already squashed the previous commit into what is patch 6 in this series, as requested by Borislav :) --=20 All Rights Reversed.