From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D0F9C05027 for ; Fri, 10 Feb 2023 21:59:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E7D028002A; Fri, 10 Feb 2023 16:59:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 997E9280021; Fri, 10 Feb 2023 16:59:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8600F28002A; Fri, 10 Feb 2023 16:59:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 75B7C280021 for ; Fri, 10 Feb 2023 16:59:42 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3EE37C05A9 for ; Fri, 10 Feb 2023 21:59:42 +0000 (UTC) X-FDA: 80452749804.07.18AA99F Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf15.hostedemail.com (Postfix) with ESMTP id 25870A0018 for ; Fri, 10 Feb 2023 21:59:38 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=gi1sh1VR; spf=pass (imf15.hostedemail.com: domain of dave.jiang@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=dave.jiang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676066379; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tNtyCZNjJAOEhRtYuXVVP4VJldW5iTrODqCZV4rY2KM=; b=0xOpBVH06Vr/JlSRfNsRgu6UJkhFRGAZIkricEEhntAc0RdR9WLmNuX5h9nooL4/Ga0UmU tkmU3nhe+LWBCgv/TJZTfhrktjVx0ZU/Gi8Z58kENhHvcDEBBsg9geMt74eNPdoj0koHAP /PDeOSSg1cPR4fySAfyTAdK4osZt5zk= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=gi1sh1VR; spf=pass (imf15.hostedemail.com: domain of dave.jiang@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=dave.jiang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676066379; a=rsa-sha256; cv=none; b=rLY7FHIsuKvvNMe9t+VRdymMWJb6kg2hMUHszXY+oscyaGnvRA73Pz9KgVvvRqZiJ1d15t KOxVC2XlbqufqeTdLzdj8kfVKi5OSPTC82DszpoQfQIUdQNkjiYGXd9KIToqta7n4ZatNd lOWbjQtJaVpj+BPBJHkYVfbAufChdjw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676066379; x=1707602379; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=IWeWBAcXU8gR83oqaSxz80kzyVRTcSG6AcaGmWbiYD8=; b=gi1sh1VRIqTz22n1NptKr76ethn4k2sIAti260ScOcDOujzvtGVM+SML iClR3tDW4z9I0H6vGV4NGtIAoGtdNPz9ID5CB+IqiWfZpz1VW6cJ0p7I6 9JdakBdkMYWl12osjMmvCsodIBYbSyiEQUmS1B3dRu6+hel0SYVmbq1w0 CpzunVcQd69T/HgNuoPrGEyKNOZYpQfqIuLYA6xNUKb65Lmw0ZptRy9aI b/K6Rb1MxgzFN+AggeawVGcmjb8a0XfHQRYlO8YgSvAdWG4x8kwuj9Mum 2qzKyjzo9impUkHrJxiZYho/7gOYLVj7+ty9/+l0/7X0uDUDkt75Ve3hA w==; X-IronPort-AV: E=McAfee;i="6500,9779,10617"; a="330545037" X-IronPort-AV: E=Sophos;i="5.97,287,1669104000"; d="scan'208";a="330545037" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2023 13:59:37 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10617"; a="700616322" X-IronPort-AV: E=Sophos;i="5.97,287,1669104000"; d="scan'208";a="700616322" Received: from djiang5-mobl3.amr.corp.intel.com (HELO [10.213.190.133]) ([10.213.190.133]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2023 13:59:37 -0800 Message-ID: <3bef679e-ddb6-45a1-2152-522fc217efa8@intel.com> Date: Fri, 10 Feb 2023 14:59:36 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.6.0 Subject: Re: [PATCH v2 16/20] dax/hmem: Drop unnecessary dax_hmem_remove() Content-Language: en-US To: Dan Williams , linux-cxl@vger.kernel.org Cc: Jonathan Cameron , Gregory Price , Fan Ni , vishal.l.verma@intel.com, dave.hansen@linux.intel.com, linux-mm@kvack.org, linux-acpi@vger.kernel.org References: <167601992097.1924368.18291887895351917895.stgit@dwillia2-xfh.jf.intel.com> <167602001664.1924368.9102029637928071240.stgit@dwillia2-xfh.jf.intel.com> From: Dave Jiang In-Reply-To: <167602001664.1924368.9102029637928071240.stgit@dwillia2-xfh.jf.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: k9nsse5fxszer7k6mx1tnbs4zximm4ey X-Rspam-User: X-Rspamd-Queue-Id: 25870A0018 X-Rspamd-Server: rspam06 X-HE-Tag: 1676066378-83782 X-HE-Meta: U2FsdGVkX193+fDBLeXUnkCBNkVFaN4T6AsJVlQZ0/b20q5ep7hnRrZ1HCMOn3Ck0hPC1Nf6K6eadZoeFYqRQg0kMDi5BdTgLCqWJQh65x+lV2LKgh/cQCE+43MmelhVifHF4w0kWy6H2SarBFvH8zxnWoAgxQli+mW88TPbU9ftaNbrR7mSsE9ux0F0ezwMuNAzR7UDz02xHEGKvqMiT3Jyfm9S0mUNijRdewFlh3uotfV5NHV31xIrPUFYCwMFP8fYUTRk0tDExPP0fCy1v9bdgs6Y948cmcq9hPkalTv/NeLkzERJSjitcthMedCX+s0MgV48HxNIJ7CTMkSvos/r+BfRckgcnvE40vGAE0dlogXhd5sHKaGCJO5rwNEOQJljgyzvkYRbTbYxxmmsqQIwWhO5SSsNI+yV55/jg2z0eLu3ropSsVJH5p1OH6H9lOZNo8YSRoPta7NnY+qYbW3bLGVQFe1L1LjXdluAADyvgFixkxm3TvBluYz7IY7y8eh+2BME88nCJyM0vIJlWZXL0hl0+O4NfURXEJNlUCbcKVdoH4cuZqC3JsM0s+EwTXMJ5kmavUqqi5erFt9W7iedud0z2veKFaPm/rYmV7IeGddKNog/Sl3bMgOwwHm3zmARmVlPP5qjMjeeF1VSADP+omjfj2rqpZRIcYGvmiwDXwlJkEgUkxB25RKcvHrpU2LV2lObZlmHqi0GjtKA5vlg9AWsm2bGozNlsCZ+lQzB2GGAg5vRsPYkatU4zx1vpaGaZq2k77E8HkFdTlZwNjVxqX6jDxqkANt2Wl7SDl/yVOfIPQ+vfCWnpRflDXbooaM+YnyoKHDGOQeddMt9tuBCKdwDp1jSkIK22+4xJVuo+LBGSV4iV3ctFih2A0vn7g03pwnnsu1Iy7dwNLD11FMBTo10qfLPzDxUDoamOe0+gbX4HUgwBHxjS6t6kAGd0K1FO4mM1QM8LkwZm5W ohKw+ac+ SEvK2LoWGEd4bITiNoxD0lH11Oi/Dg27Mid/Q6G++IDmxY8/KyvHAElF5gAY4KIPck6JkJWZ37PAoqHk33mvDnxc2ZzBZsyuwdd+Qp06PdfoYfy07es283cSTzf+7Bkv/kGKOMEfXCInu6wKJmeyv6tt/UHj4Ax2nzYQVgMVNFTmmEOEjuJZ2C/g1rIYD7bZZzulJqimOsAZxlHspcQb4Ong+/p/ilrdYek4qQ0u6pg1Er+lHiPbXyCcirSR+UAZyMwsfGAaH+jgU1SSvAHfjqwi6ta/WaENBqo+mTIiTIPmTv0zYy81IF7skAgnyGxaIklZWsmdRnenPoQa5sD7TIvQf91A+VFwlwSHbok93JZ3SYxSV08mhfWzDk3Fvt/U/r9zZYMmr9vRHrYLa8WULqzzgMw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/10/23 2:06 AM, Dan Williams wrote: > Empty driver remove callbacks can just be elided. > > Reviewed-by: Jonathan Cameron > Reviewed-by: Gregory Price > Tested-by: Fan Ni > Link: https://lore.kernel.org/r/167564542679.847146.17174404738816053065.stgit@dwillia2-xfh.jf.intel.com > Signed-off-by: Dan Williams Reviewed-by: Dave Jiang > --- > drivers/dax/hmem/hmem.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/dax/hmem/hmem.c b/drivers/dax/hmem/hmem.c > index 1bf040dbc834..c7351e0dc8ff 100644 > --- a/drivers/dax/hmem/hmem.c > +++ b/drivers/dax/hmem/hmem.c > @@ -44,15 +44,8 @@ static int dax_hmem_probe(struct platform_device *pdev) > return 0; > } > > -static int dax_hmem_remove(struct platform_device *pdev) > -{ > - /* devm handles teardown */ > - return 0; > -} > - > static struct platform_driver dax_hmem_driver = { > .probe = dax_hmem_probe, > - .remove = dax_hmem_remove, > .driver = { > .name = "hmem", > }, >