From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01B7DC4332F for ; Mon, 31 Jan 2022 07:49:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 32C4F6B0074; Mon, 31 Jan 2022 02:49:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2DCE86B0075; Mon, 31 Jan 2022 02:49:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A40C6B0078; Mon, 31 Jan 2022 02:49:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay025.a.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 0B7FA6B0074 for ; Mon, 31 Jan 2022 02:49:04 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BCA9B21D2C for ; Mon, 31 Jan 2022 07:49:03 +0000 (UTC) X-FDA: 79089806166.02.A872974 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 2E8A740002 for ; Mon, 31 Jan 2022 07:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643615342; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZAt16hzi0jARVC2SH2tfH/9B/mqcxkzoEuuB90n1AMk=; b=CmRYQFuJH6yB2KQLE7oMkHUfTpfGl+jBXq66TK/e1pymA9QTuU8YS28mWzDhCoykv/Un9/ vFjIar+1f3zKoxBfyBPaiYUaJBSgjAz5qB1SkubWQOC9wSQo2NC3SmfnPJPBGAQHYcXqc3 5FPFOXv5U5QBbiGMDdjEt5ibPH5z32g= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-452-1QmQ0q3xNImMri6LAmwquA-1; Mon, 31 Jan 2022 02:48:59 -0500 X-MC-Unique: 1QmQ0q3xNImMri6LAmwquA-1 Received: by mail-wr1-f70.google.com with SMTP id c9-20020adfa709000000b001dde29c3202so4458879wrd.22 for ; Sun, 30 Jan 2022 23:48:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=ZAt16hzi0jARVC2SH2tfH/9B/mqcxkzoEuuB90n1AMk=; b=RUjDUP/gbeWcGS0lDEmLsOMuqxvUReo2vaurEpkRWvulJJ4XgFJSVxd57oOExoHKvL 7mwVZvUqFPskD2aYtP9fj2M6gO7REPPEk0HoT3xhpDoAGLeowv1KEJaUCHVJBVAXXw4X kAZuS19fegiNQWHrOgjs6KJepeKsWrKMuBGgZ2ICAJcriWeYjJ6azl/oijPpzVFz+AY7 qYRqbL2MJgP6Uw72773ZxNu7wOhWttM6ZKeKf2++tV+2jVyWJMhyr+P9a9NYGAbJ8+mS dS2i7wmDReXyLdRT44chrDvOTvRXUu/ENVYVNzmHVi8kNkjDhxCCYf8iMoRDt0y0/li4 KdzA== X-Gm-Message-State: AOAM533xPW1Yk/BZqMxZ2HVuzobjmSvwkF0GsIVA95q5M0Tarn1BV4jQ 5hzApBzDlSiLD25PIOl4OYRkT07ejJ/Q188jQA916uVtfUOLqNWxToUnJlBYMCZ9skh1cECKKCh FiZrfnCFhijA= X-Received: by 2002:a05:6000:1008:: with SMTP id a8mr15911182wrx.563.1643615337601; Sun, 30 Jan 2022 23:48:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJziNLNeLdU3x1hO5PuIt8mvz7fg18Pv6lGvSgHdK7fS7xha3a7EYrVkbUytI3CwE4ViZc3ZTg== X-Received: by 2002:a05:6000:1008:: with SMTP id a8mr15911171wrx.563.1643615337390; Sun, 30 Jan 2022 23:48:57 -0800 (PST) Received: from ?IPV6:2003:cb:c709:b200:f007:5a26:32e7:8ef5? (p200300cbc709b200f0075a2632e78ef5.dip0.t-ipconnect.de. [2003:cb:c709:b200:f007:5a26:32e7:8ef5]) by smtp.gmail.com with ESMTPSA id y6sm5081791wrl.46.2022.01.30.23.48.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 30 Jan 2022 23:48:56 -0800 (PST) Message-ID: <3be2e20c-f0b9-c080-adf4-b0e17c046eb0@redhat.com> Date: Mon, 31 Jan 2022 08:48:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH RFC v1] drivers/base/node: consolidate node device subsystem initialization in node_dev_init() To: Oscar Salvador Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Greg Kroah-Hartman , Michal Hocko , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Yoshinori Sato , Rich Felker , "David S. Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "Rafael J. Wysocki" , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org References: <20220128151540.164759-1-david@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: nil X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 2E8A740002 X-Stat-Signature: y39n77rq341eqph3std3ynr6dx15rhwy Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CmRYQFuJ; spf=none (imf01.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1643615342-878450 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 31.01.22 07:23, Oscar Salvador wrote: > On Fri, Jan 28, 2022 at 04:15:40PM +0100, David Hildenbrand wrote: >> ... and call node_dev_init() after memory_dev_init() from driver_init(), >> so before any of the existing arch/subsys calls. All online nodes should >> be known at that point. >> >> This is in line with memory_dev_init(), which initializes the memory >> device subsystem and creates all memory block devices. >> >> Similar to memory_dev_init(), panic() if anything goes wrong, we don't >> want to continue with such basic initialization errors. >> >> The important part is that node_dev_init() gets called after >> memory_dev_init() and after cpu_dev_init(), but before any of the >> relevant archs call register_cpu() to register the new cpu device under >> the node device. The latter should be the case for the current users >> of topology_init(). > Hi Oscar, > So, before this change we had something like this: > > do_basic_setup > driver_init > memory_dev_init > do_init_calls > ... > topology_init > register_nodes/register_one_node > > And after the patch all happens in driver_init() > > driver_init > memory_dev_init > node_dev_init > > I guess this is fine as we do not have any ordering problems (aka: none > of the functions we used to call before expect the nodes not to be > there for some weird reason). > > So, no functional change, right? > Right, and the idea is that the online state of nodes (+ node/zone ranges) already has to be known at that point in time, because otherwise, we'd be in bigger trouble. Thanks! -- Thanks, David / dhildenb