From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36010C4345F for ; Thu, 18 Apr 2024 09:25:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9692B6B0099; Thu, 18 Apr 2024 05:25:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 919126B009A; Thu, 18 Apr 2024 05:25:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 806D76B009B; Thu, 18 Apr 2024 05:25:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 631CA6B0099 for ; Thu, 18 Apr 2024 05:25:07 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 09AF6C12EE for ; Thu, 18 Apr 2024 09:25:07 +0000 (UTC) X-FDA: 82022118654.30.2FB5941 Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf05.hostedemail.com (Postfix) with ESMTP id 138B7100013 for ; Thu, 18 Apr 2024 09:25:03 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713432305; a=rsa-sha256; cv=none; b=yl4n1SGvTz+klYc6LXDjKCeEFnaRBZXqHdnDCtF/Vg7J60TTW9Qpp5GI2neNUYaS0xzLUg V8vM7fi8/Pla0ynQDS9L4rmFnZqxJ65jTSVaYti6J84JI+JlBz8D1A4bTqzltQox54mnij WghSzlyJCn/elq9BUhM/tP5bx6uLXOY= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713432305; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fMQfaOL9Tcomi8eFw8HLHihpmX8uKJiOPzseis0n0y4=; b=FfzSM2fHzDjH64lJxVHg5lDFqO3HWKs0YnzEsbFOYXpRtkZyQAkhCVNFSKXs3qjCFd3LQo lrRdUhp3GtHraaX49rTjhR99mH+ZExKxGamY0gZD+81veXlyOrUrHV4rCZmwwxjKXMli4F KkH/yzDLrpFVPGubDEsUJLH0grpEGBo= Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4VKskM2QJGz1xtyb; Thu, 18 Apr 2024 17:22:35 +0800 (CST) Received: from canpemm500002.china.huawei.com (unknown [7.192.104.244]) by mail.maildlp.com (Postfix) with ESMTPS id ACCEC140444; Thu, 18 Apr 2024 17:24:59 +0800 (CST) Received: from [10.173.135.154] (10.173.135.154) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 18 Apr 2024 17:24:59 +0800 Subject: Re: [PATCH v3 07/11] mm/memory-failure: Convert memory_failure() to use a folio To: "Matthew Wilcox (Oracle)" CC: References: <20240412193510.2356957-1-willy@infradead.org> <20240412193510.2356957-8-willy@infradead.org> From: Miaohe Lin Message-ID: <3bd86e90-5d13-49bd-a2ac-7719d5934c7b@huawei.com> Date: Thu, 18 Apr 2024 17:24:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20240412193510.2356957-8-willy@infradead.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.135.154] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 138B7100013 X-Stat-Signature: xyztiqjdabqwxs7zoy4wte7yxq7f8k9t X-Rspam-User: X-HE-Tag: 1713432303-301671 X-HE-Meta: U2FsdGVkX18UdEW7mFdbZf6zFggnpKyELbXS25FLYjLqGGNp79pxy5HgPtJRLov7UdMItr/Th00SAnlB7ivOXhGYIim/CkJ3QcQ7yvc9aKwSrkXaRzupJ4IbHm7KzOMSy5V6VjMrlKikuRE7+CVzdL9XRbaPQpW0V6Osl+UDTo536LC5TODvG6Ocp5Yw6xCEOmEN2l2KtzfwB66UNeqHP5iqwr0GTcdLm/h2g4+53voeFf8Ra5R8dVdh0LsYAQPcIIfwtMoKwx7O4dHYO+k7pVCz8A+tf5n+oTjNy6uYRDhGTa8/94e04VlDtBFFncz6L2I1TvyGB066DiEfviENB3PEQkaNJQnYL6ynJQ2n4ureQCYOgGnf536xCv4PE3e2hU5IDcdMbA8AYTEwoT1J2BeJFUG/jW7Omgvayf/6U1qTVwO2GK2oZApwO6t3tO7s4iPEn9FCjuvh2jlQ7S4nga93QrihNPhHVs5bn5NNDA0U5YT3+hTPON2Hp4r5u7rNbV2LppgQTLQMcA8GjoDOA8qYbcXg4mXaJPFMKnAUuKhCmLURULBcK8kkSyGFa3Dq60jNDr+pNM5OqCkiGN6HfLsXgzTl3/fyg1BF3zuFP2DMwzLeR2FF/ebkNTZwUBc7PrQJr7RaxFHE0wXSerkyzlKUMicaGYEncbjVaBo1USCXBFOr5Xi152AhzkQio7s268oHWcGPJuy0WD3HfoRd6DX5wsLMaZ10z0KCkUiJgifgLFzukUykEawxAqkDeW2T8alKA2OFpciVPK+wJoR5HrueXok1lgxvJSwrh9mKRXGcjcFe9rGR+E8VqwpImZwPqjSVv2haMdBRyo3iUuqRetbxNtbG3cOx0rqaCIdgiq9USGu/zHacjB96fqP+VFVY5+bA3Uimd9fCAS7b0lbxmeSElrujHPNHO9yhorjRMBjuwH29z7uPPqZ7A+sLYbXcR8IeeOlVie3tS+xxsn1 YgGNtmjZ sUGw/R0zVL0H2NXKNS66oLRfqYXGDQjJ5nuFhQhewTuytuR8bPSBslL9N7o7inDWv5taLx529b9bJsN28cAfcCRxpFH/0olofcEiTzAsCiHa6/5JVV93muthmUWeoT6qKr6VYFi05KAQjblMzz63T0dKAsJinwc+v5ntXrDClQGi1jyNayWRtYwiufnw1sgDgcB1yyWl3Y6GspfU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/4/13 3:35, Matthew Wilcox (Oracle) wrote: > > /* > * Now take care of user space mappings. > @@ -2368,7 +2369,8 @@ int memory_failure(unsigned long pfn, int flags) > /* > * Torn down by someone else? > */ > - if (PageLRU(p) && !PageSwapCache(p) && p->mapping == NULL) { > + if (folio_test_lru(folio) && !folio_test_swapcache(folio) && > + folio->mapping == NULL) { > res = action_result(pfn, MF_MSG_TRUNCATED_LRU, MF_IGNORED); > goto unlock_page; > } > @@ -2378,7 +2380,7 @@ int memory_failure(unsigned long pfn, int flags) > mutex_unlock(&mf_mutex); > return res; > unlock_page: This label might be replaced with unlock_folio: ? Anyway, this patch looks good to me. Acked-by: Miaohe Lin Thanks. .