From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 442D3C3DA49 for ; Fri, 26 Jul 2024 01:09:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C12AC6B00A1; Thu, 25 Jul 2024 21:09:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC3DB6B00A2; Thu, 25 Jul 2024 21:09:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB1896B00A3; Thu, 25 Jul 2024 21:09:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 83FFE6B00A1 for ; Thu, 25 Jul 2024 21:09:38 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0B5DEA14C3 for ; Fri, 26 Jul 2024 01:09:38 +0000 (UTC) X-FDA: 82380121236.23.05AD7EB Received: from out30-124.freemail.mail.aliyun.com (out30-124.freemail.mail.aliyun.com [115.124.30.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 4421610000B for ; Fri, 26 Jul 2024 01:09:34 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=ImYfaLYq; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf05.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.124 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721956121; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PsON5V5U5DNnoUnPVjiIOxDNIXZW2cw+8PLE2L1M6Yc=; b=J1egngilZePIFe3FbKn93wUJzznnVPGgGtoNspYAucC1rpeYN+goOZdMjHenQYrCt9Vetk OVPtIlU9rF20jgWeho2sCQdtBv2MSHwSMfDK6hHSDETxzozmYDKIQ3ic0S+ZJn9PXLgnxz 2XF8vRKNIO1CDUi2m3my2VCm9rBHDIE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721956121; a=rsa-sha256; cv=none; b=08jmxuFU3FOyJbpuI/PZN6v06MGCJIdyPcF92u84VQV/Gd9D83YFydYCPeZlFL4IJ0K0GO +VxBXPE4K33on9WLd9VpQAUHQtE9w5FtBJ5sMwxbIrYlUu/CZwg6pb5v5ALyo1fwMhGQgK DsXYufedYTc6ylXjb859BPb4+Pces3I= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=ImYfaLYq; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf05.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.124 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1721956172; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=PsON5V5U5DNnoUnPVjiIOxDNIXZW2cw+8PLE2L1M6Yc=; b=ImYfaLYqQNWmKc/fEgsHRZwhPfNzsF3gggXx9t+siqCvLbyGiSo57sBnPlkHwwfqGoTFEdVp8lK7rF129hBrKGmA6IPhVApsgNVMIAo4W+tuKwdLLLAYrWV9tYDJqYxFC43UKNAF4C3oz+D3Chwd3ECuBjrPZZAaLy17UfIebJM= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R821e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037067109;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0WBJoD9L_1721956170; Received: from 30.97.56.64(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WBJoD9L_1721956170) by smtp.aliyun-inc.com; Fri, 26 Jul 2024 09:09:31 +0800 Message-ID: <3bd0c129-fdca-4f30-b5a6-c0b8d997d3e6@linux.alibaba.com> Date: Fri, 26 Jul 2024 09:09:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] mm: shmem: move shmem_huge_global_enabled() into shmem_allowable_huge_orders() To: David Hildenbrand , Ryan Roberts , akpm@linux-foundation.org, hughd@google.com Cc: willy@infradead.org, 21cnbao@gmail.com, ziy@nvidia.com, ioworker0@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <16dad33282617ecb90a3f466b35273b10be68d21.1720755678.git.baolin.wang@linux.alibaba.com> <1e635cfd-d461-4e56-95b8-c6ea512f64ca@redhat.com> From: Baolin Wang In-Reply-To: <1e635cfd-d461-4e56-95b8-c6ea512f64ca@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4421610000B X-Stat-Signature: uebbpphozrrbm5scn8nbue7hybetd13b X-Rspam-User: X-HE-Tag: 1721956174-614099 X-HE-Meta: U2FsdGVkX1+OF/8J5BFIMcMzPAvTpdAWnZspjPjePGd28BsG9WWyg91jTacL36oU32rpCyYa2tgEE+uOZe4pMGxCow2fCXTia7NK0AGenhBnoDZACnHI2+VcrNMayEvQgtYOQkuhsQ7BR37wUOqNbrcEpdpNNPQHer6nno/uTQToFnlxMpQiU+/jM9XIgNI1w8E/1m203oAmKiJtblQIwLi2cxJLElrMM/fs2nQ7rjjy5PlzVijBbW2IZo3lm4FELjVXwI5kdBQZuvEWVRJC5Vo4fEqDO+leviUKeVXtnL9mxnY/ovX2qilgrhuWYEwXBgRXdk7z+7H2LvIV/SNKt+F6/znQyii9+BknRCqTUu/OZuEAqaHszIQEfZBfZJ0ziDW5AlMZjBWAxCoCHJ3tIxqOKDNbpg1qXaR/a2Y+35sSPtEr6n5S0OJUs/px8B0bnh7r760VA0m5n+0pooooAm7oBI0cOJ00LiibyWCzGMLUnUQtGdIKOJn1wd7/U2ffYFMmPSpGCt7x+xzhet5QSlnUuIPIOyaNLTFQ5w+513thiNH/9s0QOI1m6UnEqEkJXPj/3THgiKMrF90FXecoPb3LH12sM4ZVoBOJ25o6h7gusnzStmB7APdlMvYlUQVXZyqNnFmRVuIaYOu9yok4YQ4Ouc/vcwk1dbfhp1ytNy1YcT8XyMEo1qqJ57WRdpjOrSrlgMJ1qr2VBMYD5fJn9sYU4H1kC+4PWW9U3dhhjihdpeP85mcEjsdSjN2ULBVTwX1MsEbI4fBwaP5FpT6gxiik+pRbUtpmZCfaVQC60P2Pq4298mZnVpXo1qYZ7JdNNzsp+rSWB/Fyr0PlB2a3suZbSQpdjQxbu5OF2on5u74NVmmbifd/gI1qE9MDA9obGDEtsgUhv0huPItIOir2k/HG1FBexSjSrswV73OJ0JpFXRlqD6r6YEw3C32RWLCQY43hHpP5rC135vURA2e OOp9xunY 8vneSrtiBemL+h7gEMxLnoqmwZiJCFlsy/8uYbOZPL1Bk8bWFFrmrhcEY2jVRqeOryVXuJQt2Bw5o+bGIKZZwyP/egWB89svBC0GxgGVmaVq7ZQ27bMaqlC3DFzddlR0YI/Ia9/nq+aMZRJ4AVG5zpfahxmXxtTv1g6cI9MxT71YidXuKVchUSRaEv6raaXNBVIpTmYEbLv1mc3j5densnrJzcEynJhD2v8dvUYbWbGEPD39nx3DD9aK859G5T3WRJZY2xfyvTuViGr2LQ0GGeJS8JiJF1H7XupM+tG6W1mytZXETOETdBUgLNInRDa3z0cXt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/7/25 21:09, David Hildenbrand wrote: >>>>    /* >>>> @@ -1625,27 +1632,39 @@ static gfp_t limit_gfp_mask(gfp_t huge_gfp, >>>> gfp_t limit_gfp) >>>>    #ifdef CONFIG_TRANSPARENT_HUGEPAGE >>>>    unsigned long shmem_allowable_huge_orders(struct inode *inode, >>>>                    struct vm_area_struct *vma, pgoff_t index, >>>> -                bool global_huge) >>>> +                bool shmem_huge_force) >>>>    { >>>>        unsigned long mask = READ_ONCE(huge_shmem_orders_always); >>>>        unsigned long within_size_orders = >>>> READ_ONCE(huge_shmem_orders_within_size); >>>> -    unsigned long vm_flags = vma->vm_flags; >>>> +    unsigned long vm_flags = vma ? vma->vm_flags : 0; >>>> +    struct mm_struct *fault_mm = vma ? vma->vm_mm : NULL; >>> >>> nit: rather than deriving the fault_mm here, I wonder if its cleaner >>> to just >>> pass vma to shmem_huge_global_enabled()? shmem_huge_global_enabled() >>> is just >>> using it as a guard to access vm_flags, which you can just as easily >>> do by >>> testing the vma for non-NULL. And you can access mm flags with >>> vma->vm_mm->flags >>> after testing the vma too. >> >> Make sense to me, and will do in next version. > > Feel free to add my > > Acked-by: David Hildenbrand Thanks David. Andrew has already queued my v3 patchset into the mm-unstable branch. Andrew, please help to add David's acked tag for v3 series. Thanks.