From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A523ACA0EC6 for ; Mon, 18 Aug 2025 11:28:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 411846B00EA; Mon, 18 Aug 2025 07:28:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E9B26B00ED; Mon, 18 Aug 2025 07:28:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B1236B00EA; Mon, 18 Aug 2025 07:28:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1002F6B00EC for ; Mon, 18 Aug 2025 07:28:32 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CC5D883ED2 for ; Mon, 18 Aug 2025 11:28:31 +0000 (UTC) X-FDA: 83789655222.29.EC28D6B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 3D80B1C000C for ; Mon, 18 Aug 2025 11:28:29 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Z4v5ROuS; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1755516509; a=rsa-sha256; cv=none; b=AZ+/Grb7nIi9Xm7fnbR0c6M5mZgGLO2yvqO/ekQSp6n0z0/wyNEYtL3nc+WPaBwl61ReZG PX0qi9Oq6POQkLufxDDF3bz6K5dLCl0l9cFTVtyT212qMbw766u3Yq5MKM0p/Kvi9dMQk4 nOly/tTYlQEoautMJfYDg0FEnmbkdnI= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Z4v5ROuS; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1755516509; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J0poHkf7IJxzNGcjiPzQE+7iEkpA1901ZpOaMVbBkbk=; b=A8tmAJKCteyLr6T3MaSr3IR46gTEZhyzWM4PNHNpeiWTitVje1pBwPc2CNiikgSLy07/Z4 FVgdRc0LEy318GnoiBRlPnjODWYQKk/aaIRFDgmxWEXNIXCeUUQAtRkDa7f0cLnNv0bKS0 noUforgDvqfyi+trX2mhrDkTj/S+c+8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755516508; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=J0poHkf7IJxzNGcjiPzQE+7iEkpA1901ZpOaMVbBkbk=; b=Z4v5ROuSMIsUYsQ550OSnBuw4T3qh5Np8rkOURSaWI8sre0uWbOX9G4i8z/H19ID6pWZTL IANTWBTJZQ6luFiclDuIY4F8OmsAVl5QdpWVntEJH2Y3nfucX7UW5KkYro8HS7yt93SAqw E7u2mCgpJWqsAlho5H/IO+9F0cSTX2w= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-218-v9Zpnt8oMPi2j5YQHSEKuA-1; Mon, 18 Aug 2025 07:28:27 -0400 X-MC-Unique: v9Zpnt8oMPi2j5YQHSEKuA-1 X-Mimecast-MFC-AGG-ID: v9Zpnt8oMPi2j5YQHSEKuA_1755516506 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3b9edf41d07so2619414f8f.3 for ; Mon, 18 Aug 2025 04:28:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755516506; x=1756121306; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=J0poHkf7IJxzNGcjiPzQE+7iEkpA1901ZpOaMVbBkbk=; b=AzIApl6Jx80V2BEm84Dt9Cv2JX6c6coQd4PrYLu7BnRz40spwAUgCMh61J5rsRq2xU 7pGK4Waf8gbsx0E2C/Th5fZHfgzmyVfZKjqtqOo4TvM+43TllPFhAWqsS22sYXd5FZaO +t4amFPJOcHwtmlvpRuqL4Wm6becrTbCd7k66ieW60nrxHjzfdYFNHK9prxnEusitS/f YjnDU0ENZh78hlnCnytxEoOB1G992G7dba0mCHkhw5nzALePKwWFYEOl+cbOFz8Fqf1f oITOvMQRe0/fiEZBBAZ2XzSw0w3R/OEYqeNIQFMTJbmMXUd8rIPvfIxKFFFqvUQwFUdd ktZg== X-Forwarded-Encrypted: i=1; AJvYcCWrOEbsoKFdlVp+tiStDRF/9RKMsiB3MvwtlXbVarkCTrQ1vU97FGx+2ZIoX3S21rQxgE9R0xMKPw==@kvack.org X-Gm-Message-State: AOJu0YzNCk6Lrc4gANCex4rb8WT9EAv7vQ7bQHyFOPLRjF+fc9wFqshS tcwIsyPHtRqSsdr9G2vno39Us8oG1gIujFpW8sEqNHLAnPfwpZi5oigVY8OfEsX8foCsE/hOuGD Ezw3a5BjlnPz11hFigddDOUqv1QhtTYtDZhTZ3fdjBK+K/RYdBSAa X-Gm-Gg: ASbGncuZ4pHaCz+YMsTtJX9vhUcnjhPZ7jQo7pSVj2M0Xh30eJWvoxA+LEI8gvIFd0R 5BLm5mSP5fg5p8Hr6l4yMBqEmUsMgNoTmVw/m8cr8HJoEa8rVI+RWoVtfWH+mWPmf2Z4pOGmA2F BfwW9OLfGgShWyqd2uIQxMnWF3LrcbpDD9dOonzb7aYkjOA3E2J7aCa6etpd3BJWE9yI0VI1W/i xS3qJ0j42JSc4t6rU+eJgdxrfQQknFyVO0O3Q1at/8+PRI25cQweV6eFrKX8h3IqBPb3I9KvE+e KSLecYbKAGUGfZZBGBuWhygX/Zb8duNifTzdpDzmuLKfFiulOP1sXwVONGj4aU5rDLqlBw== X-Received: by 2002:a05:6000:2301:b0:3bb:2fb3:9c7e with SMTP id ffacd0b85a97d-3bb674db9eemr9706751f8f.21.1755516505929; Mon, 18 Aug 2025 04:28:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFoJ2j4tybVSbT2mQ2UN8mZP25LV2c4F54aus7k4qiE296Q/C3YEoCeE99f3tiBsFkHDADQDg== X-Received: by 2002:a05:6000:2301:b0:3bb:2fb3:9c7e with SMTP id ffacd0b85a97d-3bb674db9eemr9706715f8f.21.1755516505387; Mon, 18 Aug 2025 04:28:25 -0700 (PDT) Received: from [192.168.3.141] (p57a1a246.dip0.t-ipconnect.de. [87.161.162.70]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45a22211395sm129258685e9.4.2025.08.18.04.28.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Aug 2025 04:28:24 -0700 (PDT) Message-ID: <3bb725f8-28d7-4aa2-b75f-af40d5cab280@redhat.com> Date: Mon, 18 Aug 2025 13:28:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] mm/migrate: remove MIGRATEPAGE_UNMAP To: Lance Yang Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, linux-btrfs@vger.kernel.org, jfs-discussion@lists.sourceforge.net, Andrew Morton , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Benjamin LaHaise , Chris Mason , Josef Bacik , David Sterba , Muchun Song , Oscar Salvador , Dave Kleikamp , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Minchan Kim , Sergey Senozhatsky References: <20250811143949.1117439-1-david@redhat.com> <20250811143949.1117439-2-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: GzBWrQp4jOBAJ2mG1EhpX76xQsY_DiD_wuCl4xUEV50_1755516506 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 3D80B1C000C X-Stat-Signature: dws8g6o3r91s6e4onjw1tis14gzekd86 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1755516509-479345 X-HE-Meta: U2FsdGVkX1/WARFxSIwgwz/C4j2hvYcdG6ErFcV1cBYFbPHV/v5lYQGDYCp3ZqihpoQ9l9xX7a+fRvUkww2/V5lfrXq0itPAleX16h7L8KV2/HXMR4Tw/12F3pj+FDlIAk2OxhaEHVTRqRCZGLyHC0fAy0gVPlDKyK/s623I99XkrHbZxfiXsc7chGfT+pESCvA6XU6zKpM0qgBz4OFUM8JGIu3xu5OufdKzY2pwNTPTrjJqrqtKdjnN1hGc5bA4G5XWzAiicmri0zSD5aHyVIed7MDDgcmJQi2vcUboCYpsmSOpSucBKcWt9XFsPZ8fmFoIFPHJWURGMHpQJPbQnrsXLjeY+zH9xDEt/3FaxvxoOX+7oJPyNCYj5mPcuL1oAGHCFuSCbxZVwqUZQtZfISNCrlNYNbhExDy8LlNqqXUtB8YphKCmRqhjYekk5VXyLvwTiMiRqcCIqO70iKOrES239eGTNk5aqjFnV8RHTMGmdjelRsNRiQs4MgU2x/CdqkMdnWhJITy1P+EfVtm8yhZ4T8hpIAD5XW5/wYYrZG8lXVZj0RmyDUaF84NXfip8o08sgjJfcKCCeAfM5V1AYz3tMeBvPHvGxhFtbfSxC2esgm+ccFe0qP3HU6pXPI7DivOEg+CMc70/crLMIHX0jpTK3Ixywy1RDRcdirFKb+Bg0W3Sq8/pocVfU69/Wl3EMHT+PdAMm4nzuyDLrG5tvJJlpNL66/pHc4EjqHqfcmcvTEGjz9U+YsELlFQ0h7J/rMYHlzYXxwY6uMpGGGPxPfaUOwxPzWI7oKChtL29vOKXEa/nB/lr6o73GPdigiSQT5q8zumoqkJZI+YVsj36ItatWprZ6k4ib2tp/I/Loub0scHqiHgOGqB+W606HC9daoh0UMEOpbld4CCTkZLhKayS7uXocSsJatSAy29aOYbmyD8z9f8RhnoXBfHMpSFfbUTiV+36SQa+YnsEw+o EoCRX1y+ Q8XF2708yjmVg2gTmhpiGgQFcWXnlol3Zrv/eCxONxPRX2GPzWZBp1uK2kVcRncXUUxFcq3SyBU54LV2CFDOcUQaR9offytp75Pp0iYXXIkEAn/94oQtmmNXGSzm1AXXaUGbZSLyLu/qc6m6AcPr9xBJ4zhGYzWQ5LjADlexh5idLY1N9JVcCYT0Q6HHFT5DNHZWmkVFaK2zqldn+kmB6FYaMG6jYsXOORQZCKM4H77Cj70N2F8m94DfLpQ1Ft+g8+/0XyQ5xxTS4Yyhf68NKGsVZ4zy7KCQErMdKtTUouX98qxi4HyYUjZzpJ75X7UEQQcYKU5mEY36AkeN5ZB+PEq0l05kvLCqxrVOmmFCpRiVMizVGkh35vzuiHAyN+ZD5gi/wbzuKio5r0/nLHebgRWR99fCoN47UzzXu9fKmETEsuLheJ+79bugm0mOe2Vv8SaQ2HQJWOFPXAl7Lh9t9dzPLDoHsQfKCD/5vf8FXaDG1VY6BmrefLWr4XXAPrDTDpyws6KcIzQe3yUIH6gZdAsFrFc7frALrMgIA+vS+So9reTI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.08.25 07:05, Lance Yang wrote: > On Mon, Aug 11, 2025 at 10:47 PM David Hildenbrand wrote: >> > [...] >> +++ b/mm/migrate.c >> @@ -1176,16 +1176,6 @@ static int migrate_folio_unmap(new_folio_t get_new_folio, >> bool locked = false; >> bool dst_locked = false; >> >> - if (folio_ref_count(src) == 1) { >> - /* Folio was freed from under us. So we are done. */ >> - folio_clear_active(src); >> - folio_clear_unevictable(src); >> - /* free_pages_prepare() will clear PG_isolated. */ >> - list_del(&src->lru); >> - migrate_folio_done(src, reason); >> - return MIGRATEPAGE_SUCCESS; >> - } >> - >> dst = get_new_folio(src, private); >> if (!dst) >> return -ENOMEM; >> @@ -1275,7 +1265,7 @@ static int migrate_folio_unmap(new_folio_t get_new_folio, >> >> if (unlikely(page_has_movable_ops(&src->page))) { >> __migrate_folio_record(dst, old_page_state, anon_vma); >> - return MIGRATEPAGE_UNMAP; >> + return 0; >> } >> >> /* >> @@ -1305,7 +1295,7 @@ static int migrate_folio_unmap(new_folio_t get_new_folio, >> >> if (!folio_mapped(src)) { >> __migrate_folio_record(dst, old_page_state, anon_vma); >> - return MIGRATEPAGE_UNMAP; >> + return 0; >> } >> >> out: >> @@ -1848,14 +1838,28 @@ static int migrate_pages_batch(struct list_head *from, >> continue; >> } >> >> + /* >> + * If we are holding the last folio reference, the folio >> + * was freed from under us, so just drop our reference. >> + */ >> + if (likely(!page_has_movable_ops(&folio->page)) && >> + folio_ref_count(folio) == 1) { >> + folio_clear_active(folio); >> + folio_clear_unevictable(folio); >> + list_del(&folio->lru); >> + migrate_folio_done(folio, reason); >> + stats->nr_succeeded += nr_pages; >> + stats->nr_thp_succeeded += is_thp; >> + continue; >> + } >> + > > It seems the reason parameter is no longer used within migrate_folio_unmap() > after this patch. > > Perhaps it could be removed from the function's signature ;) Thanks, well spotted, @Andrew can you squash the following? From 40938bb0de20e03250c813d5abc7286aea69d835 Mon Sep 17 00:00:00 2001 From: David Hildenbrand Date: Mon, 18 Aug 2025 13:26:05 +0200 Subject: [PATCH] fixup: mm/migrate: remove MIGRATEPAGE_UNMAP No need to pass "reason" to migrate_folio_unmap(). Signed-off-by: David Hildenbrand --- mm/migrate.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/mm/migrate.c b/mm/migrate.c index 2db4974178e6a..aabc736eec022 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -1166,7 +1166,7 @@ static void migrate_folio_done(struct folio *src, static int migrate_folio_unmap(new_folio_t get_new_folio, free_folio_t put_new_folio, unsigned long private, struct folio *src, struct folio **dstp, enum migrate_mode mode, - enum migrate_reason reason, struct list_head *ret) + struct list_head *ret) { struct folio *dst; int rc = -EAGAIN; @@ -1852,8 +1852,7 @@ static int migrate_pages_batch(struct list_head *from, } rc = migrate_folio_unmap(get_new_folio, put_new_folio, - private, folio, &dst, mode, reason, - ret_folios); + private, folio, &dst, mode, ret_folios); /* * The rules are: * 0: folio will be put on unmap_folios list, -- 2.50.1 -- Cheers David / dhildenb