From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB09FC05027 for ; Mon, 20 Feb 2023 14:50:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6845D6B0073; Mon, 20 Feb 2023 09:50:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 634246B0074; Mon, 20 Feb 2023 09:50:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FC866B0075; Mon, 20 Feb 2023 09:50:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3D89A6B0073 for ; Mon, 20 Feb 2023 09:50:03 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5016C80808 for ; Mon, 20 Feb 2023 14:50:02 +0000 (UTC) X-FDA: 80487955044.23.864A6C3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 20A181C0017 for ; Mon, 20 Feb 2023 14:49:59 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dJjDqq9n; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of dakr@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dakr@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676904600; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=14aOzXv8/LFbctYEfZwWWmrtrURJsidYi3oSxaFz0Xw=; b=thf4x0X9uAOFDSqrCIVgOy1aGlx6hiFAger2kq3zTGKHwr7pIkSzda5eE6D5jgbS+kD8i2 JDl4D7YixDIdSkRA+qwzEHLu+pM1FDtdVqrEqJRroP2SiULGn8q/Oc6tiBSfW9Z2lkidv0 ScPxWr0AiheVife3+sjSqv59IW74HQo= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dJjDqq9n; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of dakr@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dakr@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676904600; a=rsa-sha256; cv=none; b=cHvLxYGzZcTMwrJ1zjs1rdac+V0qfrUZjL+WS+2PWXcskI67dZ0+YVURa2oNww5YDEUamW RI6i8LrFLdZOapCuCmoLrfqCGBOnKV44AqpuY9n78r6cY7AM1bq1cxdOko2aq663e5IApv +APfwKf/LJ6UJZV1iyIQRtNKuv2G/3w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676904599; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=14aOzXv8/LFbctYEfZwWWmrtrURJsidYi3oSxaFz0Xw=; b=dJjDqq9nQeGAtaGn/elYkQbmnBvbpDrw1X7OUQKTwZJiInENZvjZL7V6TNiYkReuUVKEke jEIs0SlRZs6jw+u9iaUVHv5n1YXXE+Dvs2XO2xRpBTw8inIndPCUmBwJr0tHyIZuvT4dPL cJjzlCdhSvyT2EWuuBRziSY2o+9udfc= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-637-JI0vVmwiOLyB6RqOjK4z2A-1; Mon, 20 Feb 2023 09:49:58 -0500 X-MC-Unique: JI0vVmwiOLyB6RqOjK4z2A-1 Received: by mail-ed1-f69.google.com with SMTP id r6-20020aa7c146000000b004acd97105ffso2204360edp.19 for ; Mon, 20 Feb 2023 06:49:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=14aOzXv8/LFbctYEfZwWWmrtrURJsidYi3oSxaFz0Xw=; b=WBP48HkOB/fGBBVd/35E/05KHsdsqCEjat10gSzsemFm2WmIwb4QqFSaKkyMDN2pBb fpLPEHm0p4VCeyOm0ssk02FXT//j3TDb3Tk+c/9kGV2D1EBLGdiG9UAanpYstp3RdZHR aycUq4z3/suLFNAtt/S9R7xHssC9yBRJq/gExBTe0gXT6m9trtlhfbm6GofcjNY3OgJY VXnAm6yjoY594YJ9vVbp+6oiqbuEgQoxKQWP2K3/bWiqCOlG6vbZS6v6JW1O3M2K8/k+ JnbDqclL5bgwY4YXbhdJJ5Xi9Q4T2jQkZmt5m1dhKM7F1wohqj83DiGf2KwlhBeXGtgl oVfA== X-Gm-Message-State: AO0yUKXsCFWV9urVw4TdS4EYByMMWLJ2XHjqiUXbFAT+cjDsXCGjgyGp Pn+KgOgp10EpATJCLxaTBap5qHFAdm7S7cYA8ZjFfQ+DJEBtW7oJAg3m4yoJUZdpLWdXh31s6ND NJeN9VVXnb7c= X-Received: by 2002:a17:906:c451:b0:88b:4962:b72f with SMTP id ck17-20020a170906c45100b0088b4962b72fmr7384955ejb.20.1676904597384; Mon, 20 Feb 2023 06:49:57 -0800 (PST) X-Google-Smtp-Source: AK7set+98u/y2Cal3np2ksbwfkOOCjcq6rtCsH8aYGEsMo5bVtK+OVJWU6UbYetsNggJNxfOhh/MAw== X-Received: by 2002:a17:906:c451:b0:88b:4962:b72f with SMTP id ck17-20020a170906c45100b0088b4962b72fmr7384942ejb.20.1676904597149; Mon, 20 Feb 2023 06:49:57 -0800 (PST) Received: from ?IPV6:2a02:810d:4b3f:de78:642:1aff:fe31:a15c? ([2a02:810d:4b3f:de78:642:1aff:fe31:a15c]) by smtp.gmail.com with ESMTPSA id jr14-20020a170906a98e00b008af574fbfc2sm5934451ejb.33.2023.02.20.06.49.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Feb 2023 06:49:56 -0800 (PST) Message-ID: <3bb02ec3-4d19-9135-cabc-26ed210f7396@redhat.com> Date: Mon, 20 Feb 2023 15:00:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH drm-next v2 04/16] maple_tree: add flag MT_FLAGS_LOCK_NONE To: Matthew Wilcox Cc: matthew.brost@intel.com, dri-devel@lists.freedesktop.org, corbet@lwn.net, nouveau@lists.freedesktop.org, ogabbay@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, boris.brezillon@collabora.com, bskeggs@redhat.com, tzimmermann@suse.de, Liam.Howlett@oracle.com, bagasdotme@gmail.com, christian.koenig@amd.com, jason@jlekstrand.net References: <20230217134422.14116-1-dakr@redhat.com> <20230217134422.14116-5-dakr@redhat.com> From: Danilo Krummrich Organization: RedHat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 20A181C0017 X-Stat-Signature: 8jammujfck61pddc4qkqmtp7apmqpc8p X-HE-Tag: 1676904599-316176 X-HE-Meta: U2FsdGVkX19NlJBrOq9RsXqy0UkwPmE+/Ey4dNi8vVF1k84DTHWFORxiD2PRSD97ejZsu9z7onZokgMCglSqNGwc8ro8uD/damJozG85EO34kW6MXnjZvSxx/vg3IRPGOjlorLwUEWQwVoCbdYpg7R9R4FhO2zx35ZFB2LvlNdx6NOLPRx0qE31Tmt7CXxSNU9gQ+Q7XK+iHe6FdWs45dCARzV6mhm/59O+dVBaBi2oAbGPqhUxzMY1KjoISYXaYaTcCmBnl6Fjn1fqlCPZbgnabFsL/iQpNJ04G8py+U66bZ7UU5ueV9IBjN17Ha6BPLxqSPheGyuztKfHqWiF8wvrtH/YLP7pwzsq9g3HvgWI5qSCWhkfsIjhp3PjEM1s2ZDz2PgraWV9WaR6GxWJpGOoU1+qLsQzq7GLA+nfg8nR2N+wwf0nyxS8FFHzgLXcvcLpUg1VM+fp/padAJRO+6ZzPfcB7R9BN+oS0d2th0W6TG9LZvJGfuAotO0OPeXtU8oDVf0sCg0A06lQ3ZQ9sLBswuHA0b72fnT7mDGzojPnnQyhoMvHtDItHOhXTHXZbMl0/xIlWmERSB0sX7ocZeKe3B+BJQrczY+910iX3yKGDmz3zn3efZX1AvRsJJjWaY17WFCH4kTkMUBAFN8MBFDz3n7F9+LxO0KgNCeLodVCsBd/87VCjElyTnDowVzHWAFpVghy6xsTtEDZQPJhu5lQrnjO1F58jN9raahKcNk/gXeQROQceyPHoxsAh3TuLLe518RYeSqpSAVUwJ3W82iVO730hiS++FInQUVRCoFBEtkalgPQQM0sd27eZ0rZDhCXYOTym5+6X+uxXaOmd7HRBld4zvWchzmQId5Hngoq3fekusFlmI4G3L4DgtEDLuMKXbX1DoSPmjwhsTU7HtaArpQhvfLuFh5uBM2XLSVlGQECNJraC0ntd+hMSlcZhWjxw0+/q2xS8L7Xk/pr /kaRUzaf 3yJ5B5//Ls7NnaxHhn/ggukrtOKkDxUl9gO8DDqs/kM4SjMbvQqFFvBMZLy9rizzx+nSoVDvZsTVn29oPr1SdkjC5aDIZ2bRFC+Lifdyq1sSnOaSqltvp+EMC7e/K/5PjVmoMzJnZbfbNDfMJo/neTn6ZYAKQr6fyFxbPmhdluh5uqcf5dK8f7FeU13HQElefAhR6Oarxfvynd0RUvXo1rNEsu6+czd7ikn2caxZtWrxMsW3qSEy7kJcLU3DS7wyOJ1qr7lSRnfxTTM7PLAKzYc0LbWOSsNyBCNPixsZGUcC1Y49F3SDUrNq+DKQaNVxoH9ThaJPjhMYWgqqnb0AdsklHM3DRAypvzwJ3fsxejDxAdlcfjgBi78+7AXFoknHW675SBjg9w+TzdeBcbVmfEpmXsTRSVNlHQCFXnSgBdXdow5FWkYebBnn9evdownrpaApE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/17/23 20:38, Matthew Wilcox wrote: > On Fri, Feb 17, 2023 at 02:44:10PM +0100, Danilo Krummrich wrote: >> Generic components making use of the maple tree (such as the >> DRM GPUVA Manager) delegate the responsibility of ensuring mutual >> exclusion to their users. >> >> While such components could inherit the concept of an external lock, >> some users might just serialize the access to the component and hence to >> the internal maple tree. >> >> In order to allow such use cases, add a new flag MT_FLAGS_LOCK_NONE to >> indicate not to do any internal lockdep checks. > > I'm really against this change. > > First, we really should check that users have their locking right. > It's bitten us so many times when they get it wrong. In case of the DRM GPUVA manager, some users might serialize the access to the GPUVA manager and hence to it's maple tree instances, e.g. through the drm_gpu_scheduler. In such a case ensuring to hold a lock would be a bit pointless and I wouldn't really know how to "sell" this to potential users of the GPUVA manager. > > Second, having a lock allows us to defragment the slab cache. The > patches to do that haven't gone anywhere recently, but if we drop the > requirement now, we'll never be able to compact ranges of memory that > have slabs allocated to them. > Not sure if I get that, do you mind explaining a bit how this would affect other users of the maple tree, such as my use case, the GPUVA manager?