From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB147C28B20 for ; Wed, 2 Apr 2025 13:34:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1D0D280003; Wed, 2 Apr 2025 09:34:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ACB99280001; Wed, 2 Apr 2025 09:34:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99293280003; Wed, 2 Apr 2025 09:34:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7E627280001 for ; Wed, 2 Apr 2025 09:34:19 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B08A3C19A0 for ; Wed, 2 Apr 2025 13:34:19 +0000 (UTC) X-FDA: 83289197838.16.906FDE0 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf03.hostedemail.com (Postfix) with ESMTP id 1AE5C20012 for ; Wed, 2 Apr 2025 13:34:16 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=hQvSdOGQ; spf=pass (imf03.hostedemail.com: domain of vineethr@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=vineethr@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743600857; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WyEyXUzQBG5YYWYNGano5THo76MoLBzhRYTP61tbVHg=; b=dS6VCCE6ml2ifvmlCscaxcvxqYYxEPFTVnzwIc1HeNhSb050nHF86LRp8q0mZ0FvZziWGY SZW2wYhom/wb5Gwadje4HgU+f2RyxxL8FMFFpG2mx7LXGF4p+G+XSpJKtNy024n4OiYp6c Igr7mrkACQCpQwuoROeYTZTqZ29gwA4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743600857; a=rsa-sha256; cv=none; b=zSsUaMN5YHoPghOYsOvZtizh0k33WvVLbJIKPRs/AuC/IHE8wEGiwR4YdXUOmar5F1ifiL S2CpDomlSCgKE6qL/S6W8TLalOF99a3HxS8rT/2KHXpj+KGJrmuuKIJwQiecLN/wqkb5A8 zFqLpKzJ/wPffdkb0kWSkvj9W7yRoXo= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=hQvSdOGQ; spf=pass (imf03.hostedemail.com: domain of vineethr@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=vineethr@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 532A7cOn032720; Wed, 2 Apr 2025 13:34:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:reply-to:subject:to; s=pp1; bh=WyEyXUzQBG5YYWYNGano5THo76MoLBzhRYTP61tbVHg=; b=hQvSdOGQLXH1 biParECBb3mpF18P129RUrhEDgFDbZkodAxrPyaAahoufJkKahT8k3PqhYf7QpD+ +jSjMh1XdxuugkDsx2OJOG6m1NPdPOcJLObyrOD7ZuyE5s0xut/HUd+tFqdD+vKr uepOc/HDhuNoYZNL3WAMiH5hVrwDvkObFtJXNYgEu657kE0xs/d1wo2qSR8y9LDH B5Zb+JtGKGgPgBUhNlFQdtcrJo8pT7lAUG1UUjWyIuLsd+/1Ysf/hSnSoOsI10XX XtsBq8g7Phj/GrERqKNjMN8LoSDyV0mSZsWJGswbmAgMEJpILisPF6zfWDCuaXIG yRTE4ngZGw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 45rwmaaua7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 02 Apr 2025 13:34:06 +0000 (GMT) Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 532Cj0xn001558; Wed, 2 Apr 2025 13:34:05 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 45rwmaaua3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 02 Apr 2025 13:34:05 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 532D34Uk010394; Wed, 2 Apr 2025 13:34:04 GMT Received: from smtprelay07.dal12v.mail.ibm.com ([172.16.1.9]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 45pv6p0305-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 02 Apr 2025 13:34:04 +0000 Received: from smtpav04.dal12v.mail.ibm.com (smtpav04.dal12v.mail.ibm.com [10.241.53.103]) by smtprelay07.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 532DY3Br29819586 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 2 Apr 2025 13:34:03 GMT Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 613155805E; Wed, 2 Apr 2025 13:34:03 +0000 (GMT) Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8634B58056; Wed, 2 Apr 2025 13:33:55 +0000 (GMT) Received: from [9.43.67.35] (unknown [9.43.67.35]) by smtpav04.dal12v.mail.ibm.com (Postfix) with ESMTP; Wed, 2 Apr 2025 13:33:55 +0000 (GMT) Message-ID: <3ba327b9-3020-4a63-9623-e6eea0120056@linux.ibm.com> Date: Wed, 2 Apr 2025 19:03:54 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] sched/numa: Add statistics of numa balance task migration and swap To: Chen Yu Cc: Peter Zijlstra , Ingo Molnar , Juri Lelli , Vincent Guittot , Mel Gorman , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Tim Chen , Aubrey Li , Rik van Riel , Raghavendra K T , K Prateek Nayak , Baolin Wang , Xunlei Pang , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Chen Yu , Madadi Vineeth Reddy References: <20250402010611.3204674-1-yu.c.chen@intel.com> Content-Language: en-US Reply-To: 20250402010611.3204674-1-yu.c.chen@intel.com From: Madadi Vineeth Reddy In-Reply-To: <20250402010611.3204674-1-yu.c.chen@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: HXJV5Q-jqXHxdR2AcOHw3yx69yUfEuGO X-Proofpoint-ORIG-GUID: d9-NvWT-09rPiaSGGOiXdBzqDhqISW8d X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-02_05,2025-04-02_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 impostorscore=0 phishscore=0 clxscore=1011 mlxlogscore=999 bulkscore=0 suspectscore=0 mlxscore=0 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504020085 X-Stat-Signature: o95ug1xxhpih1uz4wdhtxnunh8earyeo X-Rspam-User: X-Rspamd-Queue-Id: 1AE5C20012 X-Rspamd-Server: rspam08 X-HE-Tag: 1743600856-542843 X-HE-Meta: U2FsdGVkX18WmqT6Za6fMhIo/UUJ01An7ZM7Bi8+4Sl0FCvjR1II2Wa4KGiWQVlmTwQlmWiLQ3kFMbxDXbWSGiwJ7kK3lk7w6sfs75S9q0XqWjiGWsZZA/pmHiQNvt9MKJTAJessO80BzW5QDexwClRClnJ2aVTtsOeyBQ8H5wnQHmG+X1w/BwQRd0YPOgYC/ArexuYcqnnLeSzLa5VLwR1/h5IOiPY8qGT08mjVuV67A0e9DcDNQMlhnHBW5rS3z9aT1ckyXtTx2Z6jZ8plsuUuZEsePiIMv7KY2gnQbiyI5rYw8T2xQz24gI/nxi1uXu1vXXlHBlbKYqSRfxTquLU2UV2S/xNWPyaEevy8/2rfg0yxziTumvJWC3SZOniWpEKCFnL+ib8Op4hSMBlEWD7/8uaWi6MgmspaRtnc7VW2TTgEojJhm7OtCI+P8bAnwyzzugCLPOvPIjr83ocuHjyKdo9Lly//VfBvdPUHnbfhwz7dARgmLVzqpmn2RLFgfBXHkSXs9zEuU7pUclQr9EZZLBUVTE8KcV3xVgv3Z/gxLskY8s4LQw33G7GhTrdSHjsepocjSJ9XMbIpiEcNY2Nt1VMhOHQbWBPUnCIa9EUrdpRU4V7B0382kp5bLhccmzTDtWRyTWsyJVLuMyWMO8CgPvIQgh+7tlOE6B4GAl1oQQsg5QIQgCHd/dh+MyEHTDxZC7qbkrtb+qutCONnHZyXoKO8YAxKVBicGzwyfdWjRLekXGCJeC/+1eIBdd87CxxPfd/SyDIB878pZR0RN0/NBKRLF/G3vOSzw+nNdT6FmRxLgO/59/FU9lqBvbpyzokxJWrckQhmXvEx1O5kjLD4BDrO74p4itRWm4CYUAQIpoiOgTOksB6DnEkz/V65uAWwqgfXGMyyP3K8uQm7cSgyCmo+tae2uDpRjSpfmV/tjt6NDTI5Tpbas+Elch+hlFJu10sDOfyOOCN8LLK zeX7J5Vd UnxOS0wjYJSuIqU+1LlCjQHi1mgKRYLiz98TuiLtzfZ7c66Q5qpWnx1lOV70W9caqh4m+/7RNuOpseH0xaiSkEH25TxJJJZv8ZCFLOpVkRGL/AaeaVD7tqXJKN7a53pu+62wqR023eABI+QrDd+zfhA0FkSadxfF3S2kBLuAyUUjgKXoDM5SCeHJ62HnWduHukn/pEiwZMVHzP15dPyOaFJ30LgR95kkExObDBvl7EoMmrkZc2/Z5JrbckRs5WwIRjfMi6vXXKDchNBGsBWbiZEg7NBNf4PEQ4VhHLIhUjxiipdlLHF/cbiAh0qqt8PMg9MQlIfFP8FMdmkAD0GzqChh+pY9jORwsexR8+H1PYivzu5iQTkIIreeYZGL8jVVkmSW9wcfZg7MerXxAMjhVqe2hLZbjv81us5Uf5NQ4fMPfMGTT05f5AMpcjc2ZvsUyQ60Fa2aivgk8nzs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Chen Yu, On 02/04/25 06:36, Chen Yu wrote: > On system with NUMA balancing enabled, it is found that tracking > the task activities due to NUMA balancing is helpful. NUMA balancing > has two mechanisms for task migration: one is to migrate the task to > an idle CPU in its preferred node, the other is to swap tasks on > different nodes if they are on each other's preferred node. > > The kernel already has NUMA page migration statistics in > /sys/fs/cgroup/mytest/memory.stat and /proc/{PID}/sched. > but does not have statistics for task migration/swap. > Add the task migration and swap count accordingly. > > The following two new fields: > > numa_task_migrated > numa_task_swapped > > will be displayed in both > /sys/fs/cgroup/{GROUP}/memory.stat and /proc/{PID}/sched I applied this patch, but I still don't see the two new fields in /proc/{PID}/sched. Am I missing any additional steps? Thanks, Madadi Vineeth Reddy > > Previous RFC version can be found here: > https://lore.kernel.org/lkml/1847c5ef828ad4835a35e3a54b88d2e13bce0eea.1740483690.git.yu.c.chen@intel.com/ > > Signed-off-by: Chen Yu > --- > RFC->v1: Rename the nr_numa_task_migrated to > numa_task_migrated, and nr_numa_task_swapped > numa_task_swapped in /proc/{PID}/sched, > so both cgroup's memory.stat and task's > sched have the same field name. > --- > include/linux/sched.h | 4 ++++ > include/linux/vm_event_item.h | 2 ++ > kernel/sched/core.c | 10 ++++++++-- > kernel/sched/debug.c | 4 ++++ > mm/memcontrol.c | 2 ++ > mm/vmstat.c | 2 ++ > 6 files changed, 22 insertions(+), 2 deletions(-)