From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CCDBC74A5B for ; Wed, 29 Mar 2023 23:31:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DAF016B0075; Wed, 29 Mar 2023 19:31:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D38336B007B; Wed, 29 Mar 2023 19:31:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB1FB6B007D; Wed, 29 Mar 2023 19:31:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A76626B0075 for ; Wed, 29 Mar 2023 19:31:20 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8955012074B for ; Wed, 29 Mar 2023 23:31:20 +0000 (UTC) X-FDA: 80623534320.11.175FDED Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by imf28.hostedemail.com (Postfix) with ESMTP id 19C67C0014 for ; Wed, 29 Mar 2023 23:31:17 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=Zjg7dg8p; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=Ca2fO6rc; spf=pass (imf28.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680132678; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SuIhUSYu9mlDLVk/42hpUGYhE6FgIDE6xMsSHGOH+GY=; b=YznSe0uMSLQgfLlFDscMEdny6ik2kr2WTVpw3tN0b450ruXN17tv//GGxSHBNjMJ0FaZbG e0U4dcOQ/TAnUgJCD+EMhZc8aRS5H1ELiLs5Kwx9Vy61xL2a30JG17DhElZti9bi4xgO/M lRBj46FlZ+aJwHBXjRjFTZvf5aHgBKM= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=Zjg7dg8p; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=Ca2fO6rc; spf=pass (imf28.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680132678; a=rsa-sha256; cv=none; b=Sx8aFkkJPBbZhkpQAi9cknVbjZnUToeoqZOYok3aTZs/yTDWWshqbUq5spprGHbyte+5S8 cso7I4nYyeQIEvdWoAomax0TBC9pN16xJrlIwsYWZJ2L1nz5RIPHOA1SLuWjjGYl2gAH0l e1mW8OGy/Tudqo+X8zdCpsj7xX+cPPo= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1680132678; x=1711668678; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=UNlm9Cgnb69c4/O/u7KM3nCJu6vgziKIZ4YaTqHtuUE=; b=Zjg7dg8p+fjLvNjK85BbXq/dPqHa7FY63D9N7TjaILgZtYXJzQp04Lbj T3HoMvrPtyxVfJObcJogfKLakV6t/8XMIcOfmUPOPKHtEgNDQvhALmJPd IgnPaHI9lnst/7NajeSMpKNzxg3AJtfS2OX/quWbHnegqeZ0v9OrOaf2T ATERS2Itsocp2zPaXbApE3VahiI5x6IiE9MrTdwiaIIVTDIDuLws2jZuV tfA5MvY+FqH7aGEz80vGuv3QAO29wtT8Ixcfsn4kpejCb2ea72THy418U bMYw+YzLQpYU4x7OvTfiXF9ibMhvg5aVVwiYIOCrZDY2xt7B6abqGeijT A==; X-IronPort-AV: E=Sophos;i="5.98,301,1673884800"; d="scan'208";a="231808511" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 30 Mar 2023 07:31:16 +0800 IronPort-SDR: PIHw+glwwpW0bbCb7maMcxFE4RggX1b1Y5Hl13cVuetODAMwrS/OXxCgrHORUSYernUsrDo3+G cMb3z643emE3VRcq94kyOQ3Z0XMjaWZeFC8rjysxwoZI2XZPJdx/lJ98zCZl4U/8I/AXKoFUDV c6Nm+2P8I7/I1GGlCgQlr6sOXwhjWPTY2nvkDoxS0VpwpkGZGvSdORm4W343arWrkR77sFCxFB NDEqXQ/eBnmFg5UDlDo2a+NAauP+CrVvC0ilfJB0DegRzO7e7aaLoX19JdNCagDgd9u064oJSk C8Q= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 15:47:25 -0700 IronPort-SDR: qSTOd9EkGDZtZk63x80DjQfNrLnfU5ANRIwPk8iip0mcHMI/K7qyoL/1zPTjpldPbZC381jS20 scxK/JWpKoSPLNp22oThniGUZWj6Z+Ed2b2pkKRd84b2m0XcumKrrx0i1i6aQfWbi6E9F1/m3k +G2FyKrMZXeo9j1nalyiOPvOCcRIy5FmtL+lX0cfqpZPRNV8aJczYNoXqorbM9FmrVt+MDaFsz LBkJDF1vPf9klOtih6Vv7WfMk3T6lmw1cm8v9C1HRvWTIIKifQVrsOO2CS94VvFyRkydXsF5ek IaA= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 16:31:16 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Pn2qm0ncjz1RtW4 for ; Wed, 29 Mar 2023 16:31:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1680132675; x=1682724676; bh=UNlm9Cgnb69c4/O/u7KM3nCJu6vgziKIZ4Y aTqHtuUE=; b=Ca2fO6rcxglppHNXYxRAHziKkRlfWQdPRtKcotDpyHFiP/dqL1l +eRINX7r2eICbC4KQtNpc23E7B6cTVrRj9Ksclu4Jqd/OhE7FGf0WFts4RSkNvRZ vyDh64QjNua4rA3LG9nobAs9hY5rxbY67Vr2/TNnOHh89mZ8LeAkwGHM4RGHVU7Q G2zLU+l3brOhyc7kjdil5v6zpK4QdjwQTJ4zW86BPD9Cb/sL1GpTuVvrOGcehbqI 6BtW6hfXgSgZ2432WxO3xb5C7AONp6W2nDb+sKaqwGk9QuSWfywQR32EdxP4QOPx RFADdkCfux4rv8H/ZisxP0MjM4uYkF1VzgA== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id OXnjfUvfqdae for ; Wed, 29 Mar 2023 16:31:15 -0700 (PDT) Received: from [10.225.163.116] (unknown [10.225.163.116]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Pn2qh3MbGz1RtVm; Wed, 29 Mar 2023 16:31:12 -0700 (PDT) Message-ID: <3ba0a4e1-7b75-9d0c-d6d3-dfc3d4bbbef0@opensource.wdc.com> Date: Thu, 30 Mar 2023 08:31:11 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 04/19] fs: buffer: use __bio_add_page to add single page to bio Content-Language: en-US To: Johannes Thumshirn , Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org References: <56321f8ef1e70e9e541074593575b74d3e25ade2.1680108414.git.johannes.thumshirn@wdc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <56321f8ef1e70e9e541074593575b74d3e25ade2.1680108414.git.johannes.thumshirn@wdc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 19C67C0014 X-Stat-Signature: ppf89dxfq7zxo9t4qssa8dw7a5pe6aek X-HE-Tag: 1680132677-689244 X-HE-Meta: U2FsdGVkX1+rMYwBswF3bLWyhjSySfhFTt0zewj4iUPI9ckzQn8+JufvfbV7JfJCDs3rZkjcc64hkhVYf4RddjspHIbRrx9T1IbQKgnInc1n6xD2vqD5kSQIuEWzvzlCThIqMOJFv9XAyOFevstU70dKAe4cGqWfIBpTs1v1zOUpOemMOac2ZvMD0Ug9gVtiiGg17SCxHruWznggK4IhXjC9moC+Lu4j/AOXvEn7ZCUK2ib+EjV2NJtGO6ViiiIs7MuCChoN6QnhMI3y7dUfuvBojizy6BJUgtZSN9BqOk5dA4Lhiq6LjwrW0KqW2QMIwdiiOVULCXfAHwYjwx+Btcei5GjFzA8sG/x4Ey3NUsiurBKoIdxgaQBTeAxd9UM8kYDMUCzA2St3ThvIrYBCNm91snst/t59xqZT03ZGuI878FWvEWyZNrQyG+KFLG6YFiZXgv5ugZMzO++n1IxnGI6ouOOGSbnLblqxQ1rErCp2eBF6OepWmOPQpkr7Fh7nwRT74hp679YzejYBPtfknDVlGhpVDeWrBibUrnTbyVSqORqa+T8RGBch3vzVRtmirinW4K+Oi4wZH/ZwApnGKav0yfaQYesEoTObIiEUJ1x0TBkNrxtZxi5UjHfoKr8kB2oxgX5L3vBwKgBal5IAqxQva0Hni9DDoI8uEK08C6vOnZ7OlAZiGrLwAH7lsQKsAa6/XTvy9ZZs4/ufyftSS3kHnpoWx8LnxcjbKPvE298/kP3w7UKuuKvcReNA/Pnx65F2WsVmGifAqzOMiBJahyXS1JyksulzS571Zi53GfgZDa7MgYlccEa4C2qYR6hLAOIWvN3oNYLaSyB07xiVAB7pb+4hJUdVYxTkggNdxSIs9nJO2Mt64n1Sk3QMp0IfLAz/+IZ+m5Iu4eyIHvWzoiUP7UJcn7RMswJ9h9LNlxE0ajUic0fnDm/HrVQ8+P+YEXPDWIUiUV/xo422GfY Ap/Rjs2h lvnPv1HvVqKxrpSoeYqOspkJ9Dyaj8HfQIKTyHtDOCpeRYJJvQp+JwI8hEd2MTwjxq+pzlD6G1nuGeDQ6uhNTUWLB3qk5DCT66fkXeWEGpb8UNvVGbLBhi/Pb2GQBdQcT3XQhmtWHgVANRx5u4KUsJsLOjhRpqUk9JZvEzsuLQ5MLtDM+eGFyZBUR4pOT0iWxsJtz4EyQQt4IpOqOgh9B9qXiA0/hwtgH1SyNWs3vYhFSKvcsWp8qNjvR4to36MGJ3frxl7+jKWpMuGzV/91ioD9zvhMrwFsdV3wqUnSLafCjIfssS5mCcAX2iKgwBVkR4P/gSxQfdUM7/WWXwYXNCsnAGsTE6DLuaWrM+4f3eeOMYU57RL7leGbHJ+EOot1htXglebAuFVS7AINVczZlRmcsJYwPAvrdUoZ8UxpEmQDISCpV+elSGoHHj9lM7YZdI49cPFmJINl8Vh7ZcN9OQt7GkZ+xRYXn4nVLlFXIpGWBmwBZ2M6R2rjsFcBsLm/8ERQtooK0Ya16KVBMWpDrHK4QDgPULoS07D4N6goxinyJo5MvCD//G4WfvfL9JlZutAhAU9GCLh8Do8UCk/jmht6XHcPor7WeRUFOIUo1OaVdRWKSznZRgeCpoZXSGsg2LzpjH4Hjg6Ied3vUg2SNVnU7lj0IUVimc7MYSiUAdpVWgK0HNI4BusTzhA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/30/23 02:05, Johannes Thumshirn wrote: > The buffer_head submission code uses bio_add_page() to add a page to a > newly created bio. bio_add_page() can fail, but the return value is never > checked. > > Use __bio_add_page() as adding a single page to a newly created bio is > guaranteed to succeed. > > This brings us a step closer to marking bio_add_page() as __must_check. > > Signed-off-by: Johannes Thumshirn Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research