From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B33C0D7832F for ; Mon, 2 Dec 2024 15:56:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4683B6B0085; Mon, 2 Dec 2024 10:56:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 417AE6B0088; Mon, 2 Dec 2024 10:56:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DF3F6B0089; Mon, 2 Dec 2024 10:56:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 102966B0085 for ; Mon, 2 Dec 2024 10:56:34 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B65334203C for ; Mon, 2 Dec 2024 15:56:33 +0000 (UTC) X-FDA: 82850470962.07.96BE4D2 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by imf21.hostedemail.com (Postfix) with ESMTP id 6993E1C001E for ; Mon, 2 Dec 2024 15:56:08 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b="epBVXn7/"; spf=pass (imf21.hostedemail.com: domain of quic_jjohnson@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_jjohnson@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733154980; a=rsa-sha256; cv=none; b=3mzHHEGLrLzUnN/qskmtPuGGFMMvU9ALyLDsY3kgUTZ1mRyO82IRhcO9UF+sdfNDvxdfo0 V1WC96oUMqgc6RbqfojjtCDyJozq4q8G0B3L0pfF5cXmV7IgPf/TFoKrD9ZJ8kysL5Ed29 aYqi/+8lJZlSSkEyFBNFwV5/FJI+f90= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b="epBVXn7/"; spf=pass (imf21.hostedemail.com: domain of quic_jjohnson@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_jjohnson@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733154980; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4KX6/MWUVKSnemowOD8s5zQJLgs/M/OAtcQuDIuKaI0=; b=PdSNv7lRWDuBJ4eJS2xQMrW+EYyBfUBw+wqn0n8YsvxpsQ2pfS38zx1eRns61baIEo4bwH i5wfNtRc4Ab8GEQ//YdHrWPrP24sm0FVMLr6SMGny677osmY0U5w+A654aBOE5QfrrTQuN EjMaS/Cpn/Z77yOeWQSrh36sIT+69sM= Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4B28oj7t010215; Mon, 2 Dec 2024 15:56:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4KX6/MWUVKSnemowOD8s5zQJLgs/M/OAtcQuDIuKaI0=; b=epBVXn7/KuI9LGvg TlY6FNZVox3ap3kg3bD5YXGge0tyspb06cVgMUBvrSlvCAWh1Aa6xIh3QdhCAhYO qHFm9nU80eyy5btOTGKGUeuZIkPRYn2nsT/jO47jlGeEtIehsWNo1f7qaSXx1cdd 4Nuaf/+D2jtvR9PtMR+/mZ77/SlPPjvORtSEOVUhgiCzdikqu3Tyu0DnGMUQLxvW 8KTkAXz8NiBpB22+ksH+HT3X4te6L+cBPLJvC7wSI1R6rOEf1gCFaPLpLcr4MRgT +Hkbp+m5gbFAuuIF4I3ph4/pUiN7HnapXl2YRhPqz9u65nTIcvJGbULGOXRWktHP eDbzYQ== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 437t1gdbsu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 02 Dec 2024 15:56:26 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4B2FuPij019234 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 2 Dec 2024 15:56:25 GMT Received: from [10.81.24.74] (10.49.16.6) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 2 Dec 2024 07:56:25 -0800 Message-ID: <3b8e8227-82d3-41c9-89d3-e70de1afa43e@quicinc.com> Date: Mon, 2 Dec 2024 07:56:24 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 4/4] Add base implementation of an MFS To: Bijan Tabatabai , , , CC: , , , References: <20241122203830.2381905-1-btabatabai@wisc.edu> <20241122203830.2381905-5-btabatabai@wisc.edu> From: Jeff Johnson Content-Language: en-US In-Reply-To: <20241122203830.2381905-5-btabatabai@wisc.edu> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01a.na.qualcomm.com (10.47.209.196) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: N_2rXqtcJ5ENEIEtl5tkPwT6AGsvBhpZ X-Proofpoint-ORIG-GUID: N_2rXqtcJ5ENEIEtl5tkPwT6AGsvBhpZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 mlxscore=0 malwarescore=0 spamscore=0 priorityscore=1501 clxscore=1011 suspectscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412020137 X-Rspamd-Queue-Id: 6993E1C001E X-Stat-Signature: 54zo5wotm15t7tw48u95ebwpwuirnf6y X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1733154968-524460 X-HE-Meta: U2FsdGVkX1+XKxz0GjsfZVpn9h0MYX9lHDSTUyoJ0y4fXCZZOucMMpTXcBh/kmwXSaYums/00L+q6KabTO5tiHinD6vB6hNSFpBGbnL27X7E8YEd/+rFnH9ixdF4kn+UDhWQ0p76nOMaVf37vaulA7dpEgohaW8Ovuhy6xZZoOB0LzbRvzQuaaIwGXVQE9K44Got1zGEVQ0d+percOIOymvAP3PjveKGurMVuZ4553yfUDAL4yeIoKZlQLXeOxOsQmNuiskLHYKr1KgXo/g3tqQaE72uX3sXFpMX7pf3whaQuleSgoMXxz6vMtJPkCvkamQxASzroPhUDtVPFQdzcLIIAnDbQI5xVgjIhaFgL5LXlwr3CmoIKcFeCy6PgCfYWEpLpXIAyoOyM7FREeMM13NYvn2X/T9dkLzms+p/JdVww0pn0sp1D+OAnYRVPrrSK6p6BOWOqXMCcJMOD533eViIUsbT2EejsWxA9uBK4e0vO6Hq7uP0zt8RcvdAvb7vXsM1vFGpfENBd96F47pA1RzvkLEDQFr/m+3GlowO2eO6NGxzOov1ke1Q891spWJncMJqMr6534ADsW8VmCGUyZJB4KHleUSa6Kb7yXJtHBqs8HbuxKJVkBvhRd15S37qUIOWOFL1yNuOosW882i8b4JfS2CSN2ALze5FdZCHoQTBgOGs2BIToih56xD9l+frLMVk9AwrqalI8aD4Hh6IDgAZLJkjriwynS4WA/78EwlKFMasJXsFIkSDxPrFXKXR3Au5LPp/2AhFrHdOjjNyZA1mWkFivA+UuUZGv19ndONyWDXlRV/6ud8zHg/KCLJftLfX4PSWYlZefcDL/g41bbfVSBPK39Yibp2NnuCYAAQPpRMnjYeN4LAf1TP+b6jYzDVgk/H7jc+8JuZ5P8bKf1epvG7yKdQ3kJfVJlNOxSx1tFSr/CAuARie0/FgYjqIxMHolCAg4uPqnmJAJC3 qSaVmu9K pq45gkKmEIUTrt2QtmdGThecJaDReL44vGqJc28BqEhRa0R3sSoHiMQSntuVJu6ZjXZAuyxbmtySQ0BxiKkl7K6u9h0SRGVhzHLMk+Dtc5qeqSvAWPnHSubnb3M/ne4h2S1nvuWNvrPYYf9bRZ3c93lOxw57qDFO51syWg13lABm+EaL3jL0e/jTMd+yoyQrOrLkqsUITFDQxsuhEuuhopVh29KFEvoWV/S76xF4nHPu2rLozPwxutF40L4oksOniAOWEQYETLdp4xA6dqBFtqlXyAhuMxIUmekWCAcK2lpLagsM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/22/24 12:38, Bijan Tabatabai wrote: > Mount by running > sudo mount -t BasicMFS BasicMFS -o numpages= > > Where is the max number of 4KB pages it can use, and is > the directory to mount the filesystem to. > > This patch is meant to serve as a reference for the reviewers and is not > intended to be upstreamed. > > Signed-off-by: Bijan Tabatabai ... > +static int __init init_basicmfs(void) > +{ > + printk(KERN_INFO "Starting BasicMFS"); > + register_filesystem(&basicmfs_fs_type); > + > + return 0; > +} > +module_init(init_basicmfs); > + > +static void cleanup_basicmfs(void) > +{ > + printk(KERN_INFO "Removing BasicMFS"); > + unregister_filesystem(&basicmfs_fs_type); > +} > +module_exit(cleanup_basicmfs); > + > +MODULE_LICENSE("GPL"); > +MODULE_AUTHOR("Bijan Tabatabai"); Based on the other feedback it looks like this won't be accepted, but for completeness I have a specific commit check which flagged this patch. Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the description is missing"), a module without a MODULE_DESCRIPTION() will result in a warning when built with make W=1. Recently, multiple developers have been eradicating these warnings treewide, and very few (if any) are left, so please don't introduce a new one :) Please add the missing MODULE_DESCRIPTION() /jeff