linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Bijan Tabatabai <bijan311@gmail.com>,
	<linux-fsdevel@vger.kernel.org>, <linux-mm@kvack.org>,
	<btabatabai@wisc.edu>
Cc: <akpm@linux-foundation.org>, <viro@zeniv.linux.org.uk>,
	<brauner@kernel.org>, <mingo@redhat.com>
Subject: Re: [RFC PATCH 4/4] Add base implementation of an MFS
Date: Mon, 2 Dec 2024 07:56:24 -0800	[thread overview]
Message-ID: <3b8e8227-82d3-41c9-89d3-e70de1afa43e@quicinc.com> (raw)
In-Reply-To: <20241122203830.2381905-5-btabatabai@wisc.edu>

On 11/22/24 12:38, Bijan Tabatabai wrote:
> Mount by running
> sudo mount -t BasicMFS BasicMFS -o numpages=<pages> <mntdir>
> 
> Where <pages> is the max number of 4KB pages it can use, and <mntdir> is
> the directory to mount the filesystem to.
> 
> This patch is meant to serve as a reference for the reviewers and is not
> intended to be upstreamed.
> 
> Signed-off-by: Bijan Tabatabai <btabatabai@wisc.edu>
...
> +static int __init init_basicmfs(void)
> +{
> +	printk(KERN_INFO "Starting BasicMFS");
> +	register_filesystem(&basicmfs_fs_type);
> +
> +	return 0;
> +}
> +module_init(init_basicmfs);
> +
> +static void cleanup_basicmfs(void)
> +{
> +	printk(KERN_INFO "Removing BasicMFS");
> +	unregister_filesystem(&basicmfs_fs_type);
> +}
> +module_exit(cleanup_basicmfs);
> +
> +MODULE_LICENSE("GPL");
> +MODULE_AUTHOR("Bijan Tabatabai");

Based on the other feedback it looks like this won't be accepted, but
for completeness I have a specific commit check which flagged this patch.

Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
description is missing"), a module without a MODULE_DESCRIPTION() will
result in a warning when built with make W=1. Recently, multiple
developers have been eradicating these warnings treewide, and very few
(if any) are left, so please don't introduce a new one :)

Please add the missing MODULE_DESCRIPTION()

/jeff


  reply	other threads:[~2024-12-02 15:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-22 20:38 [RFC PATCH 0/4] Add support for File Based Memory Management Bijan Tabatabai
2024-11-22 20:38 ` [RFC PATCH 1/4] mm: " Bijan Tabatabai
2024-11-22 20:38 ` [RFC PATCH 2/4] fbmm: Add helper functions for FBMM MM Filesystems Bijan Tabatabai
2024-11-22 20:38 ` [RFC PATCH 3/4] mm: Export functions for writing " Bijan Tabatabai
2024-11-22 20:38 ` [RFC PATCH 4/4] Add base implementation of an MFS Bijan Tabatabai
2024-12-02 15:56   ` Jeff Johnson [this message]
2024-11-23 12:23 ` [RFC PATCH 0/4] Add support for File Based Memory Management Lorenzo Stoakes
2024-11-24 16:53   ` Bijan Tabatabai
2024-11-28 10:22   ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b8e8227-82d3-41c9-89d3-e70de1afa43e@quicinc.com \
    --to=quic_jjohnson@quicinc.com \
    --cc=akpm@linux-foundation.org \
    --cc=bijan311@gmail.com \
    --cc=brauner@kernel.org \
    --cc=btabatabai@wisc.edu \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox