From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B44EFD32D82 for ; Tue, 12 Nov 2024 10:06:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41E5F6B0085; Tue, 12 Nov 2024 05:06:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D7D46B00B1; Tue, 12 Nov 2024 05:06:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 295986B009D; Tue, 12 Nov 2024 05:06:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 07C8E8D0001 for ; Tue, 12 Nov 2024 05:06:48 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 867694173D for ; Tue, 12 Nov 2024 10:06:47 +0000 (UTC) X-FDA: 82777012710.21.1C89E40 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by imf09.hostedemail.com (Postfix) with ESMTP id 9F75E140007 for ; Tue, 12 Nov 2024 10:06:16 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=T9J2LnUV; dmarc=pass (policy=none) header.from=igalia.com; spf=pass (imf09.hostedemail.com: domain of andrealmeid@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=andrealmeid@igalia.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731405877; a=rsa-sha256; cv=none; b=KdXwg7M9Ba9/V515Bp+yqhlZuxNmoEx3x8dKMtdY55sm2ZLE2ot88qAlLnESEJ1k3K0ejE I2mKBCGILttO62OeYvF10lzUhZwCrDeBwFHotJ5aVTQ5wrudROG1E+huT3AcDQwDUmulAn LI9k9qfyQxzHzyD53E/x083EabfmLF8= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=T9J2LnUV; dmarc=pass (policy=none) header.from=igalia.com; spf=pass (imf09.hostedemail.com: domain of andrealmeid@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=andrealmeid@igalia.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731405877; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1pqRFrb7LJiNaHS4T5S4SpHG1gN5+IWgrYGFa1h/sYQ=; b=0IiN03/+c1HBRQywcEjeibayolBG16vRHSVq/zQz9j25/D0M5tI1itM0utzfbUmdk/o2ge WcoWI/OJgSkCeg4jELsvB10z8OB6cV05G+5/hF5sdzeaZbUZXptfPE117WNFcq2QVkx7Z5 rTmfQQl3mrjRyfoPuDMqSIiAzZ7nfWE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1pqRFrb7LJiNaHS4T5S4SpHG1gN5+IWgrYGFa1h/sYQ=; b=T9J2LnUVn48Az2kWIFhkaV0ZJl yibpGFPtsjSmnwZgQKRkWgQnj9tQRjZfOb04PCYHYsta4Ac2mNE21d0Q+CIsINTO921RznWn6Uw21 Yc/Nhrq18j9xewvkHovAx66NSg2+/yGljQgG/KyC2wJQNFntoFEAK3juqMQLqLP+4R/2bWucQrEUp 1gsmBVSzdf5BxiCWgczsPe3kDpw3UCi+liI9azMxXRbQSFwMbcBq9ICYFVxqgF6cnCSwcnem7YfgN XRjQURijnEyBzpToRYRypMweNDrVseo41TbCIaYuD2Et7tCuNO+c6AlUyF95KcjU5pM1QHZ35N0XX gkWnfM0w==; Received: from [179.118.191.54] (helo=[192.168.15.100]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1tAnnD-005pfX-BG; Tue, 12 Nov 2024 11:06:39 +0100 Message-ID: <3b865b4a-5d82-4d11-a60c-f4bea6cd25c0@igalia.com> Date: Tue, 12 Nov 2024 07:06:35 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH][next] mm: shmem: Fix error checking on utf8_parse_version failures To: Colin Ian King Cc: Hugh Dickins , linux-mm@kvack.org, Christian Brauner , Gabriel Krisman Bertazi , Andrew Morton , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241112095449.461196-1-colin.i.king@gmail.com> Content-Language: en-US From: =?UTF-8?Q?Andr=C3=A9_Almeida?= In-Reply-To: <20241112095449.461196-1-colin.i.king@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9F75E140007 X-Stat-Signature: pgzzmxbz5usetbety5iz3hpkzc4er7em X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1731405976-388118 X-HE-Meta: U2FsdGVkX18lDMo+tDXiAGVJZ+ve6KAaZKCZFyPGLhoWyKobFDOb8w1IFMNKGwZZuj1fBarJ/Oo49qMq+NWdmBPc67yeGu0FncVThA1Y09aXYTrTZYlKAg2xdIXQEiHu6Nb2xFEsg7NncxsWE20Mgmg3UmpTjrJqSnAnL8QnxE3U4E7CMitdLgH8psNxLkGea3I8A6bl+aDjSq3mwTdbAgeVQp/+6jtf7ukjK8P4F6INte5st84A141d/QFzjY03pkGE78a4D3KuuE9ZWs9x8EZtgc9VJS64os3rGd1HHSuFFSmz7fyXalJHI36lrL+TTkNeAMdsOnyKOoT5ugHUcmd7seAjuz2UMIuxFskz4uwYVZqKCSHL5CtGoBRVTLude+R1IKAjplPs8Fr/88YMTjUwpYOt9GzgixEA6NkCi+xRTtSk8XuQAuhDpr1BxQh85rTBGwlO0Ti7jENSPMCpY1HAXD1bCNUaEvH9/AX4hmO3AjmY70XQRsX0BEiRIZ3Vp+YigbYw6rA5E0iXW0n6Q/2alPfdRysNxKU7HMlyEr3LcPKy5bzCnuj+e7GzHbWh8IUoKVIdUITshAkAvH7Qj2/7X7kWXdDOxocxPL+XXoimpAhGWUKbc+vLBYwTkjU64AUjMoIlUoBlMI4o3K8jeLdZCfXdh7UJsNqkGduG3lG4i0sVJoz/2a7JeMYdm7XHhp5j4jfLgohcsqsOFzH85Aet/Cu5Y7ez10RB6w1iONQmsrlh8YzzzaRzr7Zxg42GWM1KhQ2lq7e/SDhBhTF1d/2NzdZ5DZkqg60pvvHUmWWw61tVUFd6BKctUNbFIlGcaWZfLSMMfnCUu0ixhL6rg7qN3Kn4n11t2nz0/g7m55sHTQwoxr7sXdIw06fCgLVdFcOsImmhh6xrYIBCC5rN/M6/TuBlHo5xUicYZQjpHc2jbH4f0lL1SuwuavRWmWaIbvPliWnvUqSfvi4kERh BKQctj8P LjszxlhWgY6m5ajMzhyjeOHYxRnZQTGvkr1L8RzDgPQnvvF2ioFRJKoanH8bQpWZyMTIDUHZTHHq3E3CqqXhIfTWxPBscOYEzHMlq7V5inzeJXZJWHrDESasn0CmUqM8idiF23RZrMDgodaVhr8PYg5Tgun15TGLih2DR4y58USSo2jeK8L9VGd456GUagPGiCKuiOOsFK1SPGFrMcX1aKwurz6/rU4kMpj77oDbrXTv/QnqSas4WKC23WVXmiOHWE9xmbU5DiYxOjlYx3Cv4tdNLeMisDfdBHVlRLnuaw3Z5kH3q4PTKE8qYfHvNIQb07h7mR5iTnlMY+80Ty+p+sJdPf+/8W+dJUAWHm1ocxqKHZIfjgUSls16QtRyXcH3dMzkABj7TDm4hjwqibp18E+aRDQrnsAkyJRJUSWjzuNZvmtlEqEUAe0x6oq81zUP06bT5lpzB47G+0Yw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Colin, Em 12/11/2024 06:54, Colin Ian King escreveu: > Currently the error check on the call to utf8_parse_version is always > false because version is an unsigned int and this can never be less > than zero. Because version is required to be an unsigned int, fix the > issue by casting it to int just for the error check. Why is it required to be an unsigned int? > > Fixes: 58e55efd6c72 ("tmpfs: Add casefold lookup support") > Signed-off-by: Colin Ian King Another fix was already sent: https://lore.kernel.org/lkml/20241111-unsignedcompare1601569-v1-1-c4a9c3c75a52@gmail.com/