From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B104C433EF for ; Mon, 28 Feb 2022 09:37:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE7968D0002; Mon, 28 Feb 2022 04:37:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A97518D0001; Mon, 28 Feb 2022 04:37:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 986D88D0002; Mon, 28 Feb 2022 04:37:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0169.hostedemail.com [216.40.44.169]) by kanga.kvack.org (Postfix) with ESMTP id 8642C8D0001 for ; Mon, 28 Feb 2022 04:37:51 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 068A28249980 for ; Mon, 28 Feb 2022 09:37:51 +0000 (UTC) X-FDA: 79191686742.29.E9B6E10 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 7BA14180003 for ; Mon, 28 Feb 2022 09:37:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646041070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O6xuI99PpvDDOODhlbvd9Uc1T3uVIjTSRXmL6hAEYXs=; b=b0Oecg70y75kS+Rhvfp4wLjXiM+jgIOAQeKQXWFAUHIE2q9XN8JltyOqxuwZhLhIYZ5hwD uJPg/dUDOCNjNr2pwJfSfeCrF/nq0XKJmJ4fY26+P8EKJfOcyX9S6OTg9mtRO7oA6bL6UD M6BpBjlMFiRoW4pwC1xIueCbGUTp2uI= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-648-YVcqdKjWMXqSXdgYatwSLw-1; Mon, 28 Feb 2022 04:37:48 -0500 X-MC-Unique: YVcqdKjWMXqSXdgYatwSLw-1 Received: by mail-wr1-f72.google.com with SMTP id o9-20020adfca09000000b001ea79f7edf8so1825017wrh.16 for ; Mon, 28 Feb 2022 01:37:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=O6xuI99PpvDDOODhlbvd9Uc1T3uVIjTSRXmL6hAEYXs=; b=kwYZK2MBXNjm39jB7HaNR8sZdxPBs0jXsZek7tyJuwPM/R2hPl3Sa/D+eEUAWRhyNT 5IUHTUrRRKSKzRGsQfm0wDEaSrR1k0Fyvzr6QNvIkLBMn0kiWXvB4aYlHG8dkHRtGUS6 15CnH0q3UNVz47zsS/K2KvVUes6d2KTlmrrcJBgLE09oWUrBtaE5IHAKIAxy0bkG3kYX VUmRymGBzNvFnF+qdQQf1ooMb0hnEKdVMnAIQr13Gfh4gyWfNw6+k+9bMDNvl7R2mJM3 ++c33y1VVNQvomhliu/wbdtZ2rcgFq0TNBe54a06B5FIl2oqA0XUWYSxr7kWkX5jy4Iq Oeng== X-Gm-Message-State: AOAM531rSFCfGy3TRAMmf3k4hYQapx9XRlGHejl2S/6QtrR+uQJgXyf8 ayw6ArHgOJBNcjqZ6hg3N1OPeFSAMLLGU9PZ9s/4yMbTv5Mfw+Zm4tWgDc15htN+QbeK9XAs5fM 2HDz6mFVcego= X-Received: by 2002:a05:600c:68b:b0:380:d3e3:5bac with SMTP id a11-20020a05600c068b00b00380d3e35bacmr12725265wmn.127.1646041067484; Mon, 28 Feb 2022 01:37:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJxhW7y7soOEk6w3DJYoM93NX0XSqq5ao6PuHL/oQN6/HEeVH+4iT1S317aR4vg+JubPxFR9UQ== X-Received: by 2002:a05:600c:68b:b0:380:d3e3:5bac with SMTP id a11-20020a05600c068b00b00380d3e35bacmr12725255wmn.127.1646041067304; Mon, 28 Feb 2022 01:37:47 -0800 (PST) Received: from ?IPV6:2003:cb:c702:9700:f1d:e242:33b4:67f? (p200300cbc70297000f1de24233b4067f.dip0.t-ipconnect.de. [2003:cb:c702:9700:f1d:e242:33b4:67f]) by smtp.gmail.com with ESMTPSA id a17-20020a5d5091000000b001edb61b2687sm14108652wrt.63.2022.02.28.01.37.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Feb 2022 01:37:46 -0800 (PST) Message-ID: <3b7c068b-ac7e-62fc-f0cd-a8dbf8642876@redhat.com> Date: Mon, 28 Feb 2022 10:37:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH V3] selftests: vm: Add test for Soft-Dirty PTE bit To: Muhammad Usama Anjum , Andrew Morton , Shuah Khan Cc: kernel@collabora.com, kernelci@groups.io, Will Deacon , Gabriel Krisman Bertazi , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20220224212335.3045905-1-usama.anjum@collabora.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220224212335.3045905-1-usama.anjum@collabora.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 7BA14180003 X-Stat-Signature: y6dqzu7em8no5kfkrync5egh5q84cktf Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=b0Oecg70; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf16.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-HE-Tag: 1646041070-655741 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000159, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 24.02.22 22:23, Muhammad Usama Anjum wrote: > This introduces three tests: > 1) Sanity check soft dirty basic semantics: allocate area, clean, dirty, > check if the SD bit flipped. > 2) Check VMA reuse: validate the VM_SOFTDIRTY usage > 3) Check soft-dirty on huge pages > > This was motivated by Will Deacon's fix commit 912efa17e512 ("mm: proc: > Invalidate TLB after clearing soft-dirty page state"). I was tracking the > same issue that he fixed, and this test would have caught it. > A note that madv_populate.c already contains some SOFTDIRTY tests regarding MADV_POPULATE. Eventually we want to factor out softdirty/pagemap handling+checks for easier reuse. -- Thanks, David / dhildenb