From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F862EED617 for ; Thu, 12 Sep 2024 16:10:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC5606B0092; Thu, 12 Sep 2024 12:10:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4E3E6B0093; Thu, 12 Sep 2024 12:10:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF0106B0095; Thu, 12 Sep 2024 12:10:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8C2036B0092 for ; Thu, 12 Sep 2024 12:10:09 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2A36380FAA for ; Thu, 12 Sep 2024 16:10:09 +0000 (UTC) X-FDA: 82556572938.18.A04815E Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by imf25.hostedemail.com (Postfix) with ESMTP id 1DBA7A0025 for ; Thu, 12 Sep 2024 16:10:06 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=gzo9mUbL; spf=pass (imf25.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.54 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726157302; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X4YRLuNUgSWopISY8++0gxqGMIlZgrgvlLfTtwvHiqc=; b=tMWWnZltwWHAjtHc0ICEiPc3THOxYe9NZMWdEVz62eQbPe0BnY9BXz33nW8j4AgHgdRHYP ZAonIh2BhjZPDNZvbt52SeCZ0dp3cGCeFO7PWKpps+Vtig+h02/uhTLuGbmLXwT5b12oK3 9JzJaIL2NByEAFtYKyKbbV99OoX49lU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726157302; a=rsa-sha256; cv=none; b=stYx05AZSvm4oISGOJoHEoN4n37VZCempz5iAQyioJ4eMDQk08PF7wtAYrjJ3DYi5wfRk2 oaYTQLWSBc2TMAU71z8FPvcikd9+ysbmI/AwlCeEObNQRvVes+OxffTEEphqctiu4GrMOr OGYp8h09ITyGC2ccKXyGlxZ+appsqzg= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=gzo9mUbL; spf=pass (imf25.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.54 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org Received: by mail-io1-f54.google.com with SMTP id ca18e2360f4ac-82a109bc459so75589939f.1 for ; Thu, 12 Sep 2024 09:10:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1726157406; x=1726762206; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=X4YRLuNUgSWopISY8++0gxqGMIlZgrgvlLfTtwvHiqc=; b=gzo9mUbLkLDJbk/Kdl93GNxakuafxEY0ITDDq2YjoatXxznWa26Z6pMIYaMYgmIdBB NaH/wfTUT52nCc6F+mRlR0p6w2b2JldXD0H62nCTfQ5VhSmqphP4FH0YaQxb3fzOLh/3 +QX49ZZU8IiGinOAPo9fRFu/unSZLZukvA7K8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726157406; x=1726762206; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=X4YRLuNUgSWopISY8++0gxqGMIlZgrgvlLfTtwvHiqc=; b=u1JBYzjggjNsN5+BbBGiG/OFu0+onJPsXtJ8nbYrzXHARHSr2Gsd2vQPdUpJugDTYG 0Drpt991O8sSwxeSu+X3kuHFcia5odbouxF3jR+rS9YlRFqnNzNNVCXTgrML/q+7MhpC Gosj4bbJ/dV77/4qLTbVLY+8DhIglyq7sUW+evVlf5DD2byD48UV5baCYVpk660iej/B jNtiHMStYjFv/8XhDABJwL4fIs9G2SymlbqHtuGr4YyEXpIYPyiLUgPUeSOP0QNx/iDy ImZhGteFek7w9I+GS5yo/Em/ApNzu/EUgZbBpSmS691grpF95hQxxiyHpdNz6OrIv9IV v4PA== X-Forwarded-Encrypted: i=1; AJvYcCXntpw6yKmZw8uBUD81rQuJ5BIuctFAIqGIHM+AaatSX3FQoHpNg/2oIEdNoWiLeSOIei+zj60HYA==@kvack.org X-Gm-Message-State: AOJu0YyHwnGrNVjdGUhEN0par6SWqLlOFM3zjfZXyzw+FdDhhd+o/Pgh ThVZDK08gh9ojQ4vVP5bG6TopoLTjQhUlGQNzY6j5kZv0SWCyOpfc/PhDmTX1bU= X-Google-Smtp-Source: AGHT+IGnS9TE/OydSI4yqMHXeq5iZE4Pmnu5pLtOOIdRRqk2ravQJ1hGZCVSj5FbU4ycOavc1l8rFA== X-Received: by 2002:a05:6e02:1565:b0:39f:5783:fbbb with SMTP id e9e14a558f8ab-3a084611adamr24909165ab.3.1726157405966; Thu, 12 Sep 2024 09:10:05 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3a059016161sm32481005ab.73.2024.09.12.09.10.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Sep 2024 09:10:05 -0700 (PDT) Message-ID: <3b700650-159d-45ad-91a3-59fca3019766@linuxfoundation.org> Date: Thu, 12 Sep 2024 10:10:04 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] kselftests: mm: Fail the test if userfaultfd syscall isn't found To: Muhammad Usama Anjum , Andrew Morton , Shuah Khan Cc: kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20240912103151.1520254-1-usama.anjum@collabora.com> <20240912103151.1520254-2-usama.anjum@collabora.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240912103151.1520254-2-usama.anjum@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1DBA7A0025 X-Stat-Signature: 6gjuxdeprutqsrgg4paus31rt5u81p54 X-HE-Tag: 1726157406-601232 X-HE-Meta: U2FsdGVkX18edOmkAcEE8OL+nQ4Dq48cy+8kKQa5mTjY/vDKqOBx4OtRAsV9qNz0d+RuUVva9gHluM7R34uwyeuiAw/6BZe+IZmTWeGZz3Z+bSQiJHIwDrmuVSHj1XR4P7z9snFlwAXm8eh9DlNSnyb5DlWfi++q+blZehDMlGeO2CIRoPgwr8b2AMq3haa/fLj87PXpHCl+lrpI8I3y67Hz7txnb00YriUc4Lj3g1FbSagcutOdYzgjh8mLSDQs55bIQIAscBoiFBX7VDlu+fgOjbc66JE+jU1ID24Pyz53CHz/yVH9wzuLd2zDIzkMbtQCX9asLw7TUe0Jx5NLn0gxeK0yFrPx14Kavh0q23ktWHQlVjH/BD5QQ8jlG0vJzGeqDmu3cpBecOgoB5fRE0beSsW++NppmdgF0YnET10AciLnEf5LCqJXLCHtDvQp7848RNZpM5Wm76APTfrl23wQNWGHqqhgbqyMqKc38+/FqC6QpiN5eT/P1NaRwT45xUh+p+iywJCVjfnmE9FcpsJJUZoID+75AkxLZUTk1mhZl0Gth6X6YI59p5H7VYoKHKMA9GpXFkBT46Z7DCCL8xC7rSBmwdT8AXHSfbbzlBkfui/pZKGa7VI5qyNLIXH217MwGGfM1KEy/XTM15rKa5VbPs8mGDEAyTiBaD04TSroTeI3HWcF6LsRIik65WFIySU15B3IP5zWSQrchzbYDFsnJzIth8NIm71rEJXhgPKiRQNyqZukKlWolecPhV/pabwrt+esyMwrMVDIHAsTv9cAjKGyawv87pjq5Zm4PszSsMI+KkatT8QmVeVy8rzjMkRXLDov9WZKAhCskq6kJKIcN6B8k0AdkDMOXI7cZ/iRFgQ32rMtD50xyGkP4+4TlBl2ZFwAP3A1r7N1A97kLTro5zXvFpGJNhGnDpGF65RzHf1kAP7DW7SwjBCfVCpgEGL5cVt83q2g6RZtePZ NFl59dC4 9wgcKk9mgvAi5yf9K4MiyVRyH2cgNu7qwV/57LcybJ+gAHX/uoLh1bT7voe70o0F3LfOmIe5LC3hzmDbAZPRTgiQuZFDoOxhyJ5Mn95KbO5FL+NIcYx+FYLeFRUiKqyOf6BoDm8QML63geTKpAFvur7yXmWVGmgNOec7jOpkdCSfEpQa5FcoyChHhbbdwTN8bkxACX/Z5UuznJ8wNSFqcoQAqQ0oSpaoxPXLmj9iBWj/ImHGnsXZzGP7Dno7QnRVEvJPptPxZMw8PsgQzQCUM1kgEjDmrRRI9CZWsgfRJhIfrAN4KAEeBIfQMZ3p4K7UVvwIKmEd/Oa2xxv75O+g+KwGlmXs7yT5i826I0a5iriJxWjDRHa9U6deJzeqb5pki6oDL X-Bogosity: Ham, tests=bogofilter, spamicity=0.001445, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/12/24 04:31, Muhammad Usama Anjum wrote: > The userfaultfd is enabled in the config fragment of mm selftest suite. > It must always be present. If it isn't present, we should throw error > and not just skip. This would have helped us catch the test breakage. Please elaborate on this to help understand the what breakage was missed. Also this commit log doesn't look right to me. syscall() could fail for any reason. Do you mean to see skip is incorrect in this error leg? Please see comments below. > Adding this now to catch the future breakages. > > Signed-off-by: Muhammad Usama Anjum > --- > tools/testing/selftests/mm/pagemap_ioctl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/pagemap_ioctl.c b/tools/testing/selftests/mm/pagemap_ioctl.c > index bcc73b4e805c6..d83dda8edf62c 100644 > --- a/tools/testing/selftests/mm/pagemap_ioctl.c > +++ b/tools/testing/selftests/mm/pagemap_ioctl.c > @@ -95,7 +95,7 @@ int init_uffd(void) > > uffd = syscall(__NR_userfaultfd, O_CLOEXEC | O_NONBLOCK | UFFD_USER_MODE_ONLY); > if (uffd == -1) > - return uffd; > + ksft_exit_fail_perror("Userfaultfd syscall failed"); This looks wrong to me - Is missing config the only reason this syscall would fail? > > uffdio_api.api = UFFD_API; > uffdio_api.features = UFFD_FEATURE_WP_UNPOPULATED | UFFD_FEATURE_WP_ASYNC | thanks, -- Shuah