From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 050B4C7EE32 for ; Thu, 26 Jun 2025 10:52:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 419266B009B; Thu, 26 Jun 2025 06:52:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F08F6B009C; Thu, 26 Jun 2025 06:52:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32D8B6B009D; Thu, 26 Jun 2025 06:52:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 21AEF6B009B for ; Thu, 26 Jun 2025 06:52:45 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 957E812033C for ; Thu, 26 Jun 2025 10:52:44 +0000 (UTC) X-FDA: 83597238648.14.0752C72 Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) by imf25.hostedemail.com (Postfix) with ESMTP id 5E1CBA0007 for ; Thu, 26 Jun 2025 10:52:42 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.236.30 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu; dmarc=pass (policy=quarantine) header.from=csgroup.eu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750935162; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JNPRNVa0NXAIt/TPNv1Il9lD8lH58j3TXeT6bKfk/5M=; b=qQbfvPVYL9P7ePMkPXxAfLdR1vGSsrjUFA6/9PqOsBgrjDSaIUojhlvKiKymvDg1Chu+vH hMKNtH74B4098GFPiw8Y3BQJzpMrVVURYBCB+PK3vclx0MtEYc9t4ylZAePHbWTgTeNJFm //yhtgm7GyZ86YGLolPTHFy9AYtmjIQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750935162; a=rsa-sha256; cv=none; b=zJLRXI2JPJr9POTCNIH6nr1tzujTDXTsS4xmdPEy3BtvHL0aEZIrmKUIVaanDhW43WfiWs 8Kpk4BZICcPL84FCnKH136gSv75/ee1Q605VeUpuHatRSnXfmxtuFhGPZRXZgJo6YIkgcq 2MoYyK3xAkKjHbQHktQvSDUb1BanfXw= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.236.30 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu; dmarc=pass (policy=quarantine) header.from=csgroup.eu Received: from localhost (mailhub3.si.c-s.fr [192.168.12.233]) by localhost (Postfix) with ESMTP id 4bSbB02K49z9vGJ; Thu, 26 Jun 2025 12:52:40 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uDQegORpF3hS; Thu, 26 Jun 2025 12:52:40 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4bSbB017ZFz9vGH; Thu, 26 Jun 2025 12:52:40 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 1B36F8B7B7; Thu, 26 Jun 2025 12:52:40 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id 1FFBuvr_5nqx; Thu, 26 Jun 2025 12:52:39 +0200 (CEST) Received: from [192.168.235.99] (unknown [192.168.235.99]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 8F3C38B7A7; Thu, 26 Jun 2025 12:52:37 +0200 (CEST) Message-ID: <3b6ff3a9-6b88-4a28-a0fd-31f31ae3e84b@csgroup.eu> Date: Thu, 26 Jun 2025 12:52:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 9/9] kasan/powerpc: call kasan_init_generic in kasan_init To: Sabyrzhan Tasbolatov , ryabinin.a.a@gmail.com, glider@google.com, andreyknvl@gmail.com, dvyukov@google.com, vincenzo.frascino@arm.com, catalin.marinas@arm.com, will@kernel.org, chenhuacai@kernel.org, kernel@xen0n.name, maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, chris@zankel.net, jcmvbkbc@gmail.com, akpm@linux-foundation.org Cc: guoweikang.kernel@gmail.com, geert@linux-m68k.org, rppt@kernel.org, tiwei.btw@antgroup.com, richard.weiyang@gmail.com, benjamin.berg@intel.com, kevin.brodsky@arm.com, kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-um@lists.infradead.org, linux-mm@kvack.org References: <20250625095224.118679-1-snovitoll@gmail.com> <20250625095224.118679-10-snovitoll@gmail.com> Content-Language: fr-FR From: Christophe Leroy In-Reply-To: <20250625095224.118679-10-snovitoll@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5E1CBA0007 X-Stat-Signature: ytgs6kskcm7z5ztxb3sm54ubjxsd7c9j X-Rspam-User: X-HE-Tag: 1750935162-669754 X-HE-Meta: U2FsdGVkX1+YmLtUQ58c5IKLoBFjFfYTtfNLARCcBUqw2U6qsEjlMentlj8PRNqQEGLRsVTcRmfpjC7fKnejatCjFAlBKaiBq+sYyn0nTHyHN4GlfMx9LITPk52ExenoewUe2ivUYpaRvtcAr0Pl7xz2nXSglFSG5Rq6kIGppX1usERNZDflWbn65Fmoivj8ZzJu9RXT/yyhCQyMfrayA5m0Z52Rfl/nCwYxpRBWRZ2MfvE/UBBfi+wNOhjhcEm66BVuKpLPxDczvtHzU3ajtXJxsRwfwOiT1MQeB/ubl7F6tVtktX9mJzrlwVBOeG9eSnHfzsQVYOqJUYd/v+SDEO1HF46PxfDCAi6a4miGpayt7N48Xah6c5Uj3CIlZuc6WBvAwhbSF0gfN2d+kf2PGYB+D5VEb3jIYvrUC+fl4RnJHWexmw++gK7ePsnsL/CWy1pPRt0PyrxIovpDPkWWZZbvjRsXQa25iq2v+20X/bN/Hxy9odgQsnCEL6p6RdT1BFNUCGGmfYlp9KHGBn9ECmwLo2n6naH/Visr8vGO2Kc+967aKtGfphoKduFyDGUOCxYOU4LUodkJgabxyplvHXmfqDQhhcD6MxYWMQMew3hyWSS9kSETEuHC+EYnW6p8CA++8pzpcbsJ1/+jm6j36ayX7hWiZv/mWmXNtqQNNgFceafQTKrj2zaJtHfsZbHXsIkkOZYZFlyzdMmY/Bt8Xew72xHPDQidCt/K+uCouhLlR9NHa8NeZUPh6mmCgfPwLsE6gX6Xa78c+cmwlPjhSae4DpAeRcUQmJ9o7o9A7P5x5ZY9P+wL6ckNs13loMhdMsOkN0/NI/nsIf6yH8qH6pM5N1p2zXQtDiw61rGg1bOF16bFCpc4Q19DgEZDrkaCeKWsapOnWXNIemJ6PJczvHGkkoLIiBJtVsy5NmRO8G9Y++dXdYScBAonVohAxTOhY4mI+ZBDRAV9Q+6gtvL 2A2skQUw 1hYX8XoBdl5l3kaNvYVYXAjso3UJwjwkXFe8Wj/zAkjVo6sB3vz5J5Puy+8z6V9NTVo5tnj5WVm27BbFFUZnHduOuOMbzP/oNh7wfJgBbRzEu4pyXBqbuXGe3dyAgosWovOo2y7jAvy9M3khcpmKuddeGvssRsPe+bEfHWMwQK+bm627A4TCt/xJcBPMo6AJW7N9gk8nEzqo1MwMxU6cNXwAnULiTxqTiyUCBPlRmrS8wI0BHikns1q/pHETjcOLuDcH29JVr2YzNEtRRdaAzbUeYySFBbBuubIPNyZygMHwf1Fa2nmhDPwItGxuO7BUD1WJNrYePOcW42Q8g3fMoj0qkLlf6tyITTOFp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Le 25/06/2025 à 11:52, Sabyrzhan Tasbolatov a écrit : > Call kasan_init_generic() which enables the static flag > to mark generic KASAN initialized, otherwise it's an inline stub. > Also prints the banner from the single place. > > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218315 > Fixes: 55d77bae7342 ("kasan: fix Oops due to missing calls to kasan_arch_is_ready()") > Signed-off-by: Sabyrzhan Tasbolatov > --- > arch/powerpc/include/asm/kasan.h | 14 -------------- > arch/powerpc/mm/kasan/init_book3s_64.c | 6 +----- > 2 files changed, 1 insertion(+), 19 deletions(-) > > diff --git a/arch/powerpc/include/asm/kasan.h b/arch/powerpc/include/asm/kasan.h > index b5bbb94c51f..23a06fbec72 100644 > --- a/arch/powerpc/include/asm/kasan.h > +++ b/arch/powerpc/include/asm/kasan.h > @@ -52,20 +52,6 @@ > > #endif > > -#ifdef CONFIG_KASAN The above #ifdef must remain, at the moment I get: CC arch/powerpc/kernel/asm-offsets.s In file included from ./arch/powerpc/include/asm/nohash/32/pgtable.h:65, from ./arch/powerpc/include/asm/nohash/pgtable.h:13, from ./arch/powerpc/include/asm/pgtable.h:20, from ./include/linux/pgtable.h:6, from ./arch/powerpc/include/asm/kup.h:43, from ./arch/powerpc/include/asm/uaccess.h:8, from ./include/linux/uaccess.h:12, from ./include/linux/sched/task.h:13, from ./include/linux/sched/signal.h:9, from ./include/linux/rcuwait.h:6, from ./include/linux/percpu-rwsem.h:7, from ./include/linux/fs.h:34, from ./include/linux/compat.h:17, from arch/powerpc/kernel/asm-offsets.c:12: ./arch/powerpc/include/asm/kasan.h:70:2: error: #endif without #if #endif ^~~~~ In file included from ./include/linux/kasan.h:21, from ./include/linux/slab.h:260, from ./include/linux/fs.h:46, from ./include/linux/compat.h:17, from arch/powerpc/kernel/asm-offsets.c:12: ./arch/powerpc/include/asm/kasan.h:70:2: error: #endif without #if #endif ^~~~~ make[2]: *** [scripts/Makefile.build:182: arch/powerpc/kernel/asm-offsets.s] Error 1 > -#ifdef CONFIG_PPC_BOOK3S_64 > -DECLARE_STATIC_KEY_FALSE(powerpc_kasan_enabled_key); > - > -static __always_inline bool kasan_arch_is_ready(void) > -{ > - if (static_branch_likely(&powerpc_kasan_enabled_key)) > - return true; > - return false; > -} > - > -#define kasan_arch_is_ready kasan_arch_is_ready > -#endif > - > void kasan_early_init(void); > void kasan_mmu_init(void); > void kasan_init(void); > diff --git a/arch/powerpc/mm/kasan/init_book3s_64.c b/arch/powerpc/mm/kasan/init_book3s_64.c > index 7d959544c07..dcafa641804 100644 > --- a/arch/powerpc/mm/kasan/init_book3s_64.c > +++ b/arch/powerpc/mm/kasan/init_book3s_64.c > @@ -19,8 +19,6 @@ > #include > #include > > -DEFINE_STATIC_KEY_FALSE(powerpc_kasan_enabled_key); > - > static void __init kasan_init_phys_region(void *start, void *end) > { > unsigned long k_start, k_end, k_cur; > @@ -92,11 +90,9 @@ void __init kasan_init(void) > */ > memset(kasan_early_shadow_page, 0, PAGE_SIZE); > > - static_branch_inc(&powerpc_kasan_enabled_key); > - > /* Enable error messages */ > init_task.kasan_depth = 0; > - pr_info("KASAN init done\n"); > + kasan_init_generic(); > } > > void __init kasan_early_init(void) { }