From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B70FD0BB7A for ; Thu, 24 Oct 2024 09:19:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 044546B0085; Thu, 24 Oct 2024 05:19:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F35E26B0088; Thu, 24 Oct 2024 05:19:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D88566B0089; Thu, 24 Oct 2024 05:19:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B9D2A6B0085 for ; Thu, 24 Oct 2024 05:19:03 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 71C221A11F1 for ; Thu, 24 Oct 2024 09:18:30 +0000 (UTC) X-FDA: 82707945348.17.F0FEA94 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf13.hostedemail.com (Postfix) with ESMTP id 2FD7F20011 for ; Thu, 24 Oct 2024 09:18:41 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=HHPOafjz; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=ZH1FHlmB; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf13.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729761386; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=43/GtsqQ69btnmDJ5/PfUx6wfwpYBdjrbCRpRXDTZhQ=; b=kanQqnJs5URLLrVoKq9Cjo2S8UeFn1euEx7bWddZdmYpgdxP/darSq19JEJwofj6XAt7XU 0d2pjGmJqYVWaUjm63B9xuFzrKicdD+IHo+qF2TKzszTXErASluBSH1L0WJGvMvYP6D0Zg pBaijEoJIELIEQL3XCIJbdu7Cw1ZrUk= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1729761386; a=rsa-sha256; cv=pass; b=Xk9l18ayflSOZ80QUdK5pfsvZIZUMMEg9R1lFSAz2sdDpgae2Z8j2rZSbiT4j3lI4wA5zC G8Vk7Y2n8Ise3U/jl1YaG4dIum1rcI1kTZjPQ7rTMRxVrCIRGB7mmnsqdkK0a/qu3uaTfC THCJGbGq8aDvQRzFNFJBfqDkaGFWWKw= ARC-Authentication-Results: i=2; imf13.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=HHPOafjz; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=ZH1FHlmB; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf13.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49O2feEO024005; Thu, 24 Oct 2024 09:18:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=43/GtsqQ69btnmDJ5/ PfUx6wfwpYBdjrbCRpRXDTZhQ=; b=HHPOafjz9uzO9L41TxeuOBNPX5B6DiQEhn UhcUHhBFknHkKTCuKyl3tkH5BuRxiuTihog9jv6Kk+ESi1CQMzMChZAeCLmt/fiJ zaYqOH4/e8HC3aX2nRAzvyoYFmm65pfLnHxjiI+r3X2w/ZbbySKFLnyJo97aXQHH tj+ox18R7GQfVmPGaqAiz71FLiW9RU4d3Ghtx8yDHx5ZkWp4E7pNxBW0tIl6Ie4i l45jZYi9vWQ1CajRFjCeJD/km4A57IQAuLOeUW9XHjAanqHldu1j7rvJj15DJaYs ivjMBKuIraUkGtWXmoEJKmrdJCImFDkEelflCyLWyjcOHp8YdGCw== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 42cqv3h7q4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Oct 2024 09:18:57 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49O8Tji5027117; Thu, 24 Oct 2024 09:18:56 GMT Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam04lp2046.outbound.protection.outlook.com [104.47.74.46]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 42emh40rb5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Oct 2024 09:18:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KEltD/JY23lKp5UPGVt753s3Y4atqxjgDZI7rm7Xfzubghiz6canwi2Sh/WOYHAje8v01YVqJHrzMgr7WxknD1fJYAegN8pqP4zufufVqeTiEtkhGuyT5aH1LgpzNndjLl9wtd/eGwFWZLZ/99ByDQbIhFIusdKRmaPN4604piBy84Qja79sQdvj/72vo4jO2qoKBDYvf4GFHc5/2L1MOljavH1QeFGrTzLxYYj3UUYs8ToXQwMreH57sbEd7IAUYTesLBOAukBZh/pKoC1RhQDAFZO/rIhIsTX2h+ysSDUrtj/lDmAg9CkBOiIxMsNFiC0n7WRseDuTsMJLtFS2PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=43/GtsqQ69btnmDJ5/PfUx6wfwpYBdjrbCRpRXDTZhQ=; b=XetOugestTB6PIomXRl8LTf4iXmxaRR56KclnVO7Yq4jwTy9Ve4NJmfQKt+a6R8CGHvcznPFE8YM7/vb9IJ14YkjO5T5povyZYM6QX2/6TXBYfwf8YFMJU+kfc4w9Kx9CzKe9CIlWSSZyh0dBo2b1Tzu3do7DxRVhMmB4ZPsmmOL62RYoUr5SC1puPrUZUblrifcRx41h3hWTUggw7JUMG6VplbA3yYEyEkFpVO9OD6uSB17W8H5sl5FOVHKBFXGe3mCex/S5AbraZl7mvTsSFm3D/71SGade0Hwvzr5gp21ykEbYNPLdcT9w2sAQj9wJ/dH11r0/nvqQfzcUC+HPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=43/GtsqQ69btnmDJ5/PfUx6wfwpYBdjrbCRpRXDTZhQ=; b=ZH1FHlmBpLBMqxC0g+q/A3UFFI7T/1ewB3suq9rxlMa4PI3DLf9a/+oTYN3mnA1M4RVZidvNdaUc2u0oo/bbZYQuhjPh+fHEao2PNDD9eB/0sduCxPCYVnwE6e/zrTD8Rf6E3K3Tput1Y/0/fCnTRn1lk5UxAi/LQ1Lg+kK5Y5s= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by DS0PR10MB8032.namprd10.prod.outlook.com (2603:10b6:8:1ff::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.20; Thu, 24 Oct 2024 09:18:37 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%6]) with mapi id 15.20.8093.014; Thu, 24 Oct 2024 09:18:37 +0000 Date: Thu, 24 Oct 2024 10:18:33 +0100 From: Lorenzo Stoakes To: Wei Yang Cc: akpm@linux-foundation.org, vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org Subject: Re: [PATCH] mm/vma: the pgoff is correct if can_merge_right Message-ID: <3b565157-9a9b-47da-a0b9-11a4e318de44@lucifer.local> References: <20241024084222.17201-1-richard.weiyang@gmail.com> <20241024091012.52f2pugeaxd4xrul@master> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241024091012.52f2pugeaxd4xrul@master> X-ClientProxiedBy: LO4P123CA0457.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1aa::12) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|DS0PR10MB8032:EE_ X-MS-Office365-Filtering-Correlation-Id: 53442650-8404-48b3-80fc-08dcf40cd751 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024|10070799003; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?yn6xLWVAJIPETkJHlzDuvL1lMouaQV8jEYXHxrBqd0lUlNKfWMEttChTl88b?= =?us-ascii?Q?93OEyUPQdJM3jQlZ0j33EITC+hKXaRCk+DYG+8qaL8EsH3AWYgp/CJzXOxlZ?= =?us-ascii?Q?YGEN13wKU5FhigY7Yd535aGE40j9CJr11D0O+xh7Bn+KnUlL9IFPHxclon6Y?= =?us-ascii?Q?4JDZezdt+Rbf9WmLrUtagXMJ40WRDtEWlx3LSacBrdS+BXvskFbbkGBUZMyQ?= =?us-ascii?Q?n9YwxhQro3BrH0x+nJ4NKVc8C+Rm+bhwm/lcl8uQ6ucpqfUxCdz8ImDPYEer?= =?us-ascii?Q?e3qlhR5h3zUDVLs+Oz+2VXn4OyVzEdIoNIphFmyJsVUS9nMRNOe2aZRA1+Ha?= =?us-ascii?Q?Y7ldGcqRF6OoTlOutoc1a74RKE4/5S/ksVBH2Lj90bk9s9cAjMTb13Aju+jJ?= =?us-ascii?Q?MA5dn6jArmvO2HyDQdIjDH21gEQZsIBZrdHqGCjwuPBxZuG0zImJh5NefZES?= =?us-ascii?Q?HLM68KJzRvTPXiaHCrIMRNa1+T7gOqPCBkq10ODHcRel6ktEmVoD+kYXcc0e?= =?us-ascii?Q?1xJLi/40m+SCIDFgbHMkJCgmkJAdxgDEaySq+r3QJNvlXoroEcfHtHjeh1yf?= =?us-ascii?Q?ei7A1MHTjw7xRwKpDPblabGFCE+ykYEraY78y7t4y9UJ6umqeVlNmLC91hrU?= =?us-ascii?Q?aVAbz3DRJI5SzR6RgNFQfR8Zp73tIlLFgWJeObOfAbG1foatT7b5YZ1yC7SV?= =?us-ascii?Q?aSlpLG8GEgr+xCKFCgCg+PzHY3CvYV19obvVsGoySTKPHtX4DO9S/zEp/k2g?= =?us-ascii?Q?/DUUZWSZ/yttUMawqAGC1BTOxIToNyaHEN2Z+o1ICCKSTLeNVRyk9ROY1iYd?= =?us-ascii?Q?It1TCMtiAI4GyBsa9mE7jCEwjDKgzSrtbleXCgFJamAaprxDyxHDLj77Ucjo?= =?us-ascii?Q?bpWZGBnHuYjc2niPsY2diedR4Rahu0FkNAtLfoXHjd5G3wfb4DIy9dBd3gJr?= =?us-ascii?Q?9jLXEJKNK/2H513FAytHv6GroBZEgT0i3l0cLkOQYlu0nNxZCXVq/lx+eLjY?= =?us-ascii?Q?gkLDXhMC4VCDJgN7nI+5dcdDrpSsOP0fH9kwH4aZcM9auIY+lP6cR6TUxIn1?= =?us-ascii?Q?1x7s3kmBp6uRrvqMsfHMJ/MVE39+wMsECP0fJPGx/sqysurpYlz7XOT7fq96?= =?us-ascii?Q?ZcRUlQFNexqnKBYpBqHIgexF/78JnNJht3kCA/zqBy9OA416Cr11EfshO9hw?= =?us-ascii?Q?N7n6NEcqxyKmVxoQkozqXUUBobPZ8UGEjJAiP1e3jBrrkFJUXzEuo+zd8Lur?= =?us-ascii?Q?K9LFrQnuSzWKARk/wDyV7fb4azPNipKj0bkqHu1w9WcicvDnJiRQKIm0E1D5?= =?us-ascii?Q?UDA415B6fzDncX9ZqTJEsHVh?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(10070799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GnNJpW/A+5j46mJi98Ujtc6WfhzbM94qpWw8LrSZMLDHKsbrFc3xC65Tezka?= =?us-ascii?Q?wPyO7JDc/1YDEL8oLIEgC4kFfwty+p9jNQuIAC3oMeOi2vyLmbQgEA1vuQ4p?= =?us-ascii?Q?xx0n0hLDfARlVPnHJgaUuXVqwc1UafMf8SoO7LcaX/hLHeZs6xhHBYhLuwrF?= =?us-ascii?Q?ZOGmCcBGbhMRVrc/z1SJRz8w4GHine608BVs8fiP6Gnuh/FrXdVHh6ONevxA?= =?us-ascii?Q?aO/KjVbYqcJZjgwFhJMoUBvpQtAqQSuxcrH58RcaP5gsuLd7+dJJr5xzgTas?= =?us-ascii?Q?CIh0QXKjE4FWKnJd9jFmoTz/UGTWDCW+QFIokNFxBwjB5MVjNWtsiyCP1A3E?= =?us-ascii?Q?XsvtNyDkWYIcOdBTk0WuBDTnVe2Vn+/xHuvINKC9yEl2au+Usv3KA4aC4uBh?= =?us-ascii?Q?+fM/XXK5D60MuutTlZJVjxLtcf7BEjcjDdSuM06jb8TFIyNSiZFN97udT6Cx?= =?us-ascii?Q?cyEfDqDHI8vJHSVitV8jpV/MeosdW6zUIhAam1PmjQIy62+fJ7sWaKo+d79r?= =?us-ascii?Q?zn4qK4Ar7g/uwcxHNtTjSR5dItDb4w03fKzPi+0UH0qzW0byuINR+AGvKWnl?= =?us-ascii?Q?qjj9CBxOm7b3imPnr10CBZaDm0/QDzEZZkfaXGM3VPrKWnHqU+Tn6clERP/2?= =?us-ascii?Q?BHW2146rH7M6nJJVjuWY6U+NElfRuDAqCOvKveoovVKLV5w4ARJA+lWTJ9X2?= =?us-ascii?Q?tG6DXBoU96QilsC/A/ZvW3KA0/4tLiEQ0vb7PxvZBBnKa7tShEjVichMmgpY?= =?us-ascii?Q?eksfFCkX89OM5Zn+/r7sVf90W1myhJwa7O/fQTM86m3QE8wpa6MFQlhmE9PJ?= =?us-ascii?Q?cKFSwg/y19Tb1zV9OxSRRI795+IoTcDOmP3u2uGBOJnt23hlcs9ZjhLDDox6?= =?us-ascii?Q?uJ9q+fZiwGiojCNo8r6Sxpqt266jAYLw4tgJArCR03c+x1BobwPmLxNmrANZ?= =?us-ascii?Q?mhrv0hRBlbyszAS10AvLZNL29zljtFhkf5q8tBTAKHC3oR30uPklSXLShP+f?= =?us-ascii?Q?T9lj47gScTIj/xxAaFiYq/59FPfquEbNhn1Q9RVAXI7ClOTp++r7wejHV1kh?= =?us-ascii?Q?ImNb6uYXOEHTktqw+yshYQuPVnKVWIOsI2eNYeDSeIEQ43lQ/Iacgg1H5TaM?= =?us-ascii?Q?2NOXZJitvU/HdYcF0TGwmmY8yg1AZ5aOL7BGTAR+UBY6V92rOftHbpwZ12/X?= =?us-ascii?Q?IeheBUwelg5HCVEmUfW9qSjk/gApnSJa0S2IzbUsrRN8beq+j6gmXipsMWbg?= =?us-ascii?Q?z+QNk/GWBuXbb6vY8DnPSoLB0bSy3/i6CyT49swNm03L6DNIYI7vYaCL2IPj?= =?us-ascii?Q?KDFBUD5kjiA+xgD7nxpxL5b6uzqH//ki5dPoBCPddgDm1KPcAZYmw3OyHh8d?= =?us-ascii?Q?wKijuqMoS6hmH4cq+zlgM1/XkUjnOwsswaMHN7C3gZvTCO+0xI57x30P3SDw?= =?us-ascii?Q?+7R0ULH+Lx4DBzV/aYIApTvgGlwbZEVTBTAsm7/rMU/SVhLK5mc38qvTA1WU?= =?us-ascii?Q?C4mimFAD8cbbDka5k2km5ggJvbJESvpoRuZbD9czOO4BacSt9NtaB7XShOhs?= =?us-ascii?Q?oGBOZ1bgBsj+CNxECMtRA5WesA2Ir67iLmxFxhsb2kASWs+f355SFvOGy51B?= =?us-ascii?Q?qamGmJNJQw7JP68Ao0h4mlrWY5oL6+iziEETIJiwI9UEf8cXt0yHMLvevGe0?= =?us-ascii?Q?71JkPA=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 5WnZeh66WIMSgc/vU1TekektrUmAcpx3IbdNGoVAUSvuRmnO/0r1/B9IMVAlNrTWZ5latsXsV/ynjWBxOa32Qul+YOTlhgjmK8GaAF7yvJFkwdM0p4Vee/29M5QEobmoKCgR+pMEV/cK0lnDJ0Cdw4dUH0L09NS7yFHyYeltos+uFGc4AwOQFr/t7godCZJX4EatU++sNZsYCowC5UPzBQIs+VMdNY/rBnq3Zn5GnCjbBUTiNFix/IkN8rV2cFsAnOx22dHOAOgcrsO3GB/Wy0zdkZAJCsGO8ipTUpfMgveg7EQzwdqkJ2gf+BjAZ37O3nGJ3P4kURxQE6qrGhUw/rATt3RAY6fhw31CsDAgGxbhhjpCSMfkbA5UAoKcrOLFR5rjX3kscnzr/wgNKXbMOQ5D+Wv5/jyOsgvY9h46Vf0K23CvbSff3M+YIg8QsQe2Br/QuRg+jvxdvThxJqy4aevegzqtMhWEcbfSn7xOYucJBrobGgV06cW59HY+xhQgeUowyus6ilNQmKyFDndeprcqYx0KsbcfYSL4Wdx2tVfJFIKJT0xdWEr1tYdjb8iqlUo1snuAGJBSe5Fv/bz20x0z6dSXuzOeGqBCCHrWJlY= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53442650-8404-48b3-80fc-08dcf40cd751 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2024 09:18:37.1111 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aep6RdKN/VAC6x8niMINwpR6GH030EZXyfwcOXd3Tw0VUDqtR0UBTdgS2G6eeb38ddJ+5RPqARk5B6tgUWXu2WoLF5YA5UkIyWGVRtlV/2Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB8032 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-24_09,2024-10-24_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 malwarescore=0 adultscore=0 mlxscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410240072 X-Proofpoint-ORIG-GUID: JyNEFH8zxdHkoZRDoMBiGi5cYWHhGasF X-Proofpoint-GUID: JyNEFH8zxdHkoZRDoMBiGi5cYWHhGasF X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2FD7F20011 X-Stat-Signature: a8u7putwp6z4jxxgg7ybesmz7ew4d8fp X-HE-Tag: 1729761521-291002 X-HE-Meta: U2FsdGVkX19VbZIcRboGtfCnZIwpVw5ooS2aoz8Wy1GGeFRDTtY9wabeHyXsHBDaeYULlwDmsrDh9UDCrthZTjbi6dRfSBi4ah4FxJhQ5OO/aAZMBJgfEp4bHcH45nZsi7vIWfRCYrknBPSTjnwQnjQI6wSR1uXfx3LVKooQUrMw1z0F25Sz6QJivRk4qUAAEmhqgq6W5ZrawMhdIcgxT7437uL9YJ1QFyUonseSmYchEO5UdhJmrTVLbkgJZXSIlCuNfVXIJeoWUBWXSzuiy2gBEswbu2ATRcEnMzofLi2AT0xHiEOvQYhuWyXiFdLt++KnLNK0eSMuJkDqMmZBmMiCcx051NRK/aum7Lnifa0uQyv4cfOVrMVRw697ZFxPzCnZM31I/bHvKFgSV5MJ26d4HTYh34+ZHbcymKchMti/sq+OD1FchA71fBUWRQivLn2Bs+N4LNh3G2fxOVjDzNejydA6wSCvUTFPV4SbJYwQ1NcY8tZBagoMtsCx3CrjPiCDyagTfV7N4YzubFi01Kf34V2P7b7E/VTK+N9FIz1eXfOR8ejH1aIu6Q2Zs6Us5cyz7znvZVRRd7zu48atk8EqcVFhLcnjrb0orTqyktBEGR+TMbhjztAtwxqAXEL5of8hvF54+V748ATMsXSCGfK32hWk8og1mP6doN7N1zQW1NJYtXMIzMLAISVL09f5a72rIL+cnd5nL0f1mYMc+tLdhgmezed5pT1Y5Kk783OABUq7Is1I98eGce04S5b0LAQLahIJ7MyXD9xiApbnWzGvq2PaJHrst/m3+9zvyvcz7E+q0ErwdLh2Tsm943N/jc75/xWDg6b1siRnX2qD0GgATqYq5NuC1cTliLJmVhsd4GuRSaE0kSnRIL8hqvxziaBhlTNz8bA977WyIxSDThdCJrL2qY/jWNAIoSPfZ40kAyoFW7s+IH4CfewKF4ZQ/yFwLfSmG2ng6MgGB+C PbUtUtTR Pj72KrEC2vMR1ltdMflBOZqB4ery2P+z9M3ZvFzhQK2glkI434S1mWz1dBcc7nbJ0x+1kAvPtdUYJIhFntfW45OUuL1h29UP8K3KfriYk536TPti5JKEqTeGZ0y1kc6DYU7he/ZsItldAyNgsobpB9scDzIUl8ykmJMsrvlaHK5wSFbO5eQx31myIWXtKe8ujloNCvAqdXaj1+v6mB8dLmN4bD2v382hlvJ0yD80jlNouvqdnUNpAXdSwHq3xEqZvd/fgruUgnC138agO9d4Y0Emt3298GHgna64+IPlP+/uOInVr7bvvR8wcOn71s+v23zmUl6UPZnyjno1qA9I6CiP0Rb+7AeL5RoRihmezsJAVePKJEYYTvD/+Pjz89PaZHwNKBwdnq6OFsEH1XN/bVSMVXJTha1MtmW+4XwlqfDjnQz+iMPxMe7VlPPAGNZoCn1GMNPrYa3HCrhaIP/HLXlDi51cN4gbfB9kQYsQgSNP9FLbcS/gwOD3pFcLQEtIh4Qr7c8+jtWn8VmC6mfN2BU+ClPnH7gEX5F7h4ZeFt6rRgQ08GBZ+X0JlHD1tN8G15ZAnzaEbsrbJehglprQgy3P0QopgUzntA/WPzO9AYXoL5X9A9z3YT0SzgWy/2UOfBM8uwuHjEvB2LcDDnclCntxOeUQSlTRQtZpB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 24, 2024 at 09:10:12AM +0000, Wei Yang wrote: > On Thu, Oct 24, 2024 at 10:03:34AM +0100, Lorenzo Stoakes wrote: > >On Thu, Oct 24, 2024 at 08:42:22AM +0000, Wei Yang wrote: > >> can_merge_right implies can_vma_merge_right() has checked the pgoff. > >> > >> Don't need to assign it again. > > > >Would prefer a bigger commit message something like: > > > >By this point can_vma_merge_right() must have returned true, which implies > >can_vma_merge_before() also returned true, which already asserts that the > >pgoff is as expected for a merge with the following VMA, thus this > >assignment is redundant. > > > > Will change to this in next version. Thanks. The actual change itself looks good! > > >> > >> Signed-off-by: Wei Yang > > > >Reviewed-by: Lorenzo Stoakes > > > >> CC: Lorenzo Stoakes > >> --- > >> mm/vma.c | 2 -- > >> 1 file changed, 2 deletions(-) > >> > >> diff --git a/mm/vma.c b/mm/vma.c > >> index 4737afcb064c..fb4f1863f88e 100644 > >> --- a/mm/vma.c > >> +++ b/mm/vma.c > >> @@ -915,7 +915,6 @@ struct vm_area_struct *vma_merge_new_range(struct vma_merge_struct *vmg) > >> unsigned long start = vmg->start; > >> unsigned long end = vmg->end; > >> pgoff_t pgoff = vmg->pgoff; > >> - pgoff_t pglen = PHYS_PFN(end - start); > >> bool can_merge_left, can_merge_right; > >> > >> mmap_assert_write_locked(vmg->mm); > >> @@ -936,7 +935,6 @@ struct vm_area_struct *vma_merge_new_range(struct vma_merge_struct *vmg) > >> if (can_merge_right) { > >> vmg->end = next->vm_end; > >> vmg->vma = next; > >> - vmg->pgoff = next->vm_pgoff - pglen; > >> } > >> > >> /* If we can merge with the previous VMA, adjust vmg accordingly. */ > >> -- > >> 2.34.1 > >> > >> > > > >Thanks, nice spot! > > > >For the purposes of explaining it on-list this is because: > > > >static bool can_vma_merge_right(struct vma_merge_struct *vmg, > > bool can_merge_left) > >{ > > if (!vmg->next || vmg->end != vmg->next->vm_start || > > !can_vma_merge_before(vmg)) > > return false; > > ... > >} > > > >And: > > > >static bool can_vma_merge_before(struct vma_merge_struct *vmg) > >{ > > pgoff_t pglen = PHYS_PFN(vmg->end - vmg->start); > >... > > if (vmg->next->vm_pgoff == vmg->pgoff + pglen) > > return true; > >... > >} > > > >Which implies vmg->pgoff == vmg->next->vm_pgoff - pglen. > > > >None of these values are changed between the check and prior assignment, so > >this was an entirely redundant assignment. > > Do you suggest me to add this in change log? Sure, I am a big believer in putting as much detail as possible in commit messages, we definitely need to explain why we're doing this to future observers (including me... ;) > > -- > Wei Yang > Help you, Help me >