From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13551CD611C for ; Mon, 9 Oct 2023 18:20:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A6C0B6B0250; Mon, 9 Oct 2023 14:20:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A1C086B0251; Mon, 9 Oct 2023 14:20:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90BEB6B0252; Mon, 9 Oct 2023 14:20:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 81C4A6B0250 for ; Mon, 9 Oct 2023 14:20:41 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5C1EDA037F for ; Mon, 9 Oct 2023 18:20:41 +0000 (UTC) X-FDA: 81326738682.03.6B4422B Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by imf09.hostedemail.com (Postfix) with ESMTP id 66D2D140038 for ; Mon, 9 Oct 2023 18:20:39 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Eq1L8EXG; spf=pass (imf09.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696875639; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oc0nbYwvTpqhRguEfQQTyDgA4rUKYn1mDLi3z4hzlZ8=; b=r1/nlfs5PmXbAubd9dAENV5txFnJWG44GeYgcVbL43aH1HUTN9HQgc8e2683P+aS8d14/S Rjnhw27S1Lpshmf23yLdEXhuszlqBbRX3ck74IdhX1bEoBTJv1QsQJ4NDX2qckNsih/GX5 2wVZZCK+ab7Ei31ejR6Ofca6jGo1Xj8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696875639; a=rsa-sha256; cv=none; b=fGNXJdNzdR6r2aFP6q8O02OnC300Sj0BjSjatTeDUKuW9sByUaiu7q368poowI4acDNWVc gT8gwJztduROUpUc6ab+hdtg+Tv5z9KyS96ptT1BVPdf/ySilLizzJmD8c0JLM/tZP0Ivs 8Y9ate1iW+giva8n8FVzZNOJVnypm6Y= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Eq1L8EXG; spf=pass (imf09.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-31fa15f4cc6so4806646f8f.2 for ; Mon, 09 Oct 2023 11:20:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696875638; x=1697480438; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oc0nbYwvTpqhRguEfQQTyDgA4rUKYn1mDLi3z4hzlZ8=; b=Eq1L8EXGanScaD/Zn+hojE403Y7EZq2M3GCDivD66DFKsm7BWzwaCuIsrlcrETmhff PvA908l8u1MsjP4iCEgZHGIW2jyUGS8RIh97A7A32CYlW6b4NLORxv9gpInc4p9uHJ9Y UTTL+sLxAWYP+RX9SQgr7EN1DXSwEnltnmQZ4gP7Kv7+BoEnCwePsx9gjuzKijUGqdmM 5fvnukNkrihHwuFIVwN22pJm2yCuMfyBAwisPxMl90yiLlYw60PnQjBPzoWhTX0VumN6 QeA7rwTeqi4Yvt4NWXTIwQxbSKujLA4y65yyS4x67zrndshOkTYHekk89yAqSflkhkwl fKug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696875638; x=1697480438; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oc0nbYwvTpqhRguEfQQTyDgA4rUKYn1mDLi3z4hzlZ8=; b=tRoUvqmtna/ZDNiShEO1ZE/nQtglaI4tXh6jPKG0V+bXRqsVQfCdjgMvI3WshQb2nN 6Cc+aAUfFJxrxor78KaTNqw25tXOBynYCL8Kg97RYB6r0j3AYiTJLUkrvmdRcsD6qduI TiV4E9IsXQ9w5A5hoQYBvvPi0Pg2BhIU6imY01+EcE4CTlcJPSCRvt6svKshSNnxw85o nzB02VqFUoIIVS3wInlSI+ouEg3vfW3iJmm2LV6Xw3SJ+NkttfkzEP3gQ7owON64A91A HrXOQYw4ZD7ASug9DhkGYfSk//p7/Vp8R/ush/uZxFx+MjZcM6PIrLtcMJ+b2btv9YkH qCXg== X-Gm-Message-State: AOJu0YzuE4WJciD8/DmP19FhEVaTqWcOwIC2jjgFMZX9E70Xe8O49/rJ WWEkDOvuHvA8ggwBL5GTDIQ= X-Google-Smtp-Source: AGHT+IGfcDtfe4ydZ2UzcW8YtqCbLsCspc7CXkeTrTBQMxNmzlEg94yh27Yrc1mXwnP+2Hn4rbiIPA== X-Received: by 2002:a5d:4c8a:0:b0:313:ecd3:7167 with SMTP id z10-20020a5d4c8a000000b00313ecd37167mr13988616wrs.42.1696875637878; Mon, 09 Oct 2023 11:20:37 -0700 (PDT) Received: from localhost ([2a00:23c5:dc8c:8701:1663:9a35:5a7b:1d76]) by smtp.gmail.com with ESMTPSA id bd5-20020a05600c1f0500b004030e8ff964sm14235674wmb.34.2023.10.09.11.20.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 11:20:37 -0700 (PDT) Date: Mon, 9 Oct 2023 19:20:36 +0100 From: Lorenzo Stoakes To: Vlastimil Babka Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Alexander Viro , Christian Brauner , "=Liam R . Howlett" , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 2/4] mm: make vma_merge() and split_vma() internal Message-ID: <3b46dabf-b9d8-46bc-8cec-3b7aa3b7a609@lucifer.local> References: <6237f46d751d5dca385242a92c09169ad4d277ee.1696795837.git.lstoakes@gmail.com> <4d8968e8-a103-8320-fce6-d2a78fbf05ba@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4d8968e8-a103-8320-fce6-d2a78fbf05ba@suse.cz> X-Rspamd-Queue-Id: 66D2D140038 X-Rspam-User: X-Stat-Signature: 1q9iyhmw6uz76w5hmsyuhxq5otyrxw88 X-Rspamd-Server: rspam03 X-HE-Tag: 1696875639-466845 X-HE-Meta: U2FsdGVkX185+AiWSR+HgTrpp+4aMTv8C9glgN9XtF9JWxq9u9ocE+R8FaW5gOY3x2ljTJzN8jjspLKaHwEyO7MoiGKxIdb49eT/hq/BUDM9qW8XSnw+WoZX80uY/uMkQ4W3BQO1VNipj7ytHpTabgTI+f5vtCl0n84yI14EX3TTZ8ky5rWmSGBzWuWhB+DLx4MqJGREfnhUuIv7CZADbypLV494rZ2yyQVK3wa3qra9kp884Nk9MR90+Ky9TL6zhNDcs5nFV6SncAnRjzfEQbp5eZO2qkqWOerleQYv8dR/+Q1QrHXNBYCsW1kQ50DEjD59ajfIc/8DMyOt7nRjE4UzfhGpC9ycQAGA7JUa0PFYZM5U7cSbxCUJh6WnmYJ8Al4scWSl3vlU7XKjcScf9ay8bknNC5VkV6NKfRHh8GP2/ShCTKsPikPQBu1uEGdYEFhQ5/WBkZloiDq5HhcLS1gSz9C5d568YZh+6Kq8el/3tN7i66EQx1i4qaKUEyaHD5inUbpR7Im56nTd4Vo0GWxZs3nGJYH6mcd0EtnnfJubDSTpivoEilaActDK+/FyzeoaBXxctbYRDNJnC4aMV8OHqrM7pnnkipIEnlGf9HREGxY/dK/nh8JfKFdQinD18iRIqqCVvG02Mg0aUFu4QNpWIOTIFWuSoQzIApQDneAV03+9B8fMpO7GeZx3oBqIbaBrjQY7/jcyJq9wz14WYA8K+6KKk3r1Zaof1ACRN5UOc664NxQ9+XA0/tEclpFnMaOuq3uHvkDiDYtzxeGgvilqweUppzW2r08yaOWGMPyQbIyYl+mc+YvOlGQqknGDqQb8WdRFmdyXbrFomfZLvkzafQzp3S/qAw6sas0v7oOuUuhEqt9gFBv5lZyozZtm3fTXq9m2UhG4tzQ5obpiLzIMg9evgko2QkylN05fQezLsd/5CmMfY5YdS9t6xFYnUoBo7Oj6fEdlZZWnZZW tofRNbXj 4lbJeU0r0onSG9Boavol7RcYVolMU7xCW2gDujCCcVSiS2MJv6tys0nUPPoySD31OwDufztvUM790pcY3JXc3taNsblQn8B4Zn1a7Wu9icUCdhKpGjVcrqWcBVbAii6yrqWuRZtZXsLPi145iWGZuC46xjz7h1Nk78ZetA8FsNXzPR3ZgAQbz7IrquDoCufOfHLMVjl1TuIKNX2MD8H+7Bw06PwnjC3Fv/MQXjWaVHFatusa402PkCtjZxOnRI1/Ric5IKoJ+dDdGmyoOHilL57rTW4hdaGvll8ninhJibMH8gvbVRwsYszPlejZb/pTa8RnfeB7B03bHb44zRh7tmcG16OJUE+1y+U/8qelLBx5/StSB9b0aWuqwiKS6wwLvNJmMshq8oH6mtP1kEYqOnMc33BoeEjxMJoFux/9A545NIaWqkMGFpV1brgYnYV/5TtJjwhhRIU8Xwsdm6qKUGcQLCW/xRMifSe77KEHgy1uXvNUSrBmvl25QjB3KzR3euubATG9qh9CWups= X-Bogosity: Ham, tests=bogofilter, spamicity=0.022527, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 09, 2023 at 05:45:26PM +0200, Vlastimil Babka wrote: > On 10/8/23 22:23, Lorenzo Stoakes wrote: > > Now the vma_merge()/split_vma() pattern has been abstracted, we use it > > "it" refers to split_vma() only so "the latter" or "split_vma()"? > I mean to say the pattern of attempting vma_merge(), then if that fails, splitting as necessary. I will try to clarify the language in v2. > > entirely internally within mm/mmap.c, so make the function static. We also > > no longer need vma_merge() anywhere else except mm/mremap.c, so make it > > internal. > > > > In addition, the split_vma() nommu variant also need not be exported. > > > > Signed-off-by: Lorenzo Stoakes > > Reviewed-by: Vlastimil Babka > Thanks!